This is an archive of the discontinued LLVM Phabricator instance.

Differential D62019

[clang] Handle lrint/llrint builtins
ClosedPublic

Authored by zatrazz on May 16 2019, 11:28 AM.

Details

Reviewers
efriedma
rengolin
javed.absar
huntergr
SjoerdMeijer
t.p.northover
echristo
evandro
craig.topper
Commits
rG14689910737b: [clang] Handle lrint/llrint builtins
rL361878: [clang] Handle lrint/llrint builtins
rC361878: [clang] Handle lrint/llrint builtins
Summary

As for other floating-point rounding builtins that can be optimized
when build with -fno-math-errno, this patch adds support for lrint
and llrint. It currently only optimize for AArch64 backend.

This patch depends on https://reviews.llvm.org/D62017.

Diff Detail

Event Timeline

zatrazz created this revision.May 16 2019, 11:28 AM
Herald added subscribers: kristina, kristof.beyls. · View Herald TranscriptMay 16 2019, 11:28 AM
zatrazz updated this revision to Diff 200291.May 20 2019, 8:13 AM

Updated patch based on D62026.

craig.topper accepted this revision.May 20 2019, 9:34 AM
craig.topper added a subscriber: craig.topper.

LGTM

This revision is now accepted and ready to land.May 20 2019, 9:34 AM
zatrazz mentioned this in D62018: [AArch64] Handle ISD::LRINT and ISD::LLRINT.May 21 2019, 5:22 AM
Closed by commit rC361878: [clang] Handle lrint/llrint builtins (authored by azanella). · Explain WhyMay 28 2019, 2:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
lib/
CodeGen/
16 lines
test/
CodeGen/
9 lines
12 lines
12 lines

Diff 200291

clang/lib/CodeGen/CGBuiltin.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,743 Lines • ▼ Show 20 Lines if (FD->hasAttr<ConstAttr>()) {
case Builtin::BIllround: case Builtin::BIllround:
case Builtin::BIllroundf: case Builtin::BIllroundf:
case Builtin::BIllroundl: case Builtin::BIllroundl:
case Builtin::BI__builtin_llround: case Builtin::BI__builtin_llround:
case Builtin::BI__builtin_llroundf: case Builtin::BI__builtin_llroundf:
case Builtin::BI__builtin_llroundl: case Builtin::BI__builtin_llroundl:
return RValue::get(emitFPToIntRoundBuiltin(*this, E, Intrinsic::llround)); return RValue::get(emitFPToIntRoundBuiltin(*this, E, Intrinsic::llround));
case Builtin::BIlrint:
case Builtin::BIlrintf:
case Builtin::BIlrintl:
case Builtin::BI__builtin_lrint:
case Builtin::BI__builtin_lrintf:
case Builtin::BI__builtin_lrintl:
return RValue::get(emitFPToIntRoundBuiltin(*this, E, Intrinsic::lrint));
case Builtin::BIllrint:
case Builtin::BIllrintf:
case Builtin::BIllrintl:
case Builtin::BI__builtin_llrint:
case Builtin::BI__builtin_llrintf:
case Builtin::BI__builtin_llrintl:
return RValue::get(emitFPToIntRoundBuiltin(*this, E, Intrinsic::llrint));
default: default:
break; break;
} }
} }
switch (BuiltinID) { switch (BuiltinID) {
default: break; default: break;
case Builtin::BI__builtin___CFStringMakeConstantString: case Builtin::BI__builtin___CFStringMakeConstantString:
▲ Show 20 Lines • Show All 12,480 Lines • Show Last 20 Lines

clang/test/CodeGen/builtins.c

Show First 20 Lines • Show All 384 Lines • ▼ Show 20 Linesvoid test_float_builtin_ops(float F, double D, long double LD) {
resli = __builtin_lroundf (F); resli = __builtin_lroundf (F);
// CHECK: call i64 @llvm.lround.i64.f32 // CHECK: call i64 @llvm.lround.i64.f32
resli = __builtin_lround (D); resli = __builtin_lround (D);
// CHECK: call i64 @llvm.lround.i64.f64 // CHECK: call i64 @llvm.lround.i64.f64
resli = __builtin_lroundl (LD); resli = __builtin_lroundl (LD);
// CHECK: call i64 @llvm.lround.i64.f80 // CHECK: call i64 @llvm.lround.i64.f80
resli = __builtin_lrintf (F);
// CHECK: call i64 @llvm.lrint.i64.f32
resli = __builtin_lrint (D);
// CHECK: call i64 @llvm.lrint.i64.f64
resli = __builtin_lrintl (LD);
// CHECK: call i64 @llvm.lrint.i64.f80
} }
// __builtin_longjmp isn't supported on all platforms, so only test it on X86. // __builtin_longjmp isn't supported on all platforms, so only test it on X86.
#ifdef __x86_64__ #ifdef __x86_64__
// CHECK-LABEL: define void @test_builtin_longjmp // CHECK-LABEL: define void @test_builtin_longjmp
void test_builtin_longjmp(void **buffer) { void test_builtin_longjmp(void **buffer) {
// CHECK: [[BITCAST:%.*]] = bitcast // CHECK: [[BITCAST:%.*]] = bitcast
▲ Show 20 Lines • Show All 459 Lines • Show Last 20 Lines

clang/test/CodeGen/math-builtins.c

Show First 20 Lines • Show All 347 Lines • ▼ Show 20 Lines
// NO__ERRNO: declare float @lgammaf(float) [[NOT_READNONE]] // NO__ERRNO: declare float @lgammaf(float) [[NOT_READNONE]]
// NO__ERRNO: declare x86_fp80 @lgammal(x86_fp80) [[NOT_READNONE]] // NO__ERRNO: declare x86_fp80 @lgammal(x86_fp80) [[NOT_READNONE]]
// HAS_ERRNO: declare double @lgamma(double) [[NOT_READNONE]] // HAS_ERRNO: declare double @lgamma(double) [[NOT_READNONE]]
// HAS_ERRNO: declare float @lgammaf(float) [[NOT_READNONE]] // HAS_ERRNO: declare float @lgammaf(float) [[NOT_READNONE]]
// HAS_ERRNO: declare x86_fp80 @lgammal(x86_fp80) [[NOT_READNONE]] // HAS_ERRNO: declare x86_fp80 @lgammal(x86_fp80) [[NOT_READNONE]]
__builtin_llrint(f); __builtin_llrintf(f); __builtin_llrintl(f); __builtin_llrint(f); __builtin_llrintf(f); __builtin_llrintl(f);
// NO__ERRNO: declare i64 @llrint(double) [[READNONE]] // NO__ERRNO: declare i64 @llvm.llrint.i64.f64(double) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @llrintf(float) [[READNONE]] // NO__ERRNO: declare i64 @llvm.llrint.i64.f32(float) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @llrintl(x86_fp80) [[READNONE]] // NO__ERRNO: declare i64 @llvm.llrint.i64.f80(x86_fp80) [[READNONE_INTRINSIC]]
// HAS_ERRNO: declare i64 @llrint(double) [[NOT_READNONE]] // HAS_ERRNO: declare i64 @llrint(double) [[NOT_READNONE]]
// HAS_ERRNO: declare i64 @llrintf(float) [[NOT_READNONE]] // HAS_ERRNO: declare i64 @llrintf(float) [[NOT_READNONE]]
// HAS_ERRNO: declare i64 @llrintl(x86_fp80) [[NOT_READNONE]] // HAS_ERRNO: declare i64 @llrintl(x86_fp80) [[NOT_READNONE]]
__builtin_llround(f); __builtin_llroundf(f); __builtin_llroundl(f); __builtin_llround(f); __builtin_llroundf(f); __builtin_llroundl(f);
// NO__ERRNO: declare i64 @llvm.llround.i64.f64(double) [[READNONE_INTRINSIC]] // NO__ERRNO: declare i64 @llvm.llround.i64.f64(double) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @llvm.llround.i64.f32(float) [[READNONE_INTRINSIC]] // NO__ERRNO: declare i64 @llvm.llround.i64.f32(float) [[READNONE_INTRINSIC]]
▲ Show 20 Lines • Show All 44 Lines • ▼ Show 20 Lines
// NO__ERRNO: declare float @logbf(float) [[READNONE]] // NO__ERRNO: declare float @logbf(float) [[READNONE]]
// NO__ERRNO: declare x86_fp80 @logbl(x86_fp80) [[READNONE]] // NO__ERRNO: declare x86_fp80 @logbl(x86_fp80) [[READNONE]]
// HAS_ERRNO: declare double @logb(double) [[NOT_READNONE]] // HAS_ERRNO: declare double @logb(double) [[NOT_READNONE]]
// HAS_ERRNO: declare float @logbf(float) [[NOT_READNONE]] // HAS_ERRNO: declare float @logbf(float) [[NOT_READNONE]]
// HAS_ERRNO: declare x86_fp80 @logbl(x86_fp80) [[NOT_READNONE]] // HAS_ERRNO: declare x86_fp80 @logbl(x86_fp80) [[NOT_READNONE]]
__builtin_lrint(f); __builtin_lrintf(f); __builtin_lrintl(f); __builtin_lrint(f); __builtin_lrintf(f); __builtin_lrintl(f);
// NO__ERRNO: declare i64 @lrint(double) [[READNONE]] // NO__ERRNO: declare i64 @llvm.lrint.i64.f64(double) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @lrintf(float) [[READNONE]] // NO__ERRNO: declare i64 @llvm.lrint.i64.f32(float) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @lrintl(x86_fp80) [[READNONE]] // NO__ERRNO: declare i64 @llvm.lrint.i64.f80(x86_fp80) [[READNONE_INTRINSIC]]
// HAS_ERRNO: declare i64 @lrint(double) [[NOT_READNONE]] // HAS_ERRNO: declare i64 @lrint(double) [[NOT_READNONE]]
// HAS_ERRNO: declare i64 @lrintf(float) [[NOT_READNONE]] // HAS_ERRNO: declare i64 @lrintf(float) [[NOT_READNONE]]
// HAS_ERRNO: declare i64 @lrintl(x86_fp80) [[NOT_READNONE]] // HAS_ERRNO: declare i64 @lrintl(x86_fp80) [[NOT_READNONE]]
__builtin_lround(f); __builtin_lroundf(f); __builtin_lroundl(f); __builtin_lround(f); __builtin_lroundf(f); __builtin_lroundl(f);
// NO__ERRNO: declare i64 @llvm.lround.i64.f64(double) [[READNONE_INTRINSIC]] // NO__ERRNO: declare i64 @llvm.lround.i64.f64(double) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @llvm.lround.i64.f32(float) [[READNONE_INTRINSIC]] // NO__ERRNO: declare i64 @llvm.lround.i64.f32(float) [[READNONE_INTRINSIC]]
▲ Show 20 Lines • Show All 165 Lines • Show Last 20 Lines

clang/test/CodeGen/math-libcalls.c

Show First 20 Lines • Show All 302 Lines • ▼ Show 20 Lines
// NO__ERRNO: declare float @lgammaf(float) [[NOT_READNONE]] // NO__ERRNO: declare float @lgammaf(float) [[NOT_READNONE]]
// NO__ERRNO: declare x86_fp80 @lgammal(x86_fp80) [[NOT_READNONE]] // NO__ERRNO: declare x86_fp80 @lgammal(x86_fp80) [[NOT_READNONE]]
// HAS_ERRNO: declare double @lgamma(double) [[NOT_READNONE]] // HAS_ERRNO: declare double @lgamma(double) [[NOT_READNONE]]
// HAS_ERRNO: declare float @lgammaf(float) [[NOT_READNONE]] // HAS_ERRNO: declare float @lgammaf(float) [[NOT_READNONE]]
// HAS_ERRNO: declare x86_fp80 @lgammal(x86_fp80) [[NOT_READNONE]] // HAS_ERRNO: declare x86_fp80 @lgammal(x86_fp80) [[NOT_READNONE]]
llrint(f); llrintf(f); llrintl(f); llrint(f); llrintf(f); llrintl(f);
// NO__ERRNO: declare i64 @llrint(double) [[READNONE]] // NO__ERRNO: declare i64 @llvm.llrint.i64.f64(double) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @llrintf(float) [[READNONE]] // NO__ERRNO: declare i64 @llvm.llrint.i64.f32(float) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @llrintl(x86_fp80) [[READNONE]] // NO__ERRNO: declare i64 @llvm.llrint.i64.f80(x86_fp80) [[READNONE_INTRINSIC]]
// HAS_ERRNO: declare i64 @llrint(double) [[NOT_READNONE]] // HAS_ERRNO: declare i64 @llrint(double) [[NOT_READNONE]]
// HAS_ERRNO: declare i64 @llrintf(float) [[NOT_READNONE]] // HAS_ERRNO: declare i64 @llrintf(float) [[NOT_READNONE]]
// HAS_ERRNO: declare i64 @llrintl(x86_fp80) [[NOT_READNONE]] // HAS_ERRNO: declare i64 @llrintl(x86_fp80) [[NOT_READNONE]]
llround(f); llroundf(f); llroundl(f); llround(f); llroundf(f); llroundl(f);
// NO__ERRNO: declare i64 @llvm.llround.i64.f64(double) [[READNONE_INTRINSIC]] // NO__ERRNO: declare i64 @llvm.llround.i64.f64(double) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @llvm.llround.i64.f32(float) [[READNONE_INTRINSIC]] // NO__ERRNO: declare i64 @llvm.llround.i64.f32(float) [[READNONE_INTRINSIC]]
▲ Show 20 Lines • Show All 44 Lines • ▼ Show 20 Lines
// NO__ERRNO: declare float @logbf(float) [[READNONE]] // NO__ERRNO: declare float @logbf(float) [[READNONE]]
// NO__ERRNO: declare x86_fp80 @logbl(x86_fp80) [[READNONE]] // NO__ERRNO: declare x86_fp80 @logbl(x86_fp80) [[READNONE]]
// HAS_ERRNO: declare double @logb(double) [[NOT_READNONE]] // HAS_ERRNO: declare double @logb(double) [[NOT_READNONE]]
// HAS_ERRNO: declare float @logbf(float) [[NOT_READNONE]] // HAS_ERRNO: declare float @logbf(float) [[NOT_READNONE]]
// HAS_ERRNO: declare x86_fp80 @logbl(x86_fp80) [[NOT_READNONE]] // HAS_ERRNO: declare x86_fp80 @logbl(x86_fp80) [[NOT_READNONE]]
lrint(f); lrintf(f); lrintl(f); lrint(f); lrintf(f); lrintl(f);
// NO__ERRNO: declare i64 @lrint(double) [[READNONE]] // NO__ERRNO: declare i64 @llvm.lrint.i64.f64(double) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @lrintf(float) [[READNONE]] // NO__ERRNO: declare i64 @llvm.lrint.i64.f32(float) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @lrintl(x86_fp80) [[READNONE]] // NO__ERRNO: declare i64 @llvm.lrint.i64.f80(x86_fp80) [[READNONE_INTRINSIC]]
// HAS_ERRNO: declare i64 @lrint(double) [[NOT_READNONE]] // HAS_ERRNO: declare i64 @lrint(double) [[NOT_READNONE]]
// HAS_ERRNO: declare i64 @lrintf(float) [[NOT_READNONE]] // HAS_ERRNO: declare i64 @lrintf(float) [[NOT_READNONE]]
// HAS_ERRNO: declare i64 @lrintl(x86_fp80) [[NOT_READNONE]] // HAS_ERRNO: declare i64 @lrintl(x86_fp80) [[NOT_READNONE]]
lround(f); lroundf(f); lroundl(f); lround(f); lroundf(f); lroundl(f);
// NO__ERRNO: declare i64 @llvm.lround.i64.f64(double) [[READNONE_INTRINSIC]] // NO__ERRNO: declare i64 @llvm.lround.i64.f64(double) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @llvm.lround.i64.f32(float) [[READNONE_INTRINSIC]] // NO__ERRNO: declare i64 @llvm.lround.i64.f32(float) [[READNONE_INTRINSIC]]
▲ Show 20 Lines • Show All 163 Lines • Show Last 20 Lines