Page MenuHomePhabricator

kristina (Kristina Brooks)
Bikeshed Expert

Projects

User does not belong to any projects.

User Details

User Since
Apr 8 2018, 2:18 PM (103 w, 2 d)

Maintainer of an LLVM backend fork for Broadcom VideoCore4, never went upstream as Julian's GCC port turned out to work a lot better and did not require a separate assembler/linker. Expert on Darwin kernel, Mach-O file format, dynamic linking infrastructure on Darwin (dyld, shared caches, codesigning).

Personal GitHub Account: https://github.com/christinaa
Personal Blog: http://crna.cc/
Use notstina (at) gmail (dot) com if you need to email me.

Not representing any organization.

Recent Activity

Mar 2 2020

kristina accepted D75373: [Clang] Fix Hurd toolchain class hierarchy.

The patch did not make sense conceptually. Hurd is not Linux. I think now it makes more sense.

Mar 2 2020, 1:05 AM · Restricted Project

Feb 8 2020

kristina added a comment to D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu.

I feel like in this specific case it may be worth splitting this into two patches:

Feb 8 2020, 9:17 AM · Restricted Project

Jan 5 2020

kristina committed rGce67db418537: [Clang] Force rtlib=platform in test to avoid fails with CLANG_DEFAULT_RTLIB (authored by kristina).
[Clang] Force rtlib=platform in test to avoid fails with CLANG_DEFAULT_RTLIB
Jan 5 2020, 11:30 PM
kristina closed D72236: [Clang] Force rtlib=platform in test to avoid fails with CLANG_DEFAULT_RTLIB.
Jan 5 2020, 11:30 PM · Restricted Project
kristina created D72236: [Clang] Force rtlib=platform in test to avoid fails with CLANG_DEFAULT_RTLIB.
Jan 5 2020, 4:25 PM · Restricted Project
kristina updated subscribers of D72233: Add a new AST matcher 'optionally'..
Jan 5 2020, 3:10 PM
kristina added reviewers for D72233: Add a new AST matcher 'optionally'.: steveire, lebedev.ri, aaron.ballman.

Add some reviewers.

Jan 5 2020, 2:55 PM
kristina abandoned D56482: DO NOT SUBMIT. Draft for guidelines on using Phabricator..

Abandoning in favor of D71916.

Jan 5 2020, 2:45 PM · Restricted Project
kristina added a comment to D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.

For future - Since you seem to put up a lot of (well, almost all) patches related to Hurd support, may I suggest requesting commit access so you can land patches yourself after review?

Jan 5 2020, 1:59 PM · Restricted Project
kristina committed rGb18cb9c47166: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default (authored by kristina).
[Gnu toolchain] Look at standard GCC paths for libstdcxx by default
Jan 5 2020, 1:50 PM
kristina closed D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.
Jan 5 2020, 1:50 PM · Restricted Project
kristina accepted D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.

On second look this seems to be caused by compiler-rt being used as the default runtime, which is not accounted for in that particular test.

Jan 5 2020, 1:33 PM · Restricted Project
kristina added a comment to D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.

I ran check-clang on a x86_64 Ubuntu 18.04 machine (toolchain compiled with compiler-rt as the default CRT and libc++/libc++abi/libunwind_llvm). I think one of the driver tests for multilib stuff may be broken, in which case it should probably be investigated/fixed before this lands. And yes you are right, this test seems to fail with this configuration even without the patch applied. Is this the same test you're referring to (cross-linux.c)?

Jan 5 2020, 12:51 PM · Restricted Project
kristina requested changes to D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.

Sorry for responding late, was away. This seems to be tripping up a regression test:

Jan 5 2020, 1:14 AM · Restricted Project

Nov 16 2019

kristina committed rG5e782e74b37f: [Docs] Remove stray :doc: directive. (authored by kristina).
[Docs] Remove stray :doc: directive.
Nov 16 2019, 3:37 PM
kristina committed rGfb55d56fcfaf: [Docs] Fix sphinx warning. (authored by kristina).
[Docs] Fix sphinx warning.
Nov 16 2019, 3:29 PM
kristina committed rG63cf7040814e: [Docs] Try fixing the tutorial toctree (authored by kristina).
[Docs] Try fixing the tutorial toctree
Nov 16 2019, 3:12 PM
kristina committed rG2916489c54a3: [Docs] Fix relative links in tutorial. (authored by kristina).
[Docs] Fix relative links in tutorial.
Nov 16 2019, 1:19 PM

Nov 13 2019

kristina added inline comments to D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.
Nov 13 2019, 12:14 PM · Restricted Project

Nov 12 2019

kristina added reviewers for D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default: mclow.lists, ldionne, EricWF, rsmith.

Added libcxx maintainers, would like one of them to sign off on this. I presume this is NFCI for Linux so it should be covered by existing regression tests?

Nov 12 2019, 7:15 PM · Restricted Project

Nov 6 2019

kristina committed rG79c89033fdf1: [Clang] Add ENABLE_LINKER_BUILD_ID to Hurd driver. (authored by kristina).
[Clang] Add ENABLE_LINKER_BUILD_ID to Hurd driver.
Nov 6 2019, 10:12 PM
kristina closed D69754: [hurd] Add --build-id option when enabled.
Nov 6 2019, 10:12 PM · Restricted Project
kristina accepted D69754: [hurd] Add --build-id option when enabled.

LGTM, at least following the same reasoning as in rC271692 (http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160530/160984.html). I presume you want to be able to allow the default to be baked into the driver.

Nov 6 2019, 9:36 PM · Restricted Project

Nov 1 2019

kristina committed rGf42671239ffd: [Support] Use /proc/self/exe for GNU Hurd (authored by kristina).
[Support] Use /proc/self/exe for GNU Hurd
Nov 1 2019, 10:38 AM
kristina closed D69683: [Hurd]: use /proc/self/exe to get program path.
Nov 1 2019, 10:38 AM · Restricted Project
kristina accepted D69683: [Hurd]: use /proc/self/exe to get program path.

gnu_hurd can work as well indeed

Nov 1 2019, 10:00 AM · Restricted Project
kristina added a comment to D69683: [Hurd]: use /proc/self/exe to get program path.

Is there a better way to check for a Hurd host than using the __GNU__ preprocessor macro? I'm worried it may cause some confusion otherwise similar to the issue with Hurd triples. It seems that Hurd target defines __gnu_hurd__, which is a lot less ambiguous and probably self-explanatory than __GNU__ (especially considering how often __GNUC__ is defined and given that it has a completely different meaning). Aside from that, LGTM!

Nov 1 2019, 9:49 AM · Restricted Project
kristina added a reviewer for D69683: [Hurd]: use /proc/self/exe to get program path: kristina.
Nov 1 2019, 9:29 AM · Restricted Project

Oct 8 2019

kristina committed rG0746aafd8975: [TypeSize] Fix module builds (cassert) (authored by kristina).
[TypeSize] Fix module builds (cassert)
Oct 8 2019, 8:59 PM
kristina committed rL374138: [TypeSize] Fix module builds (cassert).
[TypeSize] Fix module builds (cassert)
Oct 8 2019, 8:59 PM

Oct 7 2019

kristina committed rL374019: Request commit access for kristina.
Request commit access for kristina
Oct 7 2019, 10:27 PM

Oct 3 2019

kristina added a comment to D68410: [AttrDocs] document always_inline.

Just linking relevant bug for the record: https://bugs.llvm.org/show_bug.cgi?id=43517

Oct 3 2019, 9:24 PM · Restricted Project
kristina committed rG43817e1915bb: Revert 373551 (CodeExpander.cpp CMake issue) (authored by kristina).
Revert 373551 (CodeExpander.cpp CMake issue)
Oct 3 2019, 4:04 AM
kristina committed rL373581: Revert 373551 (CodeExpander.cpp CMake issue).
Revert 373551 (CodeExpander.cpp CMake issue)
Oct 3 2019, 4:04 AM
kristina added a reverting change for rL373551: [gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion: rL373581: Revert 373551 (CodeExpander.cpp CMake issue).
Oct 3 2019, 4:04 AM
kristina committed rGabc35f1bd8e2: Revert 373555: libLLVM+modules failure with CMake 3.10.2 (authored by kristina).
Revert 373555: libLLVM+modules failure with CMake 3.10.2
Oct 3 2019, 3:50 AM
kristina committed rL373579: Revert 373555: libLLVM+modules failure with CMake 3.10.2.
Revert 373555: libLLVM+modules failure with CMake 3.10.2
Oct 3 2019, 3:50 AM
kristina added a reverting change for rL373555: [gicombiner] Make rL373551 compatible with older cmakes: rL373579: Revert 373555: libLLVM+modules failure with CMake 3.10.2.
Oct 3 2019, 3:50 AM

Sep 13 2019

kristina added a comment to D66843: Change datalayout compatibility check for X86 to allow datalayouts without the new address spaces..

This seems to have been causing problems during linking, got hundreds of those:

Sep 13 2019, 10:33 AM · Restricted Project

Aug 10 2019

kristina committed rG3ab587df82c8: [modulemap] Add AArch64SVEACLETypes.def (authored by kristina).
[modulemap] Add AArch64SVEACLETypes.def
Aug 10 2019, 1:25 AM
kristina committed rL368508: [modulemap] Add AArch64SVEACLETypes.def .
[modulemap] Add AArch64SVEACLETypes.def
Aug 10 2019, 1:20 AM

Aug 6 2019

kristina committed rG26e60f065318: [Attributor][modulemap] Revert r368064 but fix the build (authored by kristina).
[Attributor][modulemap] Revert r368064 but fix the build
Aug 6 2019, 12:54 PM
kristina committed rL368076: [Attributor][modulemap] Revert r368064 but fix the build.
[Attributor][modulemap] Revert r368064 but fix the build
Aug 6 2019, 12:52 PM
kristina closed D65821: [Attributor][modulemap] Revert r368064 but fix the build.
Aug 6 2019, 12:52 PM · Restricted Project
kristina accepted D65821: [Attributor][modulemap] Revert r368064 but fix the build.

Thank you for taking the time to fix this properly, Modules+LTO linked successfully.

Aug 6 2019, 12:44 PM · Restricted Project
kristina committed rG3a4d5ed232dc: [modulemap] exclude a non-module friendly header (authored by kristina).
[modulemap] exclude a non-module friendly header
Aug 6 2019, 10:20 AM
kristina committed rL368064: [modulemap] exclude a non-module friendly header.
[modulemap] exclude a non-module friendly header
Aug 6 2019, 10:19 AM

Aug 4 2019

kristina added 2 commit(s) for D63378: [ORC] WIP Speculative compilation: rGf5c40cb9002a: Speculative Compilation, rL367756: Speculative Compilation.
Aug 4 2019, 5:17 AM · Restricted Project, Restricted Project
kristina added an edge to rGf5c40cb9002a: Speculative Compilation: D63378: [ORC] WIP Speculative compilation.
Aug 4 2019, 5:17 AM
kristina added an edge to rL367756: Speculative Compilation: D63378: [ORC] WIP Speculative compilation.
Aug 4 2019, 5:17 AM

Jul 9 2019

kristina committed rG21b28fb8c5fe: Fix modular build issues caused by BitCodes.h (authored by kristina).
Fix modular build issues caused by BitCodes.h
Jul 9 2019, 8:54 PM
kristina committed rL365594: Fix modular build issues caused by BitCodes.h.
Fix modular build issues caused by BitCodes.h
Jul 9 2019, 8:52 PM
kristina closed D64469: Fixing modular build issues caused by BitCodes.h.
Jul 9 2019, 8:52 PM · Restricted Project
kristina updated the summary of D64469: Fixing modular build issues caused by BitCodes.h.
Jul 9 2019, 8:44 PM · Restricted Project
kristina created D64469: Fixing modular build issues caused by BitCodes.h.
Jul 9 2019, 8:36 PM · Restricted Project

Jun 4 2019

kristina committed rGc0eb8a982538: Add __FILE_NAME__ to ReleaseNotes. NFC (authored by kristina).
Add __FILE_NAME__ to ReleaseNotes. NFC
Jun 4 2019, 8:45 PM
kristina committed rL362581: Add __FILE_NAME__ to ReleaseNotes. NFC.
Add __FILE_NAME__ to ReleaseNotes. NFC
Jun 4 2019, 8:45 PM
kristina added reviewers for D62842: tvos_version_min and watchos_version_min flag: lhames, kledzik.

As trivial as it may seem, this is missing tests, even if it's for a few flags. Also please try to include context with your patches as it makes them much easier to review. If you have some sort of plan for actually bringing Mach-O LLD closer to ld64 feature-wise, I think llvm-dev may be a good place to actually outline your plan for this, which will give everyone a more clear picture of what future changes you have planned in mind.

Jun 4 2019, 1:07 PM · Restricted Project, lld
kristina added a comment to D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF.

Experienced the same, updated my test build configuration to always force CLANG_ENABLE_STATIC_ANALYZER to On when building with tests. Maybe it's worth adding a warning about when Clang tests are being built?

Jun 4 2019, 12:59 PM · Restricted Project
kristina added a reviewer for D62842: tvos_version_min and watchos_version_min flag: ruiu.
Jun 4 2019, 12:37 PM · Restricted Project, lld

May 28 2019

kristina added a comment to D61975: [CodeGen] Fix hashing for MO_ExternalSymbol MachineOperands..

Would it make sense to also add a test explicitly using llvm::hash_combine

Using llvm::hash_combine on what, exactly?

as well as a negative test where hash code comparison fails for a literal and the same literal in a StringRef every time

You mean something like ASSERT_NE(SymName1.data(), SymName2.data());?

May 28 2019, 11:48 AM · Restricted Project

May 25 2019

kristina added a comment to D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++.

I have a question about qsort.. If we provide own implementation of qsort and replace calls to libc's qsort to our qsort, we could fully inline cmp function then. Ideas?

May 25 2019, 2:47 AM · Restricted Project, Restricted Project
kristina added a comment to D61975: [CodeGen] Fix hashing for MO_ExternalSymbol MachineOperands..

Seems good. Would it make sense to also add a test explicitly using llvm::hash_combine, as well as a negative test where hash code comparison fails for a literal and the same literal in a StringRef every time (if it's possible to do reliably)? Just a random suggestion, probably overly paranoid.

May 25 2019, 2:25 AM · Restricted Project

May 16 2019

kristina committed rG5652063eff60: [Clang][Docs] Document __FILE_NAME__. NFC (authored by kristina).
[Clang][Docs] Document __FILE_NAME__. NFC
May 16 2019, 11:45 PM
kristina added 2 commit(s) for D61756: Add a __FILE_NAME__ macro.: rC360994: [Clang][Docs] Document __FILE_NAME__. NFC, rL360994: [Clang][Docs] Document __FILE_NAME__. NFC.
May 16 2019, 11:45 PM · Restricted Project
kristina added an edge to rC360994: [Clang][Docs] Document __FILE_NAME__. NFC: D61756: Add a __FILE_NAME__ macro..
May 16 2019, 11:45 PM
kristina added an edge to rL360994: [Clang][Docs] Document __FILE_NAME__. NFC: D61756: Add a __FILE_NAME__ macro..
May 16 2019, 11:45 PM
kristina committed rL360994: [Clang][Docs] Document __FILE_NAME__. NFC.
[Clang][Docs] Document __FILE_NAME__. NFC
May 16 2019, 11:44 PM
kristina committed rC360994: [Clang][Docs] Document __FILE_NAME__. NFC.
[Clang][Docs] Document __FILE_NAME__. NFC
May 16 2019, 11:44 PM
kristina added a comment to D54742: [CodeMetrics] Don't let extends of i1 be free..

My bad, I didn't check well enough, it seems an unrelated patch made certain tests crash due to asserts. Thanks to @craig.topper for pointing that out.

May 16 2019, 10:54 PM
kristina added a comment to D54742: [CodeMetrics] Don't let extends of i1 be free..

This seems to be causing multiple performance regressions across several bots in compile time and execution time tests.

May 16 2019, 8:56 PM
kristina added 1 commit(s) for D54742: [CodeMetrics] Don't let extends of i1 be free.: rL360970: [CodeMetrics] Don't let extends of i1 be free..
May 16 2019, 8:49 PM
kristina added an edge to rL360970: [CodeMetrics] Don't let extends of i1 be free.: D54742: [CodeMetrics] Don't let extends of i1 be free..
May 16 2019, 8:49 PM
kristina committed rGbd9748424165: Reland "[Clang][PP] Add the __FILE_NAME__ builtin macro" (authored by kristina).
Reland "[Clang][PP] Add the __FILE_NAME__ builtin macro"
May 16 2019, 2:12 PM
kristina committed rL360938: Reland "[Clang][PP] Add the __FILE_NAME__ builtin macro".
Reland "[Clang][PP] Add the __FILE_NAME__ builtin macro"
May 16 2019, 2:11 PM
kristina committed rC360938: Reland "[Clang][PP] Add the __FILE_NAME__ builtin macro".
Reland "[Clang][PP] Add the __FILE_NAME__ builtin macro"
May 16 2019, 2:11 PM
kristina closed D61756: Add a __FILE_NAME__ macro..
May 16 2019, 2:11 PM · Restricted Project
kristina updated the diff for D61756: Add a __FILE_NAME__ macro..

Revised to use llvm::sys::path::filename to avoid issues on Windows hosts.

May 16 2019, 12:28 PM · Restricted Project

May 15 2019

kristina reopened D61756: Add a __FILE_NAME__ macro..

Reverted in rL360842 as Windows bots were failing.

May 15 2019, 8:42 PM · Restricted Project
kristina committed rG9d65624bf657: Revert r360833 until I can work out the issue with Win32 bots (authored by kristina).
Revert r360833 until I can work out the issue with Win32 bots
May 15 2019, 8:28 PM
kristina committed rL360842: Revert r360833 until I can work out the issue with Win32 bots.
Revert r360833 until I can work out the issue with Win32 bots
May 15 2019, 8:27 PM
kristina committed rC360842: Revert r360833 until I can work out the issue with Win32 bots.
Revert r360833 until I can work out the issue with Win32 bots
May 15 2019, 8:27 PM
kristina committed rG69e927662dc9: Fix assumption about Win32 paths in r360833 (authored by kristina).
Fix assumption about Win32 paths in r360833
May 15 2019, 7:44 PM
kristina committed rL360839: Fix assumption about Win32 paths in r360833.
Fix assumption about Win32 paths in r360833
May 15 2019, 7:44 PM
kristina committed rC360839: Fix assumption about Win32 paths in r360833.
Fix assumption about Win32 paths in r360833
May 15 2019, 7:44 PM
kristina committed rG3acc1d1be329: [Clang][PP] Add the __FILE_NAME__ builtin macro. (authored by kristina).
[Clang][PP] Add the __FILE_NAME__ builtin macro.
May 15 2019, 5:52 PM
kristina committed rC360833: [Clang][PP] Add the __FILE_NAME__ builtin macro..
[Clang][PP] Add the __FILE_NAME__ builtin macro.
May 15 2019, 5:50 PM
kristina committed rL360833: [Clang][PP] Add the __FILE_NAME__ builtin macro..
[Clang][PP] Add the __FILE_NAME__ builtin macro.
May 15 2019, 5:50 PM
kristina closed D61756: Add a __FILE_NAME__ macro..
May 15 2019, 5:50 PM · Restricted Project
kristina added a comment to D61756: Add a __FILE_NAME__ macro..

Landing this as discussed on IRC, will try to push it forward with WG14.

May 15 2019, 5:42 PM · Restricted Project
kristina added a comment to D61756: Add a __FILE_NAME__ macro..

@rsmith Ping.

May 15 2019, 3:28 PM · Restricted Project

May 10 2019

kristina added a comment to D61756: Add a __FILE_NAME__ macro..

Need @rsmith to bless this as it's introducing a nonstandard extension, however small it may be. The original diff did have a consensus on it, so I didn't really put up a formal RFC on cfe-dev.

May 10 2019, 4:38 PM · Restricted Project
kristina updated the diff for D61756: Add a __FILE_NAME__ macro..

Actually I got it wrong, the path is normalized to use regular slashes at that point, so there is no point in handling backslashes in paths at all even with Microsoft extensions.

May 10 2019, 3:55 PM · Restricted Project

May 9 2019

kristina updated the summary of D61756: Add a __FILE_NAME__ macro..
May 9 2019, 1:52 PM · Restricted Project
kristina updated the diff for D61756: Add a __FILE_NAME__ macro..

Fix style, remove unnecessary braces, add missing newline.

May 9 2019, 1:29 PM · Restricted Project
kristina added a reviewer for D61756: Add a __FILE_NAME__ macro.: dexonsmith.
May 9 2019, 1:24 PM · Restricted Project
kristina abandoned D17741: adds __FILE_BASENAME__ builtin macro.

Superseded by D61756

May 9 2019, 1:23 PM
kristina created D61756: Add a __FILE_NAME__ macro..
May 9 2019, 1:20 PM · Restricted Project

May 8 2019

kristina commandeered D17741: adds __FILE_BASENAME__ builtin macro.

Sorry, forgot about this, will make a new diff with just the macro for review later tonight.

May 8 2019, 9:30 AM

Apr 9 2019

kristina committed rGa1c44941f360: Update modulemaps for Analysis/VecFuncs.def. (authored by kristina).
Update modulemaps for Analysis/VecFuncs.def.
Apr 9 2019, 10:04 AM