This allow to avoid materialize constants which would required 2 instructions (mov plus movk for instance) when optimizing for size.
Details
Diff Detail
Event Timeline
TargetLoweringBase::isFPImmLegal() could have a default value of false for ForCodeSize.
include/llvm/CodeGen/TargetLowering.h | ||
---|---|---|
782 | CamelCase. | |
lib/Target/AArch64/AArch64ISelLowering.cpp | ||
5386 | Ditto. | |
lib/Target/AArch64/AArch64ISelLowering.h | ||
290 | Ditto. | |
lib/Target/AMDGPU/AMDGPUISelLowering.cpp | ||
643 | Ditto. | |
lib/Target/AMDGPU/AMDGPUISelLowering.h | ||
165 | Ditto. | |
lib/Target/ARM/ARMISelLowering.cpp | ||
14370 | Ditto. | |
lib/Target/ARM/ARMISelLowering.h | ||
482 | Ditto. | |
lib/Target/Hexagon/HexagonISelLowering.cpp | ||
2928 | Ditto. | |
lib/Target/Hexagon/HexagonISelLowering.h | ||
288 | Ditto. | |
lib/Target/Mips/MipsISelLowering.cpp | ||
4150 | Ditto. | |
lib/Target/Mips/MipsISelLowering.h | ||
679 | Ditto. | |
lib/Target/PowerPC/PPCISelLowering.cpp | ||
14326 | Ditto. | |
lib/Target/PowerPC/PPCISelLowering.h | ||
891 | Ditto. | |
lib/Target/SystemZ/SystemZISelLowering.cpp | ||
695 | Ditto. | |
lib/Target/SystemZ/SystemZISelLowering.h | ||
404 | Ditto. | |
lib/Target/X86/X86ISelLowering.cpp | ||
4804 | Ditto. | |
lib/Target/X86/X86ISelLowering.h | ||
1013 | Ditto. |
lib/Target/AArch64/AArch64ISelLowering.cpp | ||
---|---|---|
5398 | Oops! | |
lib/Target/ARM/ARMISelLowering.cpp | ||
4177 | Should this be in another patch? | |
4182 | Ditto. | |
4188 | Ditto. | |
4214–4215 | Ditto. | |
13703–13704 | ? | |
lib/Target/SystemZ/SystemZISelLowering.cpp | ||
3721–3722 | Ditto. | |
lib/Target/SystemZ/SystemZISelLowering.h | ||
645–646 | Should this be in another patch? | |
lib/Target/X86/X86ISelLowering.cpp | ||
6887–6888 | Ditto. | |
7451–7452 | Ditto. | |
7467–7468 | Ditto. | |
28818–28819 | Ditto. | |
32763–32764 | Ditto. | |
41771–41772 | Ditto. |
lib/Target/AArch64/AArch64ISelLowering.cpp | ||
---|---|---|
5398 | Hi Evandro, I am not following your remarks. At least on phabricator they are pointing on code section that has not been actually changed. Should I submit the patch again? |
lib/Target/AArch64/AArch64ISelLowering.cpp | ||
---|---|---|
5398 | I don't know what Phabricator showed me before either. Please, ignore my previous review. I'll go over the patch again. |
CamelCase.