Asserting on invalid input isn't very nice, hence the patch to emit an error instead.
This is the first of many patches to overhaul the way we handle checker options, and I admit that it's a kind of "things that didn't fit anywhere else" patch.
Differential D57850
[analyzer] Emit an error rather than assert on invalid checker option input Szelethus on Feb 6 2019, 2:43 PM. Authored by
Details
Asserting on invalid input isn't very nice, hence the patch to emit an error instead. This is the first of many patches to overhaul the way we handle checker options, and I admit that it's a kind of "things that didn't fit anywhere else" patch.
Diff Detail
Event TimelineComment Actions Looks cool, thanks!!
Comment Actions
Comment Actions
Np, please do, the patch is great regardless!
|
I suggest hardcoding the word "value" in every message rather than putting it here, because it may be desirable to substitute it with something more specific or more accurate in every checker's specific circumstances.
Eg., "a non-negative integer" would be more precise than "a non-negative value".