george.karpenkov (George Karpenkov)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 14 2017, 1:59 PM (58 w, 1 d)

Recent Activity

Fri, May 25

george.karpenkov added a comment to D47402: [analyzer] Improve simplifySVal performance further..

@NoQ we should make sure the memory is not exploding and that we don't make the analyzer slower in other cases. Though we could commit this, and then let CI figure out potential regressions.

Fri, May 25, 6:03 PM
george.karpenkov added inline comments to D43134: [analyzer] [tests] Show detailed statistics comparision in CmpRuns.
Fri, May 25, 10:35 AM
george.karpenkov requested review of D47292: [libFuzzer] [NFC] Generalize DSO tests to work even when files are moved..

Reverted in r333257

Fri, May 25, 10:29 AM

Thu, May 24

george.karpenkov committed rL333245: [libFuzzer] [NFC] Generalize fdmask test..
[libFuzzer] [NFC] Generalize fdmask test.
Thu, May 24, 5:00 PM
george.karpenkov committed rL333244: [libFuzzer] [NFC] Do not remove SanitizerLintCheck from libFuzzer tests.
[libFuzzer] [NFC] Do not remove SanitizerLintCheck from libFuzzer tests
Thu, May 24, 5:00 PM
george.karpenkov committed rL333243: [libFuzzer] [NFC] Generalize DSO tests to work even when files are moved..
[libFuzzer] [NFC] Generalize DSO tests to work even when files are moved.
Thu, May 24, 5:00 PM
george.karpenkov committed rL333242: [libFuzzer] Fix multi-arch build support for fuzzer tests..
[libFuzzer] Fix multi-arch build support for fuzzer tests.
Thu, May 24, 5:00 PM
george.karpenkov committed rL333241: [libFuzzer] Run libFuzzer unit tests only on host architecture..
[libFuzzer] Run libFuzzer unit tests only on host architecture.
Thu, May 24, 5:00 PM
george.karpenkov committed rL333240: [libFuzzer] XFAIL a few libFuzzer tests on iOS..
[libFuzzer] XFAIL a few libFuzzer tests on iOS.
Thu, May 24, 5:00 PM
george.karpenkov committed rCRT333245: [libFuzzer] [NFC] Generalize fdmask test..
[libFuzzer] [NFC] Generalize fdmask test.
Thu, May 24, 5:00 PM
george.karpenkov committed rL333239: [libFuzzer] Fix a typo in CMake configuration..
[libFuzzer] Fix a typo in CMake configuration.
Thu, May 24, 5:00 PM
george.karpenkov closed D47294: [libFuzzer] [NFC] Generalize fdmask test..
Thu, May 24, 5:00 PM
george.karpenkov committed rCRT333244: [libFuzzer] [NFC] Do not remove SanitizerLintCheck from libFuzzer tests.
[libFuzzer] [NFC] Do not remove SanitizerLintCheck from libFuzzer tests
Thu, May 24, 5:00 PM
george.karpenkov committed rCRT333243: [libFuzzer] [NFC] Generalize DSO tests to work even when files are moved..
[libFuzzer] [NFC] Generalize DSO tests to work even when files are moved.
Thu, May 24, 5:00 PM
george.karpenkov committed rCRT333242: [libFuzzer] Fix multi-arch build support for fuzzer tests..
[libFuzzer] Fix multi-arch build support for fuzzer tests.
Thu, May 24, 5:00 PM
george.karpenkov closed D47293: [libFuzzer] [NFC] Do not remove SanitizerLintCheck from libFuzzer tests.
Thu, May 24, 5:00 PM
george.karpenkov closed D47292: [libFuzzer] [NFC] Generalize DSO tests to work even when files are moved..
Thu, May 24, 5:00 PM
george.karpenkov committed rCRT333241: [libFuzzer] Run libFuzzer unit tests only on host architecture..
[libFuzzer] Run libFuzzer unit tests only on host architecture.
Thu, May 24, 5:00 PM
george.karpenkov closed D47287: [libFuzzer] Fix multi-arch build support for fuzzer tests..
Thu, May 24, 5:00 PM
george.karpenkov committed rCRT333240: [libFuzzer] XFAIL a few libFuzzer tests on iOS..
[libFuzzer] XFAIL a few libFuzzer tests on iOS.
Thu, May 24, 5:00 PM
george.karpenkov committed rCRT333239: [libFuzzer] Fix a typo in CMake configuration..
[libFuzzer] Fix a typo in CMake configuration.
Thu, May 24, 5:00 PM
george.karpenkov closed D47286: [libFuzzer] Run libFuzzer unit tests only on host architecture..
Thu, May 24, 5:00 PM
george.karpenkov closed D47284: [libFuzzer] [NFC] XFAIL a few tests on iOS.
Thu, May 24, 5:00 PM
george.karpenkov closed D47283: [libFuzzer] Fix a typo in CMake configuration..
Thu, May 24, 5:00 PM
george.karpenkov added inline comments to D47295: [libFuzzer] [NFC] Make compiler command generation more readable..
Thu, May 24, 4:51 PM
george.karpenkov updated the diff for D47295: [libFuzzer] [NFC] Make compiler command generation more readable..
Thu, May 24, 4:51 PM
george.karpenkov updated the diff for D47288: [libFuzzer] [NFC] Do not use hardcoded relative paths in tests..
Thu, May 24, 4:45 PM
george.karpenkov added inline comments to D47295: [libFuzzer] [NFC] Make compiler command generation more readable..
Thu, May 24, 4:21 PM
george.karpenkov added a comment to D47288: [libFuzzer] [NFC] Do not use hardcoded relative paths in tests..

George, how do you create such stack of patches? Is there any automated tool for that?

Thu, May 24, 4:07 PM
george.karpenkov added inline comments to D47288: [libFuzzer] [NFC] Do not use hardcoded relative paths in tests..
Thu, May 24, 3:32 PM
george.karpenkov added inline comments to D47288: [libFuzzer] [NFC] Do not use hardcoded relative paths in tests..
Thu, May 24, 3:26 PM
george.karpenkov added inline comments to D47288: [libFuzzer] [NFC] Do not use hardcoded relative paths in tests..
Thu, May 24, 2:56 PM
george.karpenkov added a comment to D47286: [libFuzzer] Run libFuzzer unit tests only on host architecture..

What happens without this change?

Thu, May 24, 2:53 PM
george.karpenkov added a comment to D47286: [libFuzzer] Run libFuzzer unit tests only on host architecture..

IIRC that's how it is for all sanitizers.

Thu, May 24, 2:53 PM
george.karpenkov resigned from D47324: Add llvm-bcanalyzer as an LLD test dependency.
Thu, May 24, 10:52 AM

Wed, May 23

george.karpenkov added inline comments to D47295: [libFuzzer] [NFC] Make compiler command generation more readable..
Wed, May 23, 6:26 PM
george.karpenkov added a comment to D47294: [libFuzzer] [NFC] Generalize fdmask test..

@morehouse we have issues with stdout/stderr arriving in unexpected order when run on devices and streaming across the network.
In this case adding -DAG seems like an easiest choice, since the test purpose is to check that close_fd_mask would close the corresponding file descriptor.

Wed, May 23, 6:26 PM
george.karpenkov accepted D47305: [analyzer] pr37270: Fix binding constructed object to DeclStmt when ConstructionContext is already lost..
Wed, May 23, 6:21 PM
george.karpenkov accepted D47304: [analyzer] NFC: Merge the functions for obtaining constructed object location and storing this location for later use..
Wed, May 23, 6:19 PM
george.karpenkov requested changes to D47303: [analyzer] NFC: Merge object construction related state traits into one..

Definitely looks much cleaner, some nits inline. Can we protect against API misuse?

Wed, May 23, 6:17 PM
george.karpenkov added dependencies for D47296: [libFuzzer] [NFC] Support multi-arch and multi-OS building and testing: D47284: [libFuzzer] [NFC] XFAIL a few tests on iOS, D47286: [libFuzzer] Run libFuzzer unit tests only on host architecture., D47283: [libFuzzer] Fix a typo in CMake configuration., D47287: [libFuzzer] Fix multi-arch build support for fuzzer tests., D47288: [libFuzzer] [NFC] Do not use hardcoded relative paths in tests., D47295: [libFuzzer] [NFC] Make compiler command generation more readable., D47294: [libFuzzer] [NFC] Generalize fdmask test., D47293: [libFuzzer] [NFC] Do not remove SanitizerLintCheck from libFuzzer tests, D47292: [libFuzzer] [NFC] Generalize DSO tests to work even when files are moved..
Wed, May 23, 3:39 PM
george.karpenkov added a dependent revision for D47283: [libFuzzer] Fix a typo in CMake configuration.: D47296: [libFuzzer] [NFC] Support multi-arch and multi-OS building and testing.
Wed, May 23, 3:39 PM
george.karpenkov added a dependent revision for D47284: [libFuzzer] [NFC] XFAIL a few tests on iOS: D47296: [libFuzzer] [NFC] Support multi-arch and multi-OS building and testing.
Wed, May 23, 3:39 PM
george.karpenkov added a dependent revision for D47286: [libFuzzer] Run libFuzzer unit tests only on host architecture.: D47296: [libFuzzer] [NFC] Support multi-arch and multi-OS building and testing.
Wed, May 23, 3:39 PM
george.karpenkov added a dependent revision for D47295: [libFuzzer] [NFC] Make compiler command generation more readable.: D47296: [libFuzzer] [NFC] Support multi-arch and multi-OS building and testing.
Wed, May 23, 3:39 PM
george.karpenkov added a dependent revision for D47292: [libFuzzer] [NFC] Generalize DSO tests to work even when files are moved.: D47296: [libFuzzer] [NFC] Support multi-arch and multi-OS building and testing.
Wed, May 23, 3:39 PM
george.karpenkov added a dependent revision for D47293: [libFuzzer] [NFC] Do not remove SanitizerLintCheck from libFuzzer tests: D47296: [libFuzzer] [NFC] Support multi-arch and multi-OS building and testing.
Wed, May 23, 3:39 PM
george.karpenkov added a dependent revision for D47294: [libFuzzer] [NFC] Generalize fdmask test.: D47296: [libFuzzer] [NFC] Support multi-arch and multi-OS building and testing.
Wed, May 23, 3:39 PM
george.karpenkov added a dependent revision for D47288: [libFuzzer] [NFC] Do not use hardcoded relative paths in tests.: D47296: [libFuzzer] [NFC] Support multi-arch and multi-OS building and testing.
Wed, May 23, 3:39 PM
george.karpenkov added a dependent revision for D47287: [libFuzzer] Fix multi-arch build support for fuzzer tests.: D47296: [libFuzzer] [NFC] Support multi-arch and multi-OS building and testing.
Wed, May 23, 3:39 PM
george.karpenkov created D47296: [libFuzzer] [NFC] Support multi-arch and multi-OS building and testing.
Wed, May 23, 3:38 PM
george.karpenkov created D47295: [libFuzzer] [NFC] Make compiler command generation more readable..
Wed, May 23, 3:36 PM
george.karpenkov created D47294: [libFuzzer] [NFC] Generalize fdmask test..
Wed, May 23, 3:23 PM
george.karpenkov created D47293: [libFuzzer] [NFC] Do not remove SanitizerLintCheck from libFuzzer tests.
Wed, May 23, 3:20 PM
george.karpenkov created D47292: [libFuzzer] [NFC] Generalize DSO tests to work even when files are moved..
Wed, May 23, 3:17 PM
george.karpenkov created D47288: [libFuzzer] [NFC] Do not use hardcoded relative paths in tests..
Wed, May 23, 3:02 PM
george.karpenkov created D47287: [libFuzzer] Fix multi-arch build support for fuzzer tests..
Wed, May 23, 2:59 PM
george.karpenkov created D47286: [libFuzzer] Run libFuzzer unit tests only on host architecture..
Wed, May 23, 2:55 PM
george.karpenkov created D47284: [libFuzzer] [NFC] XFAIL a few tests on iOS.
Wed, May 23, 2:45 PM
george.karpenkov created D47283: [libFuzzer] Fix a typo in CMake configuration..
Wed, May 23, 2:39 PM
george.karpenkov abandoned D46569: [libFuzzer] Generalize libFuzzer build and tests to multiple architectures.

OK let's try to split it further.

Wed, May 23, 2:39 PM

Mon, May 21

george.karpenkov added a comment to D47155: [analyzer] Improve simplifySVal performance..

Also we should make sure that all recursive transformations on expressions represented as DAGs should be memoized.

Mon, May 21, 3:53 PM
george.karpenkov added inline comments to D47135: [analyzer] A checker for dangling internal buffer pointers in C++.
Mon, May 21, 3:33 PM
george.karpenkov requested changes to D47155: [analyzer] Improve simplifySVal performance..
Mon, May 21, 3:22 PM
george.karpenkov added a comment to D47155: [analyzer] Improve simplifySVal performance..

@NoQ I'm really wary of magic numbers.

Mon, May 21, 3:21 PM

Fri, May 18

george.karpenkov added a comment to D46933: [analyzer] Added template argument lists to the Pathdiagnostic output.

@Szelethus I can, but since you've had quite a few patches accepted, do you want to just apply for a commit access ? https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

Fri, May 18, 2:38 PM

Thu, May 17

george.karpenkov added inline comments to D46569: [libFuzzer] Generalize libFuzzer build and tests to multiple architectures.
Thu, May 17, 5:23 PM
george.karpenkov updated the diff for D46569: [libFuzzer] Generalize libFuzzer build and tests to multiple architectures.
Thu, May 17, 2:03 PM
george.karpenkov added inline comments to D46569: [libFuzzer] Generalize libFuzzer build and tests to multiple architectures.
Thu, May 17, 1:08 PM
george.karpenkov added inline comments to D46933: [analyzer] Added template argument lists to the Pathdiagnostic output.
Thu, May 17, 1:02 PM

Wed, May 16

george.karpenkov committed rC332545: [ASTMatchers] Introduce a blockDecl matcher for matching block declarations.
[ASTMatchers] Introduce a blockDecl matcher for matching block declarations
Wed, May 16, 3:51 PM
george.karpenkov committed rC332546: [analyzer] Extend ObjCAutoreleaseWriteChecker to catch block declarations with….
[analyzer] Extend ObjCAutoreleaseWriteChecker to catch block declarations with…
Wed, May 16, 3:51 PM
george.karpenkov committed rL332546: [analyzer] Extend ObjCAutoreleaseWriteChecker to catch block declarations with….
[analyzer] Extend ObjCAutoreleaseWriteChecker to catch block declarations with…
Wed, May 16, 3:51 PM
george.karpenkov committed rL332545: [ASTMatchers] Introduce a blockDecl matcher for matching block declarations.
[ASTMatchers] Introduce a blockDecl matcher for matching block declarations
Wed, May 16, 3:51 PM
george.karpenkov closed D46984: [analyzer] Exrtend ObjCAutoreleaseWriteChecker to also catch block declarations with autoreleasing variables.
Wed, May 16, 3:51 PM
george.karpenkov closed D46980: [ASTMatchers] Introduce a blockDecl matcher for matching block declarations.
Wed, May 16, 3:51 PM
george.karpenkov committed rC332544: [analyzer] Change the warning message for GCD antipattern checker.
[analyzer] Change the warning message for GCD antipattern checker
Wed, May 16, 3:50 PM
george.karpenkov committed rL332544: [analyzer] Change the warning message for GCD antipattern checker.
[analyzer] Change the warning message for GCD antipattern checker
Wed, May 16, 3:50 PM
george.karpenkov added inline comments to D46980: [ASTMatchers] Introduce a blockDecl matcher for matching block declarations.
Wed, May 16, 3:43 PM
george.karpenkov added a dependency for D46984: [analyzer] Exrtend ObjCAutoreleaseWriteChecker to also catch block declarations with autoreleasing variables: D46980: [ASTMatchers] Introduce a blockDecl matcher for matching block declarations.
Wed, May 16, 3:31 PM
george.karpenkov added a dependent revision for D46980: [ASTMatchers] Introduce a blockDecl matcher for matching block declarations: D46984: [analyzer] Exrtend ObjCAutoreleaseWriteChecker to also catch block declarations with autoreleasing variables.
Wed, May 16, 3:31 PM
george.karpenkov created D46984: [analyzer] Exrtend ObjCAutoreleaseWriteChecker to also catch block declarations with autoreleasing variables.
Wed, May 16, 3:31 PM
george.karpenkov created D46980: [ASTMatchers] Introduce a blockDecl matcher for matching block declarations.
Wed, May 16, 3:07 PM
george.karpenkov accepted D46933: [analyzer] Added template argument lists to the Pathdiagnostic output.

LGTM provided that nits inline are fixed

Wed, May 16, 10:53 AM
george.karpenkov added a comment to D46603: [Support] TimerGroup changes.

Not sure yet whether i will land them right away, or wait for clang-tidy part.

Wed, May 16, 10:43 AM
george.karpenkov accepted D46937: [Timers] TimerGroup::printJSONValue(): print doubles with no precision loss.

LGTM

Wed, May 16, 10:36 AM

Tue, May 15

george.karpenkov committed rC332422: [analyzer] Do not crash on callback for call_once passed by value.
[analyzer] Do not crash on callback for call_once passed by value
Tue, May 15, 5:33 PM
george.karpenkov committed rL332422: [analyzer] Do not crash on callback for call_once passed by value.
[analyzer] Do not crash on callback for call_once passed by value
Tue, May 15, 5:33 PM
george.karpenkov closed D46913: [analyzer] Do not crash on callback for call_once passed by value.
Tue, May 15, 5:32 PM
george.karpenkov added a comment to D46603: [Support] TimerGroup changes.

I see four separate changes: s/.sys/mem one (can be committed without review), exposing printJSONValues and consequent adding of a lock, adding a constructor accepting a map, and fixing formatting in printJSONValue. All four look good to me, but probably should be reviewed separately.

Tue, May 15, 5:31 PM
george.karpenkov accepted D46902: [analyzer] Make plist-html multi-file..

LGTM! with stable-filename option we could even avoid the regexp.

Tue, May 15, 5:09 PM
george.karpenkov added a comment to D46913: [analyzer] Do not crash on callback for call_once passed by value.

that you don't need function to pointer decay when there's already a function pointer?

Tue, May 15, 4:48 PM
george.karpenkov created D46913: [analyzer] Do not crash on callback for call_once passed by value.
Tue, May 15, 4:09 PM

Mon, May 14

george.karpenkov committed rC332300: [analyzer] Extend the ObjCAutoreleaseWriteChecker to warn on captures as well.
[analyzer] Extend the ObjCAutoreleaseWriteChecker to warn on captures as well
Mon, May 14, 2:43 PM
george.karpenkov committed rL332300: [analyzer] Extend the ObjCAutoreleaseWriteChecker to warn on captures as well.
[analyzer] Extend the ObjCAutoreleaseWriteChecker to warn on captures as well
Mon, May 14, 2:43 PM
george.karpenkov closed D46772: [analyzer] Extend the ObjCAutoreleaseWriteChecker to warn on captures as well.
Mon, May 14, 2:43 PM
george.karpenkov closed D46772: [analyzer] Extend the ObjCAutoreleaseWriteChecker to warn on captures as well.
Mon, May 14, 2:43 PM
george.karpenkov updated the diff for D46772: [analyzer] Extend the ObjCAutoreleaseWriteChecker to warn on captures as well.
Mon, May 14, 2:11 PM
george.karpenkov updated the diff for D46772: [analyzer] Extend the ObjCAutoreleaseWriteChecker to warn on captures as well.
Mon, May 14, 1:58 PM
george.karpenkov added inline comments to D46772: [analyzer] Extend the ObjCAutoreleaseWriteChecker to warn on captures as well.
Mon, May 14, 1:57 PM