george.karpenkov (George Karpenkov)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 14 2017, 1:59 PM (27 w, 2 d)

Recent Activity

Fri, Oct 20

george.karpenkov committed rL316249: [Analyzer] Correctly handle parameters passed by reference when bodyfarming std….
[Analyzer] Correctly handle parameters passed by reference when bodyfarming std…
Fri, Oct 20, 4:30 PM
george.karpenkov closed D39031: [Analyzer] Correctly handle parameters passed by reference when bodyfarming std::call_once by committing rL316249: [Analyzer] Correctly handle parameters passed by reference when bodyfarming std….
Fri, Oct 20, 4:30 PM

Tue, Oct 17

george.karpenkov created D39031: [Analyzer] Correctly handle parameters passed by reference when bodyfarming std::call_once.
Tue, Oct 17, 6:10 PM
george.karpenkov added a comment to D38971: Enhance libsanitizer support for invalid-pointer-pair..

(just saw this by accident)

Tue, Oct 17, 5:43 PM
george.karpenkov committed rL316041: [Analyzer] Always use non-reference types when creating expressions in BodyFarm..
[Analyzer] Always use non-reference types when creating expressions in BodyFarm.
Tue, Oct 17, 3:28 PM
george.karpenkov closed D39015: [Analyzer] Always use non-reference types when creating expressions in BodyFarm, removes std::call_once crash by committing rL316041: [Analyzer] Always use non-reference types when creating expressions in BodyFarm..
Tue, Oct 17, 3:28 PM
george.karpenkov updated the diff for D39015: [Analyzer] Always use non-reference types when creating expressions in BodyFarm, removes std::call_once crash.
Tue, Oct 17, 11:47 AM
george.karpenkov created D39015: [Analyzer] Always use non-reference types when creating expressions in BodyFarm, removes std::call_once crash.
Tue, Oct 17, 11:44 AM
george.karpenkov abandoned D38923: [Analyzer] Do not crash on reference types when generating body for std::call_once.

Abandoned in favor of a more general approach.

Tue, Oct 17, 11:42 AM

Mon, Oct 16

george.karpenkov created D38986: [Analyzer] Better unreachable message in enumeration.
Mon, Oct 16, 6:29 PM

Sat, Oct 14

george.karpenkov committed rL315827: [xray] Fix CMake for X-RAY tests.
[xray] Fix CMake for X-RAY tests
Sat, Oct 14, 2:38 PM
george.karpenkov closed D38917: [xray] Fix CMake for X-RAY tests by committing rL315827: [xray] Fix CMake for X-RAY tests.
Sat, Oct 14, 2:38 PM
george.karpenkov created D38923: [Analyzer] Do not crash on reference types when generating body for std::call_once.
Sat, Oct 14, 2:35 PM
george.karpenkov added a comment to D38917: [xray] Fix CMake for X-RAY tests.

@dberris to be frank neither do I.
There seems to be a separate llvm-xray target, which is not invoked when you depend on xray.
As for target properties, somehow unit tests does not get picked up without it.
(yet somehow tsan's ones happily run without).

Sat, Oct 14, 2:30 PM
george.karpenkov added a comment to D38917: [xray] Fix CMake for X-RAY tests.

Sent email manually, as the email does no get sent if the CC list is updated =(

Sat, Oct 14, 2:16 PM
george.karpenkov updated subscribers of D38917: [xray] Fix CMake for X-RAY tests.

Adding LLVM commits as requested.
@dberris better now?

Sat, Oct 14, 2:10 PM

Fri, Oct 13

george.karpenkov created D38917: [xray] Fix CMake for X-RAY tests.
Fri, Oct 13, 6:15 PM
george.karpenkov committed rL315776: Allow building libFuzzer tests in two-stage compiler-rt build..
Allow building libFuzzer tests in two-stage compiler-rt build.
Fri, Oct 13, 4:51 PM
george.karpenkov committed rL315771: Allow building libFuzzer in two-stage compiler-rt build.
Allow building libFuzzer in two-stage compiler-rt build
Fri, Oct 13, 3:03 PM
george.karpenkov closed D38904: Allow building libFuzzer in two-stage compiler-rt build by committing rL315771: Allow building libFuzzer in two-stage compiler-rt build.
Fri, Oct 13, 3:03 PM
george.karpenkov created D38904: Allow building libFuzzer in two-stage compiler-rt build.
Fri, Oct 13, 2:54 PM

Thu, Oct 12

george.karpenkov committed rL315655: [Analyzer] Assume that CFBooleanRef const globals are non-null.
[Analyzer] Assume that CFBooleanRef const globals are non-null
Thu, Oct 12, 5:52 PM
george.karpenkov closed D38867: [Analyzer] Assume that CFBooleanRef const globals are non-null by committing rL315655: [Analyzer] Assume that CFBooleanRef const globals are non-null.
Thu, Oct 12, 5:52 PM
george.karpenkov updated the diff for D38867: [Analyzer] Assume that CFBooleanRef const globals are non-null.

Adhered to naming suggestion.

Thu, Oct 12, 5:46 PM
george.karpenkov created D38867: [Analyzer] Assume that CFBooleanRef const globals are non-null.
Thu, Oct 12, 5:18 PM
george.karpenkov accepted D38840: [compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests.

LGTM, provided tests pass both in standalone and "normal" modes.

Thu, Oct 12, 1:19 PM
george.karpenkov requested changes to D38840: [compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests.

@mgorny so this one actually changes semantics.
The previous one reused generated object files, and with the change it will start recompiling all the tests again.
(and actually being able to export object files has added quite a bit of complexity to all these compiler-rt macros).

Thu, Oct 12, 10:15 AM
george.karpenkov accepted D38838: [compiler-rt] [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile().

Yep, thanks! Good to go provided tests run.
Looks like we haven't spotted it due to other bug you have fixed cancelling this one out.

Thu, Oct 12, 10:07 AM
george.karpenkov accepted D38839: [compiler-rt] [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS.

Yep, thanks! This was probably the root cause of the failure.

Thu, Oct 12, 10:05 AM

Wed, Oct 11

george.karpenkov added a comment to D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds.

@mgorny I've replied via email, but the message didn't seem to appear here.

Wed, Oct 11, 4:19 PM
george.karpenkov committed rL315508: [Analyzer] Support bodyfarming libstdc++ implementation of std::call_once..
[Analyzer] Support bodyfarming libstdc++ implementation of std::call_once.
Wed, Oct 11, 1:53 PM
george.karpenkov closed D38810: [Analyzer] Support bodyfarming std::call_once for libstdc++ by committing rL315508: [Analyzer] Support bodyfarming libstdc++ implementation of std::call_once..
Wed, Oct 11, 1:53 PM
george.karpenkov committed rL315492: [Analyzer] Fix introduced regression: properly check for nullable attribute..
[Analyzer] Fix introduced regression: properly check for nullable attribute.
Wed, Oct 11, 12:13 PM
george.karpenkov committed rL315489: [Analyzer] Remove dead code from testing scripts.
[Analyzer] Remove dead code from testing scripts
Wed, Oct 11, 11:43 AM
george.karpenkov closed D38488: [Analyzer] Remove dead code from testing scripts by committing rL315489: [Analyzer] Remove dead code from testing scripts.
Wed, Oct 11, 11:42 AM
george.karpenkov committed rL315488: [Analyzer] Assume that string-like const globals are non-nil..
[Analyzer] Assume that string-like const globals are non-nil.
Wed, Oct 11, 11:40 AM
george.karpenkov closed D38764: [Analyzer] Assume const string-like globals are non-null by committing rL315488: [Analyzer] Assume that string-like const globals are non-nil..
Wed, Oct 11, 11:40 AM
george.karpenkov updated the diff for D38764: [Analyzer] Assume const string-like globals are non-null.
Wed, Oct 11, 11:38 AM
george.karpenkov added inline comments to D38764: [Analyzer] Assume const string-like globals are non-null.
Wed, Oct 11, 11:38 AM
george.karpenkov created D38810: [Analyzer] Support bodyfarming std::call_once for libstdc++.
Wed, Oct 11, 11:03 AM

Tue, Oct 10

george.karpenkov updated the diff for D38764: [Analyzer] Assume const string-like globals are non-null.

Typo fix.

Tue, Oct 10, 6:47 PM
george.karpenkov added a comment to D38764: [Analyzer] Assume const string-like globals are non-null.

Marking requests as "done".

Tue, Oct 10, 6:40 PM
george.karpenkov updated the diff for D38764: [Analyzer] Assume const string-like globals are non-null.

Adhering to comments.

Tue, Oct 10, 6:39 PM
george.karpenkov updated the diff for D38764: [Analyzer] Assume const string-like globals are non-null.
Tue, Oct 10, 3:00 PM
george.karpenkov created D38764: [Analyzer] Assume const string-like globals are non-null.
Tue, Oct 10, 2:41 PM

Mon, Oct 9

george.karpenkov committed rL315250: [Analyzer] Do not segfault on unexpected call_once implementation.
[Analyzer] Do not segfault on unexpected call_once implementation
Mon, Oct 9, 4:21 PM
george.karpenkov closed D38702: [Analyzer] Do not segfault on unexpected call_once implementation by committing rL315250: [Analyzer] Do not segfault on unexpected call_once implementation.
Mon, Oct 9, 4:21 PM
george.karpenkov updated the diff for D38702: [Analyzer] Do not segfault on unexpected call_once implementation.

Review comments.

Mon, Oct 9, 4:14 PM
george.karpenkov added a comment to D38702: [Analyzer] Do not segfault on unexpected call_once implementation.

Ooops, updated to https://bugs.llvm.org/show_bug.cgi?id=34869

Mon, Oct 9, 1:06 PM
george.karpenkov updated the summary of D38702: [Analyzer] Do not segfault on unexpected call_once implementation.
Mon, Oct 9, 1:06 PM
george.karpenkov created D38702: [Analyzer] Do not segfault on unexpected call_once implementation.
Mon, Oct 9, 1:03 PM

Thu, Oct 5

george.karpenkov committed rL314992: [Analyzer Tests] Run static analyzer integration tests until the end,.
[Analyzer Tests] Run static analyzer integration tests until the end,
Thu, Oct 5, 10:33 AM
george.karpenkov closed D38589: [Analyzer] Run tests until the end, do not stop at the first failure by committing rL314992: [Analyzer Tests] Run static analyzer integration tests until the end,.
Thu, Oct 5, 10:33 AM
george.karpenkov updated the diff for D38589: [Analyzer] Run tests until the end, do not stop at the first failure.
Thu, Oct 5, 10:13 AM
george.karpenkov created D38589: [Analyzer] Run tests until the end, do not stop at the first failure.
Thu, Oct 5, 10:13 AM

Wed, Oct 4

george.karpenkov committed rL314960: [Analyzer Tests] Fix misc bugs in analyzer reference results updater..
[Analyzer Tests] Fix misc bugs in analyzer reference results updater.
Wed, Oct 4, 6:04 PM
george.karpenkov added a comment to D32312: Changing thread_local to __thread in libFuzzer.

@devernay do you actually need to use libFuzzer, or do you simply want to be able to build LLVM?
I think I've talked about this issue previously with a person who maintains macports for LLVM, and they've simply used a workaround which does not build libFuzzer.

Wed, Oct 4, 12:27 PM

Tue, Oct 3

george.karpenkov committed rL314859: [Analyzer] Re-apply r314820 with a fix for StringRef lifetime..
[Analyzer] Re-apply r314820 with a fix for StringRef lifetime.
Tue, Oct 3, 4:17 PM
george.karpenkov committed rL314820: [Analyzer] More granular special casing in RetainCountChecker.
[Analyzer] More granular special casing in RetainCountChecker
Tue, Oct 3, 11:14 AM
george.karpenkov closed D38487: [Analyzer] More granular special casing in RetainCountChecker by committing rL314820: [Analyzer] More granular special casing in RetainCountChecker.
Tue, Oct 3, 11:14 AM
george.karpenkov updated the diff for D38487: [Analyzer] More granular special casing in RetainCountChecker.

Adhered to review comments.

Tue, Oct 3, 11:11 AM

Mon, Oct 2

george.karpenkov created D38488: [Analyzer] Remove dead code from testing scripts.
Mon, Oct 2, 6:49 PM
george.karpenkov created D38487: [Analyzer] More granular special casing in RetainCountChecker.
Mon, Oct 2, 6:47 PM
george.karpenkov committed rL314722: [Analyzer] Avoid copy and modifying passed reference in BodyFarm….
[Analyzer] Avoid copy and modifying passed reference in BodyFarm…
Mon, Oct 2, 2:03 PM
george.karpenkov closed D38475: [Analyzer] Avoid copy and modifying passed reference in BodyFarm::create_call_once by committing rL314722: [Analyzer] Avoid copy and modifying passed reference in BodyFarm….
Mon, Oct 2, 2:03 PM
george.karpenkov created D38475: [Analyzer] Avoid copy and modifying passed reference in BodyFarm::create_call_once.
Mon, Oct 2, 12:48 PM
george.karpenkov closed D38213: [Analyzer] Make testing scripts flake8-compliant.

Misspelled revision/review, committed in r314692, closing manually.

Mon, Oct 2, 11:05 AM
george.karpenkov added a comment to D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds.

breaking stand-alone builds as a result

Mon, Oct 2, 11:04 AM
george.karpenkov committed rL314692: [Analyzer] Make testing scripts flake8 compliant.
[Analyzer] Make testing scripts flake8 compliant
Mon, Oct 2, 11:01 AM

Fri, Sep 29

george.karpenkov committed rL314580: [Analyzer] Add dummy implementation to call_once to avoid linkage warnings in….
[Analyzer] Add dummy implementation to call_once to avoid linkage warnings in…
Fri, Sep 29, 6:17 PM
george.karpenkov updated the diff for D38213: [Analyzer] Make testing scripts flake8-compliant.
Fri, Sep 29, 5:12 PM
george.karpenkov committed rL314573: [Analyzer] Document a gotcha: for C++ -analyze-function requires parameters in….
[Analyzer] Document a gotcha: for C++ -analyze-function requires parameters in…
Fri, Sep 29, 5:09 PM
george.karpenkov closed D37596: [Analyzer] Document a gotcha: for C++ -analyze-function requires parameters in function name by committing rL314573: [Analyzer] Document a gotcha: for C++ -analyze-function requires parameters in….
Fri, Sep 29, 5:09 PM
george.karpenkov committed rL314572: [Analyzer] Add nullability to the list of tested checkers in SATestBuild.
[Analyzer] Add nullability to the list of tested checkers in SATestBuild
Fri, Sep 29, 5:07 PM
george.karpenkov closed D38162: [Analyzer] Add nullability to the list of tested checkers in SATestBuild by committing rL314572: [Analyzer] Add nullability to the list of tested checkers in SATestBuild.
Fri, Sep 29, 5:07 PM
george.karpenkov committed rL314571: [Analyzer] Synthesize function body for std::call_once.
[Analyzer] Synthesize function body for std::call_once
Fri, Sep 29, 5:05 PM
george.karpenkov closed D37840: [Analyzer] Synthesize function body for call_once by committing rL314571: [Analyzer] Synthesize function body for std::call_once.
Fri, Sep 29, 5:04 PM

Mon, Sep 25

george.karpenkov committed rL314042: [Analyzer] Fix minor errors in python scripts..
[Analyzer] Fix minor errors in python scripts.
Mon, Sep 25, 5:06 AM
george.karpenkov created D38213: [Analyzer] Make testing scripts flake8-compliant.
Mon, Sep 25, 5:02 AM

Sep 21 2017

george.karpenkov committed rL313950: [Analyzer] Static analyzer script for updating reference results.
[Analyzer] Static analyzer script for updating reference results
Sep 21 2017, 6:44 PM
george.karpenkov closed D38157: [Analyzer] Static analyzer script for updating reference results by committing rL313950: [Analyzer] Static analyzer script for updating reference results.
Sep 21 2017, 6:44 PM
george.karpenkov committed rL313949: [Analyzer] Refactor analyzer testing scripts..
[Analyzer] Refactor analyzer testing scripts.
Sep 21 2017, 6:42 PM
george.karpenkov closed D38156: [Analyzer] Refactor analyzer testing scripts by committing rL313949: [Analyzer] Refactor analyzer testing scripts..
Sep 21 2017, 6:42 PM
george.karpenkov added a comment to D38156: [Analyzer] Refactor analyzer testing scripts.

Also, please make sure to add @NoQ to static analyzer reviews!

OK!

Sep 21 2017, 6:39 PM
george.karpenkov added a comment to D38156: [Analyzer] Refactor analyzer testing scripts.

Does it work on Windows, Linux, and macOS?

It definitely works on OS X and Unix.
It's Windows implementation is the same one we have, so it is not worse (apparently it can fail on some obscure Windows versions, but so can the current implementation).

Sep 21 2017, 6:39 PM
george.karpenkov updated the diff for D38156: [Analyzer] Refactor analyzer testing scripts.

Do not import self from CmpRuns

Sep 21 2017, 5:54 PM
george.karpenkov committed rL313944: [Analyzer] Log when auto-synthesized body is used..
[Analyzer] Log when auto-synthesized body is used.
Sep 21 2017, 5:38 PM
george.karpenkov closed D37910: [Analyzer] Log when auto-synthesized body is used by committing rL313944: [Analyzer] Log when auto-synthesized body is used..
Sep 21 2017, 5:38 PM
george.karpenkov added a comment to D37596: [Analyzer] Document a gotcha: for C++ -analyze-function requires parameters in function name.

@NoQ ping?

Sep 21 2017, 5:37 PM
george.karpenkov added a comment to D37935: [Analyzer] Use the same filename for the header and the implementation of BugReporterVisitor.

@NoQ ping?

Sep 21 2017, 5:36 PM
george.karpenkov created D38162: [Analyzer] Add nullability to the list of tested checkers in SATestBuild.
Sep 21 2017, 5:35 PM
george.karpenkov added inline comments to D37840: [Analyzer] Synthesize function body for call_once.
Sep 21 2017, 5:12 PM
george.karpenkov updated the diff for D37840: [Analyzer] Synthesize function body for call_once.

Updated using review comments.

Sep 21 2017, 5:11 PM
george.karpenkov added a comment to D38157: [Analyzer] Static analyzer script for updating reference results.

@dcoughlin note that this can not land without https://reviews.llvm.org/D38156

Sep 21 2017, 4:00 PM
george.karpenkov closed D38004: [Analyzer] Add simple help to SATestAdd.

Failed copy-n-paste, this was fixed in r313924

Sep 21 2017, 3:59 PM
george.karpenkov added inline comments to D38157: [Analyzer] Static analyzer script for updating reference results.
Sep 21 2017, 3:43 PM
george.karpenkov updated the diff for D38157: [Analyzer] Static analyzer script for updating reference results.

Applying review comments.

Sep 21 2017, 3:43 PM
george.karpenkov committed rL313927: [Analyzer] Use CC environment variable to select analyzer path in SATestBuild..
[Analyzer] Use CC environment variable to select analyzer path in SATestBuild.
Sep 21 2017, 3:14 PM
george.karpenkov closed D38155: [Analyzer] Use CC environment variable to select analyzer path in SATestBuild by committing rL313927: [Analyzer] Use CC environment variable to select analyzer path in SATestBuild..
Sep 21 2017, 3:14 PM
george.karpenkov added a comment to D38155: [Analyzer] Use CC environment variable to select analyzer path in SATestBuild.

@dcoughlin: yes. Either would work, I thought that CC=mycompiler ./blah was already quite idiomatic.

Sep 21 2017, 3:11 PM