- User Since
- Apr 14 2017, 1:59 PM (144 w, 14 h)
Mon, Dec 23
Dec 12 2019
Nov 20 2019
If you're reasonable sure this is miscompiling, definitely revert. Help narrowing it down would be appreciated though.
Would you be OK speculatively reverting this change?
Oct 29 2019
Aug 15 2019
Feb 18 2019
High-level feedback: mixing of abstraction levels is wrong for the "bundled" documentation. This might also work better as a blogpost, if you want to jump from topic to topic.
Feb 17 2019
LGTM, but one of the code owners would need to sign of.
The benefit is not creating the temporary object, right?
Feb 8 2019
There is at least one other conflicting commit rL353465 on top of this code already.
Feb 7 2019
@mikhail.ramalho could you revert then?
In general, we should not use Z3 unless it's explicitly requested.
Feb 5 2019
In the long run - sure. But porting this page to Sphinx should be a separate commit anyway.
Feb 4 2019
I don't particularly care either way.
@alexandre.isoard any remaining concerns?
Feb 1 2019
Jan 31 2019
Jan 30 2019
The change makes sense to me: seems https://github.com/llvm/llvm-project/commit/7764a04af007eca68eafcf5caaea560ed05e35a9 was not correct and a proper fix was to use avoid crashing using ASAN_OPTIONS instead.
Jan 29 2019
After this landed, options for RetainCountChecker stopped working - e.g. I can't use osx.cocoa.RetainCount:blah=X.
Do you know why is this the case / how to fix it?
Jan 28 2019
I just fail to understand why nobody did that before. As far as i understand, that's a very large improvement.
I personally do use HTML output quite a lot (and we do have non-Xcode projects), and complex macros in HTML are currently totally unusable.
I'm not sure whether this is a right approach to handling this, but it's definitely a problem for us.
In general - thanks for working on this anyway.
I'm in favor of this change, I never understood how invalidating a field invalidates entire structure.