Page MenuHomePhabricator

george.karpenkov (George Karpenkov)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 14 2017, 1:59 PM (155 w, 4 d)

Recent Activity

Feb 14 2020

george.karpenkov added a comment to D74185: Revert the revert of vectorization commits.

@lebedev.ri Thanks! No, I haven't filed the issue yet. The current blocking issue is that I see the regression when compiled with JIT, but not with opt. I think I need to figure out the exact set of flags I need to give opt to give me the desired behavior.

Feb 14 2020, 10:21 AM · Restricted Project

Feb 10 2020

george.karpenkov added a comment to D74185: Revert the revert of vectorization commits.

@ABataev Thanks for looking into this! You are right: when I try the opt tool I also get the same result. Yet somehow when inside TensorFlow, rolling back this revision does fix the miscompile.
Do you think you could give any advice what I can do to narrow it down? Maybe places to print before and after in vectorization passes?

Feb 10 2020, 6:03 PM · Restricted Project

Feb 7 2020

george.karpenkov added a comment to D74185: Revert the revert of vectorization commits.

Even if it is not a real cause of the problem?

Feb 7 2020, 6:20 PM · Restricted Project
george.karpenkov added a comment to D74185: Revert the revert of vectorization commits.

The problem here that this patch does not introduce new vectorization, instead it just triggers the existing vetorization for more cases. If there is a bug in the vectorizer, this patch just allows to reveal it, not introduces it.

Feb 7 2020, 5:44 PM · Restricted Project
george.karpenkov added a comment to D74185: Revert the revert of vectorization commits.

I find this instruction suspicious: https://gist.github.com/cheshire/bf1047b4385bcf82c22a70f5cf1fb5df#file-bad_input_ir_opt-L29

Feb 7 2020, 3:20 PM · Restricted Project
george.karpenkov requested review of D74185: Revert the revert of vectorization commits.

I did manage to reduce the test case further.

Feb 7 2020, 3:11 PM · Restricted Project
george.karpenkov added a comment to D74185: Revert the revert of vectorization commits.

Runnable reproducer requires some prerequisites. It would be good if you could provide a simpler one.

Feb 7 2020, 9:31 AM · Restricted Project
george.karpenkov added a comment to D74185: Revert the revert of vectorization commits.

@ABataev Please check out the runnable reproducer above. It clearly demonstrates a miscompile: if the pass is correct, same IR input should give identical output (barring undefined behavior, but we use sanitizers to check for that).

Feb 7 2020, 8:27 AM · Restricted Project

Feb 6 2020

george.karpenkov created D74185: Revert the revert of vectorization commits.
Feb 6 2020, 5:26 PM · Restricted Project

Jan 31 2020

george.karpenkov planned changes to D73756: Revert of [InstCombine] Revert rL341831: relax one-use check in foldICmpAddCons… …tant() (PR44100).

I've narrowed the bug down to a ptxas miscompile, the change this revision introduces is indeed benign, but it triggers a ptxas in a bad way.

Jan 31 2020, 1:58 PM · Restricted Project
george.karpenkov added a comment to D73756: Revert of [InstCombine] Revert rL341831: relax one-use check in foldICmpAddCons… …tant() (PR44100).

@lebedev.ri Thanks for responding! I didn't intend to mail it just yet before narrowing the problem down, and realized too late just saving the revision would add the subscribers. I'll get back once I'll be able to pinpoint the problem better, it's entirely possible that your commit exposes the bug either in llvm->ptx translation (then I would be able to fix it) or the ptx emitted triggers a ptxas bug with gives bad ptx->SASS lowering.

Jan 31 2020, 8:20 AM · Restricted Project

Jan 30 2020

george.karpenkov created D73756: Revert of [InstCombine] Revert rL341831: relax one-use check in foldICmpAddCons… …tant() (PR44100).
Jan 30 2020, 5:37 PM · Restricted Project

Dec 23 2019

A. Unique TensorFlower <gardener@tensorflow.org> committed rG2df646bef6e7: Automated rollback of commit 5684a12434f923d03b6870f2aa16226bfb0b38b6 (authored by george.karpenkov).
Automated rollback of commit 5684a12434f923d03b6870f2aa16226bfb0b38b6
Dec 23 2019, 8:54 PM

Dec 12 2019

george.karpenkov committed rG73800cf2dd00: Hotfix after the merge: re-enable the option removed by the merge. (authored by george.karpenkov).
Hotfix after the merge: re-enable the option removed by the merge.
Dec 12 2019, 12:56 PM
george.karpenkov committed rGea378dfc4baf: Merge branch 'llvm-master' into upstream-with-swift (authored by george.karpenkov).
Merge branch 'llvm-master' into upstream-with-swift
Dec 12 2019, 12:56 PM
george.karpenkov committed rG6dd1d9f2ca31: Added another LLVM_FALLTHROUGH annotation. (authored by george.karpenkov).
Added another LLVM_FALLTHROUGH annotation.
Dec 12 2019, 11:58 AM
george.karpenkov committed rG2d0c835a56e9: Add LLVM_FALLTHROUGH annotation. (authored by george.karpenkov).
Add LLVM_FALLTHROUGH annotation.
Dec 12 2019, 11:57 AM
george.karpenkov committed rG4bfcfc50d772: [indexer] Fix a fallthrough bug in IndexRecordHasher (authored by george.karpenkov).
[indexer] Fix a fallthrough bug in IndexRecordHasher
Dec 12 2019, 11:57 AM
george.karpenkov committed rG735b20448d6d: Merge branch 'llvm-master' into upstream-with-swift (authored by george.karpenkov).
Merge branch 'llvm-master' into upstream-with-swift
Dec 12 2019, 11:57 AM
george.karpenkov committed rG16ff20722a91: Fix up the previous DirectoryWatcher test commit (authored by george.karpenkov).
Fix up the previous DirectoryWatcher test commit
Dec 12 2019, 11:52 AM

Nov 20 2019

george.karpenkov removed a reviewer for D53710: [FileCheck] Warn if a prefix is only used in LABEL checks: george.karpenkov.
Nov 20 2019, 6:34 PM
george.karpenkov removed a reviewer for D53185: [analyzer] Implement a prototype checker for detecting Year 2038 related issues.: george.karpenkov.
Nov 20 2019, 6:34 PM
george.karpenkov removed a reviewer for D54399: Move ExprMutationAnalyzer to Tooling/Analysis (1/3): george.karpenkov.
Nov 20 2019, 6:34 PM · Restricted Project
george.karpenkov removed a reviewer for D54149: [Analyzer] [WIP] Standard C++ library functions checker for the std::find() family: george.karpenkov.
Nov 20 2019, 6:34 PM · Restricted Project
george.karpenkov removed a reviewer for D54400: Move ExprMutationAnalyzer to Tooling/Analysis (2/3): george.karpenkov.
Nov 20 2019, 5:58 PM · Restricted Project
george.karpenkov abandoned D56069: [arcmigrator] [NFC] Change arc migrator to use "diff" instead of a custom script.
Nov 20 2019, 5:58 PM
george.karpenkov removed a reviewer for D58065: [analyzer] Document the frontend library: george.karpenkov.
Nov 20 2019, 5:58 PM · Restricted Project
george.karpenkov abandoned D56736: [analyzer] [RetainCountChecker] Introduce optional tracking of unannotated retain out parameters, behind a flag.
Nov 20 2019, 5:58 PM
george.karpenkov abandoned D57214: [analyzer] [RetainCountChecker] Escape values stored into smart pointers if they have non-stack storage.
Nov 20 2019, 5:58 PM
george.karpenkov added a comment to D70516: Revert "[DependenceAnalysis] Dependecies for loads marked with "ivnariant.load" should not be shared with general accesses. Fix for https://bugs.llvm.org/show_bug.cgi?id=42151".

If you're reasonable sure this is miscompiling, definitely revert. Help narrowing it down would be appreciated though.

Nov 20 2019, 5:22 PM · Restricted Project
george.karpenkov updated the summary of D70516: Revert "[DependenceAnalysis] Dependecies for loads marked with "ivnariant.load" should not be shared with general accesses. Fix for https://bugs.llvm.org/show_bug.cgi?id=42151".
Nov 20 2019, 3:39 PM · Restricted Project
george.karpenkov added a comment to D70516: Revert "[DependenceAnalysis] Dependecies for loads marked with "ivnariant.load" should not be shared with general accesses. Fix for https://bugs.llvm.org/show_bug.cgi?id=42151".

Would you be OK speculatively reverting this change?

Nov 20 2019, 3:39 PM · Restricted Project
george.karpenkov added a reverting change for rG5f026b6d9e88: [DependenceAnalysis] Dependecies for loads marked with "ivnariant.load" should…: D70516: Revert "[DependenceAnalysis] Dependecies for loads marked with "ivnariant.load" should not be shared with general accesses. Fix for https://bugs.llvm.org/show_bug.cgi?id=42151".
Nov 20 2019, 3:30 PM
george.karpenkov created D70516: Revert "[DependenceAnalysis] Dependecies for loads marked with "ivnariant.load" should not be shared with general accesses. Fix for https://bugs.llvm.org/show_bug.cgi?id=42151".
Nov 20 2019, 3:30 PM · Restricted Project

Oct 29 2019

george.karpenkov committed rGcb3c6a82d5e7: Merge branch 'llvm-master' into upstream-with-swift (authored by george.karpenkov).
Merge branch 'llvm-master' into upstream-with-swift
Oct 29 2019, 4:06 PM
george.karpenkov committed rGd8b88e62fccf: Merge branch 'llvm-master' into upstream-with-swift (authored by george.karpenkov).
Merge branch 'llvm-master' into upstream-with-swift
Oct 29 2019, 4:06 PM
george.karpenkov committed rG8c229c179154: Merge branch 'llvm-master' into upstream-with-swift (authored by george.karpenkov).
Merge branch 'llvm-master' into upstream-with-swift
Oct 29 2019, 4:05 PM
george.karpenkov committed rG967acb0be1bd: Merge branch 'master' of http://llvm.org/git/clang into upstream-with-swift (authored by george.karpenkov).
Merge branch 'master' of http://llvm.org/git/clang into upstream-with-swift
Oct 29 2019, 3:59 PM

Aug 15 2019

george.karpenkov committed rGe7fdf7cb71c8: Test commit #2. (authored by george.karpenkov).
Test commit #2.
Aug 15 2019, 10:18 AM
george.karpenkov committed rL369020: Test commit #2..
Test commit #2.
Aug 15 2019, 10:18 AM

Feb 18 2019

george.karpenkov added inline comments to D58199: [analyzer] ConditionBRVisitor: Remove duplicated code.
Feb 18 2019, 4:27 PM · Restricted Project, Restricted Project
george.karpenkov added inline comments to D58206: [analyzer] ConditionBRVisitor: MemberExpr support.
Feb 18 2019, 4:27 PM · Restricted Project
george.karpenkov accepted D58207: [analyzer] ConditionBRVisitor: Boolean support.
Feb 18 2019, 4:22 PM · Restricted Project, Restricted Project
george.karpenkov added a comment to D58065: [analyzer] Document the frontend library.

High-level feedback: mixing of abstraction levels is wrong for the "bundled" documentation. This might also work better as a blogpost, if you want to jump from topic to topic.

Feb 18 2019, 4:21 PM · Restricted Project

Feb 17 2019

george.karpenkov added reviewers for D58117: Workaround std::thread begin not copy-constructible: kcc, vitalybuka, morehouse.

LGTM, but one of the code owners would need to sign of.
The benefit is not creating the temporary object, right?

Feb 17 2019, 7:39 PM · Restricted Project, Restricted Project

Feb 8 2019

george.karpenkov committed rG2add627e3501: [analyzer] Opt-in C Style Cast Checker for OSObject pointers (authored by george.karpenkov).
[analyzer] Opt-in C Style Cast Checker for OSObject pointers
Feb 8 2019, 1:09 PM
george.karpenkov committed rL353566: [analyzer] Opt-in C Style Cast Checker for OSObject pointers.
[analyzer] Opt-in C Style Cast Checker for OSObject pointers
Feb 8 2019, 1:09 PM
george.karpenkov committed rC353566: [analyzer] Opt-in C Style Cast Checker for OSObject pointers.
[analyzer] Opt-in C Style Cast Checker for OSObject pointers
Feb 8 2019, 1:09 PM
george.karpenkov closed D57261: [analyzer] [WIP] Opt-in C Style Cast Checker for OSObject pointers.
Feb 8 2019, 1:09 PM · Restricted Project
george.karpenkov added a comment to D54978: Move the SMT API to LLVM.

There is at least one other conflicting commit rL353465 on top of this code already.

Feb 8 2019, 11:06 AM · Restricted Project, Restricted Project

Feb 7 2019

george.karpenkov added a comment to D54978: Move the SMT API to LLVM.

@mikhail.ramalho could you revert then?
In general, we should not use Z3 unless it's explicitly requested.

Feb 7 2019, 10:54 AM · Restricted Project, Restricted Project

Feb 5 2019

george.karpenkov committed rGa64b205ae7f9: [analyzer] [testing] Inside CmpRuns.py output also print the filename of the… (authored by george.karpenkov).
[analyzer] [testing] Inside CmpRuns.py output also print the filename of the…
Feb 5 2019, 2:27 PM
george.karpenkov committed rG63f9def72eb1: [analyzer] Document RetainCountChecker behavior and annotations (authored by george.karpenkov).
[analyzer] Document RetainCountChecker behavior and annotations
Feb 5 2019, 2:27 PM
george.karpenkov committed rG6794aa702a5e: [analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX… (authored by george.karpenkov).
[analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX…
Feb 5 2019, 2:27 PM
george.karpenkov committed rC353229: [analyzer] Document RetainCountChecker behavior and annotations.
[analyzer] Document RetainCountChecker behavior and annotations
Feb 5 2019, 2:27 PM
george.karpenkov committed rL353229: [analyzer] Document RetainCountChecker behavior and annotations.
[analyzer] Document RetainCountChecker behavior and annotations
Feb 5 2019, 2:27 PM
george.karpenkov closed D57721: [analyzer] Document RetainCountChecker behavior and annotations.
Feb 5 2019, 2:27 PM · Restricted Project
george.karpenkov committed rC353228: [analyzer] [testing] Inside CmpRuns.py output also print the filename of the….
[analyzer] [testing] Inside CmpRuns.py output also print the filename of the…
Feb 5 2019, 2:26 PM
george.karpenkov committed rL353228: [analyzer] [testing] Inside CmpRuns.py output also print the filename of the….
[analyzer] [testing] Inside CmpRuns.py output also print the filename of the…
Feb 5 2019, 2:26 PM
george.karpenkov closed D57783: [analyzer] [testing] Inside CmpRuns.py output also print the filename of the first item in the path.
Feb 5 2019, 2:26 PM · Restricted Project
george.karpenkov committed rL353227: [analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX….
[analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX…
Feb 5 2019, 2:26 PM
george.karpenkov committed rC353227: [analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX….
[analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX…
Feb 5 2019, 2:26 PM
george.karpenkov closed D57782: [analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX method calls.
Feb 5 2019, 2:26 PM · Restricted Project
george.karpenkov created D57783: [analyzer] [testing] Inside CmpRuns.py output also print the filename of the first item in the path.
Feb 5 2019, 1:48 PM · Restricted Project
george.karpenkov created D57782: [analyzer] [RetainCountChecker] Bugfix: in non-OSObject-mode, do not track CXX method calls.
Feb 5 2019, 1:47 PM · Restricted Project
george.karpenkov added a comment to D57721: [analyzer] Document RetainCountChecker behavior and annotations.

In the long run - sure. But porting this page to Sphinx should be a separate commit anyway.

Feb 5 2019, 10:28 AM · Restricted Project

Feb 4 2019

george.karpenkov created D57721: [analyzer] Document RetainCountChecker behavior and annotations.
Feb 4 2019, 4:07 PM · Restricted Project
george.karpenkov added a comment to D54978: Move the SMT API to LLVM.

I don't particularly care either way.
@alexandre.isoard any remaining concerns?

Feb 4 2019, 10:22 AM · Restricted Project, Restricted Project

Feb 1 2019

george.karpenkov committed rL352938: [analyzer] Hotfix for RetainCountChecker: assert was too strong..
[analyzer] Hotfix for RetainCountChecker: assert was too strong.
Feb 1 2019, 3:06 PM
george.karpenkov committed rC352938: [analyzer] Hotfix for RetainCountChecker: assert was too strong..
[analyzer] Hotfix for RetainCountChecker: assert was too strong.
Feb 1 2019, 3:06 PM

Jan 31 2019

george.karpenkov committed rL352824: [analyzer] [RetainCountChecker] Fix object type for CF/Obj-C bridged casts.
[analyzer] [RetainCountChecker] Fix object type for CF/Obj-C bridged casts
Jan 31 2019, 6:13 PM
george.karpenkov committed rC352824: [analyzer] [RetainCountChecker] Fix object type for CF/Obj-C bridged casts.
[analyzer] [RetainCountChecker] Fix object type for CF/Obj-C bridged casts
Jan 31 2019, 6:12 PM
george.karpenkov closed D57557: [analyzer] [RetainCountChecker] Fix object type for CF/Obj-C bridged casts.
Jan 31 2019, 6:12 PM · Restricted Project
george.karpenkov updated the summary of D57557: [analyzer] [RetainCountChecker] Fix object type for CF/Obj-C bridged casts.
Jan 31 2019, 5:38 PM · Restricted Project
george.karpenkov updated the diff for D57557: [analyzer] [RetainCountChecker] Fix object type for CF/Obj-C bridged casts.
Jan 31 2019, 5:35 PM · Restricted Project
george.karpenkov updated the diff for D57557: [analyzer] [RetainCountChecker] Fix object type for CF/Obj-C bridged casts.
Jan 31 2019, 5:35 PM · Restricted Project
george.karpenkov created D57557: [analyzer] [RetainCountChecker] Fix object type for CF/Obj-C bridged casts.
Jan 31 2019, 5:30 PM · Restricted Project
george.karpenkov accepted D57554: [analyzer] Revert D51397 "Remove the "postponed" hack..."..
Jan 31 2019, 4:31 PM · Restricted Project, Restricted Project

Jan 30 2019

george.karpenkov added a comment to D57465: [libFuzzer] Set default sanitizer options in fuzzer tests.

The change makes sense to me: seems https://github.com/llvm/llvm-project/commit/7764a04af007eca68eafcf5caaea560ed05e35a9 was not correct and a proper fix was to use avoid crashing using ASAN_OPTIONS instead.

Jan 30 2019, 2:09 PM · Restricted Project

Jan 29 2019

george.karpenkov committed rC352588: [analyzer] [RetainCountChecker] Bugfix for tracking top-level parameters of….
[analyzer] [RetainCountChecker] Bugfix for tracking top-level parameters of…
Jan 29 2019, 6:11 PM
george.karpenkov committed rL352588: [analyzer] [RetainCountChecker] Bugfix for tracking top-level parameters of….
[analyzer] [RetainCountChecker] Bugfix for tracking top-level parameters of…
Jan 29 2019, 6:11 PM
george.karpenkov closed D57433: [analyzer] [RetainCountChecker] Bugfix for tracking top-level parameters of Objective-C methods.
Jan 29 2019, 6:11 PM
george.karpenkov created D57433: [analyzer] [RetainCountChecker] Bugfix for tracking top-level parameters of Objective-C methods.
Jan 29 2019, 6:04 PM
george.karpenkov committed rC352534: [analyzer] [RetainCountChecker] Track input parameters to the top-level function.
[analyzer] [RetainCountChecker] Track input parameters to the top-level function
Jan 29 2019, 11:30 AM
george.karpenkov committed rL352534: [analyzer] [RetainCountChecker] Track input parameters to the top-level function.
[analyzer] [RetainCountChecker] Track input parameters to the top-level function
Jan 29 2019, 11:30 AM
george.karpenkov closed D57356: [analyzer] [RetainCountChecker] Track input parameters to the top-level function.
Jan 29 2019, 11:30 AM
george.karpenkov committed rL352533: [analyzer] [RetainSummaryManager] [NFC] Split one function into two, as it's….
[analyzer] [RetainSummaryManager] [NFC] Split one function into two, as it's…
Jan 29 2019, 11:30 AM
george.karpenkov committed rC352533: [analyzer] [RetainSummaryManager] [NFC] Split one function into two, as it's….
[analyzer] [RetainSummaryManager] [NFC] Split one function into two, as it's…
Jan 29 2019, 11:29 AM
george.karpenkov closed D57201: [analyzer] [RetainSummaryManager] [NFC] Split one function into two, as it's really doing two things.
Jan 29 2019, 11:29 AM
george.karpenkov committed rL352532: [analyzer] [ARCMT] [NFC] Unify entry point into RetainSummaryManager.
[analyzer] [ARCMT] [NFC] Unify entry point into RetainSummaryManager
Jan 29 2019, 11:29 AM
george.karpenkov committed rC352532: [analyzer] [ARCMT] [NFC] Unify entry point into RetainSummaryManager.
[analyzer] [ARCMT] [NFC] Unify entry point into RetainSummaryManager
Jan 29 2019, 11:29 AM
george.karpenkov closed D57346: [analyzer] [ARCMT] [NFC] Unify entry point into RetainSummaryManager.
Jan 29 2019, 11:29 AM
george.karpenkov committed rL352531: Extend AnyCall to handle callable declarations without the call expressions.
Extend AnyCall to handle callable declarations without the call expressions
Jan 29 2019, 11:29 AM
george.karpenkov committed rC352531: Extend AnyCall to handle callable declarations without the call expressions.
Extend AnyCall to handle callable declarations without the call expressions
Jan 29 2019, 11:29 AM
george.karpenkov closed D57344: Extend AnyCall to handle callable declarations without the call expressions.
Jan 29 2019, 11:29 AM
george.karpenkov committed rL352530: [analyzer] [RetainCountChecker] Support 'taggedRetain' and 'taggedRelease'.
[analyzer] [RetainCountChecker] Support 'taggedRetain' and 'taggedRelease'
Jan 29 2019, 11:29 AM
george.karpenkov committed rC352530: [analyzer] [RetainCountChecker] Support 'taggedRetain' and 'taggedRelease'.
[analyzer] [RetainCountChecker] Support 'taggedRetain' and 'taggedRelease'
Jan 29 2019, 11:29 AM
george.karpenkov closed D57211: [analyzer] [RetainCountChecker] Support 'taggedRetain' and 'taggedRelease'.
Jan 29 2019, 11:29 AM
george.karpenkov added a comment to D54438: [analyzer] Reimplement dependencies between checkers.

After this landed, options for RetainCountChecker stopped working - e.g. I can't use osx.cocoa.RetainCount:blah=X.
Do you know why is this the case / how to fix it?

Jan 29 2019, 11:22 AM

Jan 28 2019

george.karpenkov updated the diff for D57344: Extend AnyCall to handle callable declarations without the call expressions.
Jan 28 2019, 3:52 PM