Page MenuHomePhabricator

george.karpenkov (George Karpenkov)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 14 2017, 1:59 PM (92 w, 5 d)

Recent Activity

Today

george.karpenkov requested changes to D57062: [analyzer] Re-enable the "System is over constrained" assertion on optimized builds..

We would start getting crashes from TrustNonnullChecker if we enable it. Shouldn't those be fixed first?
An input which crashes with this assertion is test/Analysis/trustnonnullchecker_test.m.

Wed, Jan 23, 1:35 PM

Yesterday

george.karpenkov added a comment to D55400: [analyzer] Move out tracking retain count for OSObjects into a separate checker.

Hmmm, does this mess with options that bad? Could you please clarify?

Tue, Jan 22, 4:14 PM
george.karpenkov committed rC351865: [analyzer] Insert notes in RetainCountChecker where our dynamic cast modeling….
[analyzer] Insert notes in RetainCountChecker where our dynamic cast modeling…
Tue, Jan 22, 11:54 AM
george.karpenkov committed rL351865: [analyzer] Insert notes in RetainCountChecker where our dynamic cast modeling….
[analyzer] Insert notes in RetainCountChecker where our dynamic cast modeling…
Tue, Jan 22, 11:54 AM
george.karpenkov closed D56952: [analyzer] Insert notes in RetainCountChecker where our dynamic cast modeling assumes 'null' output.
Tue, Jan 22, 11:54 AM
george.karpenkov committed rC351864: [analyzer] Model another special-case kind of cast for OSObject….
[analyzer] Model another special-case kind of cast for OSObject…
Tue, Jan 22, 11:54 AM
george.karpenkov committed rL351864: [analyzer] Model another special-case kind of cast for OSObject….
[analyzer] Model another special-case kind of cast for OSObject…
Tue, Jan 22, 11:54 AM
george.karpenkov closed D56951: [analyzer] Model another special-case kind of cast for OSObject RetainCountChecker.
Tue, Jan 22, 11:54 AM
george.karpenkov updated the diff for D56952: [analyzer] Insert notes in RetainCountChecker where our dynamic cast modeling assumes 'null' output.
Tue, Jan 22, 11:48 AM
george.karpenkov added inline comments to D56951: [analyzer] Model another special-case kind of cast for OSObject RetainCountChecker.
Tue, Jan 22, 11:28 AM
george.karpenkov closed D56887: [analyzer] [NFC] Clean up messy handling of bug categories in RetainCountChecker.

Committed in 2bdfe0ca7a5903d24a920c8e46db28261eed0543

Tue, Jan 22, 11:27 AM
george.karpenkov added inline comments to D56952: [analyzer] Insert notes in RetainCountChecker where our dynamic cast modeling assumes 'null' output.
Tue, Jan 22, 11:27 AM
george.karpenkov added a comment to D55400: [analyzer] Move out tracking retain count for OSObjects into a separate checker.

Deal with the consequences of this, and just correct all plist files to now refer to the new base checker.

Tue, Jan 22, 11:22 AM

Fri, Jan 18

george.karpenkov created D56952: [analyzer] Insert notes in RetainCountChecker where our dynamic cast modeling assumes 'null' output.
Fri, Jan 18, 5:58 PM
george.karpenkov created D56951: [analyzer] Model another special-case kind of cast for OSObject RetainCountChecker.
Fri, Jan 18, 5:33 PM
george.karpenkov accepted D56823: [analyzer] Do not try to body-farm bodies for Objective-C properties with custom accessors..
Fri, Jan 18, 2:25 PM
george.karpenkov accepted D56899: [analyzer] pr37688: Fix a crash on trying to evaluate a deleted destructor of a union..

The code is fine, but I obviously would prefer a proper fix in a CFG

Fri, Jan 18, 2:24 PM
george.karpenkov committed rC351575: Revert "Fix failing MSan bots".
Revert "Fix failing MSan bots"
Fri, Jan 18, 11:29 AM
george.karpenkov committed rL351575: Revert "Fix failing MSan bots".
Revert "Fix failing MSan bots"
Fri, Jan 18, 11:29 AM

Thu, Jan 17

george.karpenkov committed rL351514: [analyzer] Introduce proper diagnostic for freeing unowned object.
[analyzer] Introduce proper diagnostic for freeing unowned object
Thu, Jan 17, 7:19 PM
george.karpenkov committed rC351514: [analyzer] Introduce proper diagnostic for freeing unowned object.
[analyzer] Introduce proper diagnostic for freeing unowned object
Thu, Jan 17, 7:19 PM
george.karpenkov closed D56891: [analyzer] Introduce proper diagnostic for freeing unowned object.
Thu, Jan 17, 7:19 PM
george.karpenkov committed rC351513: [analyzer] Extend the PathDiagnosticLocation constructor to handle CallExitEnd.
[analyzer] Extend the PathDiagnosticLocation constructor to handle CallExitEnd
Thu, Jan 17, 7:19 PM
george.karpenkov committed rL351513: [analyzer] Extend the PathDiagnosticLocation constructor to handle CallExitEnd.
[analyzer] Extend the PathDiagnosticLocation constructor to handle CallExitEnd
Thu, Jan 17, 7:19 PM
george.karpenkov closed D56890: [analyzer] Extend the PathDiagnosticLocation constructor to handle CallExitEnd.
Thu, Jan 17, 7:19 PM
george.karpenkov committed rC351512: [analyzer] [NFC] Clean up messy handling of bug categories in RetainCountChecker.
[analyzer] [NFC] Clean up messy handling of bug categories in RetainCountChecker
Thu, Jan 17, 7:19 PM
george.karpenkov committed rL351512: [analyzer] [NFC] Clean up messy handling of bug categories in RetainCountChecker.
[analyzer] [NFC] Clean up messy handling of bug categories in RetainCountChecker
Thu, Jan 17, 7:19 PM
george.karpenkov committed rL351511: [analyzer] const-ify reference to bug type used in BugReporter.
[analyzer] const-ify reference to bug type used in BugReporter
Thu, Jan 17, 7:19 PM
george.karpenkov committed rC351511: [analyzer] const-ify reference to bug type used in BugReporter.
[analyzer] const-ify reference to bug type used in BugReporter
Thu, Jan 17, 7:19 PM
george.karpenkov closed D56885: [analyzer] const-ify reference to bug type used in BugReporter.
Thu, Jan 17, 7:18 PM
george.karpenkov committed rL351510: [analyzer] Extend BugType constructor to accept "SuppressOnSink" as a parameter.
[analyzer] Extend BugType constructor to accept "SuppressOnSink" as a parameter
Thu, Jan 17, 7:18 PM
george.karpenkov committed rC351510: [analyzer] Extend BugType constructor to accept "SuppressOnSink" as a parameter.
[analyzer] Extend BugType constructor to accept "SuppressOnSink" as a parameter
Thu, Jan 17, 7:18 PM
george.karpenkov closed D56884: [analyzer] Extend BugType constructor to accept "SuppressOnSink" as a parameter.
Thu, Jan 17, 7:18 PM
george.karpenkov committed rL351509: [analyzer] [RetainCountChecker] Produce a correct message when OSTypeAlloc is….
[analyzer] [RetainCountChecker] Produce a correct message when OSTypeAlloc is…
Thu, Jan 17, 7:18 PM
george.karpenkov committed rC351509: [analyzer] [RetainCountChecker] Produce a correct message when OSTypeAlloc is….
[analyzer] [RetainCountChecker] Produce a correct message when OSTypeAlloc is…
Thu, Jan 17, 7:18 PM
george.karpenkov closed D56820: [analyzer] [RetainCountChecker] Produce a correct message when OSTypeAlloc is used.
Thu, Jan 17, 7:18 PM
george.karpenkov committed rC351508: [analyzer] [RetainCountChecker] Smart pointer support..
[analyzer] [RetainCountChecker] Smart pointer support.
Thu, Jan 17, 7:18 PM
george.karpenkov committed rL351508: [analyzer] [RetainCountChecker] Smart pointer support..
[analyzer] [RetainCountChecker] Smart pointer support.
Thu, Jan 17, 7:18 PM
george.karpenkov closed D56817: [analyzer] [RetainCountChecker] Smart pointer support..
Thu, Jan 17, 7:17 PM
george.karpenkov updated the diff for D56884: [analyzer] Extend BugType constructor to accept "SuppressOnSink" as a parameter.
Thu, Jan 17, 6:48 PM
george.karpenkov added parent revisions for D56891: [analyzer] Introduce proper diagnostic for freeing unowned object: D56887: [analyzer] [NFC] Clean up messy handling of bug categories in RetainCountChecker, D56885: [analyzer] const-ify reference to bug type used in BugReporter, D56884: [analyzer] Extend BugType constructor to accept "SuppressOnSink" as a parameter.
Thu, Jan 17, 6:34 PM
george.karpenkov added a child revision for D56885: [analyzer] const-ify reference to bug type used in BugReporter: D56891: [analyzer] Introduce proper diagnostic for freeing unowned object.
Thu, Jan 17, 6:33 PM
george.karpenkov added a child revision for D56887: [analyzer] [NFC] Clean up messy handling of bug categories in RetainCountChecker: D56891: [analyzer] Introduce proper diagnostic for freeing unowned object.
Thu, Jan 17, 6:33 PM
george.karpenkov added a child revision for D56884: [analyzer] Extend BugType constructor to accept "SuppressOnSink" as a parameter: D56891: [analyzer] Introduce proper diagnostic for freeing unowned object.
Thu, Jan 17, 6:33 PM
george.karpenkov created D56891: [analyzer] Introduce proper diagnostic for freeing unowned object.
Thu, Jan 17, 6:33 PM
george.karpenkov created D56890: [analyzer] Extend the PathDiagnosticLocation constructor to handle CallExitEnd.
Thu, Jan 17, 6:31 PM
george.karpenkov updated the diff for D56887: [analyzer] [NFC] Clean up messy handling of bug categories in RetainCountChecker.
Thu, Jan 17, 6:28 PM
george.karpenkov added parent revisions for D56887: [analyzer] [NFC] Clean up messy handling of bug categories in RetainCountChecker: D56885: [analyzer] const-ify reference to bug type used in BugReporter, D56884: [analyzer] Extend BugType constructor to accept "SuppressOnSink" as a parameter.
Thu, Jan 17, 4:18 PM
george.karpenkov added a child revision for D56885: [analyzer] const-ify reference to bug type used in BugReporter: D56887: [analyzer] [NFC] Clean up messy handling of bug categories in RetainCountChecker.
Thu, Jan 17, 4:18 PM
george.karpenkov added a child revision for D56884: [analyzer] Extend BugType constructor to accept "SuppressOnSink" as a parameter: D56887: [analyzer] [NFC] Clean up messy handling of bug categories in RetainCountChecker.
Thu, Jan 17, 4:18 PM
george.karpenkov created D56887: [analyzer] [NFC] Clean up messy handling of bug categories in RetainCountChecker.
Thu, Jan 17, 4:17 PM
george.karpenkov created D56885: [analyzer] const-ify reference to bug type used in BugReporter.
Thu, Jan 17, 4:15 PM
george.karpenkov created D56884: [analyzer] Extend BugType constructor to accept "SuppressOnSink" as a parameter.
Thu, Jan 17, 4:14 PM
george.karpenkov accepted D56824: [analyzer] MoveChecker: add ".assign" to the list of common reinitializing methods..
Thu, Jan 17, 3:49 PM
george.karpenkov accepted D56632: [analyzer] Track region liveness only through base regions..
Thu, Jan 17, 3:08 PM
george.karpenkov updated the diff for D56817: [analyzer] [RetainCountChecker] Smart pointer support..
Thu, Jan 17, 1:08 PM
george.karpenkov updated the diff for D56817: [analyzer] [RetainCountChecker] Smart pointer support..
Thu, Jan 17, 1:08 PM
george.karpenkov added a comment to D56817: [analyzer] [RetainCountChecker] Smart pointer support..

Addressed comments. Not sure about Inputs: plenty of headers are in the root directory.

Thu, Jan 17, 1:07 PM
george.karpenkov added a comment to D56823: [analyzer] Do not try to body-farm bodies for Objective-C properties with custom accessors..

LG, but it sounds like something which can skew results a lot (?)

Thu, Jan 17, 12:34 PM

Wed, Jan 16

george.karpenkov created D56820: [analyzer] [RetainCountChecker] Produce a correct message when OSTypeAlloc is used.
Wed, Jan 16, 5:23 PM
george.karpenkov updated the diff for D56817: [analyzer] [RetainCountChecker] Smart pointer support..
Wed, Jan 16, 4:04 PM
george.karpenkov committed rL351394: [analyzer] Another RetainCountChecker cleanup.
[analyzer] Another RetainCountChecker cleanup
Wed, Jan 16, 3:25 PM
george.karpenkov committed rC351394: [analyzer] Another RetainCountChecker cleanup.
[analyzer] Another RetainCountChecker cleanup
Wed, Jan 16, 3:25 PM
george.karpenkov closed D56759: [analyzer] Another RetainCountChecker cleanup.
Wed, Jan 16, 3:25 PM
george.karpenkov committed rC351393: [analyzer] [NFC] Yet another minor cleanup of RetainCountChecker.
[analyzer] [NFC] Yet another minor cleanup of RetainCountChecker
Wed, Jan 16, 3:25 PM
george.karpenkov committed rL351393: [analyzer] [NFC] Yet another minor cleanup of RetainCountChecker.
[analyzer] [NFC] Yet another minor cleanup of RetainCountChecker
Wed, Jan 16, 3:25 PM
george.karpenkov closed D56744: [analyzer] [NFC] Yet another minor cleanup of RetainCountChecker.
Wed, Jan 16, 3:25 PM
george.karpenkov created D56817: [analyzer] [RetainCountChecker] Smart pointer support..
Wed, Jan 16, 3:22 PM
george.karpenkov added a comment to D56759: [analyzer] Another RetainCountChecker cleanup.

Added test.

Wed, Jan 16, 10:50 AM
george.karpenkov updated the diff for D56759: [analyzer] Another RetainCountChecker cleanup.
Wed, Jan 16, 10:50 AM

Tue, Jan 15

george.karpenkov created D56759: [analyzer] Another RetainCountChecker cleanup.
Tue, Jan 15, 4:42 PM
george.karpenkov created D56744: [analyzer] [NFC] Yet another minor cleanup of RetainCountChecker.
Tue, Jan 15, 2:39 PM
george.karpenkov created D56736: [analyzer] [RetainCountChecker] Introduce optional tracking of unannotated retain out parameters, behind a flag.
Tue, Jan 15, 11:49 AM

Mon, Jan 14

george.karpenkov committed rL351113: [lit] llvm-lit.in: specify file encoding to UTF-8.
[lit] llvm-lit.in: specify file encoding to UTF-8
Mon, Jan 14, 12:06 PM
george.karpenkov closed D50201: llvm-lit.in: specify file encoding to UTF-8.
Mon, Jan 14, 12:06 PM
george.karpenkov added a comment to D50201: llvm-lit.in: specify file encoding to UTF-8.

@davispuh Someone needs to actually merge the change. Usually, the person who has opened the revision does it, but if they don't have it commit access the reviewer can do it for them (but then it is usually explicitly requested).
Would you like me to merge this?

Mon, Jan 14, 11:52 AM
george.karpenkov committed rC351097: [analyzer] [PR39792] false positive on strcpy targeting struct members.
[analyzer] [PR39792] false positive on strcpy targeting struct members
Mon, Jan 14, 10:58 AM
george.karpenkov committed rL351097: [analyzer] [PR39792] false positive on strcpy targeting struct members.
[analyzer] [PR39792] false positive on strcpy targeting struct members
Mon, Jan 14, 10:58 AM
george.karpenkov closed D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member.
Mon, Jan 14, 10:58 AM
george.karpenkov committed rL351096: [analyzer] [NFC] Remove unused undefined method..
[analyzer] [NFC] Remove unused undefined method.
Mon, Jan 14, 10:58 AM
george.karpenkov committed rC351096: [analyzer] [NFC] Remove unused undefined method..
[analyzer] [NFC] Remove unused undefined method.
Mon, Jan 14, 10:58 AM
george.karpenkov added a comment to D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member.

@Pierre-vh The patch does not compile due to unmatched braces. Please do test and compile before submitting!

Mon, Jan 14, 10:54 AM
george.karpenkov added a comment to D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member.

Whoops, sorry. There were holidays, and then I did forget about this patch. I'll commit this now.

Mon, Jan 14, 10:50 AM

Fri, Jan 11

george.karpenkov added a comment to D55616: Emit ASM input in a constant context.

Apologies - the value seems to indeed overflow, but I'm still very confused how this was affected by this change.

Fri, Jan 11, 5:48 PM
george.karpenkov added a comment to D55616: Emit ASM input in a constant context.

@void @efriedma I can't build XNU anymore after this commit, with an error message:

Fri, Jan 11, 5:25 PM
george.karpenkov committed rC350982: [analyzer] Support for OSObjects out parameters in RetainCountChecker.
[analyzer] Support for OSObjects out parameters in RetainCountChecker
Fri, Jan 11, 3:40 PM
george.karpenkov committed rL350982: [analyzer] Support for OSObjects out parameters in RetainCountChecker.
[analyzer] Support for OSObjects out parameters in RetainCountChecker
Fri, Jan 11, 3:40 PM
george.karpenkov closed D56240: [analyzer] Support for OSObjects out parameters in RetainCountChecker.
Fri, Jan 11, 3:40 PM
george.karpenkov committed rC350981: [analyzer] Introduce a convenience method for getting a CallEvent from an….
[analyzer] Introduce a convenience method for getting a CallEvent from an…
Fri, Jan 11, 3:40 PM
george.karpenkov committed rL350981: [analyzer] Introduce a convenience method for getting a CallEvent from an….
[analyzer] Introduce a convenience method for getting a CallEvent from an…
Fri, Jan 11, 3:39 PM
george.karpenkov closed D56300: [analyzer] Introduce a convenience method for getting a CallEvent from an arbitrary Stmt.
Fri, Jan 11, 3:39 PM
george.karpenkov updated the diff for D56300: [analyzer] Introduce a convenience method for getting a CallEvent from an arbitrary Stmt.
Fri, Jan 11, 3:25 PM
george.karpenkov updated the diff for D56240: [analyzer] Support for OSObjects out parameters in RetainCountChecker.
Fri, Jan 11, 2:57 PM
george.karpenkov added inline comments to D56240: [analyzer] Support for OSObjects out parameters in RetainCountChecker.
Fri, Jan 11, 2:56 PM
george.karpenkov committed rL350946: [analyzer] [NFC] Fix the FIXME in tests.
[analyzer] [NFC] Fix the FIXME in tests
Fri, Jan 11, 10:16 AM
george.karpenkov committed rC350946: [analyzer] [NFC] Fix the FIXME in tests.
[analyzer] [NFC] Fix the FIXME in tests
Fri, Jan 11, 10:16 AM
george.karpenkov committed rC350942: [attributes] Extend os_returns_(not_?)_retained attributes to parameters.
[attributes] Extend os_returns_(not_?)_retained attributes to parameters
Fri, Jan 11, 10:06 AM
george.karpenkov committed rL350942: [attributes] Extend os_returns_(not_?)_retained attributes to parameters.
[attributes] Extend os_returns_(not_?)_retained attributes to parameters
Fri, Jan 11, 10:06 AM
george.karpenkov closed D56292: [attributes] Extend os_returns_(not_?)_retained attributes to parameters..
Fri, Jan 11, 10:05 AM
george.karpenkov closed D56040: [analyzer] [NFC] Track object type with ArgEffect in RetainCountChecker..

This was committed, accidentally with the wrong associated revision number in 49ce62edef6f7e5da22eecaf3997c800bb961cac

Fri, Jan 11, 9:58 AM