- User Since
- Apr 14 2017, 1:59 PM (27 w, 2 d)
Fri, Oct 20
Tue, Oct 17
(just saw this by accident)
Abandoned in favor of a more general approach.
Mon, Oct 16
Sat, Oct 14
@dberris to be frank neither do I.
There seems to be a separate llvm-xray target, which is not invoked when you depend on xray.
As for target properties, somehow unit tests does not get picked up without it.
(yet somehow tsan's ones happily run without).
Sent email manually, as the email does no get sent if the CC list is updated =(
Adding LLVM commits as requested.
@dberris better now?
Fri, Oct 13
Thu, Oct 12
Adhered to naming suggestion.
LGTM, provided tests pass both in standalone and "normal" modes.
@mgorny so this one actually changes semantics.
The previous one reused generated object files, and with the change it will start recompiling all the tests again.
(and actually being able to export object files has added quite a bit of complexity to all these compiler-rt macros).
Yep, thanks! Good to go provided tests run.
Looks like we haven't spotted it due to other bug you have fixed cancelling this one out.
Yep, thanks! This was probably the root cause of the failure.
Wed, Oct 11
@mgorny I've replied via email, but the message didn't seem to appear here.
Tue, Oct 10
Marking requests as "done".
Adhering to comments.
Mon, Oct 9
Ooops, updated to https://bugs.llvm.org/show_bug.cgi?id=34869
Thu, Oct 5
Wed, Oct 4
@devernay do you actually need to use libFuzzer, or do you simply want to be able to build LLVM?
I think I've talked about this issue previously with a person who maintains macports for LLVM, and they've simply used a workaround which does not build libFuzzer.
Tue, Oct 3
Adhered to review comments.
Mon, Oct 2
Misspelled revision/review, committed in r314692, closing manually.
breaking stand-alone builds as a result
Fri, Sep 29
Mon, Sep 25
Sep 21 2017
Also, please make sure to add @NoQ to static analyzer reviews!
Does it work on Windows, Linux, and macOS?
It definitely works on OS X and Unix.
It's Windows implementation is the same one we have, so it is not worse (apparently it can fail on some obscure Windows versions, but so can the current implementation).
Do not import self from CmpRuns
Updated using review comments.
Failed copy-n-paste, this was fixed in r313924
Applying review comments.
@dcoughlin: yes. Either would work, I thought that CC=mycompiler ./blah was already quite idiomatic.