There are barely any lines I haven't changed in these files, so I think I could might as well leave it in an LLVM coding style conforming state. I also renamed 2 functions and moved addDependency out of line to ease on followup patches.
NoQ baloghadamsoftware xazax.hun rnkovacs
- rC358676: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename…
rGb9bc7ec304de: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename…
rL358676: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename…
Good point, sorry about that.
I wonder why this wasn't posted on cfe-dev. In any case, most of the variables are capitalized, there still is a consistency argument. Refactoring all the dependent patches would also be a pain in the buttocks for little gain.
I agree that we shouldn't try real hard to fix our code until we have a clear "party line" on how exactly do we name our variables (and ideally also how do we invalidate our caches), but having variables and fields consistent with each other makes it look much better imo, so why not.