Page MenuHomePhabricator

[InstCombine] Extra null-checking on TFE/LWE support
ClosedPublic

Authored by hliao on Jan 31 2019, 1:03 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

hliao created this revision.Jan 31 2019, 1:03 PM
  1. -U99999
  2. Test?
hliao added a comment.Jan 31 2019, 1:08 PM

this's early review. test will be added soon.

Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2019, 8:24 AM
hliao updated this revision to Diff 184771.Feb 1 2019, 9:21 AM

test case is added

arsenm added a subscriber: arsenm.Feb 1 2019, 9:26 AM
arsenm added inline comments.
llvm/test/Transforms/InstCombine/crash.tfe.ll
1 ↗(On Diff #184771)

This is going to fail if AMDGPU isn't built. This should go in test/Transforms/InstCombine/AMDGPU/amdgcn-demanded-vector-elts.ll with the others

hliao updated this revision to Diff 184776.Feb 1 2019, 9:44 AM

move to AMDGPU specific test

hliao updated this revision to Diff 184795.Feb 1 2019, 11:07 AM

update with -U9999

move to AMDGPU specific test

I meant literally in the same file. Can you move it in and follow the same naming scheme as the other functions there?

hliao updated this revision to Diff 184800.Feb 1 2019, 11:18 AM

merge that trivial test case into the originally one.

arsenm accepted this revision.Feb 1 2019, 11:25 AM

LGTM

This revision is now accepted and ready to land.Feb 1 2019, 11:25 AM
This revision was automatically updated to reflect the committed changes.