Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D52490

[AArch64][v8.5A] Add Memory Tagging instructions
ClosedPublic
Actions

Authored by olista01 on Sep 25 2018, 7:18 AM.

Details

Reviewers
javed.absar
t.p.northover
rengolin
SjoerdMeijer
ab
kcc
pcc
eugenis
vlad.tsyrklevich
Commits
rGc41902807edd: [AArch64][v8.5A] Add Memory Tagging instructions
rL343572: [AArch64][v8.5A] Add Memory Tagging instructions
Summary

This adds new instructions to manipluate tagged pointers, and to load
and store the tags associated with memory.

Patch by Pablo Barrio, David Spickett and Oliver Stannard!

Diff Detail

Repository
rL LLVM

Event Timeline

olista01 created this revision.Sep 25 2018, 7:18 AM
Herald added a reviewer: javed.absar. · View Herald TranscriptSep 25 2018, 7:18 AM
Herald added subscribers: llvm-commits, kristof.beyls. · View Herald Transcript
Harbormaster completed remote builds in B23083: Diff 166907.Sep 25 2018, 7:18 AM
olista01 added reviewers: t.p.northover, rengolin, SjoerdMeijer, ab, kcc, pcc, eugenis, vlad.tsyrklevich.Sep 25 2018, 7:31 AM
eugenis accepted this revision.Sep 25 2018, 2:25 PM

LGTM with nit

lib/Target/AArch64/AArch64InstrInfo.td
1170 ↗(On Diff #166907)

Do you need the pseudos in this patch?

This revision is now accepted and ready to land.Sep 25 2018, 2:25 PM
Closed by commit rL343572: [AArch64][v8.5A] Add Memory Tagging instructions (authored by olista01). · Explain WhyOct 2 2018, 3:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
llvm/
trunk/
lib/
Target/
AArch64/
115 lines
46 lines
14 lines
AsmParser/
25 lines
Disassembler/
40 lines
test/
MC/
AArch64/
716 lines
416 lines
Disassembler/
AArch64/
7 lines
451 lines

Diff 167909

View Options

llvm/trunk/lib/Target/AArch64/AArch64InstrFormats.td

Loading...
View Options

llvm/trunk/lib/Target/AArch64/AArch64InstrInfo.td

Loading...
View Options

llvm/trunk/lib/Target/AArch64/AArch64Subtarget.h

Loading...
View Options

llvm/trunk/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp

Loading...
View Options

llvm/trunk/lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp

Loading...
View Options

llvm/trunk/test/MC/AArch64/armv8.5a-mte-error.s

Loading...
View Options

llvm/trunk/test/MC/AArch64/armv8.5a-mte.s

Loading...
View Options

llvm/trunk/test/MC/Disassembler/AArch64/armv8.5a-mte-unpredictable.txt

Loading...
View Options

llvm/trunk/test/MC/Disassembler/AArch64/armv8.5a-mte.txt

Loading...