Page MenuHomePhabricator

vlad.tsyrklevich (Vlad Tsyrklevich)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 6 2017, 11:40 PM (197 w, 4 d)

Recent Activity

Dec 13 2019

vlad.tsyrklevich committed rG17063abd1e73: Revert "[ELF] Allow getErrPlace() to work before Out::bufferStart is set" (authored by vlad.tsyrklevich).
Revert "[ELF] Allow getErrPlace() to work before Out::bufferStart is set"
Dec 13 2019, 9:48 AM
vlad.tsyrklevich added a reverting change for rG2bbd32f5e8f0: [ELF] Allow getErrPlace() to work before Out::bufferStart is set: rG17063abd1e73: Revert "[ELF] Allow getErrPlace() to work before Out::bufferStart is set".
Dec 13 2019, 9:48 AM

Dec 10 2019

vlad.tsyrklevich committed rG636c93ed11a5: Revert "Reapply: [DebugInfo] Recover debug intrinsics when killing… (authored by vlad.tsyrklevich).
Revert "Reapply: [DebugInfo] Recover debug intrinsics when killing…
Dec 10 2019, 4:08 PM
vlad.tsyrklevich added a reverting change for rGf2ba93971ccc: Reapply: [DebugInfo] Recover debug intrinsics when killing duplicated/empty...: rG636c93ed11a5: Revert "Reapply: [DebugInfo] Recover debug intrinsics when killing….
Dec 10 2019, 4:08 PM

Dec 3 2019

vlad.tsyrklevich added a comment to D70681: [GWP-ASan] Implementation of crash handler API..

Is there a reason you want the API to be such that you can get the 'error string', 'allocation string', and metadata? The first two seem nice, though not especially useful without out the stack traces. The third seems like it might be exposing internals we don't want to expose and potentially lead to versioning issues. Also how does the crash reporter already knows the error type when calling these functions? I think perhaps it would make sense to have a getCrashReport() API that fills out a struct and perhaps having dumpReportInternal() only use the information from that struct to avoid duplicating work/ensuring all information we use is exposed? I may not be familiar enough with your crash handler case to understand the justification for why it is structured this way.

Dec 3 2019, 1:40 PM · Restricted Project, Restricted Project

Oct 31 2019

vlad.tsyrklevich committed rG92a25fbf11da: Revert "[WebAssembly] Handle multiple loads of splatted loads" (authored by vlad.tsyrklevich).
Revert "[WebAssembly] Handle multiple loads of splatted loads"
Oct 31 2019, 4:54 PM
vlad.tsyrklevich added a reverting change for rG2ab1b8c1ec45: [WebAssembly] Handle multiple loads of splatted loads: rG92a25fbf11da: Revert "[WebAssembly] Handle multiple loads of splatted loads".
Oct 31 2019, 4:54 PM
vlad.tsyrklevich committed rGe5cae5692b58: Revert "[WebAssembly] Expand setcc of v2i64" (authored by vlad.tsyrklevich).
Revert "[WebAssembly] Expand setcc of v2i64"
Oct 31 2019, 4:45 PM
vlad.tsyrklevich added a reverting change for rG11850a6305c5: [WebAssembly] Expand setcc of v2i64: rGe5cae5692b58: Revert "[WebAssembly] Expand setcc of v2i64".
Oct 31 2019, 4:45 PM

Oct 29 2019

vlad.tsyrklevich committed rG8d24d72f7f8b: Revert "[llvm-cov] Add option to whitelist filenames" (authored by vlad.tsyrklevich).
Revert "[llvm-cov] Add option to whitelist filenames"
Oct 29 2019, 10:40 PM
vlad.tsyrklevich added a reverting change for rGbfed824b57d1: [llvm-cov] Add option to whitelist filenames: rG8d24d72f7f8b: Revert "[llvm-cov] Add option to whitelist filenames".
Oct 29 2019, 10:40 PM
vlad.tsyrklevich added a comment to rGefed314118c7: Revert "[clang-format] Remove the dependency on frontend".

Ah, sorry. I should have included a link to a broken build instance. Here's one: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/36121/steps/check-clang%20ubsan/logs/stdio

Oct 29 2019, 11:51 AM
vlad.tsyrklevich committed rGefed314118c7: Revert "[clang-format] Remove the dependency on frontend" (authored by vlad.tsyrklevich).
Revert "[clang-format] Remove the dependency on frontend"
Oct 29 2019, 10:54 AM
vlad.tsyrklevich added a reverting change for rGec66603ac7ea: [clang-format] Remove the dependency on frontend: rGefed314118c7: Revert "[clang-format] Remove the dependency on frontend".
Oct 29 2019, 10:54 AM
vlad.tsyrklevich added a comment to D69569: isBuiltinFunc() uses StringRef instead of const char*.

Fix LGTM.

Oct 29 2019, 9:58 AM · Restricted Project

Oct 28 2019

vlad.tsyrklevich committed rGad531fff81a2: Revert "[clang] Add no_builtin attribute" (authored by vlad.tsyrklevich).
Revert "[clang] Add no_builtin attribute"
Oct 28 2019, 3:30 PM
vlad.tsyrklevich added a reverting change for rGbd8791610948: [clang] Add no_builtin attribute: rGad531fff81a2: Revert "[clang] Add no_builtin attribute".
Oct 28 2019, 3:30 PM
vlad.tsyrklevich committed rG38839d08b8e1: Revert "[Concepts] Constraint Enforcement & Diagnostics" (authored by vlad.tsyrklevich).
Revert "[Concepts] Constraint Enforcement & Diagnostics"
Oct 28 2019, 3:29 PM
vlad.tsyrklevich added a reverting change for rGffa214ef2289: [Concepts] Constraint Enforcement & Diagnostics: rG38839d08b8e1: Revert "[Concepts] Constraint Enforcement & Diagnostics".
Oct 28 2019, 3:29 PM
vlad.tsyrklevich added a comment to D41569: [Concepts] Constraint enforcement and diagnostics.

I noticed in Decl.cpp your change deleted some whitespace that belonged there. Not a big deal, just try to remember to run clang-format-diff when you're submitting for review. Thanks!

Oct 28 2019, 2:31 PM · Restricted Project

Sep 8 2019

vlad.tsyrklevich committed rL371347: Request commit access for vlad.tsyrklevich.
Request commit access for vlad.tsyrklevich
Sep 8 2019, 12:40 PM

Aug 30 2019

vlad.tsyrklevich committed rG802aab5de87c: Revert "[lld-link] implement -start-lib and -end-lib" (authored by vlad.tsyrklevich).
Revert "[lld-link] implement -start-lib and -end-lib"
Aug 30 2019, 4:24 PM
vlad.tsyrklevich committed rL370550: Revert "[lld-link] implement -start-lib and -end-lib".
Revert "[lld-link] implement -start-lib and -end-lib"
Aug 30 2019, 4:24 PM

Aug 28 2019

vlad.tsyrklevich committed rGb8a96f4bf5d7: Reland "[yaml2obj] - Don't allow setting StOther and Other/Visibility at the… (authored by vlad.tsyrklevich).
Reland "[yaml2obj] - Don't allow setting StOther and Other/Visibility at the…
Aug 28 2019, 7:04 AM
vlad.tsyrklevich committed rL370206: Reland "[yaml2obj] - Don't allow setting StOther and Other/Visibility at the….
Reland "[yaml2obj] - Don't allow setting StOther and Other/Visibility at the…
Aug 28 2019, 7:04 AM
vlad.tsyrklevich committed rGaba62e9c00e5: Revert "[yaml2obj] - Don't allow setting StOther and Other/Visibility at the… (authored by vlad.tsyrklevich).
Revert "[yaml2obj] - Don't allow setting StOther and Other/Visibility at the…
Aug 28 2019, 6:17 AM
vlad.tsyrklevich committed rL370198: Revert "[yaml2obj] - Don't allow setting StOther and Other/Visibility at the….
Revert "[yaml2obj] - Don't allow setting StOther and Other/Visibility at the…
Aug 28 2019, 6:14 AM

Aug 27 2019

vlad.tsyrklevich committed rG57076d3199fc: Revert "Change the X86 datalayout to add three address spaces for 32 bit signed… (authored by vlad.tsyrklevich).
Revert "Change the X86 datalayout to add three address spaces for 32 bit signed…
Aug 27 2019, 6:10 PM
vlad.tsyrklevich committed rL370142: Revert "Change the X86 datalayout to add three address spaces for 32 bit signed….
Revert "Change the X86 datalayout to add three address spaces for 32 bit signed…
Aug 27 2019, 6:10 PM
vlad.tsyrklevich accepted D66829: [zorg] Switch sanitizer-x86_64-linux-fast to use git.

Any reason not to switch the other bots as well?

Aug 27 2019, 2:14 PM · Restricted Project

Aug 20 2019

vlad.tsyrklevich added inline comments to D62875: [GWP-ASan] Add public-facing documentation [6]..
Aug 20 2019, 2:40 PM · Restricted Project, Restricted Project

Aug 18 2019

vlad.tsyrklevich added a comment to rL366708: Revert "Reland [ELF] Loose a condition for relocation with a symbol".

From the revert email http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20190722/675580.html they use:
$ gold -v
GNU gold (GNU Binutils for Debian 2.28) 1.14

Aug 18 2019, 11:42 PM

Aug 15 2019

vlad.tsyrklevich accepted D66189: [GWP-ASan] Implement stack frame compression..
Aug 15 2019, 1:28 PM · Restricted Project, Restricted Project
vlad.tsyrklevich added inline comments to D66189: [GWP-ASan] Implement stack frame compression..
Aug 15 2019, 12:47 PM · Restricted Project, Restricted Project
vlad.tsyrklevich added inline comments to D66189: [GWP-ASan] Implement stack frame compression..
Aug 15 2019, 11:31 AM · Restricted Project, Restricted Project

Aug 13 2019

vlad.tsyrklevich added inline comments to D66189: [GWP-ASan] Implement stack frame compression..
Aug 13 2019, 7:28 PM · Restricted Project, Restricted Project

Aug 12 2019

vlad.tsyrklevich accepted D66099: [GWP-ASan] Update backtrace function signature..
Aug 12 2019, 1:04 PM · Restricted Project, Restricted Project

Jul 26 2019

vlad.tsyrklevich committed rG485b8789de8b: Revert "[X86][SSE] Replace PMULDQ GetDemandedBits combine with… (authored by vlad.tsyrklevich).
Revert "[X86][SSE] Replace PMULDQ GetDemandedBits combine with…
Jul 26 2019, 11:18 AM
vlad.tsyrklevich committed rL367141: Revert "[X86][SSE] Replace PMULDQ GetDemandedBits combine with….
Revert "[X86][SSE] Replace PMULDQ GetDemandedBits combine with…
Jul 26 2019, 11:17 AM

Jul 25 2019

vlad.tsyrklevich committed rG5d5a58317cb2: Revert "[InstCombine] try to narrow a truncated load" (authored by vlad.tsyrklevich).
Revert "[InstCombine] try to narrow a truncated load"
Jul 25 2019, 8:38 AM
vlad.tsyrklevich added a reverting change for rGbc4a63fd3c29: [InstCombine] try to narrow a truncated load: rG5d5a58317cb2: Revert "[InstCombine] try to narrow a truncated load".
Jul 25 2019, 8:38 AM
vlad.tsyrklevich committed rL367029: Revert "[InstCombine] try to narrow a truncated load".
Revert "[InstCombine] try to narrow a truncated load"
Jul 25 2019, 8:37 AM

Jul 23 2019

vlad.tsyrklevich accepted D62875: [GWP-ASan] Add public-facing documentation [6]..
Jul 23 2019, 4:53 PM · Restricted Project, Restricted Project
vlad.tsyrklevich committed rGaa4f8d04a967: Revert "[Object/ELF.h] - Improve testing of the fields in ELFFile<ELFT>… (authored by vlad.tsyrklevich).
Revert "[Object/ELF.h] - Improve testing of the fields in ELFFile<ELFT>…
Jul 23 2019, 8:05 AM
vlad.tsyrklevich committed rL366815: Revert "[Object/ELF.h] - Improve testing of the fields in ELFFile<ELFT>….
Revert "[Object/ELF.h] - Improve testing of the fields in ELFFile<ELFT>…
Jul 23 2019, 8:05 AM

Jul 22 2019

vlad.tsyrklevich committed rG5874a28ac56d: Revert "Reland [ELF] Loose a condition for relocation with a symbol" (authored by vlad.tsyrklevich).
Revert "Reland [ELF] Loose a condition for relocation with a symbol"
Jul 22 2019, 10:51 AM
vlad.tsyrklevich committed rL366708: Revert "Reland [ELF] Loose a condition for relocation with a symbol".
Revert "Reland [ELF] Loose a condition for relocation with a symbol"
Jul 22 2019, 10:51 AM

Jun 29 2019

vlad.tsyrklevich accepted D63841: [GWP-ASan] Add generic unwinders and structure backtrace output..
Jun 29 2019, 10:59 AM · Restricted Project, Restricted Project

Jun 27 2019

vlad.tsyrklevich added a comment to D63841: [GWP-ASan] Add generic unwinders and structure backtrace output..

I'm not very familiar with the compiler-rt build-side of this change, eugenis can speak to that better than I can.

Jun 27 2019, 1:28 PM · Restricted Project, Restricted Project

Jun 24 2019

vlad.tsyrklevich added a comment to D63736: [GWP-ASan] Guard against recursive allocs. Pack TLS for perf..

Do we need similar protection in deallocate?

We shouldn't need to. GPA::deallocate() may call malloc() and free(), but can only be called with guarded allocations. Recursion is okay (and desirable, as the unwinder's implementation is okay to be sampled) in deallocate().

Jun 24 2019, 3:30 PM · Restricted Project, Restricted Project
vlad.tsyrklevich updated subscribers of D63703: [stack-safety] Refactoring StackSafetyAnalysis to be accsessible from other passes.

Hi gilang, out of curiosity what is your intended use of the StackSafetyAnalysis? Is it necessary to expose all of the information exposed here?

Jun 24 2019, 1:18 PM · Restricted Project

Jun 7 2019

vlad.tsyrklevich accepted D62929: [GWP-ASan] Integration with Scudo [5]..
Jun 7 2019, 2:09 PM · Restricted Project, Restricted Project
vlad.tsyrklevich committed rGa6283b06fea0: Revert "[CodeComplete] Improve overload handling for C++ qualified and ref… (authored by vlad.tsyrklevich).
Revert "[CodeComplete] Improve overload handling for C++ qualified and ref…
Jun 7 2019, 12:18 PM
vlad.tsyrklevich added a reverting change for rGf1f6e0fc2468: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified…: rGa6283b06fea0: Revert "[CodeComplete] Improve overload handling for C++ qualified and ref….
Jun 7 2019, 12:18 PM
vlad.tsyrklevich committed rL362830: Revert "[CodeComplete] Improve overload handling for C++ qualified and ref….
Revert "[CodeComplete] Improve overload handling for C++ qualified and ref…
Jun 7 2019, 12:18 PM
vlad.tsyrklevich committed rGe67f6206ac37: Revert "[llvm-objdump] Add warning if --disassemble-functions specifies an… (authored by vlad.tsyrklevich).
Revert "[llvm-objdump] Add warning if --disassemble-functions specifies an…
Jun 7 2019, 11:53 AM
vlad.tsyrklevich added a reverting change for rG50f61af3f304: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown…: rGe67f6206ac37: Revert "[llvm-objdump] Add warning if --disassemble-functions specifies an….
Jun 7 2019, 11:53 AM
vlad.tsyrklevich committed rL362826: Revert "[llvm-objdump] Add warning if --disassemble-functions specifies an….
Revert "[llvm-objdump] Add warning if --disassemble-functions specifies an…
Jun 7 2019, 11:53 AM
vlad.tsyrklevich committed rGd8e3d0dab8e7: Revert "[ADT] Enable set_difference() to be used on StringSet" (authored by vlad.tsyrklevich).
Revert "[ADT] Enable set_difference() to be used on StringSet"
Jun 7 2019, 11:32 AM
vlad.tsyrklevich added a reverting change for rG0bddef79019a: [ADT] Enable set_difference() to be used on StringSet: rGd8e3d0dab8e7: Revert "[ADT] Enable set_difference() to be used on StringSet".
Jun 7 2019, 11:32 AM
vlad.tsyrklevich committed rL362823: Revert "[ADT] Enable set_difference() to be used on StringSet".
Revert "[ADT] Enable set_difference() to be used on StringSet"
Jun 7 2019, 11:31 AM

Jun 6 2019

vlad.tsyrklevich added a comment to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

I tested the following change and verified that it works for the numeric example above, but don't have time to write a test and monitor for build failures so I'm going to revert this change for now. Leaving it here for whoever wants to pick it up:

Assuming that I have applied Vlad's patch correctly, I find that it doesn't work.

to_chars(buf, buf + 100, (int64_t)0x10000000000) gives a result of 199511627776 instead of 1099511627776
(note the missing zero)

Jun 6 2019, 3:20 PM · Restricted Project
vlad.tsyrklevich committed rGbad2b3cf08b6: Revert "Speedup to_string and to_wstring for integers using stack buffer and… (authored by vlad.tsyrklevich).
Revert "Speedup to_string and to_wstring for integers using stack buffer and…
Jun 6 2019, 12:50 AM
vlad.tsyrklevich added a reverting change for rG7ce7110e6d96: Speedup to_string and to_wstring for integers using stack buffer and SSO.: rGbad2b3cf08b6: Revert "Speedup to_string and to_wstring for integers using stack buffer and….
Jun 6 2019, 12:50 AM
vlad.tsyrklevich committed rL362680: Revert "Speedup to_string and to_wstring for integers using stack buffer and….
Revert "Speedup to_string and to_wstring for integers using stack buffer and…
Jun 6 2019, 12:48 AM
vlad.tsyrklevich added a comment to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

I tested the following change and verified that it works for the numeric example above, but don't have time to write a test and monitor for build failures so I'm going to revert this change for now. Leaving it here for whoever wants to pick it up:

--- a/libcxx/src/charconv.cpp
+++ b/libcxx/src/charconv.cpp
@@ -176,22 +176,39 @@ __u64toa(uint64_t value, char* buffer)
         const uint32_t b0 = v0 / 10000;
         const uint32_t c0 = v0 % 10000;
Jun 6 2019, 12:48 AM · Restricted Project
vlad.tsyrklevich added a comment to D59178: [libc++] Speedup to_string and to_wstring for integers using stack buffer and SSO.

After this change landed I started getting odd failures with check-llvm with MSan or ASan like the following: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/12853
/b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm/test/ThinLTO/X86/dot-dumper-full-lto.ll:12:10: error: CHECK: expected string not found in input
; CHECK: subgraph cluster_4294967295
<stdin>:3:2: note: possible intended match here
subgraph cluster_0004294967295 {

Jun 6 2019, 12:40 AM · Restricted Project

Jun 5 2019

vlad.tsyrklevich accepted D62872: [GWP-ASan] Core Guarded Pool Allocator [4]..

LGTM otherwise

Jun 5 2019, 12:05 PM · Restricted Project, Restricted Project

Jun 4 2019

vlad.tsyrklevich added inline comments to D62872: [GWP-ASan] Core Guarded Pool Allocator [4]..
Jun 4 2019, 6:03 PM · Restricted Project, Restricted Project

May 31 2019

vlad.tsyrklevich added inline comments to D62698: [GWP-ASan] Configuration options [3]..
May 31 2019, 8:51 PM · Restricted Project, Restricted Project

May 8 2019

vlad.tsyrklevich added a comment to D60593: [GwpAsan] Introduce GWP-ASan..

One thing I also just realized is that by explicitly setting TLS model to initial-exec we prevent dlopen() dynamic loading, I don't have a problem with that but just wanted to make sure @cryptoad was aware.

May 8 2019, 9:37 AM · Restricted Project, Restricted Project, Restricted Project

May 6 2019

vlad.tsyrklevich accepted D60593: [GwpAsan] Introduce GWP-ASan..
May 6 2019, 1:12 PM · Restricted Project, Restricted Project, Restricted Project

May 3 2019

vlad.tsyrklevich added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
May 3 2019, 12:10 PM · Restricted Project, Restricted Project, Restricted Project
vlad.tsyrklevich added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
May 3 2019, 12:04 PM · Restricted Project, Restricted Project, Restricted Project

May 2 2019

vlad.tsyrklevich added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
May 2 2019, 12:27 PM · Restricted Project, Restricted Project, Restricted Project

Apr 30 2019

vlad.tsyrklevich added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Apr 30 2019, 1:49 PM · Restricted Project, Restricted Project, Restricted Project
vlad.tsyrklevich added a comment to D60593: [GwpAsan] Introduce GWP-ASan..
  • Added a thread contention test. Creates allocations using multiple threads and checks to see that a guarded slot is never allocated twice. Also tests against the random slot selection.
Apr 30 2019, 1:27 PM · Restricted Project, Restricted Project, Restricted Project

Apr 24 2019

vlad.tsyrklevich added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Apr 24 2019, 6:29 PM · Restricted Project, Restricted Project, Restricted Project
vlad.tsyrklevich requested changes to D60593: [GwpAsan] Introduce GWP-ASan..

Found some bugs, requesting changes to track that I'd like to review the fixes and tests for that behavior.

Apr 24 2019, 5:49 PM · Restricted Project, Restricted Project, Restricted Project

Apr 22 2019

vlad.tsyrklevich accepted D60593: [GwpAsan] Introduce GWP-ASan..

LGTM other than nits

Apr 22 2019, 5:35 PM · Restricted Project, Restricted Project, Restricted Project

Apr 19 2019

vlad.tsyrklevich added a comment to D60593: [GwpAsan] Introduce GWP-ASan..

I believe the short circuiting of the IsInitialised load/branch in the general case basically leads to the performance being the same. The values are so close that I'm willing to believe that it's within margin-of-error, but some minor microarchitectural feature could also be leading to the ret version being faster.

Apr 19 2019, 4:19 PM · Restricted Project, Restricted Project, Restricted Project

Apr 18 2019

vlad.tsyrklevich added a comment to D60593: [GwpAsan] Introduce GWP-ASan..

For the branch case, I had the conditional branch outside of NextSampleCounter == 0, so that the RT-disabled would incur minimal overhead (single branch instead of two branches), e.g.

shouldSample() {
  if (!IsInitialised) return false;
  if (NextSampleCounter == 0`) ...
Apr 18 2019, 4:23 PM · Restricted Project, Restricted Project, Restricted Project
vlad.tsyrklevich added a comment to D60593: [GwpAsan] Introduce GWP-ASan..
OptionMedian Time (with 20 runs)Runtime increase relative to CT-Disabled
Compile-time disabled3.5715s0.0000%
Runtime disabled (init check in ret)3.6490s2.1239%
Runtime disabled (init check in branch)3.6350s1.7469%
Runtime enabled (init check in ret)3.6435s1.9761%
Runtime enabled (init check in branch)3.6500s2.1507%
Apr 18 2019, 10:55 AM · Restricted Project, Restricted Project, Restricted Project

Apr 16 2019

vlad.tsyrklevich added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Apr 16 2019, 4:38 PM · Restricted Project, Restricted Project, Restricted Project
vlad.tsyrklevich added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Apr 16 2019, 12:39 PM · Restricted Project, Restricted Project, Restricted Project

Apr 12 2019

vlad.tsyrklevich added a comment to D60593: [GwpAsan] Introduce GWP-ASan..

I've implemented them here because it gives us a few benefits:

  1. Allows us to test different configuration options at runtime without a recompile.
  2. Gives allocators more choice as to how they use GWP-ASan (they might provide alignment guarantees that we can't).
  3. We can A/B test deployments in production. We can have half a fleet using OddLeftEvenRight and half a fleet using OddRightEvenLeft, and this may hypothetically give us the best chance of finding bugs.

Happy to take feedback on this, if others see it as unneccessary we can delete them.

Apr 12 2019, 4:00 PM · Restricted Project, Restricted Project, Restricted Project
vlad.tsyrklevich added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Apr 12 2019, 7:26 AM · Restricted Project, Restricted Project, Restricted Project

Apr 11 2019

vlad.tsyrklevich added inline comments to D60593: [GwpAsan] Introduce GWP-ASan..
Apr 11 2019, 8:52 PM · Restricted Project, Restricted Project, Restricted Project
vlad.tsyrklevich added a comment to D60593: [GwpAsan] Introduce GWP-ASan..

Some thoughts after taking a quick glance at this:

  • AllocationStrategy/AlignmentStrategy don’t seem useful to me as they are. Are they just for testing? Could we get rid of them by allocating full-page allocations instead in the under/overflow tests instead? They complicate the implementation and I don’t know why people would use them outside of flipping a flag to say “full right-alignment” instead of whatever reasonable alignment strategy we choose for them. Perhaps collapse both into a single bool PerfectlyRightAlign flag and just have the default alignment strategy be something we choose?
  • What is the plan for adding stack trace support?
Apr 11 2019, 6:38 PM · Restricted Project, Restricted Project, Restricted Project

Mar 13 2019

vlad.tsyrklevich added inline comments to D59254: [RFC] Implementation of Clang randstruct.
Mar 13 2019, 8:29 PM · Restricted Project

Mar 7 2019

vlad.tsyrklevich committed rG2e1479e2f2dd: Delete x86_64 ShadowCallStack support (authored by vlad.tsyrklevich).
Delete x86_64 ShadowCallStack support
Mar 7 2019, 10:56 AM
vlad.tsyrklevich committed rL355624: Delete x86_64 ShadowCallStack support.
Delete x86_64 ShadowCallStack support
Mar 7 2019, 10:56 AM
vlad.tsyrklevich committed rCRT355624: Delete x86_64 ShadowCallStack support.
Delete x86_64 ShadowCallStack support
Mar 7 2019, 10:56 AM
vlad.tsyrklevich committed rC355624: Delete x86_64 ShadowCallStack support.
Delete x86_64 ShadowCallStack support
Mar 7 2019, 10:56 AM
vlad.tsyrklevich closed D59034: Delete x86_64 ShadowCallStack support.
Mar 7 2019, 10:56 AM · Restricted Project, Restricted Project, Restricted Project
vlad.tsyrklevich updated the diff for D59034: Delete x86_64 ShadowCallStack support.
  • Keep x86_64 doc link
Mar 7 2019, 10:34 AM · Restricted Project, Restricted Project, Restricted Project

Mar 6 2019

vlad.tsyrklevich created D59034: Delete x86_64 ShadowCallStack support.
Mar 6 2019, 11:12 AM · Restricted Project, Restricted Project, Restricted Project

Mar 1 2019

vlad.tsyrklevich committed rG53a9f1d3676c: Revert "[DWARFFormValue] Cleanup DWARFFormValue interface. (2/2) (NFC)" (authored by vlad.tsyrklevich).
Revert "[DWARFFormValue] Cleanup DWARFFormValue interface. (2/2) (NFC)"
Mar 1 2019, 5:10 PM
vlad.tsyrklevich committed rL355255: Revert "[DWARFFormValue] Cleanup DWARFFormValue interface. (2/2) (NFC)".
Revert "[DWARFFormValue] Cleanup DWARFFormValue interface. (2/2) (NFC)"
Mar 1 2019, 5:09 PM
vlad.tsyrklevich committed rGa8af6ca06523: Revert "Revert "[sanitizers] Don't use Windows Trace Logging on MinGW"" (authored by vlad.tsyrklevich).
Revert "Revert "[sanitizers] Don't use Windows Trace Logging on MinGW""
Mar 1 2019, 4:47 PM