This is an archive of the discontinued LLVM Phabricator instance.

Differential D50043

[RISCV] RISC-V using -fuse-init-array by default
ClosedPublic

Authored by kito-cheng on Jul 31 2018, 1:39 AM.

Details

Reviewers
asb
apazos
mgrang
Commits
rGed08d3739a00: [RISCV] RISC-V using -fuse-init-array by default
rC340595: [RISCV] RISC-V using -fuse-init-array by default
rL340595: [RISCV] RISC-V using -fuse-init-array by default
Summary

RISC-V target using -fuse-init-array even for bare-mental target.

Diff Detail

Repository
rC Clang

Event Timeline

kito-cheng created this revision.Jul 31 2018, 1:39 AM
Herald added subscribers: cfe-commits, rkruppe, rogfer01 and 2 others. · View Herald TranscriptJul 31 2018, 1:39 AM
asb added a comment.Aug 2 2018, 7:10 AM

Could you add a test for this please?

asb requested changes to this revision.Aug 16 2018, 4:30 AM
This revision now requires changes to proceed.Aug 16 2018, 4:30 AM
Herald added a subscriber: PkmX. · View Herald TranscriptAug 16 2018, 4:30 AM
kito-cheng updated this revision to Diff 161990.Aug 22 2018, 10:25 AM

Changes:

  • Add test.
Herald added subscribers: jocewei, the_o, brucehoult and 9 others. · View Herald TranscriptAug 22 2018, 10:26 AM
sabuasal added a reviewer: mgrang.Aug 22 2018, 6:55 PM
asb accepted this revision.Aug 23 2018, 4:42 AM

Thanks, looks good to me.

This revision is now accepted and ready to land.Aug 23 2018, 4:42 AM
Closed by commit rL340595: [RISCV] RISC-V using -fuse-init-array by default (authored by kito). · Explain WhyAug 23 2018, 8:05 PM
This revision was automatically updated to reflect the committed changes.
Herald added subscribers: llvm-commits, jrtc27. · View Herald TranscriptAug 23 2018, 8:05 PM
lewis-revill mentioned this in D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf.Aug 30 2018, 8:19 AM

Revision Contents

PathSize
lib/
Driver/
ToolChains/
4 lines

Diff 158187

lib/Driver/ToolChains/Gnu.cpp

Show First 20 Lines • Show All 2,547 Lines • ▼ Show 20 Lines bool UseInitArrayDefault =
(getTriple().getOS() == llvm::Triple::FreeBSD && (getTriple().getOS() == llvm::Triple::FreeBSD &&
getTriple().getOSMajorVersion() >= 12) || getTriple().getOSMajorVersion() >= 12) ||
(getTriple().getOS() == llvm::Triple::Linux && (getTriple().getOS() == llvm::Triple::Linux &&
((!GCCInstallation.isValid() || !V.isOlderThan(4, 7, 0)) || ((!GCCInstallation.isValid() || !V.isOlderThan(4, 7, 0)) ||
getTriple().isAndroid())) || getTriple().isAndroid())) ||
getTriple().getOS() == llvm::Triple::NaCl || getTriple().getOS() == llvm::Triple::NaCl ||
(getTriple().getVendor() == llvm::Triple::MipsTechnologies && (getTriple().getVendor() == llvm::Triple::MipsTechnologies &&
!getTriple().hasEnvironment()) || !getTriple().hasEnvironment()) ||
getTriple().getOS() == llvm::Triple::Solaris; getTriple().getOS() == llvm::Triple::Solaris ||
getTriple().getArch() == llvm::Triple::riscv32 ||
getTriple().getArch() == llvm::Triple::riscv64;
if (DriverArgs.hasFlag(options::OPT_fuse_init_array, if (DriverArgs.hasFlag(options::OPT_fuse_init_array,
options::OPT_fno_use_init_array, UseInitArrayDefault)) options::OPT_fno_use_init_array, UseInitArrayDefault))
CC1Args.push_back("-fuse-init-array"); CC1Args.push_back("-fuse-init-array");
} }