TableGen: add some more helpful error messages

[nhaehnle]

Summary

Change-Id: I6f3dacf675a4126134577616e259696bebdade3a

[simon_tatham]

lib/TableGen/TGParser.cpp

2315 ↗

(On Diff #148765)

Typo – surely "the same name", not "the same same" :-)

[nhaehnle]

Fix typo.

lib/TableGen/TGParser.cpp

2315 ↗

(On Diff #148765)

Clearly :) Thanks!

llvm/trunk/lib/TableGen/TGParser.cpp

if (!Rec->isAnonymous()) {
       return true;
     }
     Rec->setName(Records.getNewAnonymousName());
   }
 
   Rec->resolveReferences();
   checkConcrete(*Rec);
 
+  if (!isa<StringInit>(Rec->getNameInit())) {
+    PrintError(Rec->getLoc(), Twine("record name '") +
+                                  Rec->getNameInit()->getAsString() +
+                                  "' could not be fully resolved");
+    return true;
+  }
+
   // If ObjectBody has template arguments, it's an error.
   assert(Rec->getTemplateArgs().empty() && "How'd this get template args?");
 
   for (DefsetRecord *Defset : Defsets) {
     DefInit *I = Rec->getDefInit();
     if (!I->getType()->typeIsA(Defset->EltTy)) {
       PrintError(Rec->getLoc(), Twine("adding record of incompatible type '") +
                                     I->getType()->getAsString() +
if (!TemplArg)
     return true;
 
   TheRecToAddTo->addTemplateArg(TemplArg);
 
   while (Lex.getCode() == tgtok::comma) {
     Lex.Lex(); // eat the ','
 
     // Read the following declarations.
+    SMLoc Loc = Lex.getLoc();
     TemplArg = ParseDeclaration(CurRec, true/*templateargs*/);
     if (!TemplArg)
       return true;
+
+    if (TheRecToAddTo->isTemplateArg(TemplArg))
+      return Error(Loc, "template argument with the same name has already been "
+                        "defined");
+
     TheRecToAddTo->addTemplateArg(TemplArg);
   }
 
   if (Lex.getCode() != tgtok::greater)
     return TokError("expected '>' at end of template argument list");
   Lex.Lex(); // eat the '>'.
   return false;
 }