This is an archive of the discontinued LLVM Phabricator instance.

Differential D46144

Reflow paragraphs in comments.
ClosedPublic

Authored by aprantl on Apr 26 2018, 2:30 PM.

Details

Reviewers
clayborg
jingham
jasonmolenda
labath
javed.absar
• espindola
JDevlieghere
Commits
rG05097246f352: Reflow paragraphs in comments.
rLLDB331197: Reflow paragraphs in comments.
rL331197: Reflow paragraphs in comments.
Summary

This is intended as a clean up after the big clang-format commit (r280751), which unfortunately resulted in many of the comment paragraphs in LLDB being very hard to read.

FYI the script I used was:

import textwrap
import commands
import os
import sys
import re
tmp = "%s.tmp"%sys.argv[1]
out = open(tmp, "w+")
with open(sys.argv[1], "r") as f:
  header = ""
  text = ""
  for line in f:
      comment = re.compile(r'^( *//) ([^ ].*)$')
      match = comment.match(line)
      if match:
          # skip intentionally short comments.
          if not text and len(match.group(2)) < 40:
              out.write(line)
              continue

          if text:
              text += " " + match.group(2)
          else:
              header = match.group(1)
              text = match.group(2)
          
          continue
      else:
          if text:
              filled = textwrap.wrap(text, width=(73-len(header)),
                                     break_long_words=False)
              for l in filled:
                  out.write(header+" "+l+'\n')
              text = ""

      out.write(line)

os.rename(tmp, sys.argv[1])
#find source -name '*.cpp' -exec python join-comments.py \{} \;

Diff Detail

Event Timeline

aprantl created this revision.Apr 26 2018, 2:30 PM
Herald added a reviewer: javed.absar. · View Herald TranscriptApr 26 2018, 2:30 PM
Herald added a reviewer: • espindola. · View Herald Transcript
Herald added subscribers: mgrang, JDevlieghere, kbarton and 5 others. · View Herald Transcript
labath added a comment.Apr 27 2018, 1:52 AM

The formatting of the comments has been bugging me as well. So far, I have been trying to reflow them whenever I touch the code around them, but at that rate fixing all of them would take ages.

Your heuristics seem to be working fairly well. I've found a couple of sub-optimal decisions in the few files I opened, but I am not sure if it's feasible to fix the algorithm to account for them.

So overall, this seems like a good idea to me, and the few places where it gets this wrong can be fixed up afterwards (it decreases the total number of badly formatted comments).

PS: I don't see any header files in the list. Is there a particular reason for skipping them?

source/API/SBDebugger.cpp
73

Folding TODO: Here is sub-optimal.

source/API/SBInstruction.cpp
37–38

This doesn't look right.

arichardson removed a subscriber: arichardson.Apr 27 2018, 1:53 AM
aprantl updated this revision to Diff 144420.Apr 27 2018, 4:46 PM

Updated the script based on Pavel's feedback:

import textwrap
import commands
import os
import sys
import re
tmp = "%s.tmp"%sys.argv[1]
out = open(tmp, "w+")
with open(sys.argv[1], "r") as f:
  header = ""
  text = ""
  comment = re.compile(r'^( *//) ([^ ].*)$')
  special = re.compile(r'^(([A-Z]+[: ])|([0-9]+ )).*$')
  for line in f:
      match = comment.match(line)
      if match and not special.match(match.group(2)):
          # skip intentionally short comments.
          if not text and len(match.group(2)) < 40:
              out.write(line)
              continue

          if text:
              text += " " + match.group(2)
          else:
              header = match.group(1)
              text = match.group(2)
          
          continue

      if text:
          filled = textwrap.wrap(text, width=(77-len(header)),
                                 break_long_words=False)
          for l in filled:
              out.write(header+" "+l+'\n')
              text = ""

      out.write(line)

os.rename(tmp, sys.argv[1])
#find source -name '*.cpp' -exec python join-comments.py \{} \;
labath accepted this revision.Apr 30 2018, 6:06 AM

Looks fine to me, I guess if noone objects, we can land this. Thanks for doing this.

This revision is now accepted and ready to land.Apr 30 2018, 6:06 AM
clayborg accepted this revision.Apr 30 2018, 8:11 AM
JDevlieghere accepted this revision.Apr 30 2018, 8:25 AM

👍

source/Host/common/MainLoop.cpp
158

Is this intentional or maybe an off-by-one error? The a is in the 79th colum, which is okay for clang-format.

aprantl added inline comments.Apr 30 2018, 9:00 AM
source/Host/common/MainLoop.cpp
158

My script sets the threshold to 78 columns. When you are on an 80-column terminal and your editor doesn't indicate whether long lines continue or not then not using the last two characters makes it unambiguous whether the a is the beginning of a new word or whether it stands for itself.
I'll change the threshold to 80 columns to avoid reflowing paragraphs that don't need it.

Closed by commit rL331197: Reflow paragraphs in comments. (authored by adrian). · Explain WhyApr 30 2018, 9:54 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptApr 30 2018, 9:54 AM

Large Diff

This large diff affects 620 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
include/
lldb/
API/
6 lines
14 lines
29 lines
3 lines
14 lines
6 lines
8 lines
3 lines
4 lines
8 lines
4 lines
4 lines
7 lines
4 lines
7 lines
3 lines
4 lines
Breakpoint/
25 lines
3 lines
4 lines
12 lines
4 lines
20 lines
8 lines
3 lines
4 lines
10 lines
4 lines
16 lines
4 lines
20 lines
Core/
34 lines
4 lines
4 lines
36 lines
26 lines
49 lines
13 lines
8 lines
30 lines
39 lines
35 lines
6 lines
8 lines
10 lines
79 lines
15 lines
4 lines
42 lines
5 lines
7 lines
5 lines
7 lines
81 lines
19 lines
7 lines
77 lines
6 lines
DataFormatters/
11 lines
4 lines
51 lines
10 lines
3 lines
7 lines
11 lines
33 lines
7 lines
4 lines
Expression/
4 lines
7 lines
15 lines
4 lines
11 lines
3 lines
11 lines
Host/
8 lines
20 lines
36 lines
23 lines
4 lines
54 lines
7 lines
28 lines
16 lines
37 lines
19 lines
common/
4 lines
4 lines
33 lines
17 lines
linux/
3 lines
posix/
4 lines
Interpreter/
4 lines
11 lines
58 lines
46 lines
4 lines
10 lines
6 lines
19 lines
12 lines
10 lines
6 lines
28 lines
Symbol/
4 lines
18 lines
11 lines
12 lines
3 lines
33 lines
4 lines
54 lines
42 lines
6 lines
43 lines
7 lines
27 lines
74 lines
8 lines
16 lines
35 lines
40 lines
51 lines
21 lines
10 lines
6 lines
Target/
19 lines
4 lines
24 lines
29 lines
31 lines
8 lines
8 lines
25 lines
61 lines
149 lines
11 lines
7 lines
13 lines
11 lines
9 lines
15 lines
18 lines
4 lines
8 lines
4 lines
3 lines
18 lines
57 lines
105 lines
137 lines
6 lines
17 lines
62 lines
39 lines
8 lines
30 lines
7 lines
31 lines
Utility/
9 lines
13 lines
4 lines
4 lines
4 lines
12 lines
9 lines
30 lines
17 lines
22 lines
6 lines
6 lines
4 lines
21 lines
10 lines
3 lines
17 lines
6 lines
136 lines
10 lines
9 lines
35 lines
4 lines
source/
API/
13 lines
4 lines
4 lines
26 lines
4 lines
3 lines
23 lines
4 lines
16 lines
6 lines
8 lines
3 lines
3 lines
9 lines
18 lines
15 lines
5 lines
4 lines
12 lines
43 lines
24 lines
Breakpoint/
121 lines
7 lines
40 lines
15 lines
13 lines
16 lines
13 lines
40 lines
9 lines
18 lines
20 lines
4 lines
3 lines
Commands/
12 lines
8 lines
57 lines
29 lines
31 lines
11 lines
36 lines
32 lines
20 lines
22 lines
13 lines
19 lines
71 lines
7 lines
22 lines
10 lines
118 lines
97 lines
76 lines
20 lines
27 lines
30 lines
Core/
102 lines
5 lines
9 lines
26 lines
81 lines
93 lines
18 lines
21 lines
4 lines
29 lines
69 lines
168 lines
8 lines
74 lines
162 lines
44 lines
32 lines
24 lines
37 lines
4 lines
10 lines
35 lines
30 lines
229 lines
6 lines
4 lines
47 lines
4 lines
27 lines
7 lines
77 lines
DataFormatters/
7 lines
33 lines
12 lines
53 lines
5 lines
Expression/
281 lines
5 lines
8 lines
6 lines
11 lines
27 lines
4 lines
33 lines
5 lines
13 lines
26 lines
15 lines
Host/
android/
11 lines
common/
140 lines
8 lines
25 lines
18 lines
21 lines
4 lines
74 lines
10 lines
100 lines
18 lines
17 lines
24 lines
9 lines
25 lines
4 lines
4 lines
freebsd/
5 lines
linux/
4 lines
14 lines
macosx/
28 lines
cfcpp/
44 lines
14 lines
netbsd/
5 lines
posix/
78 lines
15 lines
3 lines
4 lines
31 lines
windows/
59 lines
8 lines
20 lines
9 lines
4 lines
27 lines
Interpreter/
3 lines
226 lines
51 lines
6 lines
4 lines
8 lines
6 lines
4 lines
25 lines
3 lines
8 lines
9 lines
8 lines
17 lines
12 lines
8 lines
27 lines
4 lines
144 lines
52 lines
Plugins/
ABI/
MacOSX-arm/
18 lines
MacOSX-arm64/
28 lines
MacOSX-i386/
17 lines
SysV-arm/
4 lines
SysV-arm64/
36 lines
SysV-hexagon/
4 lines
SysV-i386/
51 lines
SysV-mips/
8 lines
SysV-mips64/
37 lines
SysV-ppc/
53 lines
SysV-ppc64/
28 lines
SysV-s390x/
21 lines
SysV-x86_64/
66 lines
Architecture/
Arm/
65 lines
Disassembler/
llvm/
38 lines
DynamicLoader/
Darwin-Kernel/
194 lines
Hexagon-DYLD/
46 lines
16 lines
MacOSX-DYLD/
131 lines
66 lines
228 lines
POSIX-DYLD/
23 lines
42 lines
Static/
18 lines
ExpressionParser/
Clang/
9 lines
45 lines
86 lines
73 lines
8 lines
9 lines
38 lines
92 lines
Go/
3 lines
Instruction/
ARM/
907 lines
ARM64/
31 lines
MIPS/
19 lines
MIPS64/
11 lines
PPC64/
8 lines
InstrumentationRuntime/
MainThreadChecker/
7 lines
TSan/
5 lines
UBSan/
4 lines
Language/
CPlusPlus/
5 lines
25 lines
33 lines
14 lines
3 lines
19 lines
9 lines
4 lines
4 lines
ObjC/
6 lines
11 lines
11 lines
11 lines
25 lines
LanguageRuntime/
CPlusPlus/
ItaniumABI/
75 lines
ObjC/
AppleObjCRuntime/
3 lines
34 lines
10 lines
121 lines
161 lines
64 lines
10 lines
RenderScript/
RenderScriptRuntime/
36 lines
276 lines
80 lines
ObjectContainer/
BSD-Archive/
46 lines
Universal-Mach-O/
20 lines
ObjectFile/
ELF/
7 lines
365 lines
JIT/
13 lines
Mach-O/
721 lines
PECOFF/
12 lines
OperatingSystem/
Go/
4 lines
Python/
43 lines
Platform/
Android/
4 lines
19 lines
13 lines
FreeBSD/
29 lines
Linux/
31 lines
MacOSX/
16 lines
29 lines
29 lines
145 lines
92 lines
10 lines
6 lines
10 lines
57 lines
6 lines
37 lines
NetBSD/
28 lines
OpenBSD/
20 lines
POSIX/
38 lines
Windows/
54 lines
gdb-server/
18 lines
Process/
Darwin/
14 lines
56 lines
14 lines
153 lines
52 lines
69 lines
FreeBSD/
53 lines
26 lines
29 lines
8 lines
4 lines
33 lines
Linux/
213 lines
44 lines
21 lines
9 lines
13 lines
8 lines
57 lines
8 lines
8 lines
MacOSX-Kernel/
30 lines
48 lines
14 lines
NetBSD/
12 lines
13 lines
POSIX/
3 lines
Utility/
28 lines
6 lines
9 lines
18 lines
6 lines
331 lines
3 lines
6 lines
8 lines
8 lines
8 lines
8 lines
8 lines
4 lines
11 lines
3 lines
65 lines
154 lines
8 lines
Windows/
Common/
48 lines
120 lines
x64/
26 lines
x86/
26 lines
elf-core/
54 lines
2 lines
4 lines
4 lines
gdb-remote/
35 lines
182 lines
136 lines
32 lines
125 lines
50 lines
159 lines
524 lines
34 lines
mach-core/
143 lines
4 lines
minidump/
16 lines
7 lines
22 lines
ScriptInterpreter/
Python/
117 lines
29 lines
225 lines
StructuredData/
DarwinLog/
240 lines
SymbolFile/
DWARF/
569 lines
57 lines
7 lines
10 lines
62 lines
55 lines
128 lines
224 lines
4 lines
125 lines
99 lines
507 lines
122 lines
4 lines
PDB/
10 lines
118 lines
Symtab/
24 lines
SymbolVendor/
ELF/
14 lines
MacOSX/
48 lines
SystemRuntime/
MacOSX/
28 lines
23 lines
29 lines
28 lines
75 lines
UnwindAssembly/
InstEmulation/
62 lines
x86/
34 lines
131 lines
Symbol/
13 lines
3 lines
229 lines
12 lines
3 lines
113 lines
92 lines
33 lines
237 lines
50 lines
24 lines
25 lines
22 lines
83 lines
63 lines
59 lines
88 lines
11 lines
26 lines
123 lines
54 lines
42 lines
42 lines
12 lines
18 lines
25 lines
Target/
12 lines
16 lines
13 lines
36 lines
11 lines
7 lines
108 lines
851 lines
12 lines
30 lines
22 lines
17 lines
4 lines
157 lines
144 lines
13 lines
194 lines
245 lines
30 lines
232 lines
163 lines
43 lines
54 lines
4 lines
29 lines
4 lines
3 lines
3 lines
12 lines
85 lines
28 lines
63 lines
41 lines
115 lines
49 lines
37 lines
44 lines
11 lines
Utility/
79 lines
48 lines
28 lines
22 lines
78 lines
251 lines
88 lines
108 lines
6 lines
19 lines
43 lines
5 lines
4 lines
37 lines
27 lines
19 lines
13 lines
7 lines
4 lines
4 lines

Diff 144420

include/lldb/API/SBAddress.h

include/lldb/API/SBBroadcaster.h

include/lldb/API/SBCommandInterpreter.h

include/lldb/API/SBCommandReturnObject.h

include/lldb/API/SBData.h

include/lldb/API/SBExpressionOptions.h

include/lldb/API/SBFrame.h

include/lldb/API/SBInstruction.h

include/lldb/API/SBInstructionList.h

include/lldb/API/SBProcess.h

include/lldb/API/SBStream.h

include/lldb/API/SBSymbol.h

include/lldb/API/SBTarget.h

include/lldb/API/SBThreadPlan.h

include/lldb/API/SBType.h

include/lldb/API/SBValue.h

include/lldb/API/SBValueList.h

include/lldb/Breakpoint/Breakpoint.h

include/lldb/Breakpoint/BreakpointLocation.h

include/lldb/Breakpoint/BreakpointLocationCollection.h

include/lldb/Breakpoint/BreakpointLocationList.h

include/lldb/Breakpoint/BreakpointName.h

include/lldb/Breakpoint/BreakpointOptions.h

include/lldb/Breakpoint/BreakpointResolver.h

include/lldb/Breakpoint/BreakpointResolverAddress.h

include/lldb/Breakpoint/BreakpointResolverName.h

include/lldb/Breakpoint/BreakpointSite.h

include/lldb/Breakpoint/StoppointLocation.h

include/lldb/Breakpoint/Watchpoint.h

include/lldb/Breakpoint/WatchpointList.h

include/lldb/Breakpoint/WatchpointOptions.h

include/lldb/Core/Address.h

include/lldb/Core/AddressRange.h

include/lldb/Core/AddressResolverName.h

include/lldb/Core/Broadcaster.h

include/lldb/Core/Debugger.h

include/lldb/Core/Disassembler.h

include/lldb/Core/EmulateInstruction.h

include/lldb/Core/FormatEntity.h

include/lldb/Core/IOHandler.h

include/lldb/Core/MappedHash.h

include/lldb/Core/Module.h

include/lldb/Core/ModuleList.h

include/lldb/Core/ModuleSpec.h

include/lldb/Core/PluginManager.h

include/lldb/Core/RangeMap.h

include/lldb/Core/RegisterValue.h

include/lldb/Core/STLUtils.h

include/lldb/Core/Scalar.h

include/lldb/Core/SearchFilter.h

include/lldb/Core/Section.h

include/lldb/Core/SourceManager.h

include/lldb/Core/StreamBuffer.h

include/lldb/Core/UniqueCStringMap.h

include/lldb/Core/UserSettingsController.h

include/lldb/Core/Value.h

include/lldb/Core/ValueObject.h

include/lldb/Core/ValueObjectSyntheticFilter.h

include/lldb/DataFormatters/DataVisualization.h

include/lldb/DataFormatters/FormatClasses.h

include/lldb/DataFormatters/FormatManager.h

include/lldb/DataFormatters/FormattersContainer.h

include/lldb/DataFormatters/StringPrinter.h

include/lldb/DataFormatters/TypeFormat.h

include/lldb/DataFormatters/TypeSummary.h

include/lldb/DataFormatters/TypeSynthetic.h

include/lldb/DataFormatters/TypeValidator.h

include/lldb/DataFormatters/ValueObjectPrinter.h

include/lldb/Expression/DiagnosticManager.h

include/lldb/Expression/ExpressionSourceCode.h

include/lldb/Expression/ExpressionVariable.h

include/lldb/Expression/IRMemoryMap.h

include/lldb/Expression/LLVMUserExpression.h

include/lldb/Expression/REPL.h

include/lldb/Expression/UtilityFunction.h

include/lldb/Host/Debug.h

include/lldb/Host/Editline.h

include/lldb/Host/MainLoop.h

include/lldb/Host/MainLoopBase.h

include/lldb/Host/PosixApi.h

include/lldb/Host/Predicate.h

include/lldb/Host/Socket.h

include/lldb/Host/SocketAddress.h

include/lldb/Host/Symbols.h

include/lldb/Host/TaskPool.h

include/lldb/Host/XML.h

include/lldb/Host/common/GetOptInc.h

include/lldb/Host/common/NativeBreakpoint.h

include/lldb/Host/common/NativeProcessProtocol.h

include/lldb/Host/common/NativeRegisterContext.h

include/lldb/Host/linux/Ptrace.h

include/lldb/Host/posix/ConnectionFileDescriptorPosix.h

include/lldb/Interpreter/CommandAlias.h

include/lldb/Interpreter/CommandCompletions.h

include/lldb/Interpreter/CommandInterpreter.h

include/lldb/Interpreter/CommandObject.h

include/lldb/Interpreter/CommandObjectMultiword.h

include/lldb/Interpreter/CommandReturnObject.h

include/lldb/Interpreter/OptionGroupBoolean.h

include/lldb/Interpreter/OptionValue.h

include/lldb/Interpreter/OptionValueArray.h

include/lldb/Interpreter/OptionValueProperties.h

include/lldb/Interpreter/OptionValueUInt64.h

include/lldb/Interpreter/Options.h

include/lldb/Symbol/Block.h

include/lldb/Symbol/ClangASTContext.h

include/lldb/Symbol/ClangASTImporter.h

include/lldb/Symbol/ClangExternalASTSourceCallbacks.h

include/lldb/Symbol/ClangExternalASTSourceCommon.h

include/lldb/Symbol/CompactUnwindInfo.h

include/lldb/Symbol/CompilerDecl.h

include/lldb/Symbol/CompilerType.h

include/lldb/Symbol/DWARFCallFrameInfo.h

include/lldb/Symbol/DeclVendor.h

include/lldb/Symbol/FuncUnwinders.h

include/lldb/Symbol/GoASTContext.h

include/lldb/Symbol/ObjectFile.h

include/lldb/Symbol/Symbol.h

include/lldb/Symbol/SymbolFile.h

include/lldb/Symbol/SymbolVendor.h

include/lldb/Symbol/Type.h

include/lldb/Symbol/TypeSystem.h

include/lldb/Symbol/UnwindPlan.h

include/lldb/Symbol/UnwindTable.h

include/lldb/Symbol/Variable.h

include/lldb/Symbol/VariableList.h

include/lldb/Target/ABI.h

include/lldb/Target/DynamicLoader.h

include/lldb/Target/ExecutionContext.h

include/lldb/Target/Language.h

include/lldb/Target/LanguageRuntime.h

include/lldb/Target/Memory.h

include/lldb/Target/MemoryRegionInfo.h

include/lldb/Target/ObjCLanguageRuntime.h

include/lldb/Target/Platform.h

include/lldb/Target/Process.h

include/lldb/Target/ProcessInfo.h

include/lldb/Target/ProcessLaunchInfo.h

include/lldb/Target/Queue.h

include/lldb/Target/QueueItem.h

include/lldb/Target/QueueList.h

include/lldb/Target/RegisterCheckpoint.h

include/lldb/Target/RegisterContext.h

include/lldb/Target/RegisterNumber.h

include/lldb/Target/SectionLoadHistory.h

include/lldb/Target/SectionLoadList.h

include/lldb/Target/StackFrame.h

include/lldb/Target/StackID.h

include/lldb/Target/StopInfo.h

include/lldb/Target/Target.h

include/lldb/Target/Thread.h

include/lldb/Target/ThreadCollection.h

include/lldb/Target/ThreadList.h

include/lldb/Target/ThreadPlan.h

include/lldb/Target/ThreadPlanCallFunction.h

include/lldb/Target/ThreadPlanCallFunctionUsingABI.h

include/lldb/Target/ThreadPlanShouldStopHere.h

include/lldb/Target/ThreadPlanStepRange.h

include/lldb/Target/UnixSignals.h

include/lldb/Utility/ArchSpec.h

include/lldb/Utility/Args.h

include/lldb/Utility/Baton.h

include/lldb/Utility/ConstString.h

include/lldb/Utility/DataBufferHeap.h

include/lldb/Utility/History.h

include/lldb/Utility/JSON.h

include/lldb/Utility/Log.h

include/lldb/Utility/SafeMachO.h

include/lldb/Utility/SelectHelper.h

include/lldb/Utility/SharedCluster.h

include/lldb/Utility/SharingPtr.h

include/lldb/Utility/Stream.h

include/lldb/Utility/StreamTee.h

include/lldb/Utility/StringExtractor.h

include/lldb/Utility/StringLexer.h

include/lldb/Utility/StringList.h

include/lldb/Utility/Timeout.h

include/lldb/lldb-enumerations.h

include/lldb/lldb-private-enumerations.h

include/lldb/lldb-private-forward.h

include/lldb/lldb-private-types.h

include/lldb/lldb-versioning.h

source/API/SBAddress.cpp

source/API/SBBreakpointName.cpp

source/API/SBCommandInterpreter.cpp

source/API/SBDebugger.cpp

Context not available.
SBDebugger debugger; SBDebugger debugger;
// Currently we have issues if this function is called simultaneously on two // Currently we have issues if this function is called simultaneously on two
// different // different threads. The issues mainly revolve around the fact that the
// threads. The issues mainly revolve around the fact that the // lldb_private::FormatManager uses global collections and having two
// lldb_private::FormatManager // threads parsing the .lldbinit files can cause mayhem. So to get around
// uses global collections and having two threads parsing the .lldbinit files // this for now we need to use a mutex to prevent bad things from happening.
// can cause
// mayhem. So to get around this for now we need to use a mutex to prevent bad
// things
// from happening.
static std::recursive_mutex g_mutex; static std::recursive_mutex g_mutex;
std::lock_guard<std::recursive_mutex> guard(g_mutex); std::lock_guard<std::recursive_mutex> guard(g_mutex);
Context not available.
} }
void SBDebugger::MemoryPressureDetected() { void SBDebugger::MemoryPressureDetected() {
// Since this function can be call asynchronously, we allow it to be // Since this function can be call asynchronously, we allow it to be non-
// non-mandatory. We have seen deadlocks with this function when called // mandatory. We have seen deadlocks with this function when called so we
// so we need to safeguard against this until we can determine what is // need to safeguard against this until we can determine what is causing the
// causing the deadlocks. // deadlocks.
Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_API)); Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_API));
const bool mandatory = false; const bool mandatory = false;
Context not available.
m_opaque_sp->GetCommandInterpreter().SkipAppInitFiles(b); m_opaque_sp->GetCommandInterpreter().SkipAppInitFiles(b);
} }
// Shouldn't really be settable after initialization as this could cause lots of // Shouldn't really be settable after initialization as this could cause lots
// problems; don't want users // of problems; don't want users trying to switch modes in the middle of a
// trying to switch modes in the middle of a debugging session. // debugging session.
void SBDebugger::SetInputFileHandle(FILE *fh, bool transfer_ownership) { void SBDebugger::SetInputFileHandle(FILE *fh, bool transfer_ownership) {
Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_API)); Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_API));
Context not available.

source/API/SBEvent.cpp

source/API/SBFrame.cpp

source/API/SBInstruction.cpp

Context not available.
#include "lldb/Utility/DataExtractor.h" #include "lldb/Utility/DataExtractor.h"
//---------------------------------------------------------------------- //----------------------------------------------------------------------
// We recently fixed a leak in one of the Instruction subclasses where // We recently fixed a leak in one of the Instruction subclasses where the
// the instruction will only hold a weak reference to the disassembler // instruction will only hold a weak reference to the disassembler to avoid a
// to avoid a cycle that was keeping both objects alive (leak) and we // cycle that was keeping both objects alive (leak) and we need the
// need the InstructionImpl class to make sure our public API behaves // InstructionImpl class to make sure our public API behaves as users would
// as users would expect. Calls in our public API allow clients to do // expect. Calls in our public API allow clients to do things like:
// things like:
// //
// 1 lldb::SBInstruction inst; // 1 lldb::SBInstruction inst;
// 2 inst = target.ReadInstructions(pc, 1).GetInstructionAtIndex(0) // 2 inst = target.ReadInstructions(pc, 1).GetInstructionAtIndex(0)
Context not available.
// 4 ... // 4 ...
// //
// There was a temporary lldb::DisassemblerSP object created in the // There was a temporary lldb::DisassemblerSP object created in the
// SBInstructionList that was returned by lldb.target.ReadInstructions() // SBInstructionList that was returned by lldb.target.ReadInstructions() that
// that will go away after line 2 but the "inst" object should be able // will go away after line 2 but the "inst" object should be able to still
// to still answer questions about itself. So we make sure that any // answer questions about itself. So we make sure that any SBInstruction
// SBInstruction objects that are given out have a strong reference to // objects that are given out have a strong reference to the disassembler and
// the disassembler and the instruction so that the object can live and // the instruction so that the object can live and successfully respond to all
// successfully respond to all queries. // queries.
//---------------------------------------------------------------------- //----------------------------------------------------------------------
class InstructionImpl { class InstructionImpl {
public: public:
Context not available.

source/API/SBInstructionList.cpp

source/API/SBModule.cpp

source/API/SBModuleSpec.cpp

source/API/SBPlatform.cpp

source/API/SBProcess.cpp

source/API/SBQueueItem.cpp

source/API/SBStream.cpp

source/API/SBTarget.cpp

source/API/SBThread.cpp

source/API/SBThreadPlan.cpp

source/API/SBType.cpp

source/API/SBTypeCategory.cpp

source/API/SBValue.cpp

source/API/SystemInitializerFull.cpp

source/Breakpoint/Breakpoint.cpp

source/Breakpoint/BreakpointID.cpp

source/Breakpoint/BreakpointLocation.cpp

source/Breakpoint/BreakpointLocationList.cpp

source/Breakpoint/BreakpointOptions.cpp

source/Breakpoint/BreakpointResolver.cpp

source/Breakpoint/BreakpointResolverAddress.cpp

source/Breakpoint/BreakpointResolverFileLine.cpp

source/Breakpoint/BreakpointResolverName.cpp

source/Breakpoint/BreakpointSiteList.cpp

source/Breakpoint/Watchpoint.cpp

source/Breakpoint/WatchpointList.cpp

source/Breakpoint/WatchpointOptions.cpp

source/Commands/CommandCompletions.cpp

source/Commands/CommandObjectApropos.cpp

source/Commands/CommandObjectBreakpoint.cpp

source/Commands/CommandObjectBreakpointCommand.cpp

source/Commands/CommandObjectCommands.cpp

source/Commands/CommandObjectDisassemble.cpp

source/Commands/CommandObjectExpression.cpp

source/Commands/CommandObjectFrame.cpp

source/Commands/CommandObjectHelp.cpp

source/Commands/CommandObjectMemory.cpp

source/Commands/CommandObjectMultiword.cpp

source/Commands/CommandObjectPlatform.cpp

source/Commands/CommandObjectProcess.cpp

source/Commands/CommandObjectQuit.cpp

source/Commands/CommandObjectRegister.cpp

source/Commands/CommandObjectSettings.cpp

source/Commands/CommandObjectSource.cpp

source/Commands/CommandObjectTarget.cpp

source/Commands/CommandObjectThread.cpp

source/Commands/CommandObjectType.cpp

source/Commands/CommandObjectWatchpoint.cpp

source/Commands/CommandObjectWatchpointCommand.cpp

source/Core/Address.cpp

source/Core/AddressResolverName.cpp

source/Core/Broadcaster.cpp

source/Core/Communication.cpp

source/Core/Debugger.cpp

source/Core/Disassembler.cpp

source/Core/DumpDataExtractor.cpp

source/Core/DynamicLoader.cpp

source/Core/FileLineResolver.cpp

source/Core/FileSpecList.cpp

source/Core/FormatEntity.cpp

source/Core/IOHandler.cpp

source/Core/Listener.cpp

source/Core/Mangled.cpp

source/Core/Module.cpp

source/Core/ModuleList.cpp

source/Core/PluginManager.cpp

source/Core/RegisterValue.cpp

source/Core/Scalar.cpp

source/Core/SearchFilter.cpp

source/Core/Section.cpp

source/Core/SourceManager.cpp

source/Core/Value.cpp

source/Core/ValueObject.cpp

source/Core/ValueObjectCast.cpp

source/Core/ValueObjectChild.cpp

source/Core/ValueObjectDynamicValue.cpp

source/Core/ValueObjectList.cpp

source/Core/ValueObjectMemory.cpp

source/Core/ValueObjectSyntheticFilter.cpp

source/Core/ValueObjectVariable.cpp

source/DataFormatters/FormatManager.cpp

source/DataFormatters/StringPrinter.cpp

source/DataFormatters/TypeFormat.cpp

source/DataFormatters/ValueObjectPrinter.cpp

source/DataFormatters/VectorType.cpp

source/Expression/DWARFExpression.cpp

source/Expression/DiagnosticManager.cpp

source/Expression/ExpressionSourceCode.cpp

source/Expression/ExpressionVariable.cpp

source/Expression/FunctionCaller.cpp

source/Expression/IRExecutionUnit.cpp

source/Expression/IRInterpreter.cpp

source/Expression/IRMemoryMap.cpp

source/Expression/LLVMUserExpression.cpp

source/Expression/Materializer.cpp

source/Expression/REPL.cpp

source/Expression/UserExpression.cpp

source/Host/android/HostInfoAndroid.cpp

source/Host/common/Editline.cpp

source/Host/common/File.cpp

source/Host/common/Host.cpp

source/Host/common/HostInfoBase.cpp

source/Host/common/MainLoop.cpp

Context not available.
#ifdef __ANDROID__ #ifdef __ANDROID__
Status MainLoop::RunImpl::Poll() { Status MainLoop::RunImpl::Poll() {
// ppoll(2) is not supported on older all android versions. Also, older // ppoll(2) is not supported on older all android versions. Also, older
// versions android (API <= 19) implemented pselect in a non-atomic way, as a // versions android (API <= 19) implemented pselect in a non-atomic way, as
JDevlieghereUnsubmitted
Not Done
ReplyInline Actions

Is this intentional or maybe an off-by-one error? The a is in the 79th colum, which is okay for clang-format.

JDevlieghere: Is this intentional or maybe an off-by-one error? The `a` is in the 79th colum, which is okay…
aprantlAuthorUnsubmitted
Not Done
ReplyInline Actions

My script sets the threshold to 78 columns. When you are on an 80-column terminal and your editor doesn't indicate whether long lines continue or not then not using the last two characters makes it unambiguous whether the a is the beginning of a new word or whether it stands for itself.
I'll change the threshold to 80 columns to avoid reflowing paragraphs that don't need it.

aprantl: My script sets the threshold to 78 columns. When you are on an 80-column terminal and your…
// combination of pthread_sigmask and select. This is not sufficient for us, // a combination of pthread_sigmask and select. This is not sufficient for
// as we rely on the atomicity to correctly implement signal polling, so we // us, as we rely on the atomicity to correctly implement signal polling, so
// call the underlying syscall ourselves. // we call the underlying syscall ourselves.
FD_ZERO(&read_fd_set); FD_ZERO(&read_fd_set);
int nfds = 0; int nfds = 0;
Context not available.
void MainLoop::RunImpl::ProcessEvents() { void MainLoop::RunImpl::ProcessEvents() {
#ifdef __ANDROID__ #ifdef __ANDROID__
// Collect first all readable file descriptors into a separate vector and then // Collect first all readable file descriptors into a separate vector and
// iterate over it to invoke callbacks. Iterating directly over // then iterate over it to invoke callbacks. Iterating directly over
// loop.m_read_fds is not possible because the callbacks can modify the // loop.m_read_fds is not possible because the callbacks can modify the
// container which could invalidate the iterator. // container which could invalidate the iterator.
std::vector<IOObject::WaitableHandle> fds; std::vector<IOObject::WaitableHandle> fds;
Context not available.
} }
// We shall block the signal, then install the signal handler. The signal will // We shall block the signal, then install the signal handler. The signal will
// be unblocked in // be unblocked in the Run() function to check for signal delivery.
// the Run() function to check for signal delivery.
MainLoop::SignalHandleUP MainLoop::SignalHandleUP
MainLoop::RegisterSignal(int signo, const Callback &callback, Status &error) { MainLoop::RegisterSignal(int signo, const Callback &callback, Status &error) {
#ifdef SIGNAL_POLLING_UNSUPPORTED #ifdef SIGNAL_POLLING_UNSUPPORTED
Context not available.
assert(ret == 0); assert(ret == 0);
#endif #endif
// If we're using kqueue, the signal needs to be unblocked in order to recieve // If we're using kqueue, the signal needs to be unblocked in order to
// it. If using pselect/ppoll, we need to block it, and later unblock it as a // recieve it. If using pselect/ppoll, we need to block it, and later
// part of the system call. // unblock it as a part of the system call.
ret = pthread_sigmask(HAVE_SYS_EVENT_H ? SIG_UNBLOCK : SIG_BLOCK, ret = pthread_sigmask(HAVE_SYS_EVENT_H ? SIG_UNBLOCK : SIG_BLOCK,
&new_action.sa_mask, &old_set); &new_action.sa_mask, &old_set);
assert(ret == 0 && "pthread_sigmask failed"); assert(ret == 0 && "pthread_sigmask failed");
Context not available.

source/Host/common/NativeBreakpointList.cpp

source/Host/common/NativeProcessProtocol.cpp

source/Host/common/NativeRegisterContext.cpp

source/Host/common/PseudoTerminal.cpp

source/Host/common/Socket.cpp

source/Host/common/SoftwareBreakpoint.cpp

source/Host/common/Symbols.cpp

source/Host/common/TaskPool.cpp

source/Host/common/Terminal.cpp

source/Host/common/UDPSocket.cpp

source/Host/common/XML.cpp

source/Host/freebsd/Host.cpp

source/Host/linux/Host.cpp

source/Host/linux/HostInfoLinux.cpp

source/Host/macosx/Symbols.cpp

source/Host/macosx/cfcpp/CFCMutableDictionary.cpp

source/Host/macosx/cfcpp/CFCString.cpp

source/Host/netbsd/Host.cpp

source/Host/posix/ConnectionFileDescriptorPosix.cpp

source/Host/posix/HostInfoPosix.cpp

source/Host/posix/HostProcessPosix.cpp

source/Host/posix/PipePosix.cpp

source/Host/posix/ProcessLauncherPosixFork.cpp

source/Host/windows/ConnectionGenericFileWindows.cpp

source/Host/windows/EditLineWin.cpp

source/Host/windows/Host.cpp

source/Host/windows/HostInfoWindows.cpp

source/Host/windows/HostProcessWindows.cpp

source/Host/windows/PipeWindows.cpp

source/Interpreter/CommandAlias.cpp

source/Interpreter/CommandInterpreter.cpp

source/Interpreter/CommandObject.cpp

source/Interpreter/CommandObjectRegexCommand.cpp

source/Interpreter/CommandObjectScript.cpp

source/Interpreter/CommandReturnObject.cpp

source/Interpreter/OptionArgParser.cpp

source/Interpreter/OptionGroupBoolean.cpp

source/Interpreter/OptionGroupFormat.cpp

source/Interpreter/OptionGroupValueObjectDisplay.cpp

source/Interpreter/OptionGroupVariable.cpp

source/Interpreter/OptionValue.cpp

source/Interpreter/OptionValueDictionary.cpp

source/Interpreter/OptionValueFileSpec.cpp

source/Interpreter/OptionValueFormatEntity.cpp

source/Interpreter/OptionValuePathMappings.cpp

source/Interpreter/OptionValueProperties.cpp

source/Interpreter/OptionValueSInt64.cpp

source/Interpreter/Options.cpp

source/Interpreter/Property.cpp

source/Plugins/ABI/MacOSX-arm/ABIMacOSX_arm.cpp

source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp

source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp

source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp

source/Plugins/ABI/SysV-arm64/ABISysV_arm64.cpp

source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp

source/Plugins/ABI/SysV-i386/ABISysV_i386.cpp

source/Plugins/ABI/SysV-mips/ABISysV_mips.cpp

source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp

source/Plugins/ABI/SysV-ppc/ABISysV_ppc.cpp

source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.cpp

source/Plugins/ABI/SysV-s390x/ABISysV_s390x.cpp

source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp

source/Plugins/Architecture/Arm/ArchitectureArm.cpp

source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp

source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp

source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp

source/Plugins/DynamicLoader/Hexagon-DYLD/HexagonDYLDRendezvous.cpp

source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp

source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp

source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp

source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp

source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp

source/Plugins/DynamicLoader/Static/DynamicLoaderStatic.cpp

source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp

source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp

source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp

source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp

source/Plugins/ExpressionParser/Clang/ClangFunctionCaller.cpp

source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp

source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp

source/Plugins/ExpressionParser/Clang/IRForTarget.cpp

source/Plugins/ExpressionParser/Go/GoUserExpression.cpp

source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp

source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp

source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp

source/Plugins/Instruction/PPC64/EmulateInstructionPPC64.cpp

source/Plugins/InstrumentationRuntime/MainThreadChecker/MainThreadCheckerRuntime.cpp

source/Plugins/InstrumentationRuntime/TSan/TSanRuntime.cpp

source/Plugins/InstrumentationRuntime/UBSan/UBSanRuntime.cpp

source/Plugins/Language/CPlusPlus/BlockPointer.cpp

source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp

source/Plugins/Language/CPlusPlus/CPlusPlusNameParser.cpp

source/Plugins/Language/CPlusPlus/LibCxx.cpp

source/Plugins/Language/CPlusPlus/LibCxxInitializerList.cpp

source/Plugins/Language/CPlusPlus/LibCxxList.cpp

source/Plugins/Language/CPlusPlus/LibCxxMap.cpp

source/Plugins/Language/CPlusPlus/LibCxxVector.cpp

source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp

source/Plugins/Language/ObjC/Cocoa.cpp

source/Plugins/Language/ObjC/NSError.cpp

source/Plugins/Language/ObjC/NSException.cpp

source/Plugins/Language/ObjC/NSString.cpp

source/Plugins/Language/ObjC/ObjCLanguage.cpp

source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp

source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCClassDescriptorV2.cpp

source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp

source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp

source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp

source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTypeEncodingParser.cpp

source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp

source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptExpressionOpts.cpp

source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp

source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp

source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp

source/Plugins/ObjectContainer/Universal-Mach-O/ObjectContainerUniversalMachO.cpp

source/Plugins/ObjectFile/ELF/ELFHeader.cpp

source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp

source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp

source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp

source/Plugins/Platform/Android/AdbClient.cpp

source/Plugins/Platform/Android/PlatformAndroid.cpp

source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp

source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp

source/Plugins/Platform/Linux/PlatformLinux.cpp

source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp

source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp

source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp

source/Plugins/Platform/MacOSX/PlatformDarwin.cpp

source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp

source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp

source/Plugins/Platform/MacOSX/PlatformRemoteAppleTV.cpp

source/Plugins/Platform/MacOSX/PlatformRemoteAppleWatch.cpp

source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp

source/Plugins/Platform/MacOSX/PlatformRemoteiOS.cpp

source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp

source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp

source/Plugins/Platform/OpenBSD/PlatformOpenBSD.cpp

source/Plugins/Platform/POSIX/PlatformPOSIX.cpp

source/Plugins/Platform/Windows/PlatformWindows.cpp

source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp

source/Plugins/Process/Darwin/CFString.cpp

source/Plugins/Process/Darwin/DarwinProcessLauncher.cpp

source/Plugins/Process/Darwin/MachException.cpp

source/Plugins/Process/Darwin/NativeProcessDarwin.cpp

source/Plugins/Process/Darwin/NativeThreadDarwin.cpp

source/Plugins/Process/Darwin/NativeThreadListDarwin.cpp

source/Plugins/Process/FreeBSD/FreeBSDThread.cpp

source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp

source/Plugins/Process/FreeBSD/ProcessMonitor.cpp

source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.cpp

source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_powerpc.cpp

source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_x86.cpp

source/Plugins/Process/Linux/NativeProcessLinux.cpp

source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp

source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp

source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp

source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp

source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.cpp

source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp

source/Plugins/Process/Linux/NativeThreadLinux.cpp

source/Plugins/Process/Linux/SingleStepCheck.cpp

source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp

source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp

source/Plugins/Process/MacOSX-Kernel/ThreadKDP.cpp

source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp

source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp

source/Plugins/Process/POSIX/CrashReason.cpp

source/Plugins/Process/Utility/DynamicRegisterInfo.cpp

source/Plugins/Process/Utility/RegisterContextDarwin_arm.cpp

source/Plugins/Process/Utility/RegisterContextDarwin_arm64.cpp

source/Plugins/Process/Utility/RegisterContextDarwin_i386.cpp

source/Plugins/Process/Utility/RegisterContextDarwin_x86_64.cpp

source/Plugins/Process/Utility/RegisterContextLLDB.cpp

source/Plugins/Process/Utility/RegisterContextLinux_s390x.cpp

source/Plugins/Process/Utility/RegisterContextMemory.cpp

source/Plugins/Process/Utility/RegisterContextPOSIX_arm.cpp

source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.cpp

source/Plugins/Process/Utility/RegisterContextPOSIX_mips64.cpp

source/Plugins/Process/Utility/RegisterContextPOSIX_powerpc.cpp

source/Plugins/Process/Utility/RegisterContextPOSIX_ppc64le.cpp

source/Plugins/Process/Utility/RegisterContextPOSIX_s390x.cpp

source/Plugins/Process/Utility/RegisterContextPOSIX_x86.cpp

source/Plugins/Process/Utility/RegisterInfoPOSIX_arm64.cpp

source/Plugins/Process/Utility/StopInfoMachException.cpp

source/Plugins/Process/Utility/UnwindLLDB.cpp

source/Plugins/Process/Utility/UnwindMacOSXFrameBackchain.cpp

source/Plugins/Process/Windows/Common/DebuggerThread.cpp

source/Plugins/Process/Windows/Common/ProcessWindows.cpp

source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.cpp

source/Plugins/Process/Windows/Common/x86/RegisterContextWindows_x86.cpp

source/Plugins/Process/elf-core/ProcessElfCore.cpp

source/Plugins/Process/elf-core/RegisterContextPOSIXCore_mips64.cpp

source/Plugins/Process/elf-core/RegisterContextPOSIXCore_x86_64.cpp

source/Plugins/Process/elf-core/ThreadElfCore.cpp

source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp

source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp

source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp

source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp

source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp

source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp

source/Plugins/Process/mach-core/ProcessMachCore.cpp

source/Plugins/Process/mach-core/ThreadMachCore.cpp

source/Plugins/Process/minidump/MinidumpParser.cpp

source/Plugins/Process/minidump/MinidumpTypes.cpp

source/Plugins/Process/minidump/ProcessMinidump.cpp

source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp

source/Plugins/ScriptInterpreter/Python/PythonExceptionState.cpp

source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp

source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp

source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp

source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.cpp

source/Plugins/SymbolFile/DWARF/DWARFDebugArangeSet.cpp

source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp

source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp

source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp

source/Plugins/SymbolFile/DWARF/DWARFDeclContext.cpp

source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp

source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp

source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp

source/Plugins/SymbolFile/DWARF/UniqueDWARFASTType.cpp

source/Plugins/SymbolFile/PDB/PDBASTParser.cpp

source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp

source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.cpp

source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp

source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp

source/Plugins/SystemRuntime/MacOSX/AppleGetItemInfoHandler.cpp

source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.cpp

source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.cpp

source/Plugins/SystemRuntime/MacOSX/AppleGetThreadItemInfoHandler.cpp

source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.cpp

source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp

source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp

source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.cpp

source/Symbol/ArmUnwindInfo.cpp

source/Symbol/Block.cpp

source/Symbol/ClangASTContext.cpp

source/Symbol/ClangASTImporter.cpp

source/Symbol/ClangExternalASTSourceCallbacks.cpp

source/Symbol/CompactUnwindInfo.cpp

source/Symbol/CompileUnit.cpp

source/Symbol/CompilerType.cpp

source/Symbol/DWARFCallFrameInfo.cpp

source/Symbol/FuncUnwinders.cpp

source/Symbol/Function.cpp

source/Symbol/GoASTContext.cpp

source/Symbol/LineEntry.cpp

source/Symbol/LineTable.cpp

source/Symbol/ObjectFile.cpp

source/Symbol/Symbol.cpp

source/Symbol/SymbolContext.cpp

source/Symbol/SymbolFile.cpp

source/Symbol/SymbolVendor.cpp

source/Symbol/Symtab.cpp

source/Symbol/Type.cpp

source/Symbol/TypeList.cpp

source/Symbol/TypeMap.cpp

source/Symbol/UnwindPlan.cpp

source/Symbol/UnwindTable.cpp

source/Symbol/Variable.cpp

source/Target/ABI.cpp

source/Target/ExecutionContext.cpp

source/Target/LanguageRuntime.cpp

source/Target/Memory.cpp

source/Target/ModuleCache.cpp

source/Target/ObjCLanguageRuntime.cpp

source/Target/Platform.cpp

source/Target/Process.cpp

source/Target/ProcessInfo.cpp

source/Target/ProcessLaunchInfo.cpp

source/Target/RegisterContext.cpp

source/Target/SectionLoadHistory.cpp

source/Target/SectionLoadList.cpp

source/Target/StackFrame.cpp

source/Target/StackFrameList.cpp

source/Target/StackID.cpp

source/Target/StopInfo.cpp

source/Target/Target.cpp

source/Target/TargetList.cpp

source/Target/Thread.cpp

source/Target/ThreadList.cpp

source/Target/ThreadPlanBase.cpp

source/Target/ThreadPlanCallFunction.cpp

source/Target/ThreadPlanCallFunctionUsingABI.cpp

source/Target/ThreadPlanCallOnFunctionExit.cpp

source/Target/ThreadPlanCallUserExpression.cpp

source/Target/ThreadPlanPython.cpp

source/Target/ThreadPlanRunToAddress.cpp

source/Target/ThreadPlanShouldStopHere.cpp

source/Target/ThreadPlanStepInRange.cpp

source/Target/ThreadPlanStepInstruction.cpp

source/Target/ThreadPlanStepOut.cpp

source/Target/ThreadPlanStepOverBreakpoint.cpp

source/Target/ThreadPlanStepOverRange.cpp

source/Target/ThreadPlanStepRange.cpp

source/Target/ThreadPlanStepThrough.cpp

source/Target/ThreadPlanStepUntil.cpp

source/Target/UnixSignals.cpp

source/Utility/ArchSpec.cpp

source/Utility/Args.cpp

source/Utility/ConstString.cpp

source/Utility/DataBufferHeap.cpp

source/Utility/DataEncoder.cpp

source/Utility/DataExtractor.cpp

source/Utility/FastDemangle.cpp

source/Utility/FileSpec.cpp

source/Utility/JSON.cpp

source/Utility/Log.cpp

source/Utility/RegularExpression.cpp

source/Utility/SelectHelper.cpp

source/Utility/SharingPtr.cpp

source/Utility/Status.cpp

source/Utility/Stream.cpp

source/Utility/StringExtractor.cpp

source/Utility/StringExtractorGDBRemote.cpp

source/Utility/StructuredData.cpp

source/Utility/UUID.cpp

source/Utility/VASprintf.cpp