This is an archive of the discontinued LLVM Phabricator instance.

Differential D46144

Reflow paragraphs in comments.
ClosedPublic

Authored by aprantl on Apr 26 2018, 2:30 PM.

Details

Reviewers
clayborg
jingham
jasonmolenda
labath
javed.absar
• espindola
JDevlieghere
Commits
rG05097246f352: Reflow paragraphs in comments.
rLLDB331197: Reflow paragraphs in comments.
rL331197: Reflow paragraphs in comments.
Summary

This is intended as a clean up after the big clang-format commit (r280751), which unfortunately resulted in many of the comment paragraphs in LLDB being very hard to read.

FYI the script I used was:

import textwrap
import commands
import os
import sys
import re
tmp = "%s.tmp"%sys.argv[1]
out = open(tmp, "w+")
with open(sys.argv[1], "r") as f:
  header = ""
  text = ""
  for line in f:
      comment = re.compile(r'^( *//) ([^ ].*)$')
      match = comment.match(line)
      if match:
          # skip intentionally short comments.
          if not text and len(match.group(2)) < 40:
              out.write(line)
              continue

          if text:
              text += " " + match.group(2)
          else:
              header = match.group(1)
              text = match.group(2)
          
          continue
      else:
          if text:
              filled = textwrap.wrap(text, width=(73-len(header)),
                                     break_long_words=False)
              for l in filled:
                  out.write(header+" "+l+'\n')
              text = ""

      out.write(line)

os.rename(tmp, sys.argv[1])
#find source -name '*.cpp' -exec python join-comments.py \{} \;

Diff Detail

Event Timeline

aprantl created this revision.Apr 26 2018, 2:30 PM
Herald added a reviewer: javed.absar. · View Herald TranscriptApr 26 2018, 2:30 PM
Herald added a reviewer: • espindola. · View Herald Transcript
Herald added subscribers: mgrang, JDevlieghere, kbarton and 5 others. · View Herald Transcript
labath added a comment.Apr 27 2018, 1:52 AM

The formatting of the comments has been bugging me as well. So far, I have been trying to reflow them whenever I touch the code around them, but at that rate fixing all of them would take ages.

Your heuristics seem to be working fairly well. I've found a couple of sub-optimal decisions in the few files I opened, but I am not sure if it's feasible to fix the algorithm to account for them.

So overall, this seems like a good idea to me, and the few places where it gets this wrong can be fixed up afterwards (it decreases the total number of badly formatted comments).

PS: I don't see any header files in the list. Is there a particular reason for skipping them?

source/API/SBDebugger.cpp
73

Folding TODO: Here is sub-optimal.

source/API/SBInstruction.cpp
37–38

This doesn't look right.

arichardson removed a subscriber: arichardson.Apr 27 2018, 1:53 AM
aprantl updated this revision to Diff 144420.Apr 27 2018, 4:46 PM

Updated the script based on Pavel's feedback:

import textwrap
import commands
import os
import sys
import re
tmp = "%s.tmp"%sys.argv[1]
out = open(tmp, "w+")
with open(sys.argv[1], "r") as f:
  header = ""
  text = ""
  comment = re.compile(r'^( *//) ([^ ].*)$')
  special = re.compile(r'^(([A-Z]+[: ])|([0-9]+ )).*$')
  for line in f:
      match = comment.match(line)
      if match and not special.match(match.group(2)):
          # skip intentionally short comments.
          if not text and len(match.group(2)) < 40:
              out.write(line)
              continue

          if text:
              text += " " + match.group(2)
          else:
              header = match.group(1)
              text = match.group(2)
          
          continue

      if text:
          filled = textwrap.wrap(text, width=(77-len(header)),
                                 break_long_words=False)
          for l in filled:
              out.write(header+" "+l+'\n')
              text = ""

      out.write(line)

os.rename(tmp, sys.argv[1])
#find source -name '*.cpp' -exec python join-comments.py \{} \;
labath accepted this revision.Apr 30 2018, 6:06 AM

Looks fine to me, I guess if noone objects, we can land this. Thanks for doing this.

This revision is now accepted and ready to land.Apr 30 2018, 6:06 AM
clayborg accepted this revision.Apr 30 2018, 8:11 AM
JDevlieghere accepted this revision.Apr 30 2018, 8:25 AM

👍

source/Host/common/MainLoop.cpp
158

Is this intentional or maybe an off-by-one error? The a is in the 79th colum, which is okay for clang-format.

aprantl added inline comments.Apr 30 2018, 9:00 AM
source/Host/common/MainLoop.cpp
158

My script sets the threshold to 78 columns. When you are on an 80-column terminal and your editor doesn't indicate whether long lines continue or not then not using the last two characters makes it unambiguous whether the a is the beginning of a new word or whether it stands for itself.
I'll change the threshold to 80 columns to avoid reflowing paragraphs that don't need it.

Closed by commit rL331197: Reflow paragraphs in comments. (authored by adrian). · Explain WhyApr 30 2018, 9:54 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptApr 30 2018, 9:54 AM

Large Diff

This large diff affects 479 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
source/
API/
14 lines
4 lines
32 lines
3 lines
12 lines
3 lines
29 lines
4 lines
12 lines
6 lines
12 lines
4 lines
5 lines
28 lines
28 lines
17 lines
9 lines
4 lines
22 lines
63 lines
27 lines
Breakpoint/
133 lines
12 lines
10 lines
60 lines
23 lines
36 lines
30 lines
15 lines
54 lines
12 lines
4 lines
30 lines
36 lines
4 lines
5 lines
Commands/
31 lines
8 lines
122 lines
37 lines
52 lines
17 lines
55 lines
35 lines
30 lines
3 lines
35 lines
18 lines
21 lines
87 lines
10 lines
42 lines
14 lines
128 lines
116 lines
103 lines
33 lines
54 lines
45 lines
Core/
83 lines
5 lines
8 lines
10 lines
33 lines
110 lines
111 lines
8 lines
19 lines
21 lines
112 lines
182 lines
19 lines
66 lines
246 lines
53 lines
44 lines
40 lines
52 lines
16 lines
16 lines
84 lines
20 lines
265 lines
6 lines
4 lines
4 lines
45 lines
4 lines
31 lines
3 lines
11 lines
69 lines
DataFormatters/
19 lines
47 lines
16 lines
69 lines
7 lines
Expression/
398 lines
5 lines
12 lines
6 lines
32 lines
5 lines
31 lines
15 lines
62 lines
5 lines
25 lines
46 lines
21 lines
4 lines
Host/
android/
10 lines
3 lines
common/
172 lines
12 lines
21 lines
30 lines
35 lines
7 lines
85 lines
24 lines
96 lines
28 lines
3 lines
14 lines
32 lines
8 lines
10 lines
18 lines
3 lines
8 lines
4 lines
freebsd/
8 lines
linux/
17 lines
22 lines
macosx/
43 lines
cfcpp/
52 lines
22 lines
netbsd/
11 lines
posix/
72 lines
4 lines
21 lines
7 lines
10 lines
39 lines
windows/
76 lines
11 lines
4 lines
27 lines
9 lines
6 lines
31 lines
7 lines
Initialization/
10 lines
Interpreter/
13 lines
322 lines
81 lines
6 lines
11 lines
8 lines
4 lines
4 lines
31 lines
3 lines
8 lines
7 lines
8 lines
17 lines
12 lines
8 lines
31 lines
4 lines
251 lines
80 lines
Plugins/
ABI/
MacOSX-arm/
46 lines
MacOSX-arm64/
46 lines
MacOSX-i386/
32 lines
SysV-arm/
28 lines
SysV-arm64/
51 lines
SysV-hexagon/
14 lines
SysV-i386/
55 lines
SysV-mips/
11 lines
SysV-mips64/
73 lines
SysV-ppc/
85 lines
SysV-ppc64/
26 lines
SysV-s390x/
42 lines
SysV-x86_64/
102 lines
Architecture/
Arm/
65 lines
Disassembler/
llvm/
54 lines
DynamicLoader/
Darwin-Kernel/
286 lines
Hexagon-DYLD/
48 lines
28 lines
MacOSX-DYLD/
137 lines
76 lines
271 lines
POSIX-DYLD/
48 lines
42 lines
Static/
20 lines
Windows-DYLD/
6 lines
ExpressionParser/
Clang/
11 lines
103 lines
100 lines
105 lines
28 lines
19 lines
42 lines
141 lines
Go/
5 lines
Instruction/
ARM/
1423 lines
ARM64/
36 lines
MIPS/
27 lines
MIPS64/
11 lines
PPC64/
14 lines
InstrumentationRuntime/
MainThreadChecker/
3 lines
TSan/
13 lines
UBSan/
3 lines
Language/
CPlusPlus/
5 lines
60 lines
26 lines
19 lines
5 lines
26 lines
9 lines
6 lines
4 lines
ObjC/
8 lines
3 lines
15 lines
15 lines
14 lines
23 lines
LanguageRuntime/
CPlusPlus/
ItaniumABI/
99 lines
Go/
6 lines
ObjC/
AppleObjCRuntime/
5 lines
55 lines
23 lines
165 lines
205 lines
79 lines
25 lines
RenderScript/
RenderScriptRuntime/
43 lines
447 lines
88 lines
MemoryHistory/
asan/
4 lines
ObjectContainer/
BSD-Archive/
29 lines
Universal-Mach-O/
30 lines
ObjectFile/
ELF/
9 lines
457 lines
JIT/
17 lines
Mach-O/
913 lines
PECOFF/
32 lines
4 lines
OperatingSystem/
Go/
6 lines
Python/
95 lines
Platform/
Android/
8 lines
22 lines
15 lines
FreeBSD/
35 lines
Linux/
55 lines
MacOSX/
14 lines
42 lines
41 lines
171 lines
104 lines
16 lines
6 lines
10 lines
80 lines
6 lines
50 lines
NetBSD/
49 lines
OpenBSD/
24 lines
POSIX/
74 lines
Windows/
59 lines
gdb-server/
40 lines
Process/
Darwin/
22 lines
44 lines
38 lines
124 lines
47 lines
55 lines
FreeBSD/
66 lines
50 lines
68 lines
10 lines
12 lines
59 lines
Linux/
355 lines
66 lines
29 lines
13 lines
16 lines
15 lines
97 lines
21 lines
30 lines
MacOSX-Kernel/
42 lines
60 lines
25 lines
NetBSD/
41 lines
49 lines
POSIX/
5 lines
Utility/
58 lines
7 lines
17 lines
11 lines
20 lines
8 lines
3 lines
483 lines
3 lines
3 lines
3 lines
3 lines
23 lines
6 lines
3 lines
14 lines
14 lines
14 lines
14 lines
14 lines
8 lines
20 lines
3 lines
3 lines
3 lines
74 lines
195 lines
Windows/
Common/
74 lines
157 lines
8 lines
x64/
27 lines
x86/
27 lines
elf-core/
49 lines
4 lines
8 lines
gdb-remote/
53 lines
207 lines
166 lines
32 lines
189 lines
34 lines
172 lines
678 lines
40 lines
mach-core/
140 lines
16 lines
minidump/
60 lines
5 lines
8 lines
ScriptInterpreter/
Python/
92 lines
20 lines
293 lines
StructuredData/
DarwinLog/
187 lines
SymbolFile/
DWARF/
677 lines
61 lines
7 lines
3 lines
4 lines
10 lines
67 lines
58 lines
96 lines
186 lines
3 lines
5 lines
4 lines
4 lines
8 lines
111 lines
97 lines
611 lines
163 lines
3 lines
4 lines
PDB/
28 lines
191 lines
Symtab/
24 lines
SymbolVendor/
ELF/
18 lines
MacOSX/
56 lines
SystemRuntime/
MacOSX/
41 lines
36 lines
47 lines
41 lines
100 lines
UnwindAssembly/
InstEmulation/
79 lines
x86/
40 lines
165 lines
Symbol/
33 lines
7 lines
383 lines
18 lines
23 lines
4 lines
140 lines
79 lines
42 lines
301 lines
60 lines
21 lines
35 lines
4 lines
16 lines
113 lines
74 lines
71 lines
58 lines
9 lines
20 lines
177 lines
62 lines
46 lines
46 lines
6 lines
16 lines
25 lines
18 lines
Target/
27 lines
20 lines
4 lines
13 lines
51 lines
11 lines
9 lines
7 lines
123 lines
1032 lines
49 lines
36 lines
28 lines
21 lines
189 lines
192 lines
17 lines
274 lines
4 lines
298 lines
53 lines
285 lines
180 lines
51 lines
63 lines
4 lines
23 lines
4 lines
25 lines
15 lines
112 lines
26 lines
85 lines
57 lines
148 lines
86 lines
47 lines
58 lines
13 lines
Utility/
95 lines
75 lines
31 lines
20 lines
8 lines
74 lines
260 lines
115 lines
104 lines
10 lines
12 lines
41 lines
18 lines
12 lines
27 lines
28 lines
21 lines
17 lines
7 lines
8 lines
4 lines
4 lines

Diff 144194

source/API/SBAddress.cpp

source/API/SBCommandInterpreter.cpp

source/API/SBDebugger.cpp

Context not available.
typedef bool (*LLDBCommandPluginInit)(lldb::SBDebugger & debugger); typedef bool (*LLDBCommandPluginInit)(lldb::SBDebugger & debugger);
lldb::SBDebugger debugger_sb(debugger_sp); lldb::SBDebugger debugger_sb(debugger_sp);
// This calls the bool lldb::PluginInitialize(lldb::SBDebugger debugger) // This calls the bool lldb::PluginInitialize(lldb::SBDebugger
// function. // debugger) function. TODO: mangle this differently for your system -
labathUnsubmitted
Not Done
ReplyInline Actions

Folding TODO: Here is sub-optimal.

labath: Folding TODO: Here is sub-optimal.
// TODO: mangle this differently for your system - on OSX, the first // on OSX, the first underscore needs to be removed and the second one
// underscore needs to be removed and the second one stays // stays
LLDBCommandPluginInit init_func = LLDBCommandPluginInit init_func =
(LLDBCommandPluginInit)(uintptr_t)dynlib.getAddressOfSymbol( (LLDBCommandPluginInit)(uintptr_t)dynlib.getAddressOfSymbol(
"_ZN4lldb16PluginInitializeENS_10SBDebuggerE"); "_ZN4lldb16PluginInitializeENS_10SBDebuggerE");
Context not available.
SBDebugger debugger; SBDebugger debugger;
// Currently we have issues if this function is called simultaneously on two // Currently we have issues if this function is called simultaneously on
// different // two different threads. The issues mainly revolve around the fact that
// threads. The issues mainly revolve around the fact that the // the lldb_private::FormatManager uses global collections and having
// lldb_private::FormatManager // two threads parsing the .lldbinit files can cause mayhem. So to get
// uses global collections and having two threads parsing the .lldbinit files // around this for now we need to use a mutex to prevent bad things from
// can cause // happening.
// mayhem. So to get around this for now we need to use a mutex to prevent bad
// things
// from happening.
static std::recursive_mutex g_mutex; static std::recursive_mutex g_mutex;
std::lock_guard<std::recursive_mutex> guard(g_mutex); std::lock_guard<std::recursive_mutex> guard(g_mutex);
Context not available.
m_opaque_sp->GetCommandInterpreter().SkipAppInitFiles(b); m_opaque_sp->GetCommandInterpreter().SkipAppInitFiles(b);
} }
// Shouldn't really be settable after initialization as this could cause lots of // Shouldn't really be settable after initialization as this could cause
// problems; don't want users // lots of problems; don't want users trying to switch modes in the middle
// trying to switch modes in the middle of a debugging session. // of a debugging session.
void SBDebugger::SetInputFileHandle(FILE *fh, bool transfer_ownership) { void SBDebugger::SetInputFileHandle(FILE *fh, bool transfer_ownership) {
Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_API)); Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_API));
Context not available.
} }
++idx; ++idx;
} }
// +1 for the host platform, which should always appear first in the list. // +1 for the host platform, which should always appear first in the
// list.
return idx + 1; return idx + 1;
} }
Context not available.

source/API/SBError.cpp

source/API/SBEvent.cpp

source/API/SBFrame.cpp

source/API/SBInstruction.cpp

Context not available.
#include "lldb/Utility/DataExtractor.h" #include "lldb/Utility/DataExtractor.h"
//---------------------------------------------------------------------- //----------------------------------------------------------------------
// We recently fixed a leak in one of the Instruction subclasses where // We recently fixed a leak in one of the Instruction subclasses where the
// the instruction will only hold a weak reference to the disassembler // instruction will only hold a weak reference to the disassembler to
// to avoid a cycle that was keeping both objects alive (leak) and we // avoid a cycle that was keeping both objects alive (leak) and we need
// need the InstructionImpl class to make sure our public API behaves // the InstructionImpl class to make sure our public API behaves as users
// as users would expect. Calls in our public API allow clients to do // would expect. Calls in our public API allow clients to do things like:
// things like:
// //
// 1 lldb::SBInstruction inst; // 1 lldb::SBInstruction inst;
// 2 inst = target.ReadInstructions(pc, 1).GetInstructionAtIndex(0) // 2 inst = target.ReadInstructions(pc, 1).GetInstructionAtIndex(0) 3 if
// 3 if (inst.DoesBranch()) // (inst.DoesBranch()) 4 ...
labathUnsubmitted
Not Done
ReplyInline Actions

This doesn't look right.

labath: This doesn't look right.
// 4 ...
// //
// There was a temporary lldb::DisassemblerSP object created in the // There was a temporary lldb::DisassemblerSP object created in the
// SBInstructionList that was returned by lldb.target.ReadInstructions() // SBInstructionList that was returned by lldb.target.ReadInstructions()
// that will go away after line 2 but the "inst" object should be able // that will go away after line 2 but the "inst" object should be able to
// to still answer questions about itself. So we make sure that any // still answer questions about itself. So we make sure that any
// SBInstruction objects that are given out have a strong reference to // SBInstruction objects that are given out have a strong reference to the
// the disassembler and the instruction so that the object can live and // disassembler and the instruction so that the object can live and
// successfully respond to all queries. // successfully respond to all queries.
//---------------------------------------------------------------------- //----------------------------------------------------------------------
class InstructionImpl { class InstructionImpl {
Context not available.
if (module_sp) if (module_sp)
module_sp->ResolveSymbolContextForAddress(addr, eSymbolContextEverything, module_sp->ResolveSymbolContextForAddress(addr, eSymbolContextEverything,
sc); sc);
// Use the "ref()" instead of the "get()" accessor in case the SBStream // Use the "ref()" instead of the "get()" accessor in case the
// didn't have a stream already created, one will get created... // SBStream didn't have a stream already created, one will get
// created...
FormatEntity::Entry format; FormatEntity::Entry format;
FormatEntity::Parse("${addr}: ", format); FormatEntity::Parse("${addr}: ", format);
inst_sp->Dump(&s.ref(), 0, true, false, NULL, &sc, NULL, &format, 0); inst_sp->Dump(&s.ref(), 0, true, false, NULL, &sc, NULL, &format, 0);
Context not available.

source/API/SBLaunchInfo.cpp

source/API/SBModule.cpp

source/API/SBModuleSpec.cpp

source/API/SBPlatform.cpp

source/API/SBProcess.cpp

source/API/SBQueueItem.cpp

source/API/SBStream.cpp

source/API/SBTarget.cpp

source/API/SBThread.cpp

source/API/SBThreadPlan.cpp

source/API/SBType.cpp

source/API/SBTypeCategory.cpp

source/API/SBValue.cpp

source/API/SystemInitializerFull.cpp

source/Breakpoint/Breakpoint.cpp

source/Breakpoint/BreakpointID.cpp

source/Breakpoint/BreakpointIDList.cpp

source/Breakpoint/BreakpointLocation.cpp

source/Breakpoint/BreakpointLocationList.cpp

source/Breakpoint/BreakpointOptions.cpp

source/Breakpoint/BreakpointResolver.cpp

source/Breakpoint/BreakpointResolverAddress.cpp

source/Breakpoint/BreakpointResolverFileLine.cpp

source/Breakpoint/BreakpointResolverName.cpp

source/Breakpoint/BreakpointSite.cpp

source/Breakpoint/BreakpointSiteList.cpp

source/Breakpoint/Watchpoint.cpp

source/Breakpoint/WatchpointList.cpp

source/Breakpoint/WatchpointOptions.cpp

source/Commands/CommandCompletions.cpp

source/Commands/CommandObjectApropos.cpp

source/Commands/CommandObjectBreakpoint.cpp

source/Commands/CommandObjectBreakpointCommand.cpp

source/Commands/CommandObjectCommands.cpp

source/Commands/CommandObjectDisassemble.cpp

source/Commands/CommandObjectExpression.cpp

source/Commands/CommandObjectFrame.cpp

source/Commands/CommandObjectHelp.cpp

source/Commands/CommandObjectLog.cpp

source/Commands/CommandObjectMemory.cpp

source/Commands/CommandObjectMultiword.cpp

source/Commands/CommandObjectPlatform.cpp

source/Commands/CommandObjectProcess.cpp

source/Commands/CommandObjectQuit.cpp

source/Commands/CommandObjectRegister.cpp

source/Commands/CommandObjectSettings.cpp

source/Commands/CommandObjectSource.cpp

source/Commands/CommandObjectTarget.cpp

source/Commands/CommandObjectThread.cpp

source/Commands/CommandObjectType.cpp

source/Commands/CommandObjectWatchpoint.cpp

source/Commands/CommandObjectWatchpointCommand.cpp

source/Core/Address.cpp

source/Core/AddressResolverFileLine.cpp

source/Core/AddressResolverName.cpp

source/Core/Broadcaster.cpp

source/Core/Communication.cpp

source/Core/Debugger.cpp

source/Core/Disassembler.cpp

source/Core/DumpDataExtractor.cpp

source/Core/DynamicLoader.cpp

source/Core/FileSpecList.cpp

source/Core/FormatEntity.cpp

source/Core/IOHandler.cpp

source/Core/Listener.cpp

source/Core/Mangled.cpp

source/Core/Module.cpp

source/Core/ModuleList.cpp

source/Core/PluginManager.cpp

source/Core/RegisterValue.cpp

source/Core/Scalar.cpp

source/Core/SearchFilter.cpp

source/Core/Section.cpp

source/Core/SourceManager.cpp

source/Core/Value.cpp

source/Core/ValueObject.cpp

source/Core/ValueObjectCast.cpp

source/Core/ValueObjectChild.cpp

source/Core/ValueObjectConstResult.cpp

source/Core/ValueObjectDynamicValue.cpp

source/Core/ValueObjectList.cpp

source/Core/ValueObjectMemory.cpp

source/Core/ValueObjectRegister.cpp

source/Core/ValueObjectSyntheticFilter.cpp

source/Core/ValueObjectVariable.cpp

source/DataFormatters/FormatManager.cpp

source/DataFormatters/StringPrinter.cpp

source/DataFormatters/TypeFormat.cpp

source/DataFormatters/ValueObjectPrinter.cpp

source/DataFormatters/VectorType.cpp

source/Expression/DWARFExpression.cpp

source/Expression/DiagnosticManager.cpp

source/Expression/ExpressionSourceCode.cpp

source/Expression/ExpressionVariable.cpp

source/Expression/FunctionCaller.cpp

source/Expression/IRDynamicChecks.cpp

source/Expression/IRExecutionUnit.cpp

source/Expression/IRInterpreter.cpp

source/Expression/IRMemoryMap.cpp

source/Expression/LLVMUserExpression.cpp

source/Expression/Materializer.cpp

source/Expression/REPL.cpp

source/Expression/UserExpression.cpp

source/Expression/UtilityFunction.cpp

source/Host/android/HostInfoAndroid.cpp

source/Host/android/LibcGlue.cpp

source/Host/common/Editline.cpp

source/Host/common/File.cpp

source/Host/common/Host.cpp

source/Host/common/HostInfoBase.cpp

source/Host/common/MainLoop.cpp

Context not available.
#include <time.h> #include <time.h>
#include <vector> #include <vector>
// Multiplexing is implemented using kqueue on systems that support it (BSD // Multiplexing is implemented using kqueue on systems that support it
// variants including OSX). On linux we use ppoll, while android uses pselect // (BSD variants including OSX). On linux we use ppoll, while android uses
// (ppoll is present but not implemented properly). On windows we use WSApoll // pselect (ppoll is present but not implemented properly). On windows we
// (which does not support signals). // use WSApoll (which does not support signals).
#if HAVE_SYS_EVENT_H #if HAVE_SYS_EVENT_H
#include <sys/event.h> #include <sys/event.h>
Context not available.
#ifdef __ANDROID__ #ifdef __ANDROID__
Status MainLoop::RunImpl::Poll() { Status MainLoop::RunImpl::Poll() {
// ppoll(2) is not supported on older all android versions. Also, older // ppoll(2) is not supported on older all android versions. Also, older
// versions android (API <= 19) implemented pselect in a non-atomic way, as a // versions android (API <= 19) implemented pselect in a non-atomic way,
JDevlieghereUnsubmitted
Not Done
ReplyInline Actions

Is this intentional or maybe an off-by-one error? The a is in the 79th colum, which is okay for clang-format.

JDevlieghere: Is this intentional or maybe an off-by-one error? The `a` is in the 79th colum, which is okay…
aprantlAuthorUnsubmitted
Not Done
ReplyInline Actions

My script sets the threshold to 78 columns. When you are on an 80-column terminal and your editor doesn't indicate whether long lines continue or not then not using the last two characters makes it unambiguous whether the a is the beginning of a new word or whether it stands for itself.
I'll change the threshold to 80 columns to avoid reflowing paragraphs that don't need it.

aprantl: My script sets the threshold to 78 columns. When you are on an 80-column terminal and your…
// combination of pthread_sigmask and select. This is not sufficient for us, // as a combination of pthread_sigmask and select. This is not
// as we rely on the atomicity to correctly implement signal polling, so we // sufficient for us, as we rely on the atomicity to correctly implement
// call the underlying syscall ourselves. // signal polling, so we call the underlying syscall ourselves.
FD_ZERO(&read_fd_set); FD_ZERO(&read_fd_set);
int nfds = 0; int nfds = 0;
Context not available.
void MainLoop::RunImpl::ProcessEvents() { void MainLoop::RunImpl::ProcessEvents() {
#ifdef __ANDROID__ #ifdef __ANDROID__
// Collect first all readable file descriptors into a separate vector and then // Collect first all readable file descriptors into a separate vector
// iterate over it to invoke callbacks. Iterating directly over // and then iterate over it to invoke callbacks. Iterating directly over
// loop.m_read_fds is not possible because the callbacks can modify the // loop.m_read_fds is not possible because the callbacks can modify the
// container which could invalidate the iterator. // container which could invalidate the iterator.
std::vector<IOObject::WaitableHandle> fds; std::vector<IOObject::WaitableHandle> fds;
Context not available.
return CreateReadHandle(object_sp); return CreateReadHandle(object_sp);
} }
// We shall block the signal, then install the signal handler. The signal will // We shall block the signal, then install the signal handler. The signal
// be unblocked in // will be unblocked in the Run() function to check for signal delivery.
// the Run() function to check for signal delivery.
MainLoop::SignalHandleUP MainLoop::SignalHandleUP
MainLoop::RegisterSignal(int signo, const Callback &callback, Status &error) { MainLoop::RegisterSignal(int signo, const Callback &callback, Status &error) {
#ifdef SIGNAL_POLLING_UNSUPPORTED #ifdef SIGNAL_POLLING_UNSUPPORTED
Context not available.
g_signal_flags[signo] = 0; g_signal_flags[signo] = 0;
// Even if using kqueue, the signal handler will still be invoked, so it's // Even if using kqueue, the signal handler will still be invoked, so
// important to replace it with our "bening" handler. // it's important to replace it with our "bening" handler.
int ret = sigaction(signo, &new_action, &info.old_action); int ret = sigaction(signo, &new_action, &info.old_action);
assert(ret == 0 && "sigaction failed"); assert(ret == 0 && "sigaction failed");
Context not available.
assert(ret == 0); assert(ret == 0);
#endif #endif
// If we're using kqueue, the signal needs to be unblocked in order to recieve // If we're using kqueue, the signal needs to be unblocked in order to
// it. If using pselect/ppoll, we need to block it, and later unblock it as a // recieve it. If using pselect/ppoll, we need to block it, and later
// part of the system call. // unblock it as a part of the system call.
ret = pthread_sigmask(HAVE_SYS_EVENT_H ? SIG_UNBLOCK : SIG_BLOCK, ret = pthread_sigmask(HAVE_SYS_EVENT_H ? SIG_UNBLOCK : SIG_BLOCK,
&new_action.sa_mask, &old_set); &new_action.sa_mask, &old_set);
assert(ret == 0 && "pthread_sigmask failed"); assert(ret == 0 && "pthread_sigmask failed");
Context not available.

source/Host/common/NativeBreakpointList.cpp

source/Host/common/NativeProcessProtocol.cpp

source/Host/common/NativeRegisterContext.cpp

source/Host/common/PseudoTerminal.cpp

source/Host/common/Socket.cpp

source/Host/common/SocketAddress.cpp

source/Host/common/SoftwareBreakpoint.cpp

source/Host/common/Symbols.cpp

source/Host/common/TCPSocket.cpp

source/Host/common/TaskPool.cpp

source/Host/common/Terminal.cpp

source/Host/common/ThreadLauncher.cpp

source/Host/common/UDPSocket.cpp

source/Host/common/XML.cpp

source/Host/freebsd/Host.cpp

source/Host/linux/Host.cpp

source/Host/linux/HostInfoLinux.cpp

source/Host/macosx/Symbols.cpp

source/Host/macosx/cfcpp/CFCMutableDictionary.cpp

source/Host/macosx/cfcpp/CFCString.cpp

source/Host/netbsd/Host.cpp

source/Host/posix/ConnectionFileDescriptorPosix.cpp

source/Host/posix/DomainSocket.cpp

source/Host/posix/HostInfoPosix.cpp

source/Host/posix/HostProcessPosix.cpp

source/Host/posix/PipePosix.cpp

source/Host/posix/ProcessLauncherPosixFork.cpp

source/Host/windows/ConnectionGenericFileWindows.cpp

source/Host/windows/EditLineWin.cpp

source/Host/windows/FileSystem.cpp

source/Host/windows/Host.cpp

source/Host/windows/HostInfoWindows.cpp

source/Host/windows/HostProcessWindows.cpp

source/Host/windows/PipeWindows.cpp

source/Host/windows/ProcessLauncherWindows.cpp

source/Initialization/SystemInitializerCommon.cpp

source/Interpreter/CommandAlias.cpp

source/Interpreter/CommandInterpreter.cpp

source/Interpreter/CommandObject.cpp

source/Interpreter/CommandObjectRegexCommand.cpp

source/Interpreter/CommandObjectScript.cpp

source/Interpreter/CommandReturnObject.cpp

source/Interpreter/OptionArgParser.cpp

source/Interpreter/OptionGroupBoolean.cpp

source/Interpreter/OptionGroupFormat.cpp

source/Interpreter/OptionGroupValueObjectDisplay.cpp

source/Interpreter/OptionGroupVariable.cpp

source/Interpreter/OptionValue.cpp

source/Interpreter/OptionValueDictionary.cpp

source/Interpreter/OptionValueFileSpec.cpp

source/Interpreter/OptionValueFormatEntity.cpp

source/Interpreter/OptionValuePathMappings.cpp

source/Interpreter/OptionValueProperties.cpp

source/Interpreter/OptionValueSInt64.cpp

source/Interpreter/Options.cpp

source/Interpreter/Property.cpp

source/Plugins/ABI/MacOSX-arm/ABIMacOSX_arm.cpp

source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp

source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp

source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp

source/Plugins/ABI/SysV-arm64/ABISysV_arm64.cpp

source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp

source/Plugins/ABI/SysV-i386/ABISysV_i386.cpp

source/Plugins/ABI/SysV-mips/ABISysV_mips.cpp

source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp

source/Plugins/ABI/SysV-ppc/ABISysV_ppc.cpp

source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.cpp

source/Plugins/ABI/SysV-s390x/ABISysV_s390x.cpp

source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp

source/Plugins/Architecture/Arm/ArchitectureArm.cpp

source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp

source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp

source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp

source/Plugins/DynamicLoader/Hexagon-DYLD/HexagonDYLDRendezvous.cpp

source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp

source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp

source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp

source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp

source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp

source/Plugins/DynamicLoader/Static/DynamicLoaderStatic.cpp

source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp

source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp

source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp

source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp

source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp

source/Plugins/ExpressionParser/Clang/ClangFunctionCaller.cpp

source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp

source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp

source/Plugins/ExpressionParser/Clang/IRForTarget.cpp

source/Plugins/ExpressionParser/Go/GoUserExpression.cpp

source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp

source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp

source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp

source/Plugins/Instruction/PPC64/EmulateInstructionPPC64.cpp

source/Plugins/InstrumentationRuntime/MainThreadChecker/MainThreadCheckerRuntime.cpp

source/Plugins/InstrumentationRuntime/TSan/TSanRuntime.cpp

source/Plugins/InstrumentationRuntime/UBSan/UBSanRuntime.cpp

source/Plugins/Language/CPlusPlus/BlockPointer.cpp

source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp

source/Plugins/Language/CPlusPlus/CPlusPlusNameParser.cpp

source/Plugins/Language/CPlusPlus/LibCxx.cpp

source/Plugins/Language/CPlusPlus/LibCxxInitializerList.cpp

source/Plugins/Language/CPlusPlus/LibCxxList.cpp

source/Plugins/Language/CPlusPlus/LibCxxMap.cpp

source/Plugins/Language/CPlusPlus/LibCxxVector.cpp

source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp

source/Plugins/Language/ObjC/Cocoa.cpp

source/Plugins/Language/ObjC/CoreMedia.cpp

source/Plugins/Language/ObjC/NSError.cpp

source/Plugins/Language/ObjC/NSException.cpp

source/Plugins/Language/ObjC/NSString.cpp

source/Plugins/Language/ObjC/ObjCLanguage.cpp

source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp

source/Plugins/LanguageRuntime/Go/GoLanguageRuntime.cpp

source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCClassDescriptorV2.cpp

source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp

source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp

source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp

source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTypeEncodingParser.cpp

source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp

source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptExpressionOpts.cpp

source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp

source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp

source/Plugins/MemoryHistory/asan/MemoryHistoryASan.cpp

source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp

source/Plugins/ObjectContainer/Universal-Mach-O/ObjectContainerUniversalMachO.cpp

source/Plugins/ObjectFile/ELF/ELFHeader.cpp

source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp

source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

source/Plugins/ObjectFile/PECOFF/WindowsMiniDump.cpp

source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp

source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp

source/Plugins/Platform/Android/AdbClient.cpp

source/Plugins/Platform/Android/PlatformAndroid.cpp

source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp

source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp

source/Plugins/Platform/Linux/PlatformLinux.cpp

source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp

source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp

source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp

source/Plugins/Platform/MacOSX/PlatformDarwin.cpp

source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp

source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp

source/Plugins/Platform/MacOSX/PlatformRemoteAppleTV.cpp

source/Plugins/Platform/MacOSX/PlatformRemoteAppleWatch.cpp

source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp

source/Plugins/Platform/MacOSX/PlatformRemoteiOS.cpp

source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp

source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp

source/Plugins/Platform/OpenBSD/PlatformOpenBSD.cpp

source/Plugins/Platform/POSIX/PlatformPOSIX.cpp

source/Plugins/Platform/Windows/PlatformWindows.cpp

source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp

source/Plugins/Process/Darwin/CFString.cpp

source/Plugins/Process/Darwin/DarwinProcessLauncher.cpp

source/Plugins/Process/Darwin/MachException.cpp

source/Plugins/Process/Darwin/NativeProcessDarwin.cpp

source/Plugins/Process/Darwin/NativeThreadDarwin.cpp

source/Plugins/Process/Darwin/NativeThreadListDarwin.cpp

source/Plugins/Process/FreeBSD/FreeBSDThread.cpp

source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp

source/Plugins/Process/FreeBSD/ProcessMonitor.cpp

source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.cpp

source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_powerpc.cpp

source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_x86.cpp

source/Plugins/Process/Linux/NativeProcessLinux.cpp

source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp

source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp

source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp

source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp

source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.cpp

source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp

source/Plugins/Process/Linux/NativeThreadLinux.cpp

source/Plugins/Process/Linux/SingleStepCheck.cpp

source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp

source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp

source/Plugins/Process/MacOSX-Kernel/ThreadKDP.cpp

source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp

source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp

source/Plugins/Process/POSIX/CrashReason.cpp

source/Plugins/Process/Utility/DynamicRegisterInfo.cpp

source/Plugins/Process/Utility/InferiorCallPOSIX.cpp

source/Plugins/Process/Utility/RegisterContextDarwin_arm.cpp

source/Plugins/Process/Utility/RegisterContextDarwin_arm64.cpp

source/Plugins/Process/Utility/RegisterContextDarwin_i386.cpp

source/Plugins/Process/Utility/RegisterContextDarwin_x86_64.cpp

source/Plugins/Process/Utility/RegisterContextFreeBSD_i386.cpp

source/Plugins/Process/Utility/RegisterContextLLDB.cpp

source/Plugins/Process/Utility/RegisterContextLinux_i386.cpp

source/Plugins/Process/Utility/RegisterContextLinux_mips.cpp

source/Plugins/Process/Utility/RegisterContextLinux_mips64.cpp

source/Plugins/Process/Utility/RegisterContextLinux_s390x.cpp

source/Plugins/Process/Utility/RegisterContextMacOSXFrameBackchain.cpp

source/Plugins/Process/Utility/RegisterContextMemory.cpp

source/Plugins/Process/Utility/RegisterContextOpenBSD_i386.cpp

source/Plugins/Process/Utility/RegisterContextPOSIX_arm.cpp

source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.cpp

source/Plugins/Process/Utility/RegisterContextPOSIX_mips64.cpp

source/Plugins/Process/Utility/RegisterContextPOSIX_powerpc.cpp

source/Plugins/Process/Utility/RegisterContextPOSIX_ppc64le.cpp

source/Plugins/Process/Utility/RegisterContextPOSIX_s390x.cpp

source/Plugins/Process/Utility/RegisterContextPOSIX_x86.cpp

source/Plugins/Process/Utility/RegisterInfoPOSIX_arm.cpp

source/Plugins/Process/Utility/RegisterInfoPOSIX_arm64.cpp

source/Plugins/Process/Utility/RegisterInfoPOSIX_ppc64le.cpp

source/Plugins/Process/Utility/StopInfoMachException.cpp

source/Plugins/Process/Utility/UnwindLLDB.cpp

source/Plugins/Process/Windows/Common/DebuggerThread.cpp

source/Plugins/Process/Windows/Common/ProcessWindows.cpp

source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp

source/Plugins/Process/Windows/Common/x64/RegisterContextWindows_x64.cpp

source/Plugins/Process/Windows/Common/x86/RegisterContextWindows_x86.cpp

source/Plugins/Process/elf-core/ProcessElfCore.cpp

source/Plugins/Process/elf-core/RegisterContextPOSIXCore_mips64.cpp

source/Plugins/Process/elf-core/ThreadElfCore.cpp

source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp

source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp

source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp

source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp

source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp

source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp

source/Plugins/Process/mach-core/ProcessMachCore.cpp

source/Plugins/Process/mach-core/ThreadMachCore.cpp

source/Plugins/Process/minidump/MinidumpParser.cpp

source/Plugins/Process/minidump/MinidumpTypes.cpp

source/Plugins/Process/minidump/ProcessMinidump.cpp

source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp

source/Plugins/ScriptInterpreter/Python/PythonExceptionState.cpp

source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp

source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp

source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp

source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp

source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp

source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.cpp

source/Plugins/SymbolFile/DWARF/DWARFDebugArangeSet.cpp

source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp

source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp

source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp

source/Plugins/SymbolFile/DWARF/DWARFDebugMacinfoEntry.cpp

source/Plugins/SymbolFile/DWARF/DWARFDebugMacro.cpp

source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp

source/Plugins/SymbolFile/DWARF/DWARFDeclContext.cpp

source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp

source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp

source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp

source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp

source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp

source/Plugins/SymbolFile/DWARF/UniqueDWARFASTType.cpp

source/Plugins/SymbolFile/PDB/PDBASTParser.cpp

source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp

source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.cpp

source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp

source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp

source/Plugins/SystemRuntime/MacOSX/AppleGetItemInfoHandler.cpp

source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.cpp

source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.cpp

source/Plugins/SystemRuntime/MacOSX/AppleGetThreadItemInfoHandler.cpp

source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.cpp

source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp

source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp

source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.cpp

source/Symbol/ArmUnwindInfo.cpp

source/Symbol/Block.cpp

source/Symbol/ClangASTContext.cpp

source/Symbol/ClangASTImporter.cpp

source/Symbol/ClangExternalASTSourceCallbacks.cpp

source/Symbol/ClangUtil.cpp

source/Symbol/CompactUnwindInfo.cpp

source/Symbol/CompileUnit.cpp

source/Symbol/CompilerType.cpp

source/Symbol/DWARFCallFrameInfo.cpp

source/Symbol/FuncUnwinders.cpp

source/Symbol/Function.cpp

source/Symbol/GoASTContext.cpp

source/Symbol/JavaASTContext.cpp

source/Symbol/LineEntry.cpp

source/Symbol/LineTable.cpp

source/Symbol/ObjectFile.cpp

source/Symbol/Symbol.cpp

source/Symbol/SymbolContext.cpp

source/Symbol/SymbolFile.cpp

source/Symbol/SymbolVendor.cpp

source/Symbol/Symtab.cpp

source/Symbol/Type.cpp

source/Symbol/TypeList.cpp

source/Symbol/TypeMap.cpp

source/Symbol/TypeSystem.cpp

source/Symbol/UnwindPlan.cpp

source/Symbol/UnwindTable.cpp

source/Symbol/Variable.cpp

source/Target/ABI.cpp

source/Target/ExecutionContext.cpp

source/Target/Language.cpp

source/Target/LanguageRuntime.cpp

source/Target/Memory.cpp

source/Target/ModuleCache.cpp

source/Target/ObjCLanguageRuntime.cpp

source/Target/PathMappingList.cpp

source/Target/Platform.cpp

source/Target/Process.cpp

source/Target/ProcessLaunchInfo.cpp

source/Target/RegisterContext.cpp

source/Target/SectionLoadHistory.cpp

source/Target/SectionLoadList.cpp

source/Target/StackFrame.cpp

source/Target/StackFrameList.cpp

source/Target/StackID.cpp

source/Target/StopInfo.cpp

source/Target/StructuredDataPlugin.cpp

source/Target/Target.cpp

source/Target/TargetList.cpp

source/Target/Thread.cpp

source/Target/ThreadList.cpp

source/Target/ThreadPlanBase.cpp

source/Target/ThreadPlanCallFunction.cpp

source/Target/ThreadPlanCallFunctionUsingABI.cpp

source/Target/ThreadPlanCallOnFunctionExit.cpp

source/Target/ThreadPlanCallUserExpression.cpp

source/Target/ThreadPlanPython.cpp

source/Target/ThreadPlanShouldStopHere.cpp

source/Target/ThreadPlanStepInRange.cpp

source/Target/ThreadPlanStepInstruction.cpp

source/Target/ThreadPlanStepOut.cpp

source/Target/ThreadPlanStepOverBreakpoint.cpp

source/Target/ThreadPlanStepOverRange.cpp

source/Target/ThreadPlanStepRange.cpp

source/Target/ThreadPlanStepThrough.cpp

source/Target/ThreadPlanStepUntil.cpp

source/Target/UnixSignals.cpp

source/Utility/ArchSpec.cpp

source/Utility/Args.cpp

source/Utility/ConstString.cpp

source/Utility/DataBufferHeap.cpp

source/Utility/DataBufferLLVM.cpp

source/Utility/DataEncoder.cpp

source/Utility/DataExtractor.cpp

source/Utility/FastDemangle.cpp

source/Utility/FileSpec.cpp

source/Utility/JSON.cpp

source/Utility/Log.cpp

source/Utility/RegularExpression.cpp

source/Utility/SelectHelper.cpp

source/Utility/SharingPtr.cpp

source/Utility/Status.cpp

source/Utility/Stream.cpp

source/Utility/StringExtractor.cpp

source/Utility/StringExtractorGDBRemote.cpp

source/Utility/StructuredData.cpp

source/Utility/UUID.cpp

source/Utility/VASprintf.cpp

source/lldb.cpp