Page MenuHomePhabricator

[GlobalISel][ARM] Adding HPR and QPR regclasses to FPRB regbank

Authored by rtereshin on Mar 1 2018, 4:30 PM.



Also bringing ARMRegisterBankInfo::getRegBankFromRegClass implementation up to speed with the *.td-definition.

This is a strict requirement for D44700: Improving InstructionSelect's performance by reducing MatchTable that brings a significant compile time reduction to GlobalISel.

The reason for the dependency is simple: the MatchTable optimization sometimes re-orders some of the rules if it's safe, for instance, if 2 rules are mutually exclusive because they explicitly check different register banks of the same operands of the same instruction sequences (by topology). If let's say the original table has 4 rules in order A1 B1 A2 B2, where A1 and A2 check the same register bank A (therefore not safe to re-order), and B1 and B2 check the same bank B, where A != B it's safe to reorder them as A1 A2 B1 B2 and it's beneficial as the register banks check could be extracted out and checked once for a group (check A (A1' A2') check B (B1' B2'). It could be noticed also that check B (B1' B2') check A (A1' A2') is equally legal. As a portion of a concrete MatchTable is unreachable due to GlobalISel falling back to SelectionDAG ISel on earlier stages (Legalization, Reg Bank Selection, etc) and / or due to selectiveness of the Reg Bank Select some of the register bank checks there were never covered before by the existing tests now will (for instance if A1 hid B1 A2 B2 part of the table, check B could have avoided execution altogether, while in modified check B (B1' B2') check A (A1' A2') table check B could be executed).

And some of those checks fail because they try to look up a register bank for a register class that is not handled by the implementation.

This patch fixes exactly that for ARM.

Diff Detail


Event Timeline

rtereshin created this revision.Mar 1 2018, 4:30 PM
rtereshin edited the summary of this revision. (Show Details)Mar 1 2018, 4:31 PM
rtereshin retitled this revision from [GlobalISel][ARM] Adding HRP and QPR regclasses to FPRB regbank to [GlobalISel][ARM] Adding HPR and QPR regclasses to FPRB regbank.Mar 1 2018, 4:37 PM
rtereshin edited the summary of this revision. (Show Details)May 16 2018, 9:33 PM
rtereshin updated this revision to Diff 147236.May 16 2018, 9:37 PM

Removing Testgen'erated tests as I'm eliminating the dependency of (InstructionSelect perf patch) from (Testgen) and pushing the perf patch sooner and the perf patch depends on this one.

If the perf patch applied in front of this one a number of regression tests will fail therefore this will be immediately tested by the existing tests.

qcolombet accepted this revision.May 18 2018, 2:43 PM
This revision is now accepted and ready to land.May 18 2018, 2:43 PM
This revision was automatically updated to reflect the committed changes.