Page MenuHomePhabricator

[Tooling] [1/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

Authored by lebedev.ri on Feb 26 2018, 12:48 PM.



I'm not sure whether there are any principal reasons why it returns raw owning pointer,
or it is just a old code that was not updated post-C++11.

I'm not too sure what testing i should do, because check-all is not error clean here for some reason,
but it does not appear asif those failures are related to these changes.

This is Clang-tools-extra part.
Clang part is D43779.

Diff Detail


Event Timeline

lebedev.ri created this revision.Feb 26 2018, 12:48 PM
alexfh accepted this revision.Feb 27 2018, 3:22 AM

Awesome, thank you for this cleanup!

This revision is now accepted and ready to land.Feb 27 2018, 3:22 AM

Thank you.

I did re-read the diffs, and i don't see any invalid changes here.
I'm going to try to commit this (as two revisions, need to migrate to monorepo one day :/),
and if the bots show that i still did miss something here, i'll revert.

This revision was automatically updated to reflect the committed changes.
lebedev.ri reopened this revision.Feb 27 2018, 8:00 AM
This revision is now accepted and ready to land.Feb 27 2018, 8:00 AM
lebedev.ri abandoned this revision.Aug 29 2019, 9:50 AM

Superseded by D66960

Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2019, 9:50 AM