Page MenuHomePhabricator

jkorous-apple (Jan Korous [deprecated account])
[deprecated account] using "jkorous" now

Projects

User does not belong to any projects.

User Details

User Since
Oct 5 2017, 5:21 PM (101 w, 3 d)

[deprecated account] using "jkorous" now

Recent Activity

Apr 18 2018

jkorous-apple closed D41897: Fixing a crash in Sema..

Landed as git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@322438 91177308-0d34-0410-b5e6-96231b3b80d8

Apr 18 2018, 4:27 AM

Apr 16 2018

jkorous-apple added a reviewer for D45569: [Sema] Disable built-in increment operator for bool in overload resolution in C++17: vsapsai.
Apr 16 2018, 5:20 AM

Apr 13 2018

jkorous-apple updated the summary of D45621: [clangd][tests] Fix delimiter handling.
Apr 13 2018, 6:18 AM · Unknown Object (Project)
jkorous-apple created D45621: [clangd][tests] Fix delimiter handling.
Apr 13 2018, 6:18 AM · Unknown Object (Project)
jkorous-apple created D45620: [clangd][tests] Fix handling of EOF in delimited input.
Apr 13 2018, 6:07 AM

Apr 12 2018

jkorous-apple created D45569: [Sema] Disable built-in increment operator for bool in overload resolution in C++17.
Apr 12 2018, 7:12 AM

Apr 10 2018

jkorous-apple added a comment to D44988: [Sema] Fix decrement availability for built-in types.

Spot on with the negative test idea! Should've done that myself. Thanks.

Apr 10 2018, 9:07 AM
jkorous-apple updated the diff for D44988: [Sema] Fix decrement availability for built-in types.

Added test for decrement being disabled for bool.
Fixed comment in test (will put into separate NFC commit).

Apr 10 2018, 9:07 AM

Mar 28 2018

jkorous-apple created D44988: [Sema] Fix decrement availability for built-in types.
Mar 28 2018, 11:07 AM

Mar 26 2018

jkorous-apple accepted D42938: [Sema] Emit -Winteger-overflow for arguments in function calls, ObjC messages..

LGTM

Mar 26 2018, 3:07 PM

Mar 20 2018

jkorous-apple closed D44576: [clangd] Fix undefined behavior due to misaligned type cast.
Mar 20 2018, 10:11 AM · Unknown Object (Project)
jkorous-apple closed D44575: [clangd][nfc] Give name to a magic constant.
Mar 20 2018, 10:07 AM · Unknown Object (Project)
jkorous-apple added a comment to D44575: [clangd][nfc] Give name to a magic constant.

I commited the patch but forgot to quote this review.

Mar 20 2018, 10:07 AM · Unknown Object (Project)
jkorous-apple added a comment to D44576: [clangd] Fix undefined behavior due to misaligned type cast.

I commited the patch but forgot to quote this review.

Mar 20 2018, 10:06 AM · Unknown Object (Project)

Mar 16 2018

jkorous-apple created D44576: [clangd] Fix undefined behavior due to misaligned type cast.
Mar 16 2018, 12:39 PM · Unknown Object (Project)
jkorous-apple created D44575: [clangd][nfc] Give name to a magic constant.
Mar 16 2018, 12:27 PM · Unknown Object (Project)

Mar 8 2018

jkorous-apple added inline comments to D44088: [clangd] Extract ClangdServer::Options struct..
Mar 8 2018, 4:11 AM

Mar 2 2018

jkorous-apple added a comment to D42938: [Sema] Emit -Winteger-overflow for arguments in function calls, ObjC messages..

Sorry, my bad, I tried just older clang version which didn't produce any error.

Mar 2 2018, 11:05 AM
jkorous-apple added a comment to D42938: [Sema] Emit -Winteger-overflow for arguments in function calls, ObjC messages..

Maybe a stupid idea but in case it makes sense to add these expression types could we also add integer template arguments?

Mar 2 2018, 5:02 AM

Feb 15 2018

jkorous-apple created D43331: [WIP][Parser][FixIt] Better diagnostics for omitted template keyword (type dependent template names).
Feb 15 2018, 3:09 AM

Feb 13 2018

jkorous-apple added inline comments to D43230: [clangd] Explicitly initialize all primitive fields in Protocol.h.
Feb 13 2018, 3:46 AM

Jan 31 2018

jkorous-apple added a comment to D42170: Fixit for 'typedef' instead of 'typename' typo.

Thanks for your patience with me still learning lit/filecheck. What do you think about the test now? I totally agree that this is subjective matter but I appreciate your feedback.

Jan 31 2018, 4:14 AM
jkorous-apple updated the diff for D42170: Fixit for 'typedef' instead of 'typename' typo.

Tried to make test more readable.

Jan 31 2018, 4:11 AM

Jan 27 2018

jkorous-apple edited reviewers for D42170: Fixit for 'typedef' instead of 'typename' typo, added: vsapsai; removed: arphaman.
Jan 27 2018, 1:38 PM
jkorous-apple updated the diff for D42170: Fixit for 'typedef' instead of 'typename' typo.

I got rid of backslashes in test and added member of the type parameter with typo. Thanks for suggestions.

Jan 27 2018, 1:38 PM
jkorous-apple added a comment to D42170: Fixit for 'typedef' instead of 'typename' typo.

I got rid of backslashes in test and added member of the type parameter with typo. Thanks for these suggestions.

Jan 27 2018, 1:31 PM

Jan 23 2018

jkorous-apple updated the diff for D42170: Fixit for 'typedef' instead of 'typename' typo.

Changes based on Volodymyr's comments.

Jan 23 2018, 4:16 AM
jkorous-apple added inline comments to D42170: Fixit for 'typedef' instead of 'typename' typo.
Jan 23 2018, 4:12 AM

Jan 17 2018

Herald added a reviewer for D42173: [clangd] Simplify code handling compile commands: jkorous-apple.
Jan 17 2018, 7:10 AM
Herald added a reviewer for D42174: [clangd] Refactored threading in ClangdServer: jkorous-apple.
Jan 17 2018, 7:10 AM
jkorous-apple added a reviewer for D42170: Fixit for 'typedef' instead of 'typename' typo: arphaman.
Jan 17 2018, 5:57 AM
jkorous-apple created D42170: Fixit for 'typedef' instead of 'typename' typo.
Jan 17 2018, 5:56 AM

Jan 12 2018

jkorous-apple added a comment to D41897: Fixing a crash in Sema..

I do. Will commit this in a minute.

Jan 12 2018, 8:11 AM
jkorous-apple added a comment to D41897: Fixing a crash in Sema..

Thank you!

Jan 12 2018, 8:03 AM
jkorous-apple updated the diff for D41897: Fixing a crash in Sema..

Fixed test based on Aaron's comments.

Jan 12 2018, 7:53 AM
jkorous-apple added inline comments to D41897: Fixing a crash in Sema..
Jan 12 2018, 7:35 AM
jkorous-apple added inline comments to D41897: Fixing a crash in Sema..
Jan 12 2018, 2:38 AM

Jan 11 2018

jkorous-apple updated the diff for D41897: Fixing a crash in Sema..

Changes based on Aaron's feedback.

Jan 11 2018, 3:09 AM

Jan 10 2018

jkorous-apple created D41897: Fixing a crash in Sema..
Jan 10 2018, 4:03 AM

Dec 16 2017

jkorous-apple accepted D41306: [clangd] Update documentation page with new features, instructions.

LGTM

Dec 16 2017, 7:35 AM · Unknown Object (Project)

Dec 5 2017

jkorous-apple accepted D39279: Stringizing raw string literals containing newline.
Dec 5 2017, 4:33 AM
jkorous-apple added a comment to D39279: Stringizing raw string literals containing newline.

I see your concern. Would you just consider moving the annotation to header file then? It looks more like documentation of public interface than implementation details to me. I imagine any programmer interested in these methods needs to know these details so they would probably appreciate not having to search for it.

Dec 5 2017, 4:32 AM

Dec 4 2017

jkorous-apple added a comment to D40527: [libclang] Record parsing invocation to a temporary file when requested by client.

LGTM otherwise.

Dec 4 2017, 6:11 AM

Dec 1 2017

jkorous-apple added a comment to D39279: Stringizing raw string literals containing newline.

Thank you for your patience @twoh and sorry for the delay.
I have few suggestions about doxygen annotations but otherwise LGTM.

Dec 1 2017, 8:48 AM

Nov 29 2017

jkorous-apple added inline comments to D40527: [libclang] Record parsing invocation to a temporary file when requested by client.
Nov 29 2017, 7:54 AM
jkorous-apple added inline comments to D40527: [libclang] Record parsing invocation to a temporary file when requested by client.
Nov 29 2017, 7:10 AM
jkorous-apple added a comment to D39279: Stringizing raw string literals containing newline.

I am sorry I wasn't really clear. What I meant was to do something like this (pseudo-code, dealing only with newlines):

Nov 29 2017, 6:03 AM

Nov 28 2017

jkorous-apple added a comment to D39730: Enabling constructor code completion.

No luck. If I understand it correctly all the information that would be needed to distinguish between:

Nov 28 2017, 8:18 AM

Nov 24 2017

jkorous-apple added inline comments to D39279: Stringizing raw string literals containing newline.
Nov 24 2017, 4:56 AM

Nov 23 2017

jkorous-apple added a comment to D39730: Enabling constructor code completion.

Sorry for delays, I'm working on this on and off when there's nothing more important.

Nov 23 2017, 9:53 AM

Nov 15 2017

jkorous-apple added a comment to D39730: Enabling constructor code completion.

Sorry, what do you mean by "this works in the body of the class"?

Nov 15 2017, 7:35 AM

Nov 10 2017

jkorous-apple updated the diff for D39730: Enabling constructor code completion.

I am able to enable ctor completion selectively in translate unit scope and namespace scope so ctor completion does not appear in dot access context. I haven't figured out how to explicitly specify that completion context needs to be qualified id though.

Nov 10 2017, 10:25 AM

Nov 7 2017

jkorous-apple added a comment to D39730: Enabling constructor code completion.

I agree and it seems to be the case but I will upgrade my ad-hoc testing code snippet to a proper test as I should have done it in the first place. I also agree that this change looks really suspicious and I was basically surprised that it works.

Nov 7 2017, 10:24 AM
jkorous-apple created D39730: Enabling constructor code completion.
Nov 7 2017, 5:33 AM

Nov 3 2017

jkorous-apple updated the diff for D39419: Fix crash when parsing objective-c++ containing invalid lambda.

newline at the end of test file

Nov 3 2017, 3:07 AM
jkorous-apple added inline comments to D39419: Fix crash when parsing objective-c++ containing invalid lambda.
Nov 3 2017, 3:06 AM

Oct 30 2017

jkorous-apple created D39419: Fix crash when parsing objective-c++ containing invalid lambda.
Oct 30 2017, 6:59 AM

Oct 12 2017

jkorous-apple created D38863: Typos in tutorial.
Oct 12 2017, 3:57 PM

Oct 10 2017

jkorous-apple created D38755: Fixed crash during indexing default template template param.
Oct 10 2017, 12:26 PM

Oct 9 2017

jkorous-apple created D38711: typos in documentation?.
Oct 9 2017, 4:27 PM
jkorous-apple added inline comments to D38707: PR13575: Fix USR mangling for functions taking function pointers as arguments..
Oct 9 2017, 4:21 PM
jkorous-apple updated the diff for D38707: PR13575: Fix USR mangling for functions taking function pointers as arguments..

added another test

Oct 9 2017, 4:09 PM
jkorous-apple created D38707: PR13575: Fix USR mangling for functions taking function pointers as arguments..
Oct 9 2017, 3:16 PM
jkorous-apple updated the diff for D38643: PR13575: Fix USR mangling for fixed-size arrays..

Single char constants don't need to be c-strings.

Oct 9 2017, 11:51 AM
jkorous-apple updated the diff for D38643: PR13575: Fix USR mangling for fixed-size arrays..

clang-format

Oct 9 2017, 10:16 AM

Oct 6 2017

jkorous-apple updated the diff for D38643: PR13575: Fix USR mangling for fixed-size arrays..

Solved issues from CR.

Oct 6 2017, 5:47 PM
jkorous-apple added a comment to D38643: PR13575: Fix USR mangling for fixed-size arrays..

Replied and going to delete the end delimiter.

Oct 6 2017, 5:04 PM
jkorous-apple updated the diff for D38643: PR13575: Fix USR mangling for fixed-size arrays..

Ammenended as suggested.

Oct 6 2017, 4:05 PM
jkorous-apple updated the diff for D38643: PR13575: Fix USR mangling for fixed-size arrays..

Uploaded full diff.

Oct 6 2017, 1:35 PM
jkorous-apple created D38643: PR13575: Fix USR mangling for fixed-size arrays..
Oct 6 2017, 1:10 PM