ioeric (Eric Liu)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 12 2016, 3:46 AM (88 w, 2 d)
Roles
Administrator

Recent Activity

Fri, Oct 20

ioeric accepted D39120: [rename] Don't overwrite the template argument when renaming a template function..

lgtm

Fri, Oct 20, 6:50 AM
ioeric added inline comments to D39120: [rename] Don't overwrite the template argument when renaming a template function..
Fri, Oct 20, 6:23 AM
ioeric added inline comments to D39120: [rename] Don't overwrite the template argument when renaming a template function..
Fri, Oct 20, 5:31 AM

Thu, Oct 19

ioeric updated the diff for D39042: [Tooling] Add a factory method for CommonOptionsParser.
  • Make the factory method return an expected object instead of unique_ptr.
  • clang-format code.
Thu, Oct 19, 7:33 AM
ioeric updated the diff for D34272: [Tooling] A new framework for executing clang frontend actions..
  • Remove unused variable.
  • Narrow supported actions to FrontendActionFactory from ToolAction.
Thu, Oct 19, 7:02 AM
ioeric accepted D39086: Performance tracing facility for clangd..

lgtm

Thu, Oct 19, 5:03 AM
ioeric added a comment to D39086: Performance tracing facility for clangd..

Looks good in general. A few nits.

Thu, Oct 19, 3:38 AM

Wed, Oct 18

ioeric updated the diff for D39042: [Tooling] Add a factory method for CommonOptionsParser.
  • Move unique_ptr result.
Wed, Oct 18, 10:46 AM
ioeric added inline comments to D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions.
Wed, Oct 18, 7:58 AM
ioeric added a comment to D38982: [refactor] Initial outline of implementation of "extract function" refactoring.

Code looks good in general. I see there are a bunch of major features missing; it might make sense to print a warning or document the major missing features in the high-level API.

Wed, Oct 18, 5:45 AM
ioeric added inline comments to D39042: [Tooling] Add a factory method for CommonOptionsParser.
Wed, Oct 18, 5:17 AM
ioeric updated the diff for D39042: [Tooling] Add a factory method for CommonOptionsParser.
  • Address review comments.
Wed, Oct 18, 5:17 AM
ioeric accepted D39043: [clang-rename] Rename alias..

Lg

Wed, Oct 18, 4:54 AM
ioeric added inline comments to D34272: [Tooling] A new framework for executing clang frontend actions..
Wed, Oct 18, 3:18 AM
ioeric updated the diff for D34272: [Tooling] A new framework for executing clang frontend actions..
  • Address review comments.
Wed, Oct 18, 3:17 AM
ioeric updated the diff for D34272: [Tooling] A new framework for executing clang frontend actions..
  • Add a factory method for creating CommonOptionsParser.
  • Minor cleanup in CommonOptionsParser.
  • Revert CommonOptionsParser changes.
  • Merge branch 'option' into arcpatch-D34272
Wed, Oct 18, 2:32 AM
ioeric added a dependency for D34272: [Tooling] A new framework for executing clang frontend actions.: D39042: [Tooling] Add a factory method for CommonOptionsParser.
Wed, Oct 18, 2:30 AM
ioeric added a dependent revision for D39042: [Tooling] Add a factory method for CommonOptionsParser: D34272: [Tooling] A new framework for executing clang frontend actions..
Wed, Oct 18, 2:30 AM
ioeric created D39042: [Tooling] Add a factory method for CommonOptionsParser.
Wed, Oct 18, 2:30 AM
ioeric created D39041: [Support] Remove an outdated comment..
Wed, Oct 18, 1:22 AM

Tue, Oct 17

ioeric added a reviewer for D34272: [Tooling] A new framework for executing clang frontend actions.: sammccall.
Tue, Oct 17, 8:58 AM
ioeric updated the diff for D34272: [Tooling] A new framework for executing clang frontend actions..
  • Minor cleanup in tests.
Tue, Oct 17, 8:52 AM
ioeric added a comment to D34272: [Tooling] A new framework for executing clang frontend actions..

Thanks for the review!

Tue, Oct 17, 8:38 AM
ioeric updated the diff for D34272: [Tooling] A new framework for executing clang frontend actions..
  • Addressed review comments.
Tue, Oct 17, 8:38 AM
ioeric updated the diff for D34272: [Tooling] A new framework for executing clang frontend actions..
  • Move StandaloneToolExecutor into a separate header; added ExecutionTest.cpp.
Tue, Oct 17, 8:21 AM
ioeric updated the diff for D34272: [Tooling] A new framework for executing clang frontend actions..
  • Fix broken unit tests when they are run in threads in the same process.
Tue, Oct 17, 6:51 AM
ioeric accepted D38989: [clang-rename] Rename enum..

Lg

Tue, Oct 17, 6:29 AM
ioeric added inline comments to D38989: [clang-rename] Rename enum..
Tue, Oct 17, 3:24 AM
ioeric added inline comments to D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions.
Tue, Oct 17, 3:11 AM
ioeric added inline comments to D38989: [clang-rename] Rename enum..
Tue, Oct 17, 1:37 AM

Mon, Oct 16

ioeric updated the diff for D34272: [Tooling] A new framework for executing clang frontend actions..
  • Add a ExecutionContext class.
Mon, Oct 16, 6:44 AM
ioeric accepted D38882: [clang-rename] Add function unit tests..

Still LGTM

Mon, Oct 16, 2:48 AM
ioeric added a comment to D34272: [Tooling] A new framework for executing clang frontend actions..

Thanks for the review!

Mon, Oct 16, 2:40 AM
ioeric updated the diff for D34272: [Tooling] A new framework for executing clang frontend actions..
  • Address review comments.
Mon, Oct 16, 2:39 AM
ioeric updated the diff for D34272: [Tooling] A new framework for executing clang frontend actions..
  • clang-format code.
Mon, Oct 16, 1:51 AM
ioeric committed rL315892: [change-namespace] do not change type locs in defaulted functions..
[change-namespace] do not change type locs in defaulted functions.
Mon, Oct 16, 1:20 AM
ioeric closed D38893: [change-namespace] do not change type locs in defaulted functions. by committing rL315892: [change-namespace] do not change type locs in defaulted functions..
Mon, Oct 16, 1:20 AM

Fri, Oct 13

ioeric created D38893: [change-namespace] do not change type locs in defaulted functions..
Fri, Oct 13, 9:38 AM
ioeric accepted D38882: [clang-rename] Add function unit tests..

Lg

Fri, Oct 13, 8:14 AM
ioeric updated the diff for D34272: [Tooling] A new framework for executing clang frontend actions..
  • Minor cleanups.
Fri, Oct 13, 4:35 AM
ioeric added reviewers for D34272: [Tooling] A new framework for executing clang frontend actions.: klimek, arphaman, hokein.
Fri, Oct 13, 2:39 AM
ioeric updated subscribers of D34272: [Tooling] A new framework for executing clang frontend actions..
Fri, Oct 13, 2:39 AM
ioeric updated the summary of D34272: [Tooling] A new framework for executing clang frontend actions..
Fri, Oct 13, 2:04 AM
ioeric retitled D34272: [Tooling] A new framework for executing clang frontend actions. from Prototyping tooling::ToolExecutor. to [Tooling] A new framework for executing clang frontend actions..
Fri, Oct 13, 1:57 AM

Thu, Oct 12

ioeric updated the diff for D34272: [Tooling] A new framework for executing clang frontend actions..
  • Added ToolResults interface and moved classes to right files.
Thu, Oct 12, 11:09 AM

Tue, Oct 10

ioeric accepted D38402: [clang-refactor] Apply source replacements.

lgtm

Tue, Oct 10, 1:59 PM
ioeric updated the diff for D34272: [Tooling] A new framework for executing clang frontend actions..
  • Merged with origin/master
Tue, Oct 10, 7:26 AM
ioeric accepted D38723: [clang-rename] Don't add prefix qualifiers to the declaration and definition of the renamed symbol..

Lg with nits.

Tue, Oct 10, 6:48 AM
ioeric committed rL315309: Revert "[Modules TS] Module ownership semantics for redeclarations.".
Revert "[Modules TS] Module ownership semantics for redeclarations."
Tue, Oct 10, 6:10 AM
ioeric committed rL315308: Revert "[Modules TS] Avoid computing the linkage of the enclosing DeclContext….
Revert "[Modules TS] Avoid computing the linkage of the enclosing DeclContext…
Tue, Oct 10, 6:00 AM

Tue, Oct 3

ioeric added inline comments to D38402: [clang-refactor] Apply source replacements.
Tue, Oct 3, 12:22 AM

Sun, Oct 1

ioeric accepted D37856: [refactor] add support for refactoring options.

Looks good with some nits.

Sun, Oct 1, 3:31 PM

Tue, Sep 26

ioeric accepted D37976: [docs][refactor] add refactoring engine design documentation.

Thanks for the documentation! Now we just need to try to keep it up-to-date ;)

Tue, Sep 26, 3:29 PM
ioeric accepted D37681: [refactor] Simplify the interface and remove some template magic.

@klimek Have you got a chance to take a look?

Tue, Sep 26, 3:29 PM

Sep 19 2017

ioeric added a comment to D37856: [refactor] add support for refactoring options.

Sorry for the delay (most of us are OOO this week).

Sep 19 2017, 4:21 PM

Sep 13 2017

ioeric added a comment to D37681: [refactor] Simplify the interface and remove some template magic.

This is very nice! Thanks!

Sep 13 2017, 1:58 PM

Sep 11 2017

ioeric added a comment to D36574: [refactor] add clang-refactor tool with initial testing support and local-rename action.

Feel free to land the patch now if comments are addressed.

Sep 11 2017, 6:07 AM

Sep 8 2017

ioeric accepted D37618: Use CommonOptionsParser in clang-refactor.

Lgtm

Sep 8 2017, 3:19 AM
ioeric added a comment to D36574: [refactor] add clang-refactor tool with initial testing support and local-rename action.

Please wait for Manuel's reply before landing the patch ;-)

Sep 8 2017, 1:26 AM
ioeric accepted D36574: [refactor] add clang-refactor tool with initial testing support and local-rename action.

I think this is ready to go.

Sep 8 2017, 1:24 AM

Sep 7 2017

ioeric added inline comments to D36574: [refactor] add clang-refactor tool with initial testing support and local-rename action.
Sep 7 2017, 1:29 AM

Sep 6 2017

ioeric added inline comments to D36574: [refactor] add clang-refactor tool with initial testing support and local-rename action.
Sep 6 2017, 5:38 AM
ioeric added inline comments to D36574: [refactor] add clang-refactor tool with initial testing support and local-rename action.
Sep 6 2017, 2:50 AM

Sep 5 2017

ioeric added inline comments to D36574: [refactor] add clang-refactor tool with initial testing support and local-rename action.
Sep 5 2017, 2:37 AM

Sep 4 2017

ioeric added inline comments to D36574: [refactor] add clang-refactor tool with initial testing support and local-rename action.
Sep 4 2017, 3:41 AM

Aug 31 2017

ioeric accepted D37291: [refactor] Use a RefactoringResultConsumer instead of tagged refactoring rule classes.

@klimek Manuel, would you like to take a look? This addresses your comment https://reviews.llvm.org/D36075#854075

Aug 31 2017, 7:16 AM
ioeric added inline comments to D37291: [refactor] Use a RefactoringResultConsumer instead of tagged refactoring rule classes.
Aug 31 2017, 5:51 AM

Aug 30 2017

ioeric added inline comments to D37291: [refactor] Use a RefactoringResultConsumer instead of tagged refactoring rule classes.
Aug 30 2017, 7:51 AM

Aug 29 2017

ioeric accepted D37210: [refactor] add a refactoring action rule that returns symbol occurrences.

Lgtm

Aug 29 2017, 12:36 AM

Aug 28 2017

ioeric accepted D36075: [refactor] Initial support for refactoring action rules .

Thanks for the changes! Lgtm with a few nits.

Aug 28 2017, 2:07 AM

Aug 24 2017

ioeric added inline comments to D36075: [refactor] Initial support for refactoring action rules .
Aug 24 2017, 9:20 AM
ioeric added a comment to D36075: [refactor] Initial support for refactoring action rules .

Thanks for the changes! The code is much clearer.

Aug 24 2017, 3:43 AM

Aug 18 2017

ioeric added a comment to D36075: [refactor] Initial support for refactoring action rules .

This is great work and definitely a lot to digest! ;) Some high-level comments for the first round.

Aug 18 2017, 9:41 AM

Aug 1 2017

ioeric accepted D36149: [Tooling] Add LLVM_NODISCARD to Replacements::merge.

Thanks!!!

Aug 1 2017, 7:22 AM
ioeric accepted D35012: [refactor] Add the AST source selection component.

Yep. Lgtm!

Aug 1 2017, 3:20 AM

Jul 31 2017

ioeric committed rL309548: Added `applyAtomicChanges` function..
Added `applyAtomicChanges` function.
Jul 31 2017, 2:23 AM
ioeric closed D30777: Added `applyAtomicChanges` function. by committing rL309548: Added `applyAtomicChanges` function..
Jul 31 2017, 2:23 AM
ioeric updated the diff for D30777: Added `applyAtomicChanges` function..
  • Merged with origin/master
Jul 31 2017, 1:47 AM
ioeric updated subscribers of D30777: Added `applyAtomicChanges` function..
Jul 31 2017, 1:27 AM

Jul 17 2017

ioeric added a comment to D35012: [refactor] Add the AST source selection component.

Some nits.

Jul 17 2017, 9:16 AM

Jul 10 2017

ioeric committed rL307551: Avoid white spaces in file names. NFC.
Avoid white spaces in file names. NFC
Jul 10 2017, 9:42 AM
ioeric committed rL307550: [LLVM] Get rid of white spaces in file names in a DebugInfo test. NFC.
[LLVM] Get rid of white spaces in file names in a DebugInfo test. NFC
Jul 10 2017, 9:42 AM
ioeric closed D35203: Avoid white spaces in file names. NFC by committing rL307551: Avoid white spaces in file names. NFC.
Jul 10 2017, 9:42 AM
ioeric closed D35206: [LLVM] Get rid of white spaces in file names in a DebugInfo test. NFC by committing rL307550: [LLVM] Get rid of white spaces in file names in a DebugInfo test. NFC.
Jul 10 2017, 9:42 AM
ioeric created D35206: [LLVM] Get rid of white spaces in file names in a DebugInfo test. NFC.
Jul 10 2017, 8:59 AM
ioeric created D35203: Avoid white spaces in file names. NFC.
Jul 10 2017, 8:39 AM

Jun 28 2017

ioeric added a comment to D34696: [refactor] Move clang-rename to Clang.

The main thing I'm concerned about is having the main code in core, but having all tests in tools-extra. I think if we go that route we should also move clang-rename and its tests to core. Thoughts?

Jun 28 2017, 6:39 AM

Jun 16 2017

ioeric updated subscribers of D34272: [Tooling] A new framework for executing clang frontend actions..
Jun 16 2017, 2:40 AM
ioeric updated the summary of D34272: [Tooling] A new framework for executing clang frontend actions..
Jun 16 2017, 2:37 AM
ioeric created D34272: [Tooling] A new framework for executing clang frontend actions..
Jun 16 2017, 2:36 AM
ioeric added a comment to D33560: [clang-format] Add option to specify explicit config file.

The patch has "Context not available" issue (i.e. I couldn't expand to see code around the changes). Could you re-upload the diff?

Jun 16 2017, 1:27 AM
ioeric added a comment to D34252: Add arbitrary file/path support to clang-format style file selection.

Hi Dan, thanks for the patch! D33560, which adds the same feature, is already under review :)

Jun 16 2017, 1:26 AM
ioeric added a reviewer for D33560: [clang-format] Add option to specify explicit config file: ioeric.
Jun 16 2017, 1:19 AM

Jun 6 2017

ioeric added inline comments to D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting..
Jun 6 2017, 5:10 AM
ioeric accepted D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting..

Lgtm.

Jun 6 2017, 4:28 AM
ioeric added a reviewer for D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.: ioeric.
Jun 6 2017, 4:07 AM

May 10 2017

ioeric committed rL302624: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks
May 10 2017, 1:02 AM
ioeric closed D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks by committing rL302624: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks.
May 10 2017, 1:01 AM

May 4 2017

ioeric committed rL302141: Revert "IR: Use pointers instead of GUIDs to represent edges in the module….
Revert "IR: Use pointers instead of GUIDs to represent edges in the module…
May 4 2017, 5:19 AM
ioeric committed rL302140: Revert "IR: Use pointers instead of GUIDs to represent edges in the module….
Revert "IR: Use pointers instead of GUIDs to represent edges in the module…
May 4 2017, 5:02 AM