Page MenuHomePhabricator

ioeric (Eric Liu)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 12 2016, 3:46 AM (175 w, 4 d)
Roles
Administrator

Recent Activity

Fri, Jun 14

sanaanajjar231288 awarded rL326548: [clangd:vscode] Bump clangd-vscode version to 0.0.4. a Burninate token.
Fri, Jun 14, 5:19 AM

Apr 17 2019

ioeric added inline comments to D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion..
Apr 17 2019, 7:06 AM · Restricted Project
ioeric accepted D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion..

lgtm

Apr 17 2019, 6:43 AM · Restricted Project
ioeric accepted D60316: [clangd] Include insertion: require header guards, drop other heuristics, treat .def like .inc..
Apr 17 2019, 1:53 AM · Restricted Project, Restricted Project

Apr 16 2019

ioeric committed rG417c88940959: [clangd] Check file path of declaring header when deciding whether to insert… (authored by ioeric).
[clangd] Check file path of declaring header when deciding whether to insert…
Apr 16 2019, 7:35 AM
ioeric committed rCTE358496: [clangd] Check file path of declaring header when deciding whether to insert….
[clangd] Check file path of declaring header when deciding whether to insert…
Apr 16 2019, 7:34 AM
ioeric committed rL358496: [clangd] Check file path of declaring header when deciding whether to insert….
[clangd] Check file path of declaring header when deciding whether to insert…
Apr 16 2019, 7:34 AM
ioeric closed D60687: [clangd] Check file path of declaring header when deciding whether to insert include..
Apr 16 2019, 7:34 AM · Restricted Project, Restricted Project
ioeric added inline comments to D60687: [clangd] Check file path of declaring header when deciding whether to insert include..
Apr 16 2019, 1:59 AM · Restricted Project, Restricted Project

Apr 15 2019

ioeric committed rG9ef03dd20a58: [clangd] Wait for compile command in ASTWorker instead of ClangdServer (authored by ioeric).
[clangd] Wait for compile command in ASTWorker instead of ClangdServer
Apr 15 2019, 5:31 AM
ioeric committed rCTE358400: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
[clangd] Wait for compile command in ASTWorker instead of ClangdServer
Apr 15 2019, 5:30 AM
ioeric committed rL358400: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
[clangd] Wait for compile command in ASTWorker instead of ClangdServer
Apr 15 2019, 5:30 AM
ioeric closed D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
Apr 15 2019, 5:30 AM · Restricted Project
ioeric updated the diff for D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
  • use sync runAddDocument in test
Apr 15 2019, 5:29 AM · Restricted Project
ioeric added inline comments to D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
Apr 15 2019, 5:02 AM · Restricted Project
ioeric updated the diff for D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
  • address comments
Apr 15 2019, 5:02 AM · Restricted Project
ioeric created D60687: [clangd] Check file path of declaring header when deciding whether to insert include..
Apr 15 2019, 4:42 AM · Restricted Project, Restricted Project
ioeric updated the diff for D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
  • Only return compile command (instead of FileInputs) from AST worker.
Apr 15 2019, 2:38 AM · Restricted Project
ioeric committed rGdc8d8fb20b88: [Lookup] Invisible decls should not be ambiguous when renaming. (authored by ioeric).
[Lookup] Invisible decls should not be ambiguous when renaming.
Apr 15 2019, 1:46 AM
ioeric committed rL358378: [Lookup] Invisible decls should not be ambiguous when renaming..
[Lookup] Invisible decls should not be ambiguous when renaming.
Apr 15 2019, 1:45 AM
ioeric committed rC358378: [Lookup] Invisible decls should not be ambiguous when renaming..
[Lookup] Invisible decls should not be ambiguous when renaming.
Apr 15 2019, 1:44 AM
ioeric closed D60257: [Lookup] Invisible decls should not be ambiguous when renaming..
Apr 15 2019, 1:44 AM · Restricted Project

Apr 12 2019

ioeric added inline comments to D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
Apr 12 2019, 11:36 AM · Restricted Project
ioeric added inline comments to D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
Apr 12 2019, 11:36 AM · Restricted Project
ioeric added inline comments to D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
Apr 12 2019, 10:28 AM · Restricted Project
ioeric updated the diff for D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
  • address comments
Apr 12 2019, 8:10 AM · Restricted Project
ioeric added inline comments to D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
Apr 12 2019, 8:10 AM · Restricted Project
ioeric updated the diff for D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
  • Add missing comment to TUScheduler.h
Apr 12 2019, 5:40 AM · Restricted Project
ioeric updated the diff for D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
  • address review comments
Apr 12 2019, 5:39 AM · Restricted Project
ioeric added inline comments to D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
Apr 12 2019, 5:39 AM · Restricted Project
ioeric added inline comments to D60257: [Lookup] Invisible decls should not be ambiguous when renaming..
Apr 12 2019, 4:53 AM · Restricted Project
ioeric updated the diff for D60257: [Lookup] Invisible decls should not be ambiguous when renaming..
  • Add test comment.
Apr 12 2019, 4:53 AM · Restricted Project
ioeric requested changes to D60316: [clangd] Include insertion: require header guards, drop other heuristics, treat .def like .inc..

in case you missed this patch :)

Apr 12 2019, 4:47 AM · Restricted Project, Restricted Project
ioeric created D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer.
Apr 12 2019, 3:56 AM · Restricted Project

Apr 11 2019

ioeric accepted D59639: [clangd] Print template arguments helper.

lgtm

Apr 11 2019, 4:53 AM · Restricted Project, Restricted Project
ioeric committed rG00d99bd1c4ad: [clangd] Use identifiers in file as completion candidates when build is not… (authored by ioeric).
[clangd] Use identifiers in file as completion candidates when build is not…
Apr 11 2019, 2:38 AM
ioeric committed rL358159: [clangd] Use identifiers in file as completion candidates when build is not….
[clangd] Use identifiers in file as completion candidates when build is not…
Apr 11 2019, 2:38 AM
ioeric committed rCTE358159: [clangd] Use identifiers in file as completion candidates when build is not….
[clangd] Use identifiers in file as completion candidates when build is not…
Apr 11 2019, 2:38 AM
ioeric closed D60126: [clangd] Use identifiers in file as completion candidates when build is not ready..
Apr 11 2019, 2:38 AM · Restricted Project
ioeric added a reviewer for D60257: [Lookup] Invisible decls should not be ambiguous when renaming.: ilya-biryukov.
Apr 11 2019, 2:38 AM · Restricted Project
ioeric updated the diff for D60126: [clangd] Use identifiers in file as completion candidates when build is not ready..
  • address comments
Apr 11 2019, 2:32 AM · Restricted Project
ioeric added inline comments to D60126: [clangd] Use identifiers in file as completion candidates when build is not ready..
Apr 11 2019, 1:32 AM · Restricted Project
ioeric updated the diff for D60126: [clangd] Use identifiers in file as completion candidates when build is not ready..
  • address review comments
Apr 11 2019, 1:32 AM · Restricted Project

Apr 10 2019

ioeric accepted D60503: [clangd] Don't insert extra namespace qualifiers when Sema gets lost..

Feel free to land this. I'll rebase D60126 on this when it's in.

Apr 10 2019, 6:34 AM · Restricted Project, Restricted Project
ioeric accepted D60500: [clangd] Refactor speculateCompletionFilter and also extract scope..

lgtm

Apr 10 2019, 3:30 AM · Restricted Project, Restricted Project

Apr 9 2019

ioeric added a comment to D60126: [clangd] Use identifiers in file as completion candidates when build is not ready..

Thanks for the review!

Apr 9 2019, 6:50 AM · Restricted Project
ioeric updated the diff for D60126: [clangd] Use identifiers in file as completion candidates when build is not ready..
  • minor cleanup
Apr 9 2019, 6:50 AM · Restricted Project
ioeric updated the diff for D60126: [clangd] Use identifiers in file as completion candidates when build is not ready..
  • address review comments
Apr 9 2019, 6:44 AM · Restricted Project

Apr 8 2019

ioeric added a comment to D60409: [clangd] Add -header-insertion=never flag to disable include insertion in code completion.

lg!

Apr 8 2019, 8:18 AM · Restricted Project, Restricted Project
ioeric committed rCTE357916: [clangd] Add fallback mode for code completion when compile command or preamble….
[clangd] Add fallback mode for code completion when compile command or preamble…
Apr 8 2019, 7:57 AM
ioeric committed rGdd028259374f: [clangd] Add fallback mode for code completion when compile command or preamble… (authored by ioeric).
[clangd] Add fallback mode for code completion when compile command or preamble…
Apr 8 2019, 7:52 AM
ioeric committed rL357916: [clangd] Add fallback mode for code completion when compile command or preamble….
[clangd] Add fallback mode for code completion when compile command or preamble…
Apr 8 2019, 7:51 AM
ioeric closed D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready..
Apr 8 2019, 7:51 AM · Restricted Project, Restricted Project
ioeric added inline comments to D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready..
Apr 8 2019, 7:07 AM · Restricted Project, Restricted Project
ioeric updated the diff for D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready..
  • address review comments
Apr 8 2019, 7:07 AM · Restricted Project, Restricted Project
ioeric added a reviewer for D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.: sammccall.
Apr 8 2019, 6:42 AM · Restricted Project, Restricted Project
ioeric updated the diff for D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready..
  • Fix unit test
Apr 8 2019, 6:42 AM · Restricted Project, Restricted Project
ioeric planned changes to D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready..

Oops, forgot to update tests...

Apr 8 2019, 6:16 AM · Restricted Project, Restricted Project
ioeric added inline comments to D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready..
Apr 8 2019, 6:16 AM · Restricted Project, Restricted Project
ioeric updated the diff for D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready..
  • split out the compile command change.
Apr 8 2019, 6:15 AM · Restricted Project, Restricted Project
ioeric added inline comments to D60316: [clangd] Include insertion: require header guards, drop other heuristics, treat .def like .inc..
Apr 8 2019, 5:31 AM · Restricted Project, Restricted Project

Apr 4 2019

ioeric added a comment to D59376: [LibTooling] Add Transformer, a library for source-to-source transformations..

Per @ioeric's suggestion: why not move the helper into Tooling/Refactoring/ExtendedRange.h?
If it's in ToolingRefactoring, both stencil and transformer can access it.

For external users, a dependency on either ToolingCore or ToolingRefactoring should be fine, since they're fine with a dependency on Tooling already.

This sounds perfect. Can I do the same for the future additions -- small, focused libraries for each group of functions? I just want to be sure that we don't regret the name "ExtendedRange" when I need to add the next batch.

Apr 4 2019, 7:12 AM · Restricted Project, Restricted Project
ioeric accepted D60263: [clang-format] Preserve include blocks in ObjC Google style.
Apr 4 2019, 6:34 AM · Restricted Project, Restricted Project
ioeric added inline comments to D60263: [clang-format] Preserve include blocks in ObjC Google style.
Apr 4 2019, 6:21 AM · Restricted Project, Restricted Project
ioeric created D60257: [Lookup] Invisible decls should not be ambiguous when renaming..
Apr 4 2019, 3:30 AM · Restricted Project

Apr 3 2019

ioeric added a child revision for D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.: D60126: [clangd] Use identifiers in file as completion candidates when build is not ready..
Apr 3 2019, 7:50 AM · Restricted Project, Restricted Project
ioeric added a parent revision for D60126: [clangd] Use identifiers in file as completion candidates when build is not ready.: D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready..
Apr 3 2019, 7:50 AM · Restricted Project
ioeric accepted D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK.
Apr 3 2019, 7:40 AM · Restricted Project
ioeric added inline comments to D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK.
Apr 3 2019, 7:40 AM · Restricted Project
ioeric committed rG0f4d5f85191c: [clang-format] Regroup #includes into blocks for Google style (authored by ioeric).
[clang-format] Regroup #includes into blocks for Google style
Apr 3 2019, 2:24 AM
ioeric committed rL357567: [clang-format] Regroup #includes into blocks for Google style.
[clang-format] Regroup #includes into blocks for Google style
Apr 3 2019, 2:24 AM
ioeric committed rC357567: [clang-format] Regroup #includes into blocks for Google style.
[clang-format] Regroup #includes into blocks for Google style
Apr 3 2019, 2:23 AM
ioeric closed D60116: [clang-format] Regroup #includes into blocks for Google style.
Apr 3 2019, 2:23 AM · Restricted Project
ioeric updated the diff for D60116: [clang-format] Regroup #includes into blocks for Google style.
  • Improved test.
Apr 3 2019, 1:45 AM · Restricted Project

Apr 2 2019

ioeric created D60126: [clangd] Use identifiers in file as completion candidates when build is not ready..
Apr 2 2019, 6:29 AM · Restricted Project
ioeric updated the diff for D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready..
  • Rebase
Apr 2 2019, 6:14 AM · Restricted Project, Restricted Project
ioeric created D60116: [clang-format] Regroup #includes into blocks for Google style.
Apr 2 2019, 2:22 AM · Restricted Project

Mar 28 2019

ioeric updated the diff for D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready..
  • address review comments.
Mar 28 2019, 11:00 AM · Restricted Project, Restricted Project
ioeric added a comment to D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready..

I think this option should be configurable (and off by default) for the transition period. A few reasons to do so:

  • Before we have an actual implementation of fallback completions, the current behavior (waiting for the first preamble) actually seems like a better experience than returning empty results.
  • Some clients do this kind of fallback on their own (e.g. VSCode), so until we can provide actually semantically interesting results (anything more than identifier-based really, e.g. keyword completions) we would be better off keeping it off.
  • We can still test it if it's off by flipping the corresponding flag in the test code.
  • Would make rollout easier (clients can flip the flag back and forth and make sure it does not break stuff for them)
Mar 28 2019, 11:00 AM · Restricted Project, Restricted Project

Mar 26 2019

ioeric created D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready..
Mar 26 2019, 2:37 AM · Restricted Project, Restricted Project

Mar 25 2019

ioeric accepted D59764: [pp-trace] Use ClangTool in pp-trace, NFC.
Mar 25 2019, 5:31 AM · Restricted Project
ioeric accepted D59364: [clangd] Add std subnamespace symbols to the symbol map..
Mar 25 2019, 3:36 AM · Restricted Project

Mar 22 2019

ioeric accepted D59700: Make clang-move use same file naming convention as other tools.

lgtm

Mar 22 2019, 9:18 AM · Restricted Project, Restricted Project
ioeric added inline comments to D59639: [clangd] Print template arguments helper.
Mar 22 2019, 8:32 AM · Restricted Project, Restricted Project
ioeric accepted D59683: [Tooling] Avoid working-dir races in AllTUsToolExecutor.

Neat!

Mar 22 2019, 3:26 AM · Restricted Project, Restricted Project

Mar 21 2019

ioeric added inline comments to D59639: [clangd] Print template arguments helper.
Mar 21 2019, 10:47 AM · Restricted Project, Restricted Project
ioeric added a comment to D59640: [clangd] Add TemplateArgumentList into Symbol.

should we update YAML?

Mar 21 2019, 10:42 AM · Restricted Project, Restricted Project
ioeric added inline comments to D59639: [clangd] Print template arguments helper.
Mar 21 2019, 10:35 AM · Restricted Project, Restricted Project

Mar 20 2019

ioeric added inline comments to D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex.
Mar 20 2019, 6:21 AM · Restricted Project

Mar 19 2019

ioeric committed rG52b49ab3fd92: [Tooling] Add more scope specifiers until spelling is not ambiguous. (authored by ioeric).
[Tooling] Add more scope specifiers until spelling is not ambiguous.
Mar 19 2019, 3:12 AM
ioeric committed rC356446: [Tooling] Add more scope specifiers until spelling is not ambiguous..
[Tooling] Add more scope specifiers until spelling is not ambiguous.
Mar 19 2019, 3:11 AM
ioeric committed rL356446: [Tooling] Add more scope specifiers until spelling is not ambiguous..
[Tooling] Add more scope specifiers until spelling is not ambiguous.
Mar 19 2019, 3:11 AM
ioeric closed D59487: [Tooling] Add more scope specifiers until spelling is not ambiguous..
Mar 19 2019, 3:11 AM · Restricted Project, Restricted Project
ioeric added a comment to D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex.

I don't follow why this can over-count, FileIndex keeps only one RefSlab per each file, so we can't over-count? Did you mean it will be more than #TUs ?

Yes. This is how Symbol::References is described in its documentation. If we want to change/expand the semantic, we need to make it clear in the documentation as well.

Mar 19 2019, 2:36 AM · Restricted Project

Mar 18 2019

ioeric added inline comments to D59487: [Tooling] Add more scope specifiers until spelling is not ambiguous..
Mar 18 2019, 9:34 AM · Restricted Project, Restricted Project
ioeric created D59487: [Tooling] Add more scope specifiers until spelling is not ambiguous..
Mar 18 2019, 6:01 AM · Restricted Project, Restricted Project
ioeric added a comment to D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex.

I'm not sure if FileIndex is the correct layer to make decision about how References is calculated. Currently, we have two use cases in clangd 1) one slab per TU and 2) one slab per file. It seems to me that we would want different strategies for the two use cases, so it might make sense to make this configurable in FileIndex. And in one case, we have References ~= # of TUs, and in the other case, we would have References ~= # of files. This can over-count References in the second case. It might be fine as an approximation (if there is no better solution), but we should definitely document it (e.g. in BackgroundIndex).

Mar 18 2019, 3:24 AM · Restricted Project

Mar 15 2019

ioeric added inline comments to D59300: [clangd] Tune the fuzzy-matching algorithm.
Mar 15 2019, 3:42 AM · Restricted Project, Restricted Project
ioeric accepted D59300: [clangd] Tune the fuzzy-matching algorithm.

(The result looks great)

Mar 15 2019, 3:42 AM · Restricted Project, Restricted Project
ioeric accepted D59382: Rename directory housing clang-change-namespace to be eponymous.
Mar 15 2019, 3:26 AM · Restricted Project