ioeric (Eric Liu)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 12 2016, 3:46 AM (100 w, 4 d)
Roles
Administrator

Recent Activity

Today

ioeric added a dependent revision for D42111: [Tooling] Don't deduplicate tool results in the All-TUs executor.: D42113: [clangd] Deduplicate symbols collected in global-symbol-builder tool..
Tue, Jan 16, 10:04 AM
ioeric added a dependency for D42113: [clangd] Deduplicate symbols collected in global-symbol-builder tool.: D42111: [Tooling] Don't deduplicate tool results in the All-TUs executor..
Tue, Jan 16, 10:04 AM
ioeric created D42113: [clangd] Deduplicate symbols collected in global-symbol-builder tool..
Tue, Jan 16, 10:03 AM
ioeric created D42111: [Tooling] Don't deduplicate tool results in the All-TUs executor..
Tue, Jan 16, 9:56 AM

Thu, Jan 11

ioeric created D41946: [clangd] Add support for different file URI schemas..
Thu, Jan 11, 5:44 AM

Wed, Jan 10

ioeric committed rCTE322194: Add a missing dependency for r322192.
Add a missing dependency for r322192
Wed, Jan 10, 7:12 AM
ioeric committed rL322194: Add a missing dependency for r322192.
Add a missing dependency for r322192
Wed, Jan 10, 7:12 AM
ioeric committed rL322193: [clangd] Add more filters for collected symbols..
[clangd] Add more filters for collected symbols.
Wed, Jan 10, 6:59 AM
ioeric committed rCTE322193: [clangd] Add more filters for collected symbols..
[clangd] Add more filters for collected symbols.
Wed, Jan 10, 6:59 AM
ioeric closed D41823: [clangd] Add more filters for collected symbols..
Wed, Jan 10, 6:59 AM
ioeric added inline comments to D41823: [clangd] Add more filters for collected symbols..
Wed, Jan 10, 6:54 AM
ioeric updated the diff for D41823: [clangd] Add more filters for collected symbols..
Wed, Jan 10, 6:54 AM

Tue, Jan 9

ioeric committed rCTE322116: Try to fix build failure caused by r322097.
Try to fix build failure caused by r322097
Tue, Jan 9, 12:28 PM
ioeric committed rL322116: Try to fix build failure caused by r322097.
Try to fix build failure caused by r322097
Tue, Jan 9, 12:28 PM
ioeric updated the diff for D41823: [clangd] Add more filters for collected symbols..
  • Rebase on origin/master
Tue, Jan 9, 9:40 AM
ioeric committed rL322097: [clangd] Add more symbol information for code completion..
[clangd] Add more symbol information for code completion.
Tue, Jan 9, 9:33 AM
ioeric committed rCTE322097: [clangd] Add more symbol information for code completion..
[clangd] Add more symbol information for code completion.
Tue, Jan 9, 9:33 AM
ioeric closed D41345: [clangd] Add more symbol information for code completion..
Tue, Jan 9, 9:33 AM
ioeric updated the diff for D41345: [clangd] Add more symbol information for code completion..
  • Addrress review comment.
Tue, Jan 9, 9:30 AM
ioeric committed rCTE322084: [clangd] Use ToolExecutor to write the global-symbol-builder tool..
[clangd] Use ToolExecutor to write the global-symbol-builder tool.
Tue, Jan 9, 7:23 AM
ioeric committed rL322084: [clangd] Use ToolExecutor to write the global-symbol-builder tool..
[clangd] Use ToolExecutor to write the global-symbol-builder tool.
Tue, Jan 9, 7:23 AM
ioeric closed D41730: [clangd] Use ToolExecutor to write the global-symbol-builder tool..
Tue, Jan 9, 7:23 AM
ioeric added a comment to D41823: [clangd] Add more filters for collected symbols..

Thanks for the reviews!

Tue, Jan 9, 7:10 AM
ioeric updated the diff for D41823: [clangd] Add more filters for collected symbols..
  • Addressed comments.
  • Merged with origin/master
  • Merge with diff base.
Tue, Jan 9, 7:08 AM
ioeric added inline comments to D41345: [clangd] Add more symbol information for code completion..
Tue, Jan 9, 6:49 AM
ioeric updated the diff for D41345: [clangd] Add more symbol information for code completion..
Tue, Jan 9, 6:48 AM
ioeric added a comment to D41730: [clangd] Use ToolExecutor to write the global-symbol-builder tool..

This makes SymbolCollector (production code) depend on YAML (explicitly experimental), as well as on Tooling interfaces.
At least we should invert this by making the thing passed to SymbolCollector a function<void(const Symbol&)> or so.

Thanks for the catch! I completely missed these perspectives...

Moreover, it's unfortunate we'd need to change SymbolCollector at all. Currently it's a nice abstraction that does one thing (AST -> SymbolSlab), now we're making it do two things. It can't be for scalability reasons - there's no problem fitting all the symbols from a TU in memory. So why do we need to do this?
I don't really understand the ToolExecutor interfaces well, but ISTM overriding SymbolIndexActionFactory::runInvocation to flush the symbols in the slab out to the ExecutionContext would allow you to use SymbolCollector unchanged?

WrapperFrontendAction is helpful here. All changes have been moved into the tool now. PTAL

Tue, Jan 9, 4:46 AM
ioeric updated the diff for D41730: [clangd] Use ToolExecutor to write the global-symbol-builder tool..

Address review comment: move all ToolExecutor and YAML-specific logics out of SymbolCollector.

Tue, Jan 9, 4:40 AM
ioeric updated the diff for D41345: [clangd] Add more symbol information for code completion..
  • Minor cleanup.
Tue, Jan 9, 3:47 AM
ioeric updated the diff for D41345: [clangd] Add more symbol information for code completion..
  • [clangd] Address review comments; made Detail a pointer.
Tue, Jan 9, 3:43 AM

Mon, Jan 8

ioeric added a dependency for D41823: [clangd] Add more filters for collected symbols.: D41345: [clangd] Add more symbol information for code completion..
Mon, Jan 8, 8:35 AM
ioeric added a dependent revision for D41345: [clangd] Add more symbol information for code completion.: D41823: [clangd] Add more filters for collected symbols..
Mon, Jan 8, 8:35 AM
ioeric created D41823: [clangd] Add more filters for collected symbols..
Mon, Jan 8, 8:34 AM

Fri, Jan 5

ioeric accepted D41668: [clangd] Add static index for the global code completion..

lgtm

Fri, Jan 5, 5:59 AM
ioeric added inline comments to D41730: [clangd] Use ToolExecutor to write the global-symbol-builder tool..
Fri, Jan 5, 2:54 AM
ioeric updated the diff for D41730: [clangd] Use ToolExecutor to write the global-symbol-builder tool..

Address review comments.

Fri, Jan 5, 2:54 AM
ioeric committed rL321864: Add a tool executor that runs actions on all TUs in the compilation database..
Add a tool executor that runs actions on all TUs in the compilation database.
Fri, Jan 5, 2:33 AM
ioeric committed rC321864: Add a tool executor that runs actions on all TUs in the compilation database..
Add a tool executor that runs actions on all TUs in the compilation database.
Fri, Jan 5, 2:33 AM
ioeric closed D41729: Add a tool executor that runs actions on all TUs in the compilation database..
Fri, Jan 5, 2:33 AM
ioeric added inline comments to D41729: Add a tool executor that runs actions on all TUs in the compilation database..
Fri, Jan 5, 2:32 AM
ioeric updated the diff for D41729: Add a tool executor that runs actions on all TUs in the compilation database..

Address review comments.

Fri, Jan 5, 2:32 AM
ioeric added inline comments to D41668: [clangd] Add static index for the global code completion..
Fri, Jan 5, 1:12 AM

Thu, Jan 4

ioeric added a dependency for D41730: [clangd] Use ToolExecutor to write the global-symbol-builder tool.: D41729: Add a tool executor that runs actions on all TUs in the compilation database..
Thu, Jan 4, 9:36 AM
ioeric added a dependent revision for D41729: Add a tool executor that runs actions on all TUs in the compilation database.: D41730: [clangd] Use ToolExecutor to write the global-symbol-builder tool..
Thu, Jan 4, 9:36 AM
ioeric created D41730: [clangd] Use ToolExecutor to write the global-symbol-builder tool..
Thu, Jan 4, 9:35 AM
ioeric created D41729: Add a tool executor that runs actions on all TUs in the compilation database..
Thu, Jan 4, 9:20 AM

Wed, Jan 3

ioeric requested changes to D39050: Add index-while-building support to Clang.

(I think I forgot to update the patch status :)

Wed, Jan 3, 5:54 AM
ioeric added inline comments to D41668: [clangd] Add static index for the global code completion..
Wed, Jan 3, 3:30 AM
ioeric added inline comments to D41345: [clangd] Add more symbol information for code completion..
Wed, Jan 3, 3:08 AM
ioeric updated the diff for D41345: [clangd] Add more symbol information for code completion..
  • Merge with origin/master. Use Arena for symbol details.
Wed, Jan 3, 2:48 AM
ioeric added a comment to D41668: [clangd] Add static index for the global code completion..

You have mentioned that YAML data source is experimental only in the patch summary, but we should also mention this in the code.

Wed, Jan 3, 12:22 AM
ioeric added inline comments to D41668: [clangd] Add static index for the global code completion..
Wed, Jan 3, 12:21 AM

Wed, Dec 20

ioeric added inline comments to D41345: [clangd] Add more symbol information for code completion..
Wed, Dec 20, 1:42 PM
ioeric updated the diff for D41345: [clangd] Add more symbol information for code completion..
  • Merged with origin/master
  • Addressed some more comments.
  • Add new fields to YAML.
Wed, Dec 20, 1:42 PM
ioeric committed rL321193: [clangd] Pull CodeCompletionString handling logic into its own file and add….
[clangd] Pull CodeCompletionString handling logic into its own file and add…
Wed, Dec 20, 9:25 AM
ioeric committed rCTE321193: [clangd] Pull CodeCompletionString handling logic into its own file and add….
[clangd] Pull CodeCompletionString handling logic into its own file and add…
Wed, Dec 20, 9:25 AM
ioeric closed D41450: [clangd] Pull CodeCompletionString handling logic into its own file and add unit test..
Wed, Dec 20, 9:25 AM
ioeric committed rCTE321192: [clangd] Remove an unused lambda capture..
[clangd] Remove an unused lambda capture.
Wed, Dec 20, 9:23 AM
ioeric committed rL321192: [clangd] Remove an unused lambda capture..
[clangd] Remove an unused lambda capture.
Wed, Dec 20, 9:23 AM
ioeric added a dependency for D41345: [clangd] Add more symbol information for code completion.: D41450: [clangd] Pull CodeCompletionString handling logic into its own file and add unit test..
Wed, Dec 20, 8:12 AM
ioeric added a dependent revision for D41450: [clangd] Pull CodeCompletionString handling logic into its own file and add unit test.: D41345: [clangd] Add more symbol information for code completion..
Wed, Dec 20, 8:12 AM
ioeric added a comment to D41345: [clangd] Add more symbol information for code completion..

Thanks for the review!

Wed, Dec 20, 8:12 AM
ioeric updated the diff for D41345: [clangd] Add more symbol information for code completion..
  • Merge with origin/master
  • Fixed an error in merge
  • Make documentation etc optional in symbols
  • Merge remote-tracking branch 'origin/master' into symbol
  • Merge branch 'index-completion' into symbol
  • Address review comments; merge with D41450.
Wed, Dec 20, 8:07 AM
ioeric created D41450: [clangd] Pull CodeCompletionString handling logic into its own file and add unit test..
Wed, Dec 20, 7:14 AM
ioeric accepted D41393: Allow to apply cherry-picks when building Docker images..

lg after code comment is added.

Wed, Dec 20, 6:26 AM
ioeric accepted D41432: [clangd] Switch xrefs and documenthighlight to annotated-code unit tests. NFC.

lgtm! This is amazing!

Wed, Dec 20, 3:10 AM
ioeric added inline comments to D41393: Allow to apply cherry-picks when building Docker images..
Wed, Dec 20, 2:21 AM
ioeric added inline comments to D41393: Allow to apply cherry-picks when building Docker images..
Wed, Dec 20, 1:45 AM
ioeric committed rCTE321157: [clangd] Igore cases in index fuzzy find..
[clangd] Igore cases in index fuzzy find.
Wed, Dec 20, 1:30 AM
ioeric committed rL321157: [clangd] Igore cases in index fuzzy find..
[clangd] Igore cases in index fuzzy find.
Wed, Dec 20, 1:30 AM

Tue, Dec 19

ioeric added inline comments to D39050: Add index-while-building support to Clang.
Tue, Dec 19, 3:08 PM
ioeric added a comment to D39050: Add index-while-building support to Clang.

Thanks a lot for further cleaning up the patch! It is now much easier to review. I really appreciate it!

Tue, Dec 19, 3:01 PM
ioeric committed rL321094: [clangd] Supress a log warning by putting it behind a condition..
[clangd] Supress a log warning by putting it behind a condition.
Tue, Dec 19, 10:11 AM
ioeric committed rCTE321094: [clangd] Supress a log warning by putting it behind a condition..
[clangd] Supress a log warning by putting it behind a condition.
Tue, Dec 19, 10:11 AM
ioeric committed rL321092: [clangd] Build dynamic index and use it for code completion..
[clangd] Build dynamic index and use it for code completion.
Tue, Dec 19, 10:01 AM
ioeric committed rCTE321092: [clangd] Build dynamic index and use it for code completion..
[clangd] Build dynamic index and use it for code completion.
Tue, Dec 19, 10:01 AM
ioeric closed D41289: [clangd] Build dynamic index and use it for code completion..
Tue, Dec 19, 10:01 AM
ioeric added a comment to D41289: [clangd] Build dynamic index and use it for code completion..

Thanks for the quick review!

Tue, Dec 19, 9:57 AM
ioeric updated the diff for D41289: [clangd] Build dynamic index and use it for code completion..
  • Address review comments.
Tue, Dec 19, 9:57 AM
ioeric updated the diff for D41289: [clangd] Build dynamic index and use it for code completion..
  • Merge with D41289.
  • Merge with origin/master
Tue, Dec 19, 8:59 AM
ioeric committed rCTE321083: [clangd] Index-based code completion..
[clangd] Index-based code completion.
Tue, Dec 19, 8:51 AM
ioeric committed rL321083: [clangd] Index-based code completion..
[clangd] Index-based code completion.
Tue, Dec 19, 8:51 AM
ioeric closed D41281: [clangd] Index-based code completion..
Tue, Dec 19, 8:51 AM
ioeric added inline comments to D41281: [clangd] Index-based code completion..
Tue, Dec 19, 8:30 AM
ioeric updated the diff for D41281: [clangd] Index-based code completion..
  • Add a FIXME for Index in code completion options.
Tue, Dec 19, 8:28 AM
ioeric updated the diff for D41281: [clangd] Index-based code completion..
  • Move implementations around to make code easier to read.
Tue, Dec 19, 8:23 AM
ioeric abandoned D20496: [include-fixer] Added find-stl-symbols to retrieve symbols (with the correct include header name) from C++ standard STL headers..
Tue, Dec 19, 5:54 AM
ioeric abandoned D24380: [migrate-tool] Framework for a codebase-dependent migration tool..
Tue, Dec 19, 5:53 AM
ioeric abandoned D26610: Testing phabricator with sample diff. Do not submit!.
Tue, Dec 19, 5:53 AM
ioeric abandoned D27058: Testing phabricator email.
Tue, Dec 19, 5:53 AM
ioeric updated the diff for D41281: [clangd] Index-based code completion..
  • Fixed a bug when completing scope that starts with '::'.
  • Diff base on origin/master
Tue, Dec 19, 5:48 AM
ioeric updated the diff for D41289: [clangd] Build dynamic index and use it for code completion..
  • Merge with updated D41281
  • Fix broken merge
Tue, Dec 19, 4:22 AM
ioeric updated the diff for D41281: [clangd] Index-based code completion..
  • Merged with origin/master
  • Merged with D41351
Tue, Dec 19, 3:57 AM
ioeric committed rL321067: [clangd] Support filtering by fixing scopes in fuzzyFind..
[clangd] Support filtering by fixing scopes in fuzzyFind.
Tue, Dec 19, 3:38 AM
ioeric committed rCTE321067: [clangd] Support filtering by fixing scopes in fuzzyFind..
[clangd] Support filtering by fixing scopes in fuzzyFind.
Tue, Dec 19, 3:38 AM
ioeric closed D41367: [clangd] Support filtering by fixing scopes in fuzzyFind..
Tue, Dec 19, 3:38 AM
ioeric updated the diff for D41367: [clangd] Support filtering by fixing scopes in fuzzyFind..
  • Minor cleanup
Tue, Dec 19, 3:36 AM
ioeric updated the diff for D41367: [clangd] Support filtering by fixing scopes in fuzzyFind..
  • Address a few more comments.
Tue, Dec 19, 3:33 AM
ioeric accepted D41351: [clangd] Expose offset <-> LSP position functions, and fix bugs.

lgtm

Tue, Dec 19, 3:26 AM
ioeric added a comment to D41367: [clangd] Support filtering by fixing scopes in fuzzyFind..

Thanks for the review!

Tue, Dec 19, 3:03 AM