ioeric (Eric Liu)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 12 2016, 3:46 AM (144 w, 5 d)
Roles
Administrator

Recent Activity

Today

ioeric accepted D54781: [clangd] Add 'Switch header/source' command in clangd-vscode.

Could you run clang-format on the changed lines?

Thu, Nov 22, 1:41 AM

Yesterday

ioeric updated the diff for D54800: [clangd] Cleanup: stop passing around list of supported URI schemes..
  • remove unused include
Wed, Nov 21, 7:28 AM
ioeric created D54800: [clangd] Cleanup: stop passing around list of supported URI schemes..
Wed, Nov 21, 7:27 AM

Thu, Nov 15

ioeric accepted D54519: [clangd] Fix no results returned for global symbols in dexp.
Thu, Nov 15, 1:50 AM
ioeric added inline comments to D54519: [clangd] Fix no results returned for global symbols in dexp.
Thu, Nov 15, 1:16 AM

Wed, Nov 14

ioeric accepted D54309: [AST] Allow limiting the scope of common AST traversals (getParents, RAV)..

lgtm

Wed, Nov 14, 1:52 AM

Mon, Nov 12

ioeric updated subscribers of D54309: [AST] Allow limiting the scope of common AST traversals (getParents, RAV)..

The new API and the refactoring look good to me. Just a nit and a question.

Mon, Nov 12, 8:47 AM
ioeric accepted D54430: [clangd] Don't show all refs results if -name is ambiguous in dexp..
Mon, Nov 12, 8:39 AM
ioeric accepted D54427: [clangd] Allow symbols from AnyScope in dexp..
Mon, Nov 12, 8:03 AM
ioeric added inline comments to D54427: [clangd] Allow symbols from AnyScope in dexp..
Mon, Nov 12, 7:46 AM
ioeric committed rL346648: [clangd] Remember to serialize AnyScope in FuzzyFindRequest json..
[clangd] Remember to serialize AnyScope in FuzzyFindRequest json.
Mon, Nov 12, 4:26 AM
ioeric committed rCTE346648: [clangd] Remember to serialize AnyScope in FuzzyFindRequest json..
[clangd] Remember to serialize AnyScope in FuzzyFindRequest json.
Mon, Nov 12, 4:26 AM
ioeric added inline comments to D52273: [clangd] Initial implementation of expected types.
Mon, Nov 12, 2:10 AM

Fri, Nov 9

ioeric added inline comments to D54300: [clangd] Respect shouldIndexFile when collecting symbols..
Fri, Nov 9, 7:22 AM
ioeric added inline comments to D54300: [clangd] Respect shouldIndexFile when collecting symbols..
Fri, Nov 9, 4:46 AM

Tue, Nov 6

ioeric committed rCTE346224: [clangd] Deduplicate query scopes..
[clangd] Deduplicate query scopes.
Tue, Nov 6, 3:21 AM
ioeric committed rL346224: [clangd] Deduplicate query scopes..
[clangd] Deduplicate query scopes.
Tue, Nov 6, 3:21 AM
ioeric closed D54105: [clangd] Deduplicate query scopes..
Tue, Nov 6, 3:21 AM
ioeric added inline comments to D54106: [clangd] Limit the index-returned results in dexp..
Tue, Nov 6, 3:14 AM
ioeric committed rL346223: [clangd] Get rid of QueryScopes.empty() == AnyScope special case..
[clangd] Get rid of QueryScopes.empty() == AnyScope special case.
Tue, Nov 6, 3:11 AM
ioeric committed rCTE346223: [clangd] Get rid of QueryScopes.empty() == AnyScope special case..
[clangd] Get rid of QueryScopes.empty() == AnyScope special case.
Tue, Nov 6, 3:11 AM
ioeric closed D53933: [clangd] Get rid of QueryScopes.empty() == AnyScope special case..
Tue, Nov 6, 3:11 AM
ioeric updated the diff for D53933: [clangd] Get rid of QueryScopes.empty() == AnyScope special case..
  • rebase
Tue, Nov 6, 3:08 AM
ioeric committed rCTE346221: [clangd] auto-index stores symbols per-file instead of per-TU..
[clangd] auto-index stores symbols per-file instead of per-TU.
Tue, Nov 6, 2:58 AM
ioeric committed rL346221: [clangd] auto-index stores symbols per-file instead of per-TU..
[clangd] auto-index stores symbols per-file instead of per-TU.
Tue, Nov 6, 2:58 AM
ioeric closed D53433: [clangd] auto-index stores symbols per-file instead of per-TU..
Tue, Nov 6, 2:57 AM
ioeric updated the diff for D53433: [clangd] auto-index stores symbols per-file instead of per-TU..
  • Rebase
Tue, Nov 6, 2:54 AM
ioeric added a comment to D54077: [clangd] Implemented DraftFileSystem.

Someone mentioned to me that the interaction-between-features argument wasn't clear here:

  • we don't currently update diagnostics for A.cc when A.h is edited
  • we should, this seems more obvious & important than what we do with drafts
  • this interacts badly with using draft state, as this patch proposes - there are too many edits

FWIW, one of my "pain points" when using vim+clangd is:

  • Edit A.h in a buffer (and forget to save)
  • Switch to A.cc in another buffer
  • Realize that I forgot to save A.h
  • Go back to save A.h
  • Jump back to A.cc file.
Tue, Nov 6, 1:32 AM

Mon, Nov 5

ioeric added inline comments to D53433: [clangd] auto-index stores symbols per-file instead of per-TU..
Mon, Nov 5, 8:42 AM
ioeric added inline comments to D54106: [clangd] Limit the index-returned results in dexp..
Mon, Nov 5, 8:14 AM
ioeric updated the diff for D53933: [clangd] Get rid of QueryScopes.empty() == AnyScope special case..
  • Remove addressed FIXME.
Mon, Nov 5, 7:56 AM
ioeric abandoned D53926: [clangd] Only add global scope to completion query scopes for TU context..
Mon, Nov 5, 7:55 AM
ioeric created D54105: [clangd] Deduplicate query scopes..
Mon, Nov 5, 7:54 AM
ioeric accepted D54104: [Tooling] Correct the total number of files being processed when `filter` is provided..
Mon, Nov 5, 6:55 AM
ioeric added a comment to D54092: [Tooling] Add "-filter" option to AllTUsExecution.

maybe add a test?

Mon, Nov 5, 5:02 AM
ioeric accepted D54092: [Tooling] Add "-filter" option to AllTUsExecution.
Mon, Nov 5, 5:01 AM
ioeric added inline comments to D54092: [Tooling] Add "-filter" option to AllTUsExecution.
Mon, Nov 5, 3:22 AM
ioeric added inline comments to D54092: [Tooling] Add "-filter" option to AllTUsExecution.
Mon, Nov 5, 1:55 AM
ioeric accepted D53958: [Tooling] Produce diagnostics for missing input files..
Mon, Nov 5, 1:31 AM

Wed, Oct 31

ioeric planned changes to D53926: [clangd] Only add global scope to completion query scopes for TU context..

I got the behavior of printNamespaceScope wrong in this patch. Will update.

Wed, Oct 31, 8:28 AM
ioeric updated the diff for D53926: [clangd] Only add global scope to completion query scopes for TU context..
  • revert wrong comment
Wed, Oct 31, 8:23 AM
ioeric updated the diff for D53926: [clangd] Only add global scope to completion query scopes for TU context..
  • Clarify documentation for printNamespaceScope
Wed, Oct 31, 8:16 AM
ioeric added inline comments to D53926: [clangd] Only add global scope to completion query scopes for TU context..
Wed, Oct 31, 7:47 AM
ioeric created D53933: [clangd] Get rid of QueryScopes.empty() == AnyScope special case..
Wed, Oct 31, 7:23 AM
ioeric added a comment to D53433: [clangd] auto-index stores symbols per-file instead of per-TU..

Made some more changes to make the code work in multiple threads (add mutex for digests, take snapshot of digests for each run etc). PTAL

Wed, Oct 31, 6:23 AM
ioeric updated the diff for D53433: [clangd] auto-index stores symbols per-file instead of per-TU..
  • Merged with multi-threading changes. Added mutex for file digests.
Wed, Oct 31, 6:21 AM
ioeric created D53926: [clangd] Only add global scope to completion query scopes for TU context..
Wed, Oct 31, 3:59 AM

Tue, Oct 30

ioeric added inline comments to D53433: [clangd] auto-index stores symbols per-file instead of per-TU..
Tue, Oct 30, 5:51 AM
ioeric updated the diff for D53433: [clangd] auto-index stores symbols per-file instead of per-TU..
  • address review comments.
Tue, Oct 30, 5:51 AM

Mon, Oct 29

ioeric updated the diff for D53433: [clangd] auto-index stores symbols per-file instead of per-TU..
  • minor cleanup and a friendly ping.
Mon, Oct 29, 2:53 AM

Wed, Oct 24

ioeric committed rCTE345140: [clangd] Downrank members from base class.
[clangd] Downrank members from base class
Wed, Oct 24, 6:47 AM
ioeric committed rL345140: [clangd] Downrank members from base class.
[clangd] Downrank members from base class
Wed, Oct 24, 6:47 AM
ioeric closed D53638: [clangd] Downrank members from base class.
Wed, Oct 24, 6:47 AM
ioeric added inline comments to D53638: [clangd] Downrank members from base class.
Wed, Oct 24, 6:39 AM
ioeric updated the diff for D53638: [clangd] Downrank members from base class.
  • adjust parameter
Wed, Oct 24, 6:39 AM
ioeric accepted D53571: [clangd] Don't show base class versions of members as completions..

The diff seems to be wrong. Please rebase.

Wed, Oct 24, 6:29 AM
ioeric accepted D53399: [clangd] Ensure that we reply to each call exactly once. NFC (I think!).
Wed, Oct 24, 6:27 AM
ioeric updated the diff for D53638: [clangd] Downrank members from base class.
  • restore accidentally removed test.
Wed, Oct 24, 6:16 AM
ioeric added inline comments to D53638: [clangd] Downrank members from base class.
Wed, Oct 24, 6:16 AM
ioeric added inline comments to D53399: [clangd] Ensure that we reply to each call exactly once. NFC (I think!).
Wed, Oct 24, 6:14 AM
ioeric added a comment to D53571: [clangd] Don't show base class versions of members as completions..

Keep required quailifier machinery around though, for cross-ns completion.

Do we have cross-ns completion in sema?

Wed, Oct 24, 6:06 AM
ioeric committed rC345135: [CodeComplete] Expose InBaseClass signal in code completion results..
[CodeComplete] Expose InBaseClass signal in code completion results.
Wed, Oct 24, 6:00 AM
ioeric committed rL345135: [CodeComplete] Expose InBaseClass signal in code completion results..
[CodeComplete] Expose InBaseClass signal in code completion results.
Wed, Oct 24, 5:59 AM
ioeric closed D53635: [CodeComplete] Expose InBaseClass signal in code completion results..
Wed, Oct 24, 5:59 AM
ioeric updated the diff for D53635: [CodeComplete] Expose InBaseClass signal in code completion results..
  • Rebase
Wed, Oct 24, 5:45 AM
ioeric added inline comments to D53635: [CodeComplete] Expose InBaseClass signal in code completion results..
Wed, Oct 24, 5:45 AM
ioeric updated the diff for D53635: [CodeComplete] Expose InBaseClass signal in code completion results..
  • move tags into case.
Wed, Oct 24, 5:44 AM
ioeric added a dependency for D53638: [clangd] Downrank members from base class: D53635: [CodeComplete] Expose InBaseClass signal in code completion results..
Wed, Oct 24, 3:45 AM
ioeric added a dependent revision for D53635: [CodeComplete] Expose InBaseClass signal in code completion results.: D53638: [clangd] Downrank members from base class.
Wed, Oct 24, 3:45 AM
ioeric created D53638: [clangd] Downrank members from base class.
Wed, Oct 24, 3:45 AM
ioeric updated the diff for D53635: [CodeComplete] Expose InBaseClass signal in code completion results..
  • Add tests for the new flag.
Wed, Oct 24, 3:35 AM
ioeric added a comment to D53635: [CodeComplete] Expose InBaseClass signal in code completion results..

LG, but could we add a test for the new flag it by printing it in PrintingCodeCompleteConsumer::ProcessCodeCompleteResults() and adding corresponding tests to clang/test/CodeCompletion?

Similar to how it's done for the Hidden flag in the results

Wed, Oct 24, 3:35 AM
ioeric created D53635: [CodeComplete] Expose InBaseClass signal in code completion results..
Wed, Oct 24, 2:59 AM

Tue, Oct 23

ioeric accepted D53587: [clangd] Truncate SymbolID to 16 bytes..

We should watch out for the downstream backward compatibility.

Tue, Oct 23, 10:13 AM
ioeric added inline comments to D53433: [clangd] auto-index stores symbols per-file instead of per-TU..
Tue, Oct 23, 8:54 AM
ioeric updated the diff for D53433: [clangd] auto-index stores symbols per-file instead of per-TU..
  • address review comments
  • merged with origin/master
  • Cleanup
Tue, Oct 23, 8:54 AM
ioeric accepted D53439: [clangd] Remove caching of compilation database commands..
Tue, Oct 23, 4:55 AM

Oct 22 2018

ioeric added inline comments to D53433: [clangd] auto-index stores symbols per-file instead of per-TU..
Oct 22 2018, 9:04 AM
ioeric retitled D53433: [clangd] auto-index stores symbols per-file instead of per-TU. from [clangd] *Prototype* auto-index stores symbols per-file instead of per-TU. to [clangd] auto-index stores symbols per-file instead of per-TU..
Oct 22 2018, 9:04 AM
ioeric updated the diff for D53433: [clangd] auto-index stores symbols per-file instead of per-TU..
  • address review comments
  • minor cleanup
Oct 22 2018, 9:04 AM
ioeric committed rCTE344912: [clangd] Support URISchemes configuration in BackgroundIndex..
[clangd] Support URISchemes configuration in BackgroundIndex.
Oct 22 2018, 8:40 AM
ioeric committed rL344912: [clangd] Support URISchemes configuration in BackgroundIndex..
[clangd] Support URISchemes configuration in BackgroundIndex.
Oct 22 2018, 8:40 AM
ioeric closed D53503: [clangd] Support URISchemes configuration in BackgroundIndex..
Oct 22 2018, 8:40 AM
ioeric created D53503: [clangd] Support URISchemes configuration in BackgroundIndex..
Oct 22 2018, 8:22 AM
ioeric committed rCTE344897: [change-namespace] Enhance detection of conflicting namespaces..
[change-namespace] Enhance detection of conflicting namespaces.
Oct 22 2018, 5:51 AM
ioeric committed rL344897: [change-namespace] Enhance detection of conflicting namespaces..
[change-namespace] Enhance detection of conflicting namespaces.
Oct 22 2018, 5:51 AM
ioeric closed D53489: [change-namespace] Enhance detection of conflicting namespaces..
Oct 22 2018, 5:51 AM
ioeric created D53489: [change-namespace] Enhance detection of conflicting namespaces..
Oct 22 2018, 3:28 AM
ioeric committed rL344889: [CodeComplete] Fix accessibility of protected members when accessing members….
[CodeComplete] Fix accessibility of protected members when accessing members…
Oct 22 2018, 1:52 AM
ioeric committed rC344889: [CodeComplete] Fix accessibility of protected members when accessing members….
[CodeComplete] Fix accessibility of protected members when accessing members…
Oct 22 2018, 1:52 AM
ioeric closed D53369: [CodeComplete] Fix accessibility of protected members when accessing members implicitly..
Oct 22 2018, 1:49 AM

Oct 19 2018

ioeric created D53433: [clangd] auto-index stores symbols per-file instead of per-TU..
Oct 19 2018, 5:21 AM
ioeric added inline comments to D53399: [clangd] Ensure that we reply to each call exactly once. NFC (I think!).
Oct 19 2018, 3:14 AM
ioeric accepted D53404: [clangd] Set workspace root when initializing ClangdServer, disallow mutation..
Oct 19 2018, 1:45 AM

Oct 18 2018

ioeric accepted D53398: [clangd] Enforce rules around "initialize" request, and create ClangdServer lazily..

Looks good!

Oct 18 2018, 6:57 AM
ioeric updated the summary of D53369: [CodeComplete] Fix accessibility of protected members when accessing members implicitly..
Oct 18 2018, 5:44 AM
ioeric committed rCTE344736: [clangd] Names that are not spelled in source code are reserved..
[clangd] Names that are not spelled in source code are reserved.
Oct 18 2018, 5:25 AM
ioeric committed rL344736: [clangd] Names that are not spelled in source code are reserved..
[clangd] Names that are not spelled in source code are reserved.
Oct 18 2018, 5:25 AM
ioeric closed D53374: [clangd] Names that are not spelled in source code are reserved..
Oct 18 2018, 5:25 AM
ioeric updated the diff for D53374: [clangd] Names that are not spelled in source code are reserved..
  • add isImplementationDetail helper
Oct 18 2018, 5:22 AM