Page MenuHomePhabricator

[Tooling] Migrated APIs that take ownership of objects to unique_ptr
ClosedPublic

Authored by gribozavr on Aug 29 2019, 9:43 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

gribozavr created this revision.Aug 29 2019, 9:43 AM

This is missing documentation changes.

Could you point out such places? I tried to remove "takes ownership" comments which became redundant.

And this likely would be good to mention in releasenotes.

Will add.

lebedev.ri added a comment.EditedAug 29 2019, 10:12 AM

This is missing documentation changes.

Could you point out such places? I tried to remove "takes ownership" comments which became redundant.

See my two original patches.

And this likely would be good to mention in releasenotes.

Will add.

ilya-biryukov accepted this revision.Aug 30 2019, 2:11 AM

LGTM from my side.

This revision is now accepted and ready to land.Aug 30 2019, 2:11 AM
gribozavr updated this revision to Diff 218046.Aug 30 2019, 2:19 AM

Updated documentation and added release notes.

This is missing documentation changes.

Could you point out such places? I tried to remove "takes ownership" comments which became redundant.

See my two original patches.

Thanks, fixed docs.

And this likely would be good to mention in releasenotes.

Will add.

Added release notes.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2019, 2:31 AM