These instructions initialize a predicate vector from a pattern/immediate.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
| test/MC/AArch64/SVE/ptrue-diagnostics.s | ||
|---|---|---|
| 8 ↗ | (On Diff #128913) | Can we not give the user a more specific error message? |
| test/MC/AArch64/SVE/ptrue.s | ||
| 175 ↗ | (On Diff #128913) | Maybe these should test the corner cases? If I understand the document, 14 to 28 should be legal? |
| test/MC/AArch64/SVE/ptrues.s | ||
| 6 ↗ | (On Diff #128913) | I can see a few examples of using llvm-objdump for disassembly, but why not just use llvm-mc? |
Comment Actions
- Added more specific diagnostic message for invalid predicate patterns.
- Extended test cases.
| test/MC/AArch64/SVE/ptrue-diagnostics.s | ||
|---|---|---|
| 8 ↗ | (On Diff #128913) | Thanks for the suggestion, I've created a new diagnostic for this. |
| test/MC/AArch64/SVE/ptrue.s | ||
| 175 ↗ | (On Diff #128913) | Agreed, I've added these now. |
| test/MC/AArch64/SVE/ptrues.s | ||
| 6 ↗ | (On Diff #128913) | I've sort of copied this approach from other MC tests and the effect should be the same. Also, I wasn't able to pipe the output from llvm-mc back into llvm-mc, similar to how this is done for llvm-objdump. |