This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SVE] Asm: PTRUE and PTRUES instructions
ClosedPublic

Authored by sdesmalen on Jan 8 2018, 5:56 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sdesmalen created this revision.Jan 8 2018, 5:56 AM
samparker added inline comments.Jan 11 2018, 2:56 AM
test/MC/AArch64/SVE/ptrue-diagnostics.s
8 ↗(On Diff #128913)

Can we not give the user a more specific error message?

test/MC/AArch64/SVE/ptrue.s
175 ↗(On Diff #128913)

Maybe these should test the corner cases? If I understand the document, 14 to 28 should be legal?

test/MC/AArch64/SVE/ptrues.s
6 ↗(On Diff #128913)

I can see a few examples of using llvm-objdump for disassembly, but why not just use llvm-mc?

sdesmalen updated this revision to Diff 130588.Jan 19 2018, 4:48 AM
  • Added more specific diagnostic message for invalid predicate patterns.
  • Extended test cases.
sdesmalen added inline comments.Jan 19 2018, 4:51 AM
test/MC/AArch64/SVE/ptrue-diagnostics.s
8 ↗(On Diff #128913)

Thanks for the suggestion, I've created a new diagnostic for this.

test/MC/AArch64/SVE/ptrue.s
175 ↗(On Diff #128913)

Agreed, I've added these now.

test/MC/AArch64/SVE/ptrues.s
6 ↗(On Diff #128913)

I've sort of copied this approach from other MC tests and the effect should be the same. Also, I wasn't able to pipe the output from llvm-mc back into llvm-mc, similar to how this is done for llvm-objdump.

samparker accepted this revision.Jan 19 2018, 5:51 AM

Great, LGTM. Thanks!

This revision is now accepted and ready to land.Jan 19 2018, 5:51 AM
fhahn added a comment.Jan 22 2018, 2:00 AM

LGTM, thanks

This revision was automatically updated to reflect the committed changes.