Page MenuHomePhabricator

Add the llvm asan support

Authored by andrew on Apr 18 2017, 9:27 AM.



Add the llvm support for running AddressSanitizer on FreeBSD on AArch64. The address space is larger on FreeBSD/arm64, create a new constant for this.

Diff Detail


Event Timeline

andrew created this revision.Apr 18 2017, 9:27 AM

The compiler-rt bits are in D32172

kubamracek added a subscriber: kubamracek.
andrew added a comment.May 9 2017, 9:01 AM

Is there any feedback on this?

peter.smith edited edge metadata.May 10 2017, 1:14 AM

I think you probably have the wrong set of reviewers. From a pure change perspective it looks fine to me, however I think you'll need to check with someone who knows the details of BSD and someone in the ASAN team to check it over stylistically. Perhaps Ed Maste on the BSD side and I think Kosta Serebryany on the sanitizer side. The same comment applies to D32172 . Apologies I don't feel like I can offer much help in reviewing.

The change looks fine to me from a FreeBSD perspective

emaste added a reviewer: kcc.Nov 20 2017, 6:26 PM
vitalybuka accepted this revision.Feb 25 2020, 11:56 AM
This revision is now accepted and ready to land.Feb 25 2020, 11:56 AM