Page MenuHomePhabricator

kubamracek (Kuba (Brecka) Mracek)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 3 2014, 6:35 AM (328 w, 5 d)

Recent Activity

Mon, Aug 31

kubamracek added a comment to D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags.

Specifically, I don't want to mess with the setup for Android and/or non-Darwin crosscompiling, because I have no way of testing that.

Mon, Aug 31, 1:31 PM · Restricted Project
kubamracek added a comment to D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags.

Also, I understand that the code in question isn't best already, but I don't have the bandwidth to refactor and test any more extensive changes. I'm only trying to address the problem of getting -arch arm64 / arm64e passed into tests, otherwise we're testing the wrong thing. Let's focus on that, please.

Mon, Aug 31, 1:30 PM · Restricted Project
kubamracek added inline comments to D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags.
Mon, Aug 31, 1:28 PM · Restricted Project
kubamracek added a comment to D86377: [tsan] Use large address space mapping on Apple Silicon Macs.

@dvyukov Any feedback here, or is this OK to go in?

Mon, Aug 31, 12:48 PM · Restricted Project

Sun, Aug 30

kubamracek accepted D86106: [lldb] avoid assert in threadsanitizer tests on linux.

Looks good for get rid of the test failure.

Sun, Aug 30, 8:52 PM · Restricted Project

Tue, Aug 25

kubamracek committed rGe713b0ecbc89: [tsan] On arm64e, strip out ptrauth bits from incoming PCs (authored by kubamracek).
[tsan] On arm64e, strip out ptrauth bits from incoming PCs
Tue, Aug 25, 12:00 PM
kubamracek closed D86378: [tsan] On arm64e, strip out ptrauth bits from incoming PCs.
Tue, Aug 25, 11:59 AM · Restricted Project
kubamracek updated the diff for D86377: [tsan] Use large address space mapping on Apple Silicon Macs.
Tue, Aug 25, 11:57 AM · Restricted Project
kubamracek added a comment to D86378: [tsan] On arm64e, strip out ptrauth bits from incoming PCs.

Great finds, thanks! I've updated the missing places. I'm leaving the Go parts alone, for now, as Go isn't using ptrauth.

Tue, Aug 25, 9:35 AM · Restricted Project
kubamracek updated the diff for D86378: [tsan] On arm64e, strip out ptrauth bits from incoming PCs.
Tue, Aug 25, 9:34 AM · Restricted Project
kubamracek updated the diff for D86377: [tsan] Use large address space mapping on Apple Silicon Macs.
Tue, Aug 25, 8:18 AM · Restricted Project

Fri, Aug 21

kubamracek added a comment to D86377: [tsan] Use large address space mapping on Apple Silicon Macs.

Definitely agree that this is very annoying to read. I think it would be best if we were able to change the ifdef to use something like “HAS_48_BIT_ADDRESS_SPACE” and compute that bool separately. @yln, @dvyukov WDYT?

Fri, Aug 21, 7:24 PM · Restricted Project
kubamracek added a comment to D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags.

Ah, sorry :) The context is that any test config for arm64 or arm64e isn’t getting the right -arch flag passed in.

Fri, Aug 21, 7:20 PM · Restricted Project
kubamracek requested review of D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags.
Fri, Aug 21, 3:19 PM · Restricted Project
kubamracek requested review of D86378: [tsan] On arm64e, strip out ptrauth bits from incoming PCs.
Fri, Aug 21, 3:09 PM · Restricted Project
kubamracek requested review of D86377: [tsan] Use large address space mapping on Apple Silicon Macs.
Fri, Aug 21, 3:07 PM · Restricted Project

Aug 19 2020

kubamracek accepted D85389: Fix bug where we request a shadow memory one page larger than necessary..
Aug 19 2020, 9:23 AM · Restricted Project
kubamracek added a comment to D85389: Fix bug where we request a shadow memory one page larger than necessary..

This looks reasonable, but just for verification, could you post the "before" and "after" of the little shadow map printout from ASAN_OPTIONS=verbosity=1?

Aug 19 2020, 9:23 AM · Restricted Project

Aug 18 2020

kubamracek accepted D86103: [TSan][libdispatch] Ensure TSan dylib works on old systems.
Aug 18 2020, 5:59 PM · Restricted Project

Aug 17 2020

kubamracek added a comment to D86103: [TSan][libdispatch] Ensure TSan dylib works on old systems.

If we use #if !SANITIZER_MAC || defined(__MAC_10_14), do we still need the forward declarations and weak_import stuff?

Aug 17 2020, 6:19 PM · Restricted Project

Aug 14 2020

kubamracek accepted D85995: [TSan][libdispatch] Guard test execution on old platforms.

This looks good to me. Note that I was actually suggesting to avoid the dynamic_lookup + forward declare and requiring that the *SDK* is at least 10.14 to run tests (which is separate from your OS version). But this way it's even more compatible, so I think we should go with it.

Aug 14 2020, 2:15 PM · Restricted Project

Aug 13 2020

kubamracek accepted D85854: [TSan][libdispatch] Add interceptors for dispatch_async_and_wait().

LGTM. Maybe add an if to check if the 10.14-only API is available and just do nothing in the test otherwise?

Aug 13 2020, 7:57 PM · Restricted Project
kubamracek added a comment to D85854: [TSan][libdispatch] Add interceptors for dispatch_async_and_wait().

Does the testcase actually fail without the code change?

Aug 13 2020, 12:19 PM · Restricted Project
kubamracek added a reviewer for D85854: [TSan][libdispatch] Add interceptors for dispatch_async_and_wait(): dvyukov.
Aug 13 2020, 12:17 PM · Restricted Project

Aug 4 2020

kubamracek added a comment to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

If I read the output right, it seems that even before this change, running with TSan messes up the permissions argument. I think this may be some latent bug in glibc that is only triggered in unusual environments (like TSan). I found this comment at https://lkml.org/lkml/2014/10/30/812:

Aug 4 2020, 11:35 AM · Restricted Project

Aug 1 2020

kubamracek added a comment to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

...and could you also see if perhaps this change helps:

diff --git a/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp b/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
--- a/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
+++ b/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
@@ -137,7 +137,11 @@ const int PTHREAD_BARRIER_SERIAL_THREAD = -1;
 #endif
 const int MAP_FIXED = 0x10;
 typedef long long_t;
+#if SANITIZER_MAC || SANITIZER_FREEBSD || SANITIZER_NETBSD
 typedef __sanitizer::u16 mode_t;
+#else
+typedef __sanitizer::u32 mode_t;
+#endif
Aug 1 2020, 11:45 AM · Restricted Project

Jul 30 2020

kubamracek added a comment to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

I can provide you access to a PPC64LE machine or I can check the details myself if you can tell me exactly what to do and how.

Jul 30 2020, 6:14 PM · Restricted Project
kubamracek updated subscribers of D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

CC @simoatze, @wschmidt:

Would anyone with access to a Linux/PPC64 machine be willing to take a look if the open() syscall is receiving the right value (0600 from the testcase)?

Jul 30 2020, 12:11 PM · Restricted Project
kubamracek added a comment to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

Actually given the symptom, I'm thinking this could be a real problem with the variadic interceptor:

Jul 30 2020, 9:52 AM · Restricted Project
kubamracek committed rG1e8a9c3e026f: [tsan] Fixup for 1260a155: Move variadic-open.cpp test into Darwin/ directory (authored by kubamracek).
[tsan] Fixup for 1260a155: Move variadic-open.cpp test into Darwin/ directory
Jul 30 2020, 9:33 AM
kubamracek added a comment to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

This fails on Linux/PPC64: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/52026/steps/ninja%20check%201/logs/FAIL%3A%20ThreadSanitizer-powerpc64%3A%3A%20variadic-open.cpp

Jul 30 2020, 9:31 AM · Restricted Project
kubamracek committed rG1260a155c37f: [tsan] Fix the open and open64 interceptors to have correct declarations… (authored by kubamracek).
[tsan] Fix the open and open64 interceptors to have correct declarations…
Jul 30 2020, 9:01 AM
kubamracek closed D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).
Jul 30 2020, 9:01 AM · Restricted Project

Jul 29 2020

kubamracek added inline comments to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).
Jul 29 2020, 12:23 PM · Restricted Project
kubamracek added inline comments to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).
Jul 29 2020, 12:21 PM · Restricted Project

Jul 24 2020

kubamracek committed rG33d9c4109ac2: [tsan] Allow TSan in the Clang driver for Apple Silicon Macs (authored by kubamracek).
[tsan] Allow TSan in the Clang driver for Apple Silicon Macs
Jul 24 2020, 8:14 PM
kubamracek closed D84082: [tsan] Allow TSan in the Clang driver for Apple Silicon Macs.
Jul 24 2020, 8:14 PM · Restricted Project, Restricted Project
kubamracek created D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).
Jul 24 2020, 5:20 PM · Restricted Project

Jul 21 2020

kubamracek added a comment to D84082: [tsan] Allow TSan in the Clang driver for Apple Silicon Macs.

Let's handle simulators separately.

Jul 21 2020, 4:19 PM · Restricted Project, Restricted Project
kubamracek accepted D84262: Avoid failing a CHECK in `DlAddrSymbolizer::SymbolizePC`..
Jul 21 2020, 12:23 PM · Restricted Project

Jul 17 2020

kubamracek committed rG176a6e7abe33: [asan] Use dynamic shadow memory position on Apple Silicon macOS (authored by kubamracek).
[asan] Use dynamic shadow memory position on Apple Silicon macOS
Jul 17 2020, 5:40 PM
kubamracek closed D82912: [asan] Use dynamic shadow memory position on Apple Silicon macOS.
Jul 17 2020, 5:40 PM · Restricted Project, Restricted Project
Herald added a project to D84082: [tsan] Allow TSan in the Clang driver for Apple Silicon Macs: Restricted Project.
Jul 17 2020, 5:29 PM · Restricted Project, Restricted Project

Jul 14 2020

kubamracek committed rG2c1df94e4a14: Bring in stripWhitespace (authored by kubamracek).
Bring in stripWhitespace
Jul 14 2020, 4:31 PM
kubamracek committed rG2004d53690d8: [TextAPI] Teach TextAPI about arm64e (authored by cishida).
[TextAPI] Teach TextAPI about arm64e
Jul 14 2020, 4:31 PM
kubamracek committed rG805fd5335f73: [AArch64] Relax 'inbounds' requirement for llvm.ptrauth signed GEPs. (authored by kubamracek).
[AArch64] Relax 'inbounds' requirement for llvm.ptrauth signed GEPs.
Jul 14 2020, 4:31 PM

Jun 30 2020

kubamracek accepted D81705: [Sanitizer] Fix demangling for Swift symbol names.

Looks reasonable. Could you check that swift_demangle has been correctly returning NULL for a "long time" (a couple years at least)? I'm asking because we can run on older OS's.

Jun 30 2020, 5:23 PM · Restricted Project
kubamracek added reviewers for D82912: [asan] Use dynamic shadow memory position on Apple Silicon macOS: arphaman, dexonsmith.
Jun 30 2020, 2:41 PM · Restricted Project, Restricted Project
kubamracek created D82912: [asan] Use dynamic shadow memory position on Apple Silicon macOS.
Jun 30 2020, 2:09 PM · Restricted Project, Restricted Project

May 1 2020

kubamracek accepted D79132: [Darwin] Improve ASan diagnostics on arm64e with pointer auth.
May 1 2020, 5:09 PM · Restricted Project
kubamracek added a comment to D78942: [Darwin] Improve runtime OS version checks.

Overall LGTM - would be great to hear feedback from @eugenis though.

May 1 2020, 5:09 PM · Restricted Project
kubamracek added inline comments to D78942: [Darwin] Improve runtime OS version checks.
May 1 2020, 5:09 PM · Restricted Project
kubamracek added inline comments to D78942: [Darwin] Improve runtime OS version checks.
May 1 2020, 5:09 PM · Restricted Project
kubamracek added reviewers for D78942: [Darwin] Improve runtime OS version checks: kcc, eugenis.
May 1 2020, 5:09 PM · Restricted Project

Apr 20 2020

kubamracek accepted D78525: Unbreak ASan runtime in the simulators..
Apr 20 2020, 6:28 PM · Restricted Project

Apr 17 2020

kubamracek accepted D78409: [compiler-rt] Use --standalone when running tests on the iOS simulator.
Apr 17 2020, 8:12 PM · Restricted Project
kubamracek accepted D78179: [Darwin] Fix symbolization for recent simulator runtimes..
Apr 17 2020, 3:11 PM · Restricted Project

Apr 15 2020

kubamracek added inline comments to D78179: [Darwin] Fix symbolization for recent simulator runtimes..
Apr 15 2020, 1:13 PM · Restricted Project
kubamracek added inline comments to D78179: [Darwin] Fix symbolization for recent simulator runtimes..
Apr 15 2020, 10:24 AM · Restricted Project

Apr 8 2020

kubamracek added inline comments to D77706: [Darwin] Fix symbolization for recent simulator runtimes..
Apr 8 2020, 5:56 PM · Restricted Project
kubamracek added inline comments to D77696: [Darwin] Teach `AtosSymbolizerProcess` to work on a copy of the environment..
Apr 8 2020, 5:56 PM · Restricted Project
kubamracek added inline comments to D77696: [Darwin] Teach `AtosSymbolizerProcess` to work on a copy of the environment..
Apr 8 2020, 5:56 PM · Restricted Project

Apr 6 2020

kubamracek accepted D77623: [Darwin] Fix a bug where the symbolizer would examine the wrong process..
Apr 6 2020, 8:44 PM · Restricted Project
kubamracek accepted D77622: [Sanitizer Common] Show command used to launch symbolizer process at high verbosity level..

Nice.

Apr 6 2020, 8:10 PM · Restricted Project

Mar 18 2020

kubamracek accepted D76257: [TSan] Support pointer authentication in setjmp/longjmp interceptors.
Mar 18 2020, 11:26 AM · Restricted Project

Mar 5 2020

kubamracek created D75688: [TextAPI] Teach TextAPI about arm64e.
Mar 5 2020, 9:17 AM · Restricted Project

Jan 8 2020

kubamracek added a comment to D72305: [TSan] The "thread_terminate" event is delivered on the terminating thread.

I've mentioned this to Julian in person: The code change look good to me, but any changes in this piece of code need a high level of manual testing as this code is very critical and has potential for breaking something even with innocent changes like this.

Jan 8 2020, 10:40 AM · Restricted Project, Restricted Project

Dec 16 2019

kubamracek accepted D71559: [TSan][Darwin] Avoid calling pthread_self() before libpthread is initialized.
Dec 16 2019, 12:25 PM · Restricted Project, Restricted Project

Oct 7 2019

kubamracek closed D40032: [compiler-rt] Replace forkpty with posix_spawn.
Oct 7 2019, 4:48 AM · Restricted Project, Restricted Project
kubamracek closed D44246: [sanitizer] Generalize atomic_uint8_t, atomic_uint16_t, ... into a template. NFC..
Oct 7 2019, 4:30 AM · Restricted Project, Restricted Project

Aug 28 2019

kubamracek accepted D66915: [TSanRuntime] Upstream thread swift race detector..
Aug 28 2019, 5:02 PM · Restricted Project, Restricted Project

Aug 27 2019

kubamracek accepted D66826: [ASan] Make insertion of version mismatch guard configurable.
Aug 27 2019, 4:04 PM · Restricted Project

Aug 26 2019

kubamracek added a comment to D66616: [TSan] Add interceptors for mach_vm_[de]allocate.

Looks good to me. @dvyukov ?

Aug 26 2019, 4:07 PM · Restricted Project, Restricted Project

Aug 23 2019

kubamracek added inline comments to D66616: [TSan] Add interceptors for mach_vm_[de]allocate.
Aug 23 2019, 3:23 PM · Restricted Project, Restricted Project

Aug 14 2019

kubamracek accepted D65253: [sanitizer_common] Replace forkpty with posix_spawn on Darwin.

LGTM, even if it's just for Darwin now.

Aug 14 2019, 10:49 AM · Restricted Project, Restricted Project

Aug 9 2019

kubamracek accepted D65990: [Sanitizer][Darwin] Add interceptor for malloc_zone_from_ptr.
Aug 9 2019, 1:33 PM · Restricted Project, Restricted Project

Aug 1 2019

kubamracek committed rG2eceddfb3c43: Move macho-data-in-code.ll to X86/macho-data-in-code.ll (to only run when x86… (authored by kubamracek).
Move macho-data-in-code.ll to X86/macho-data-in-code.ll (to only run when x86…
Aug 1 2019, 9:53 AM
kubamracek committed rGa7c48b79a9d9: [llvm-objdump] Fix jumptable detection when disassembling Mach-O binaries (authored by kubamracek).
[llvm-objdump] Fix jumptable detection when disassembling Mach-O binaries
Aug 1 2019, 8:53 AM

Jul 30 2019

kubamracek updated the diff for D65491: [llvm-objdump] Fix jumptable detection when disassembling Mach-O binaries.

Adding test

Jul 30 2019, 9:26 PM · Restricted Project
kubamracek added a comment to D65253: [sanitizer_common] Replace forkpty with posix_spawn on Darwin.

Thanks! This looks like a great step in the right direction. An overall question first: Should we use posix_spawn for *all platforms*? IIRC, unifying the launch paths was discussed on mailing lists before and sounds desirable.

Jul 30 2019, 6:49 PM · Restricted Project, Restricted Project
kubamracek created D65491: [llvm-objdump] Fix jumptable detection when disassembling Mach-O binaries.
Jul 30 2019, 5:10 PM · Restricted Project

Jul 24 2019

kubamracek accepted D65235: CrashHandler: be careful about crashing while handling.

LGTM, thanks!

Jul 24 2019, 12:24 PM · Restricted Project

May 22 2019

kubamracek added a comment to D61259: AArch64: support arm64_32, an ILP32 slice for watchOS..

Looks like there's no reviewers set here. @t.p.northover who should review this?

May 22 2019, 1:09 PM · Restricted Project

May 8 2019

kubamracek added a comment to D61708: [TSan] Support `ignore_noninstrumented_modules` on Linux.

Nice, thanks. I don’t understand the ELF code so someone else should review it, but from my view this LGTM.

May 8 2019, 6:48 PM · Restricted Project, Restricted Project

Apr 17 2019

kubamracek committed rGe5e9a6be6a23: [lldb] Don't filter variable list when doing a lookup by mangled name in… (authored by kubamracek).
[lldb] Don't filter variable list when doing a lookup by mangled name in…
Apr 17 2019, 5:17 PM
kubamracek added a comment to D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables.

Okay. @jingham, any more comments, or is this okay to land?

Apr 17 2019, 10:52 AM · Restricted Project
kubamracek updated the diff for D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables.
Apr 17 2019, 10:23 AM · Restricted Project

Apr 16 2019

kubamracek added a comment to D58110: Support fiber API on macOS.

Sorry for the huge delay. @yln can you test this patch (that is passes all tests) and if yes, land it?

Apr 16 2019, 1:45 PM · Restricted Project, Restricted Project
kubamracek updated the diff for D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables.

Updating test to use run_to_source_breakpoint

Apr 16 2019, 11:30 AM · Restricted Project
kubamracek updated the diff for D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables.

Adding a test case.

Apr 16 2019, 10:46 AM · Restricted Project
kubamracek added a reviewer for D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables: labath.
Apr 16 2019, 9:02 AM · Restricted Project

Apr 15 2019

kubamracek accepted D60639: [TSan][libdispatch] Port gcd-sync-block-copy.mm to C++.
Apr 15 2019, 4:35 PM · Restricted Project, Restricted Project
kubamracek created D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables.
Apr 15 2019, 4:27 PM · Restricted Project
kubamracek added inline comments to D60639: [TSan][libdispatch] Port gcd-sync-block-copy.mm to C++.
Apr 15 2019, 10:25 AM · Restricted Project, Restricted Project
kubamracek added inline comments to D60575: [TSan][libdispatch] Use FileCheck's --implicit-check-not=....
Apr 15 2019, 10:25 AM · Restricted Project, Restricted Project

Apr 12 2019

kubamracek added a comment to D60575: [TSan][libdispatch] Use FileCheck's --implicit-check-not=....

I like this change, but there's no reason to apply it specifically to the Darwin tests, right? Can you apply it to all TSan tests?

Apr 12 2019, 1:05 PM · Restricted Project, Restricted Project
kubamracek accepted D60591: [TSan][libdispatch] Replace NSTemporaryDirectory in tests.
Apr 12 2019, 1:04 PM · Restricted Project, Restricted Project

Apr 10 2019

kubamracek accepted D60477: [TSan][libdispatch] Replace usage of NSMutableData with stack array.
Apr 10 2019, 6:32 PM · Restricted Project, Restricted Project
kubamracek accepted D60476: [TSan][libdispatch] Change test to have two simultaneous timers.
Apr 10 2019, 6:23 PM · Restricted Project, Restricted Project
kubamracek accepted D60475: [TSan][libdispatch] Replace CFRunLoop with dispatch_semaphore, pt. 2.
Apr 10 2019, 6:23 PM · Restricted Project, Restricted Project