Page MenuHomePhabricator

kubamracek (Kuba (Brecka) Mracek)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 3 2014, 6:35 AM (367 w, 2 d)

Recent Activity

Apr 20 2021

kubamracek accepted D72549: [TSan] Register threads created via pthread_create_from_mach_thread().

LGTM, thanks!

Apr 20 2021, 8:31 PM · Restricted Project, Restricted Project

Apr 18 2021

kubamracek accepted D100234: [compiler-rt][asan] use full vm range on apple silicon macs.
Apr 18 2021, 4:32 PM · Restricted Project

Apr 8 2021

kubamracek added a reviewer for D100142: [compiler-rt][aarch64] Add PAC-RET/BTI support to TSan.: dvyukov.
Apr 8 2021, 3:47 PM
kubamracek added reviewers for D100142: [compiler-rt][aarch64] Add PAC-RET/BTI support to TSan.: yln, delcypher, aralisza.
Apr 8 2021, 3:43 PM

Mar 18 2021

kubamracek added inline comments to D98008: [AArch64][compiler-rt] Strip PAC from the link register..
Mar 18 2021, 8:50 AM · Restricted Project

Mar 12 2021

kubamracek accepted D98008: [AArch64][compiler-rt] Strip PAC from the link register..

LGTM, and thanks!

Mar 12 2021, 5:36 PM · Restricted Project
kubamracek added inline comments to D98008: [AArch64][compiler-rt] Strip PAC from the link register..
Mar 12 2021, 12:47 PM · Restricted Project

Mar 11 2021

kubamracek added inline comments to D98008: [AArch64][compiler-rt] Strip PAC from the link register..
Mar 11 2021, 4:49 PM · Restricted Project
kubamracek added inline comments to D98008: [AArch64][compiler-rt] Strip PAC from the link register..
Mar 11 2021, 9:47 AM · Restricted Project
kubamracek added inline comments to D86377: [tsan] Use large address space mapping on Apple Silicon Macs.
Mar 11 2021, 9:28 AM · Restricted Project

Mar 10 2021

kubamracek added reviewers for D97682: [compiler-rt] PR#39514 Support versioned llvm-symbolizer binaries: delcypher, aralisza.
Mar 10 2021, 9:43 AM · Restricted Project
kubamracek accepted D98291: [compiler-rt] Fix stale incremental builds when using `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON`..

Looks good!

Mar 10 2021, 7:14 AM · Restricted Project

Mar 9 2021

kubamracek added a comment to D98291: [compiler-rt] Fix stale incremental builds when using `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON`..

When using Ninja, does this mean running a null build is no longer a null build, but it at least always invokes this sub-build? Not saying that's bad, just want to understand the change. What does the output of just "ninja" say in that case?

Mar 9 2021, 7:01 PM · Restricted Project
kubamracek added reviewers for D98291: [compiler-rt] Fix stale incremental builds when using `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON`.: arphaman, steven_wu, eugenis, kcc.
Mar 9 2021, 6:59 PM · Restricted Project
kubamracek added a comment to D98008: [AArch64][compiler-rt] Strip PAC from the link register..

Keep the PAC in the stack trace and only strip it when necessary like comparing traces, looking up symbols.

Mar 9 2021, 10:59 AM · Restricted Project

Mar 8 2021

kubamracek committed rG8a8fa09cb78a: [tsan] Use large address space mapping on Apple Silicon Macs (authored by kubamracek).
[tsan] Use large address space mapping on Apple Silicon Macs
Mar 8 2021, 2:10 PM
kubamracek closed D86377: [tsan] Use large address space mapping on Apple Silicon Macs.
Mar 8 2021, 2:10 PM · Restricted Project
kubamracek updated subscribers of D86377: [tsan] Use large address space mapping on Apple Silicon Macs.

I've uploaded a new version of the patch (just moving the definition of HAS_48_BIT_ADDRESS_SPACE outside of the SANITIZER_GO branch). @dyung @jmorse could I ask you to check this patch whether it builds correctly on x86_64/linux? Thanks!

Mar 8 2021, 8:02 AM · Restricted Project
kubamracek updated the diff for D86377: [tsan] Use large address space mapping on Apple Silicon Macs.
Mar 8 2021, 8:00 AM · Restricted Project
kubamracek reopened D86377: [tsan] Use large address space mapping on Apple Silicon Macs.
Mar 8 2021, 6:54 AM · Restricted Project

Mar 7 2021

kubamracek committed rGbde2e5607167: [tsan] Use large address space mapping on Apple Silicon Macs (authored by kubamracek).
[tsan] Use large address space mapping on Apple Silicon Macs
Mar 7 2021, 12:47 PM
kubamracek closed D86377: [tsan] Use large address space mapping on Apple Silicon Macs.
Mar 7 2021, 12:47 PM · Restricted Project

Mar 5 2021

kubamracek added a comment to D98008: [AArch64][compiler-rt] Strip PAC from the link register..

Could we reuse the macros/builtins from https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/sanitizer_common/sanitizer_ptrauth.h instead? Something like this:

Mar 5 2021, 10:43 AM · Restricted Project
kubamracek added a reviewer for D98008: [AArch64][compiler-rt] Strip PAC from the link register.: ab.
Mar 5 2021, 10:34 AM · Restricted Project
kubamracek added reviewers for D98008: [AArch64][compiler-rt] Strip PAC from the link register.: yln, delcypher, aralisza.
Mar 5 2021, 10:33 AM · Restricted Project

Feb 19 2021

kubamracek added inline comments to D96962: [compiler-rt/mac]: use DARWIN_osx_SYSROOT to set OSX_SYSROOT_FLAG.
Feb 19 2021, 10:00 AM
kubamracek updated subscribers of D96962: [compiler-rt/mac]: use DARWIN_osx_SYSROOT to set OSX_SYSROOT_FLAG.
Feb 19 2021, 7:37 AM
kubamracek added inline comments to D96962: [compiler-rt/mac]: use DARWIN_osx_SYSROOT to set OSX_SYSROOT_FLAG.
Feb 19 2021, 7:35 AM

Jan 12 2021

kubamracek added inline comments to D94190: [sanitizer][Darwin] GetMacosAlignedVersion() fails if sysctl is not setup.
Jan 12 2021, 6:17 PM · Restricted Project

Jan 7 2021

kubamracek accepted D94190: [sanitizer][Darwin] GetMacosAlignedVersion() fails if sysctl is not setup.

Can you add a comment to the header of the public function that eventually surfaced the "99.0" version (I guess that's GetMacosAlignedVersionInternal)? Something like "might return version 99 in rare cases".

Jan 7 2021, 6:03 PM · Restricted Project

Jan 6 2021

kubamracek added inline comments to D94190: [sanitizer][Darwin] GetMacosAlignedVersion() fails if sysctl is not setup.
Jan 6 2021, 5:32 PM · Restricted Project

Jan 5 2021

kubamracek accepted D94139: [sanitizer][Darwin] Suppress -Wno-non-virtual-dtor warning.
Jan 5 2021, 4:17 PM · Restricted Project

Dec 14 2020

kubamracek committed rGf276c008984d: [sanitizer] Restrict querying VM size on Darwin only to iOS devices (authored by kubamracek).
[sanitizer] Restrict querying VM size on Darwin only to iOS devices
Dec 14 2020, 10:50 AM
kubamracek closed D93140: [sanitizer] Restrict querying VM size on Darwin only to iOS devices.
Dec 14 2020, 10:50 AM · Restricted Project

Dec 11 2020

kubamracek requested review of D93140: [sanitizer] Restrict querying VM size on Darwin only to iOS devices.
Dec 11 2020, 1:03 PM · Restricted Project
kubamracek added a comment to D86377: [tsan] Use large address space mapping on Apple Silicon Macs.

@dvyukov a bit more ping :)

Dec 11 2020, 12:55 PM · Restricted Project

Dec 3 2020

kubamracek added reviewers for D92530: [compiler-rt] [builtins] Make lse.S compile on Darwin: danielkiss, t.p.northover.
Dec 3 2020, 8:56 AM · Restricted Project
kubamracek updated the diff for D92530: [compiler-rt] [builtins] Make lse.S compile on Darwin.
Dec 3 2020, 8:56 AM · Restricted Project

Dec 2 2020

kubamracek requested review of D92530: [compiler-rt] [builtins] Make lse.S compile on Darwin.
Dec 2 2020, 5:30 PM · Restricted Project

Oct 5 2020

kubamracek added a comment to D86377: [tsan] Use large address space mapping on Apple Silicon Macs.

@dvyukov more ping :)

Oct 5 2020, 9:55 AM · Restricted Project

Sep 23 2020

kubamracek added a comment to D86377: [tsan] Use large address space mapping on Apple Silicon Macs.

@dvyukov friendly ping :)

Sep 23 2020, 7:35 AM · Restricted Project

Aug 31 2020

kubamracek added a comment to D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags.

Specifically, I don't want to mess with the setup for Android and/or non-Darwin crosscompiling, because I have no way of testing that.

Aug 31 2020, 1:31 PM · Restricted Project
kubamracek added a comment to D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags.

Also, I understand that the code in question isn't best already, but I don't have the bandwidth to refactor and test any more extensive changes. I'm only trying to address the problem of getting -arch arm64 / arm64e passed into tests, otherwise we're testing the wrong thing. Let's focus on that, please.

Aug 31 2020, 1:30 PM · Restricted Project
kubamracek added inline comments to D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags.
Aug 31 2020, 1:28 PM · Restricted Project
kubamracek added a comment to D86377: [tsan] Use large address space mapping on Apple Silicon Macs.

@dvyukov Any feedback here, or is this OK to go in?

Aug 31 2020, 12:48 PM · Restricted Project

Aug 30 2020

kubamracek accepted D86106: [lldb] avoid assert in threadsanitizer tests on linux.

Looks good for get rid of the test failure.

Aug 30 2020, 8:52 PM · Restricted Project

Aug 25 2020

kubamracek committed rGe713b0ecbc89: [tsan] On arm64e, strip out ptrauth bits from incoming PCs (authored by kubamracek).
[tsan] On arm64e, strip out ptrauth bits from incoming PCs
Aug 25 2020, 12:00 PM
kubamracek closed D86378: [tsan] On arm64e, strip out ptrauth bits from incoming PCs.
Aug 25 2020, 11:59 AM · Restricted Project
kubamracek updated the diff for D86377: [tsan] Use large address space mapping on Apple Silicon Macs.
Aug 25 2020, 11:57 AM · Restricted Project
kubamracek added a comment to D86378: [tsan] On arm64e, strip out ptrauth bits from incoming PCs.

Great finds, thanks! I've updated the missing places. I'm leaving the Go parts alone, for now, as Go isn't using ptrauth.

Aug 25 2020, 9:35 AM · Restricted Project
kubamracek updated the diff for D86378: [tsan] On arm64e, strip out ptrauth bits from incoming PCs.
Aug 25 2020, 9:34 AM · Restricted Project
kubamracek updated the diff for D86377: [tsan] Use large address space mapping on Apple Silicon Macs.
Aug 25 2020, 8:18 AM · Restricted Project

Aug 21 2020

kubamracek added a comment to D86377: [tsan] Use large address space mapping on Apple Silicon Macs.

Definitely agree that this is very annoying to read. I think it would be best if we were able to change the ifdef to use something like “HAS_48_BIT_ADDRESS_SPACE” and compute that bool separately. @yln, @dvyukov WDYT?

Aug 21 2020, 7:24 PM · Restricted Project
kubamracek added a comment to D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags.

Ah, sorry :) The context is that any test config for arm64 or arm64e isn’t getting the right -arch flag passed in.

Aug 21 2020, 7:20 PM · Restricted Project
kubamracek requested review of D86379: [sanitizer] When building tests on Darwin, always pass -arch and other common flags.
Aug 21 2020, 3:19 PM · Restricted Project
kubamracek requested review of D86378: [tsan] On arm64e, strip out ptrauth bits from incoming PCs.
Aug 21 2020, 3:09 PM · Restricted Project
kubamracek requested review of D86377: [tsan] Use large address space mapping on Apple Silicon Macs.
Aug 21 2020, 3:07 PM · Restricted Project

Aug 19 2020

kubamracek accepted D85389: Fix bug where we request a shadow memory one page larger than necessary..
Aug 19 2020, 9:23 AM · Restricted Project
kubamracek added a comment to D85389: Fix bug where we request a shadow memory one page larger than necessary..

This looks reasonable, but just for verification, could you post the "before" and "after" of the little shadow map printout from ASAN_OPTIONS=verbosity=1?

Aug 19 2020, 9:23 AM · Restricted Project

Aug 18 2020

kubamracek accepted D86103: [TSan][libdispatch] Ensure TSan dylib works on old systems.
Aug 18 2020, 5:59 PM · Restricted Project

Aug 17 2020

kubamracek added a comment to D86103: [TSan][libdispatch] Ensure TSan dylib works on old systems.

If we use #if !SANITIZER_MAC || defined(__MAC_10_14), do we still need the forward declarations and weak_import stuff?

Aug 17 2020, 6:19 PM · Restricted Project

Aug 14 2020

kubamracek accepted D85995: [TSan][libdispatch] Guard test execution on old platforms.

This looks good to me. Note that I was actually suggesting to avoid the dynamic_lookup + forward declare and requiring that the *SDK* is at least 10.14 to run tests (which is separate from your OS version). But this way it's even more compatible, so I think we should go with it.

Aug 14 2020, 2:15 PM · Restricted Project

Aug 13 2020

kubamracek accepted D85854: [TSan][libdispatch] Add interceptors for dispatch_async_and_wait().

LGTM. Maybe add an if to check if the 10.14-only API is available and just do nothing in the test otherwise?

Aug 13 2020, 7:57 PM · Restricted Project
kubamracek added a comment to D85854: [TSan][libdispatch] Add interceptors for dispatch_async_and_wait().

Does the testcase actually fail without the code change?

Aug 13 2020, 12:19 PM · Restricted Project
kubamracek added a reviewer for D85854: [TSan][libdispatch] Add interceptors for dispatch_async_and_wait(): dvyukov.
Aug 13 2020, 12:17 PM · Restricted Project

Aug 4 2020

kubamracek added a comment to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

If I read the output right, it seems that even before this change, running with TSan messes up the permissions argument. I think this may be some latent bug in glibc that is only triggered in unusual environments (like TSan). I found this comment at https://lkml.org/lkml/2014/10/30/812:

Aug 4 2020, 11:35 AM · Restricted Project

Aug 1 2020

kubamracek added a comment to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

...and could you also see if perhaps this change helps:

diff --git a/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp b/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
--- a/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
+++ b/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
@@ -137,7 +137,11 @@ const int PTHREAD_BARRIER_SERIAL_THREAD = -1;
 #endif
 const int MAP_FIXED = 0x10;
 typedef long long_t;
+#if SANITIZER_MAC || SANITIZER_FREEBSD || SANITIZER_NETBSD
 typedef __sanitizer::u16 mode_t;
+#else
+typedef __sanitizer::u32 mode_t;
+#endif
Aug 1 2020, 11:45 AM · Restricted Project

Jul 30 2020

kubamracek added a comment to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

I can provide you access to a PPC64LE machine or I can check the details myself if you can tell me exactly what to do and how.

Jul 30 2020, 6:14 PM · Restricted Project
kubamracek updated subscribers of D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

CC @simoatze, @wschmidt:

Would anyone with access to a Linux/PPC64 machine be willing to take a look if the open() syscall is receiving the right value (0600 from the testcase)?

Jul 30 2020, 12:11 PM · Restricted Project
kubamracek added a comment to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

Actually given the symptom, I'm thinking this could be a real problem with the variadic interceptor:

Jul 30 2020, 9:52 AM · Restricted Project
kubamracek committed rG1e8a9c3e026f: [tsan] Fixup for 1260a155: Move variadic-open.cpp test into Darwin/ directory (authored by kubamracek).
[tsan] Fixup for 1260a155: Move variadic-open.cpp test into Darwin/ directory
Jul 30 2020, 9:33 AM
kubamracek added a comment to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

This fails on Linux/PPC64: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/52026/steps/ninja%20check%201/logs/FAIL%3A%20ThreadSanitizer-powerpc64%3A%3A%20variadic-open.cpp

Jul 30 2020, 9:31 AM · Restricted Project
kubamracek committed rG1260a155c37f: [tsan] Fix the open and open64 interceptors to have correct declarations… (authored by kubamracek).
[tsan] Fix the open and open64 interceptors to have correct declarations…
Jul 30 2020, 9:01 AM
kubamracek closed D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).
Jul 30 2020, 9:01 AM · Restricted Project

Jul 29 2020

kubamracek added inline comments to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).
Jul 29 2020, 12:23 PM · Restricted Project
kubamracek added inline comments to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).
Jul 29 2020, 12:21 PM · Restricted Project

Jul 24 2020

kubamracek committed rG33d9c4109ac2: [tsan] Allow TSan in the Clang driver for Apple Silicon Macs (authored by kubamracek).
[tsan] Allow TSan in the Clang driver for Apple Silicon Macs
Jul 24 2020, 8:14 PM
kubamracek closed D84082: [tsan] Allow TSan in the Clang driver for Apple Silicon Macs.
Jul 24 2020, 8:14 PM · Restricted Project, Restricted Project
kubamracek created D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).
Jul 24 2020, 5:20 PM · Restricted Project

Jul 21 2020

kubamracek added a comment to D84082: [tsan] Allow TSan in the Clang driver for Apple Silicon Macs.

Let's handle simulators separately.

Jul 21 2020, 4:19 PM · Restricted Project, Restricted Project
kubamracek accepted D84262: Avoid failing a CHECK in `DlAddrSymbolizer::SymbolizePC`..
Jul 21 2020, 12:23 PM · Restricted Project

Jul 17 2020

kubamracek committed rG176a6e7abe33: [asan] Use dynamic shadow memory position on Apple Silicon macOS (authored by kubamracek).
[asan] Use dynamic shadow memory position on Apple Silicon macOS
Jul 17 2020, 5:40 PM
kubamracek closed D82912: [asan] Use dynamic shadow memory position on Apple Silicon macOS.
Jul 17 2020, 5:40 PM · Restricted Project, Restricted Project
Herald added a project to D84082: [tsan] Allow TSan in the Clang driver for Apple Silicon Macs: Restricted Project.
Jul 17 2020, 5:29 PM · Restricted Project, Restricted Project

Jul 14 2020

kubamracek committed rG2c1df94e4a14: Bring in stripWhitespace (authored by kubamracek).
Bring in stripWhitespace
Jul 14 2020, 4:31 PM
kubamracek committed rG2004d53690d8: [TextAPI] Teach TextAPI about arm64e (authored by cishida).
[TextAPI] Teach TextAPI about arm64e
Jul 14 2020, 4:31 PM
kubamracek committed rG805fd5335f73: [AArch64] Relax 'inbounds' requirement for llvm.ptrauth signed GEPs. (authored by kubamracek).
[AArch64] Relax 'inbounds' requirement for llvm.ptrauth signed GEPs.
Jul 14 2020, 4:31 PM

Jun 30 2020

kubamracek accepted D81705: [Sanitizer] Fix demangling for Swift symbol names.

Looks reasonable. Could you check that swift_demangle has been correctly returning NULL for a "long time" (a couple years at least)? I'm asking because we can run on older OS's.

Jun 30 2020, 5:23 PM · Restricted Project
kubamracek added reviewers for D82912: [asan] Use dynamic shadow memory position on Apple Silicon macOS: arphaman, dexonsmith.
Jun 30 2020, 2:41 PM · Restricted Project, Restricted Project
kubamracek created D82912: [asan] Use dynamic shadow memory position on Apple Silicon macOS.
Jun 30 2020, 2:09 PM · Restricted Project, Restricted Project

May 1 2020

kubamracek accepted D79132: [Darwin] Improve ASan diagnostics on arm64e with pointer auth.
May 1 2020, 5:09 PM · Restricted Project
kubamracek added a comment to D78942: [Darwin] Improve runtime OS version checks.

Overall LGTM - would be great to hear feedback from @eugenis though.

May 1 2020, 5:09 PM · Restricted Project
kubamracek added inline comments to D78942: [Darwin] Improve runtime OS version checks.
May 1 2020, 5:09 PM · Restricted Project
kubamracek added inline comments to D78942: [Darwin] Improve runtime OS version checks.
May 1 2020, 5:09 PM · Restricted Project
kubamracek added reviewers for D78942: [Darwin] Improve runtime OS version checks: kcc, eugenis.
May 1 2020, 5:09 PM · Restricted Project

Apr 20 2020

kubamracek accepted D78525: Unbreak ASan runtime in the simulators..
Apr 20 2020, 6:28 PM · Restricted Project

Apr 17 2020

kubamracek accepted D78409: [compiler-rt] Use --standalone when running tests on the iOS simulator.
Apr 17 2020, 8:12 PM · Restricted Project
kubamracek accepted D78179: [Darwin] Fix symbolization for recent simulator runtimes..
Apr 17 2020, 3:11 PM · Restricted Project

Apr 15 2020

kubamracek added inline comments to D78179: [Darwin] Fix symbolization for recent simulator runtimes..
Apr 15 2020, 1:13 PM · Restricted Project
kubamracek added inline comments to D78179: [Darwin] Fix symbolization for recent simulator runtimes..
Apr 15 2020, 10:24 AM · Restricted Project