Page MenuHomePhabricator

kubamracek (Kuba (Brecka) Mracek)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 3 2014, 6:35 AM (259 w, 1 h)

Recent Activity

Wed, May 8

kubamracek added a comment to D61708: [TSan] Support `ignore_noninstrumented_modules` on Linux.

Nice, thanks. I don’t understand the ELF code so someone else should review it, but from my view this LGTM.

Wed, May 8, 6:48 PM · Restricted Project, Restricted Project

Apr 17 2019

kubamracek committed rGe5e9a6be6a23: [lldb] Don't filter variable list when doing a lookup by mangled name in… (authored by kubamracek).
[lldb] Don't filter variable list when doing a lookup by mangled name in…
Apr 17 2019, 5:17 PM
kubamracek added a comment to D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables.

Okay. @jingham, any more comments, or is this okay to land?

Apr 17 2019, 10:52 AM · Restricted Project
kubamracek updated the diff for D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables.
Apr 17 2019, 10:23 AM · Restricted Project

Apr 16 2019

kubamracek added a comment to D58110: Support fiber API on macOS.

Sorry for the huge delay. @yln can you test this patch (that is passes all tests) and if yes, land it?

Apr 16 2019, 1:45 PM · Restricted Project, Restricted Project
kubamracek updated the diff for D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables.

Updating test to use run_to_source_breakpoint

Apr 16 2019, 11:30 AM · Restricted Project
kubamracek updated the diff for D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables.

Adding a test case.

Apr 16 2019, 10:46 AM · Restricted Project
kubamracek added a reviewer for D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables: labath.
Apr 16 2019, 9:02 AM · Restricted Project

Apr 15 2019

kubamracek accepted D60639: [TSan][libdispatch] Port gcd-sync-block-copy.mm to C++.
Apr 15 2019, 4:35 PM · Restricted Project, Restricted Project
kubamracek created D60737: [lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables.
Apr 15 2019, 4:27 PM · Restricted Project
kubamracek added inline comments to D60639: [TSan][libdispatch] Port gcd-sync-block-copy.mm to C++.
Apr 15 2019, 10:25 AM · Restricted Project, Restricted Project
kubamracek added inline comments to D60575: [TSan][libdispatch] Use FileCheck's --implicit-check-not=....
Apr 15 2019, 10:25 AM · Restricted Project, Restricted Project

Apr 12 2019

kubamracek added a comment to D60575: [TSan][libdispatch] Use FileCheck's --implicit-check-not=....

I like this change, but there's no reason to apply it specifically to the Darwin tests, right? Can you apply it to all TSan tests?

Apr 12 2019, 1:05 PM · Restricted Project, Restricted Project
kubamracek accepted D60591: [TSan][libdispatch] Replace NSTemporaryDirectory in tests.
Apr 12 2019, 1:04 PM · Restricted Project, Restricted Project

Apr 10 2019

kubamracek accepted D60477: [TSan][libdispatch] Replace usage of NSMutableData with stack array.
Apr 10 2019, 6:32 PM · Restricted Project, Restricted Project
kubamracek accepted D60476: [TSan][libdispatch] Change test to have two simultaneous timers.
Apr 10 2019, 6:23 PM · Restricted Project, Restricted Project
kubamracek accepted D60475: [TSan][libdispatch] Replace CFRunLoop with dispatch_semaphore, pt. 2.
Apr 10 2019, 6:23 PM · Restricted Project, Restricted Project

Apr 8 2019

kubamracek added a comment to D60347: [TSan][libdispatch] Replace CFRunLoop with dispatch_semaphore, pt. 1.

Can you please embed all the functions into the tests themselves and drop the header file?

Apr 8 2019, 10:52 AM · Restricted Project, Restricted Project

Apr 5 2019

kubamracek added a comment to D60347: [TSan][libdispatch] Replace CFRunLoop with dispatch_semaphore, pt. 1.

General point: Should we actually be using the TSan-invisible barrier for this purpose? Maybe a "normal" primitive, like a dispatch semaphore would make this more clear that we're just trying to tell the main thread that we're done.

Apr 5 2019, 5:10 PM · Restricted Project, Restricted Project
kubamracek added a comment to D60345: [TSan][libdispatch] Fix test.

I don't think this is testing the same thing. Previously, we use barrier_wait to enforce a situation we want to test.

Apr 5 2019, 4:12 PM · Restricted Project, Restricted Project
kubamracek added inline comments to D60344: [TSan][libdispatch] Fix test.
Apr 5 2019, 4:11 PM · Restricted Project, Restricted Project
kubamracek added a comment to D60327: [TSan][libdispatch] Add RunLoop helper to ease porting tests.

See the inline notes. Is there no better approach?

Apr 5 2019, 12:46 PM · Restricted Project, Restricted Project

Mar 19 2019

kubamracek added a comment to D59526: [TSan][libdispatch] Avoid infinite recursion in dispatch_apply[_f] interceptors.

Also, I assume this is already covered by a test?

Mar 19 2019, 6:50 AM · Restricted Project, Restricted Project
kubamracek accepted D59526: [TSan][libdispatch] Avoid infinite recursion in dispatch_apply[_f] interceptors.

Looks good, thanks.

Mar 19 2019, 6:50 AM · Restricted Project, Restricted Project

Mar 18 2019

kubamracek accepted D59510: [NFC][TSan][libdispatch] Fix test for dispatch_apply[_f].

Make size just "2" to make sure we're actually able to satisfy the barrier on low-end machines. Other that that, LGTM.

Mar 18 2019, 2:12 PM · Restricted Project, Restricted Project

Mar 15 2019

kubamracek accepted D59429: [CMake] Fix broken uses of `try_compile_only()` and improve the function..
Mar 15 2019, 1:11 PM · Restricted Project, Restricted Project

Mar 14 2019

kubamracek accepted D59341: [NFC][TSan] Move libdispatch tests into their own subfolder.

Looks good, but I assume this needs the other patches to land first, right?

Mar 14 2019, 1:14 PM · Restricted Project, Restricted Project
kubamracek added a comment to D59334: [TSan][libdispatch] Enable linking and running of tests on Linux.

This looks fine to me, but I think we need @dvyukov to sign off on this.

Mar 14 2019, 1:12 PM · Restricted Project, Restricted Project
kubamracek accepted D59145: [TSan][libdispatch] Remove dependency on system headers.

Looks good, with a nit (feel free to address it separately).

Mar 14 2019, 1:10 PM · Restricted Project, Restricted Project

Feb 27 2019

kubamracek accepted D58310: [Darwin][NFC] Refactor throttling of 64bit sanitizer tests on Darwin.
Feb 27 2019, 10:15 AM · Restricted Project, Restricted Project

Feb 20 2019

kubamracek accepted D58110: Support fiber API on macOS.
Feb 20 2019, 7:12 AM · Restricted Project, Restricted Project

Feb 18 2019

kubamracek added a comment to D58110: Support fiber API on macOS.

watchOS/tvOS build is broken right now in trunk:
https://pastebin.com/Y3gsxtA7

Feb 18 2019, 11:13 AM · Restricted Project, Restricted Project

Feb 14 2019

kubamracek added a comment to D58110: Support fiber API on macOS.

For the pragma diagnostic push/ignore stuff, we might be better off just redeclaring the function ourselves without including ucontext.h.

For tsan_interceptors_mac.cc it can be done. For me such solution is more ugly than usage of #define and #pragma; but if you insist on it, I can do such change.

Feb 14 2019, 10:57 AM · Restricted Project, Restricted Project

Feb 13 2019

kubamracek added a comment to D58110: Support fiber API on macOS.

@yln Could you take a look? Do the tests actually pass on Darwin?

Feb 13 2019, 9:33 AM · Restricted Project, Restricted Project
kubamracek added a reviewer for D58110: Support fiber API on macOS: yln.
Feb 13 2019, 9:19 AM · Restricted Project, Restricted Project

Feb 11 2019

kubamracek added a reviewer for D56485: Always compare C++ typeinfo (based on libstdc++ implementation).: vsk.
Feb 11 2019, 11:19 AM

Feb 6 2019

kubamracek closed D56221: [lldb] Make frame recognizers vend synthesized eValueTypeVariableArgument values.

Landed in r353363.

Feb 6 2019, 5:54 PM · Restricted Project
kubamracek committed rG92369dcffd7e: [lldb] Make frame recognizers vend synthesized eValueTypeVariableArgument values (authored by kubamracek).
[lldb] Make frame recognizers vend synthesized eValueTypeVariableArgument values
Feb 6 2019, 5:50 PM

Jan 27 2019

Herald added a reviewer for D56221: [lldb] Make frame recognizers vend synthesized eValueTypeVariableArgument values: serge-sans-paille.

Ping.

Jan 27 2019, 8:00 PM · Restricted Project

Jan 3 2019

kubamracek added a comment to D56115: [lldb] Check SafeToCallFunctions before calling functions in GetExceptionObjectForThread.

I recently started writing these early-exit returns as return {};

Good suggestion!

Jan 3 2019, 4:27 PM · Restricted Project

Jan 2 2019

kubamracek created D56221: [lldb] Make frame recognizers vend synthesized eValueTypeVariableArgument values.
Jan 2 2019, 1:47 PM · Restricted Project
kubamracek added a comment to D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation..

This needs https://reviews.llvm.org/D56206 to land first, right?

Jan 2 2019, 11:27 AM · Restricted Project, Restricted Project

Dec 27 2018

kubamracek created D56115: [lldb] Check SafeToCallFunctions before calling functions in GetExceptionObjectForThread.
Dec 27 2018, 3:30 PM · Restricted Project

Dec 21 2018

kubamracek created D56027: [lldb] Fix ObjCExceptionRecognizedStackFrame to populate the list of recognized arguments.
Dec 21 2018, 2:42 PM · Restricted Project

Dec 20 2018

kubamracek added a comment to D55959: [TSan] Enable detection of lock-order-inversions for Objective-C @synchronized.

LGTM with a nit. @dvyukov are we using the Mutex* calls correctly here?

Dec 20 2018, 3:18 PM · Restricted Project
kubamracek updated the diff for D55954: [lldb] Add a "display-recognized-arguments" target setting to show recognized arguments by default.

Adding test.

Dec 20 2018, 3:06 PM · Restricted Project
kubamracek created D55954: [lldb] Add a "display-recognized-arguments" target setting to show recognized arguments by default.
Dec 20 2018, 1:49 PM · Restricted Project

Dec 19 2018

kubamracek added a comment to D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI.

Thanks for the review! Switched to self.assertFalse and self.assertTrue and landed in r349718.

Dec 19 2018, 6:05 PM
kubamracek updated the diff for D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI.

Addressed comment 2. Changed the test to use an Obj-C++ source file, and added a case that throws a plain C++ exception.

Dec 19 2018, 4:19 PM
kubamracek updated the diff for D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI.

Addressing comment 1 (checking that GetCurrentException and GetCurrentExceptionBacktrace returns nothing when there's no exception in flights). Will address comment 2 in a bit.

Dec 19 2018, 1:36 PM

Dec 18 2018

kubamracek updated the diff for D55794: [asan] In llvm.asan.globals, allow entries to be non-GlobalVariable and skip over them.
Dec 18 2018, 12:31 PM · Restricted Project
kubamracek updated the diff for D55794: [asan] In llvm.asan.globals, allow entries to be non-GlobalVariable and skip over them.
Dec 18 2018, 12:04 PM · Restricted Project
kubamracek added a comment to D55794: [asan] In llvm.asan.globals, allow entries to be non-GlobalVariable and skip over them.

I see, you're probably right. The reason why I suggested to skip entries with bitcasts was because the cases where I hit this crash were all such that the global was getting re-inserted into llvm.asan.globals anyway, so it didn't matter if we skipped them. But I guess that doesn't need to always be the case. I'll change the patch to look through bitcasts, and I believe the code should already be handling the case of repeated values in llvm.asan.globals.

Dec 18 2018, 11:43 AM · Restricted Project

Dec 17 2018

kubamracek created D55794: [asan] In llvm.asan.globals, allow entries to be non-GlobalVariable and skip over them.
Dec 17 2018, 2:50 PM · Restricted Project

Dec 14 2018

kubamracek added a comment to D55711: Don't trigger sanitizer initialization from `sysctlbyname` interceptor..

If we are going to support this use-case we need a test.

We have iOS simulator tests are they're all currently failing because of this: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive/13113/testReport/

Dec 14 2018, 3:09 PM

Dec 12 2018

kubamracek accepted D55116: [CMake] llvm_codesign workaround for Xcode double-signing errors.

I'd slightly prefer to use --force for *all* builds, not just Xcode builds, to have uniformity. But LGTM even in this form if you feel strongly about it.

Dec 12 2018, 11:29 AM

Dec 5 2018

kubamracek added a comment to D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI.

Ping.

Dec 5 2018, 8:06 AM

Dec 4 2018

kubamracek accepted D55064: Add new `__sanitizer_mz_default_zone()` API which returns the address of the ASan malloc zone. This API will be used for testing in future patches..
Dec 4 2018, 12:04 PM

Nov 29 2018

kubamracek retitled D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI from [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type to [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI.
Nov 29 2018, 2:21 PM
kubamracek updated the diff for D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI.
Nov 29 2018, 2:21 PM

Nov 28 2018

kubamracek added a comment to D43886: [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes.

Landed, thanks for the review!

Nov 28 2018, 2:05 PM
kubamracek updated the diff for D43886: [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes.

Updated patch. I've added a static AppleObjCRuntime::GetExceptionThrowLocation(), which returns the location of the exception throw breakpoint for the Obj-C runtime. I tried adding it as virtual method on LanguageRuntime instead, but then it wasn't clear to me how to make it easily return either an optional (there's runtimes that don't have exceptions) or an array (as you said, C++ will need multiple locations) and how to make existing code CreateExceptionResolver work with that. Let me know if that's okay.

Nov 28 2018, 1:08 PM

Nov 27 2018

kubamracek added a comment to D54904: Introduce `AddressSpaceView` template parameter to `SizeClassAllocator32`, `FlatByteMap`, and `TwoLevelByteMap`..

Please make this make independent on the other (type_trains).

Nov 27 2018, 8:32 AM
kubamracek added a comment to D54904: Introduce `AddressSpaceView` template parameter to `SizeClassAllocator32`, `FlatByteMap`, and `TwoLevelByteMap`..

The patch is quite big. I've added a couple suggestions how to reduce it to make it easier to review.

Nov 27 2018, 8:31 AM

Nov 26 2018

kubamracek added a comment to D54889: Fiber support for thread sanitizer.

Can you explain what this patch does a bit? The way I see it, it's just adding an extra level of indirection to each cur_thread() call. Is that it? Does that affect the performance of TSan?

Nov 26 2018, 11:59 AM · Restricted Project, Restricted Project
kubamracek accepted D54908: Fix objc_sync_exit TSAN interceptor.

LGTM.

Nov 26 2018, 11:12 AM · Restricted Project
kubamracek added a comment to D54904: Introduce `AddressSpaceView` template parameter to `SizeClassAllocator32`, `FlatByteMap`, and `TwoLevelByteMap`..

The patch is quite big. I've added a couple suggestions how to reduce it to make it easier to review.

Nov 26 2018, 10:06 AM
kubamracek accepted D54861: [SanitizerCommon] Test `CombinedAllocator::ForEachChunk()` in unit tests..

LGTM, of course (more tests, yay!).

Nov 26 2018, 8:53 AM

Nov 14 2018

kubamracek added inline comments to D54469: Introduce new `disable_init` ASan option that is only supported on platforms where `SANITIZER_SUPPORTS_DISABLED_INIT` is true. Currently this is only supported on Darwin..
Nov 14 2018, 8:56 AM
kubamracek added inline comments to D54469: Introduce new `disable_init` ASan option that is only supported on platforms where `SANITIZER_SUPPORTS_DISABLED_INIT` is true. Currently this is only supported on Darwin..
Nov 14 2018, 8:55 AM
kubamracek added inline comments to D54469: Introduce new `disable_init` ASan option that is only supported on platforms where `SANITIZER_SUPPORTS_DISABLED_INIT` is true. Currently this is only supported on Darwin..
Nov 14 2018, 6:56 AM

Nov 13 2018

kubamracek added a comment to D54469: Introduce new `disable_init` ASan option that is only supported on platforms where `SANITIZER_SUPPORTS_DISABLED_INIT` is true. Currently this is only supported on Darwin..

Can this be triggered by a separate environment variable instead? That way we don't have to expose it in flags at all.

Nov 13 2018, 7:06 AM

Nov 12 2018

kubamracek updated the diff for D43886: [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes.

Simplifying this a bit further, adding a test, and commenting out the backtrace API, which I'll add in a subsequent commit.

Nov 12 2018, 1:22 PM
kubamracek added a comment to D43884: [lldb] Extract more fields from NSException values.

Thanks for the review!

Nov 12 2018, 11:15 AM
kubamracek created D54432: [lldb] Fix the typo (replace underscore with dash) in svn:ignore on test/ and add "lldb-test-build.noindex" to ignored files.
Nov 12 2018, 9:25 AM
kubamracek created D54431: [lldb] Add "ninja" to svn:ignore.
Nov 12 2018, 9:21 AM
kubamracek added inline comments to D44081: [lldb] Add synthetic frontend for _NSCallStackArray.
Nov 12 2018, 9:19 AM
kubamracek updated the diff for D44081: [lldb] Add synthetic frontend for _NSCallStackArray.
Nov 12 2018, 9:19 AM
kubamracek added inline comments to D43884: [lldb] Extract more fields from NSException values.
Nov 12 2018, 9:07 AM
kubamracek updated the diff for D43884: [lldb] Extract more fields from NSException values.
Nov 12 2018, 9:07 AM

Nov 11 2018

kubamracek added a comment to D41191: [tsan] Use MonotonicNanoTime instead of NanoTime.

Ping.

Nov 11 2018, 5:21 PM · Restricted Project
kubamracek added a comment to D43886: [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes.

Hi, I've updated this patch after a while. Since then, StackFrameRecognizers have already landed, so this patch now just adds one subclass of a StackFrameRecognizer.

Nov 11 2018, 5:21 PM
kubamracek updated the diff for D43886: [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes.

Updating patch for the recently-landed StackFrameRecognizers.

Nov 11 2018, 5:11 PM
kubamracek added a reviewer for D43886: [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes: aprantl.
Nov 11 2018, 5:11 PM
kubamracek added a reviewer for D43884: [lldb] Extract more fields from NSException values: aprantl.

Ping.

Nov 11 2018, 11:18 AM
kubamracek added a reviewer for D44081: [lldb] Add synthetic frontend for _NSCallStackArray: aprantl.

Ping.

Nov 11 2018, 11:17 AM
kubamracek added a reviewer for D44073: [lldb] Refactor ObjC/NSException.cpp (cleanup, avoid code duplication). NFC.: aprantl.

Ping.

Nov 11 2018, 11:17 AM
kubamracek added a comment to D44060: [lldb] Fix "code requires global destructor" warning in g_architecture_mutex.

Ping.

Nov 11 2018, 11:08 AM

Nov 8 2018

kubamracek accepted D54045: Introduce `sanitizer_malloc_introspect_t` for Darwin which is a sub-class of Darwin's `malloc_introspection_t` and use it when setting up the malloc zone..
Nov 8 2018, 6:49 AM

Nov 6 2018

kubamracek updated subscribers of D48445: [sanitizer] Use "fast mmap" kernel flag for shadow memory on macOS 10.13.4+.
r346264 | d0k | 2018-11-06 12:42:19 -0800 (Tue, 06 Nov 2018) | 11 lines
Nov 6 2018, 12:56 PM · Restricted Project
kubamracek added a comment to D53975: Start adding the supporting code to perform out-of-process allocator enumeration..

They're not open source. The interface to them is at https://opensource.apple.com/source/Libc/Libc-498/include/malloc/malloc.h.

Nov 6 2018, 10:36 AM

Nov 5 2018

kubamracek added a comment to D53975: Start adding the supporting code to perform out-of-process allocator enumeration..

Is this out of process only to enumarate? Is there an option to support this through debugging interfaces and analysis of a program? I mean to inspect asanitized program from an external debugger(-like) program.

Nov 5 2018, 6:27 PM
kubamracek added a comment to D53975: Start adding the supporting code to perform out-of-process allocator enumeration..

Can you please be more specific about what exactly are you objecting against? We really want the code for the out-of-process enumeration to be part of compiler-rt, otherwise we'll be getting downstream failures forever. And in compiler-rt, the code belongs to the allocator.

Nov 5 2018, 6:18 PM
kubamracek added a comment to D54045: Introduce `sanitizer_malloc_introspect_t` for Darwin which is a sub-class of Darwin's `malloc_introspection_t` and use it when setting up the malloc zone..

Okay, let's initially remove the header file and just move the struct into the .inc file. We can always move it to a separate header later if needed.

Nov 5 2018, 2:00 PM
kubamracek added a comment to D54045: Introduce `sanitizer_malloc_introspect_t` for Darwin which is a sub-class of Darwin's `malloc_introspection_t` and use it when setting up the malloc zone..

Looks good. I assume the struct definition cannot be moved into the .inc file because we're going to need to access it from other places?

Nov 5 2018, 12:16 PM

Nov 2 2018

kubamracek accepted D54037: [NFC] Refactor initialisation of Darwin malloc zone fields into separate function called `InitMallocZoneFields()` which is now called from `ReplaceSystemMalloc()`..
Nov 2 2018, 8:27 AM

Nov 1 2018

kubamracek added a comment to D53975: Start adding the supporting code to perform out-of-process allocator enumeration..
In D53975#1284724, @kcc wrote:

have you considered implementing this fully outside of the sanitizer allocator?

Nov 1 2018, 3:55 PM

Oct 30 2018

kubamracek reopened D44603: [lldb] Introduce StackFrameRecognizer.
Oct 30 2018, 6:25 PM
kubamracek reopened D44603: [lldb] Introduce StackFrameRecognizer.
Oct 30 2018, 5:31 PM
kubamracek added a comment to D44603: [lldb] Introduce StackFrameRecognizer.

Ping.

Oct 30 2018, 11:17 AM