Page MenuHomePhabricator

andrew (Andrew Turner)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2015, 10:19 AM (359 w, 2 d)

Recent Activity

Tue, Jul 19

andrew added a comment to D130063: [Driver] Enable sanitizers on FreeBSD AArch64.

No tests, but D125883, D125758, and D125873 need to be committed first.

Tue, Jul 19, 2:14 AM · Restricted Project, Restricted Project
andrew requested review of D130063: [Driver] Enable sanitizers on FreeBSD AArch64.
Tue, Jul 19, 1:21 AM · Restricted Project, Restricted Project
andrew abandoned D127393: [Driver] Don't add -lresolv on FreeBSD.
Tue, Jul 19, 12:09 AM · Restricted Project, Restricted Project
andrew added inline comments to D127394: [sanitizer] Fix the posix_spawn test on FreeBSD.
Tue, Jul 19, 12:09 AM · Restricted Project, Restricted Project

Jun 13 2022

andrew added a comment to D127393: [Driver] Don't add -lresolv on FreeBSD.

I'll leave it to someone else to get non-FreeBSD working as it's unlikely I'll have time to fix them in the hear future.

Jun 13 2022, 4:12 AM · Restricted Project, Restricted Project
andrew updated the diff for D127393: [Driver] Don't add -lresolv on FreeBSD.

Update the comment

Jun 13 2022, 4:10 AM · Restricted Project, Restricted Project

Jun 9 2022

andrew requested review of D127394: [sanitizer] Fix the posix_spawn test on FreeBSD.
Jun 9 2022, 4:37 AM · Restricted Project, Restricted Project
andrew added a reviewer for D125883: [msan] Add the FreeBSD AArch64 memory layout: vitalybuka.
Jun 9 2022, 4:28 AM · Restricted Project, Restricted Project
andrew added a reviewer for D125873: [asan] Add the FreeBSD AArch64 shadow offset to llvm: vitalybuka.
Jun 9 2022, 4:28 AM · Restricted Project, Restricted Project
andrew added a reviewer for D125758: [msan] Add the FreeBSD AArch64 memory layout: vitalybuka.
Jun 9 2022, 4:27 AM · Restricted Project, Restricted Project
andrew requested review of D127393: [Driver] Don't add -lresolv on FreeBSD.
Jun 9 2022, 4:00 AM · Restricted Project, Restricted Project

Jun 1 2022

andrew updated the diff for D125756: [sanitizer] Add the common FreeBSD AArch64 support.

Rebase past rename to SANITIZER_APPLE

Jun 1 2022, 6:59 AM · Restricted Project, Restricted Project
andrew updated the diff for D125756: [sanitizer] Add the common FreeBSD AArch64 support.

Remove an unneeded SANITIZER_LINUX | SANITIZER_FREEBSD check

Jun 1 2022, 5:37 AM · Restricted Project, Restricted Project
andrew added a reviewer for D125873: [asan] Add the FreeBSD AArch64 shadow offset to llvm: Restricted Project.
Jun 1 2022, 4:38 AM · Restricted Project, Restricted Project
andrew added inline comments to D125756: [sanitizer] Add the common FreeBSD AArch64 support.
Jun 1 2022, 4:37 AM · Restricted Project, Restricted Project

May 18 2022

andrew requested review of D125902: [fuzzer] Fix TableLookupTest on FreeBSD.
May 18 2022, 9:26 AM · Restricted Project, Restricted Project
andrew requested review of D125901: [safestack] Fix Mmap on FreeBSD AArch64.
May 18 2022, 9:20 AM · Restricted Project, Restricted Project
andrew requested review of D125883: [msan] Add the FreeBSD AArch64 memory layout.
May 18 2022, 6:30 AM · Restricted Project, Restricted Project
andrew updated the summary of D125758: [msan] Add the FreeBSD AArch64 memory layout.
May 18 2022, 6:26 AM · Restricted Project, Restricted Project
andrew updated the diff for D125873: [asan] Add the FreeBSD AArch64 shadow offset to llvm.

Enable the FreeBSD llvm asan test on AArch64

May 18 2022, 4:23 AM · Restricted Project, Restricted Project
andrew requested review of D125873: [asan] Add the FreeBSD AArch64 shadow offset to llvm.
May 18 2022, 4:00 AM · Restricted Project, Restricted Project
andrew updated the summary of D125762: [tsan] Fix the longjmp sp slot on FreeBSD AArch64.
May 18 2022, 3:36 AM · Restricted Project, Restricted Project
andrew updated the summary of D125757: [asan] Add the FreeBSD AArch64 shadow offset.
May 18 2022, 3:29 AM · Restricted Project, Restricted Project
andrew added a comment to D125757: [asan] Add the FreeBSD AArch64 shadow offset.

There is no change in any tests passing as no asan tests are run on FreeBSD AArch64. This is compiler-rt part of the change that is needed to support asan there. There is also D125756 for the common sanitizer parts, and an as yet unsubmitted changes to add the offset to llvm and enable the sanitizers in clang.

May 18 2022, 3:26 AM · Restricted Project, Restricted Project

May 17 2022

andrew requested review of D125762: [tsan] Fix the longjmp sp slot on FreeBSD AArch64.
May 17 2022, 3:38 AM · Restricted Project, Restricted Project
andrew abandoned D74765: [compiler-rt] Addd FreeBSD arm64 sanitizer support.

Replaced with D125756 D125757 D125758

May 17 2022, 3:32 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
andrew requested review of D125758: [msan] Add the FreeBSD AArch64 memory layout.
May 17 2022, 3:30 AM · Restricted Project, Restricted Project
andrew requested review of D125757: [asan] Add the FreeBSD AArch64 shadow offset.
May 17 2022, 3:30 AM · Restricted Project, Restricted Project
andrew requested review of D125756: [sanitizer] Add the common FreeBSD AArch64 support.
May 17 2022, 3:29 AM · Restricted Project, Restricted Project

May 4 2022

andrew updated the diff for D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64.

Remove a stray change

May 4 2022, 7:56 AM · Restricted Project, Restricted Project
andrew updated the diff for D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64.

Cleanup based on feedback

May 4 2022, 6:57 AM · Restricted Project, Restricted Project

Apr 4 2022

andrew updated the diff for D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64.

Add support for the PAC test

Apr 4 2022, 9:17 AM · Restricted Project, Restricted Project

Mar 23 2022

andrew added a comment to D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64.

It's easy to detect in the debugee as it can check which hardware capabilities are passed to it from the kernel.

Mar 23 2022, 12:25 PM · Restricted Project, Restricted Project
andrew added a comment to D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64.

We need to make sure a test covers this as well, perhaps just enabling lldb/test/API/functionalities/unwind/aarch64_unwind_pac/TestAArch64UnwindPAC.py?

Mar 23 2022, 9:29 AM · Restricted Project, Restricted Project

Mar 1 2022

andrew added inline comments to D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64.
Mar 1 2022, 7:44 AM · Restricted Project, Restricted Project

Feb 24 2022

andrew requested review of D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64.
Feb 24 2022, 7:13 AM · Restricted Project, Restricted Project
andrew updated the diff for D110569: [lldb] [Process/FreeBSD] Rework arm64 register access.

Rebase

Feb 24 2022, 7:12 AM · Restricted Project

Sep 28 2021

andrew added inline comments to D110569: [lldb] [Process/FreeBSD] Rework arm64 register access.
Sep 28 2021, 3:42 AM · Restricted Project

Sep 27 2021

andrew requested review of D110569: [lldb] [Process/FreeBSD] Rework arm64 register access.
Sep 27 2021, 10:33 AM · Restricted Project
andrew added a comment to D110545: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test.

Yes, I found it by trying to build the tests on FreeBSD/arm64

Sep 27 2021, 9:32 AM · Restricted Project
andrew updated the diff for D110545: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test.

Set opt_regsets to eRegsetMaskDefault

Sep 27 2021, 8:49 AM · Restricted Project
andrew added a reviewer for D110545: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test: mgorny.
Sep 27 2021, 6:47 AM · Restricted Project
andrew requested review of D110545: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test.
Sep 27 2021, 6:02 AM · Restricted Project

Aug 10 2021

andrew added a comment to D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses.

FreeBSD doesn't currently support TBI. I'm trying to decide if it will be enabled everywhere, or just when needed (e.g. for HWASAN) due to how it interacts with PAC.

Aug 10 2021, 4:16 AM · Restricted Project

Feb 18 2020

andrew added inline comments to D74765: [compiler-rt] Addd FreeBSD arm64 sanitizer support.
Feb 18 2020, 6:52 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
andrew updated the diff for D74765: [compiler-rt] Addd FreeBSD arm64 sanitizer support.

Remove unintended changes

Feb 18 2020, 6:52 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
andrew created D74765: [compiler-rt] Addd FreeBSD arm64 sanitizer support.
Feb 18 2020, 6:23 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 9 2017

andrew added a comment to D32175: Add the llvm asan support.

Is there any feedback on this?

May 9 2017, 9:01 AM · Restricted Project
andrew added a comment to D32172: Port asan to FreeBSD AArch64.

Is there any feedback on this?

May 9 2017, 9:01 AM

Apr 18 2017

andrew added a comment to D32172: Port asan to FreeBSD AArch64.

The llvm bits are in D32175

Apr 18 2017, 9:28 AM
andrew added a comment to D32175: Add the llvm asan support.

The compiler-rt bits are in D32172

Apr 18 2017, 9:28 AM · Restricted Project
andrew created D32175: Add the llvm asan support.
Apr 18 2017, 9:28 AM · Restricted Project
andrew created D32172: Port asan to FreeBSD AArch64.
Apr 18 2017, 9:20 AM

Jan 12 2017

andrew added a comment to D28570: Limit sincos to Linux.

The ARM/X86 hasSinCos seems to be for macOS/iOS/watchOS.

Jan 12 2017, 1:23 AM

Jan 11 2017

andrew added inline comments to D28570: Limit sincos to Linux.
Jan 11 2017, 10:19 AM
andrew retitled D28570: Limit sincos to Linux from to Limit sincos to Linux.
Jan 11 2017, 10:14 AM

Oct 5 2016

andrew added a comment to D25079: [ELF] Set maximum page size to 65536 on AArch64.

Hello Ed,

Would changing the maximum page size to 64k in lld for AArch64 give you any cause for concern?

Sorry I didn't get a chance to look prior to commit. I don't think it's a problem but will ping @andrew for confirmation.

Oct 5 2016, 10:38 AM · lld

Feb 25 2016

andrew added a comment to D15774: [PEI] Calculate stack protector frame offset before local stack allocation..

I think something else has changed as I always get the expected SIGABRT either with or without this patch.

Feb 25 2016, 12:56 PM

Feb 9 2016

andrew added a comment to D15774: [PEI] Calculate stack protector frame offset before local stack allocation..

With this the failing FreeBSD ssp test now passes.

Feb 9 2016, 10:48 AM

Dec 29 2015

andrew added a comment to D15791: Disable generating movt on FreeBSD.

Can someone commit with the FIXME comment? I'm unable to do it myself.

Dec 29 2015, 9:47 AM

Dec 28 2015

andrew closed D15788: Support clrex on ARMv6K.

Committed at rL256505

Dec 28 2015, 2:19 PM
andrew added inline comments to D15788: Support clrex on ARMv6K.
Dec 28 2015, 2:34 AM

Dec 27 2015

andrew retitled D15791: Disable generating movt on FreeBSD from to Disable generating movt on FreeBSD.
Dec 27 2015, 8:31 AM
andrew retitled D15788: Support clrex on ARMv6K from to Support clrex on ARMv6K.
Dec 27 2015, 3:34 AM