This is an archive of the discontinued LLVM Phabricator instance.

[ARM] GlobalISel: Support i1 add and ABI extensions
ClosedPublic

Authored by rovka on Dec 13 2016, 2:28 AM.

Details

Summary

Add support for:

  • i1 add
  • i1 function arguments
  • i1 returns, with ABI signext/zeroext

Diff Detail

Event Timeline

rovka updated this revision to Diff 81202.Dec 13 2016, 2:28 AM
rovka retitled this revision from to [ARM] GlobalISel: Support i1 add and ABI extensions.
rovka updated this object.
rovka added reviewers: ab, qcolombet, t.p.northover.
rovka added subscribers: llvm-commits, rengolin, dsanders.
t.p.northover added inline comments.Dec 16 2016, 11:41 AM
lib/Target/ARM/ARMInstructionSelector.cpp
108

We've got an LLVM_FALLTHROUGH for this so that the actual attribute is used when available.

rovka added inline comments.Dec 19 2016, 3:48 AM
lib/Target/ARM/ARMInstructionSelector.cpp
108

Ok, will fix before committing. Anything else?

rengolin accepted this revision.Jan 23 2017, 10:17 AM

Again, same comment as for D27705, straightforward patch. LGTM. Thanks!

lib/Target/ARM/ARMInstructionSelector.cpp
123

Yay! New syntax! :)

This revision is now accepted and ready to land.Jan 23 2017, 10:17 AM
This revision was automatically updated to reflect the committed changes.