Page MenuHomePhabricator

vkalintiris (Vasileios Kalintiris)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2014, 5:28 AM (258 w, 48 m)

Recent Activity

Jan 17 2017

vkalintiris committed rL292208: Update the release tester for MIPS. NFC..
Update the release tester for MIPS. NFC.
Jan 17 2017, 3:11 AM

Jan 11 2017

vkalintiris accepted D24510: [mips] Correct c.cond.fmt instruction definition..

LGTM.

Jan 11 2017, 4:42 AM

Jan 9 2017

vkalintiris accepted D25438: [mips] Fix Mips MSA instrinsics.

LGTM.

Jan 9 2017, 9:26 AM

Nov 25 2016

vkalintiris added a comment to D24722: [mips] Correct jal expansion for local symbols in .local directives..

@vkalintiris this patch ok without the dependency and FIXMEs? I should be able to get the other patch in as I can provide cleaner test cases.

Nov 25 2016, 2:52 AM

Nov 22 2016

vkalintiris accepted D26961: [mips] seb, seh instruction aliases.

LGTM. I have one question/suggestion inline.

Nov 22 2016, 10:22 AM
vkalintiris closed D26793: [mips] Add support for unaligned load/store macros..

Thanks for reviewing this! I committed this in r287646.

Nov 22 2016, 8:59 AM
vkalintiris committed rL287646: [mips] Add support for unaligned load/store macros..
[mips] Add support for unaligned load/store macros.
Nov 22 2016, 8:53 AM

Nov 20 2016

vkalintiris accepted D24763: [mips] Restrict tail call optimization.

LGTM.

Nov 20 2016, 7:26 AM

Nov 17 2016

vkalintiris retitled D26793: [mips] Add support for unaligned load/store macros. from to [mips] Add support for unaligned load/store macros..
Nov 17 2016, 4:59 AM

Nov 15 2016

vkalintiris accepted D26153: [mips] not instruction alias.

LGTM.

Nov 15 2016, 3:06 PM
vkalintiris added inline comments to D25438: [mips] Fix Mips MSA instrinsics.
Nov 15 2016, 11:28 AM
vkalintiris accepted D26192: [mips] Fix unsigned/signed type error.

LGTM.

Nov 15 2016, 8:49 AM

Nov 2 2016

vkalintiris accepted D24607: [mips] seq macro support .

LGTM but there's a wrong constant that you should change before committing this.

Nov 2 2016, 10:59 AM
vkalintiris committed rL285814: [mips] Always run the MipsOptimizePICCall pass..
[mips] Always run the MipsOptimizePICCall pass.
Nov 2 2016, 8:21 AM
vkalintiris closed D26036: [mips] Always run the MipsOptimizePICCall pass. by committing rL285814: [mips] Always run the MipsOptimizePICCall pass..
Nov 2 2016, 8:21 AM

Oct 27 2016

vkalintiris retitled D26036: [mips] Always run the MipsOptimizePICCall pass. from to [mips] Always run the MipsOptimizePICCall pass..
Oct 27 2016, 9:12 AM
vkalintiris committed rL285305: [mips] Do not allow -opt-bisect-limit to skip the PIC call optimization pass..
[mips] Do not allow -opt-bisect-limit to skip the PIC call optimization pass.
Oct 27 2016, 9:00 AM

Oct 25 2016

vkalintiris requested changes to D24607: [mips] seq macro support .

I didn't consider all the cases but it seems that the macro expansion is probably fine in terms of correctness. However, the expansion is different from that of GAS' and this will generate different object files unnecessarily. As far as I can tell, GAS handles these macro in 3 different ways depending on the value of the immediate:

Oct 25 2016, 7:49 AM

Oct 24 2016

vkalintiris accepted D25795: [mips] synci microMIPS instruction definition..

LGTM.

Oct 24 2016, 2:40 AM

Oct 21 2016

vkalintiris added a comment to D25438: [mips] Fix Mips MSA instrinsics.

From immediates-bad.ll:

define void @addvi_d(<2 x i64> * %ptr) {
entry:
; CHECK-LABEL: addvi_d:
; CHECK: addv.d
  %a = load <2 x i64>, <2 x i64> * %ptr, align 16
  %r = call <2 x i64> @llvm.mips.addvi.d(<2 x i64> %a, i32 65)
  store <2 x i64> %r, <2 x i64> * %ptr, align 16
  ret void
}

will crash LLVM. Dump from llc:

Assertion failed: (width > BitWidth && "Invalid APInt ZeroExtend request"), function zext, file /Users/simon/dev/llvm/llvm2/llvm/lib/Support/APInt.cpp, line 981.
Stack dump:
0.	Program arguments: /Users/simon/dev/llvm/llvm2/llvmgitsvnbuild/./bin/llc -march=mips -mattr=+msa,+fp64 -relocation-model=pic 
1.	Running pass 'Function Pass Manager' on module '<stdin>'.
2.	Running pass 'MIPS DAG->DAG Pattern Instruction Selection' on function '@addvi_d'

As you can seeI think there may be another solution though, which is to constrain the type of the immediate operand down to things like i5. I would have to reinvestigate.

Oct 21 2016, 9:13 AM

Oct 19 2016

vkalintiris requested changes to D24607: [mips] seq macro support .

We generate different code from the GNU assembler which in some cases is wrong, see inline comment.

Oct 19 2016, 6:13 AM
vkalintiris accepted D24722: [mips] Correct jal expansion for local symbols in .local directives..

LGTM once its dependency lands.

Oct 19 2016, 4:47 AM
vkalintiris added a comment to D25438: [mips] Fix Mips MSA instrinsics.

Why shouldn't we "crash" when we pass invalid/bad constant immediates to our intrinsics? Do you have a case in mind that causes us problems if we do so?

Oct 19 2016, 4:40 AM

Oct 18 2016

vkalintiris accepted D24558: [mips][mcjit] Add the majority of N32 support..

LGTM.

Oct 18 2016, 9:00 AM
vkalintiris accepted D25672: [mips] Fix sync instruction definition.

LGTM.

Oct 18 2016, 7:18 AM
vkalintiris accepted D24556: [mips] Macro expansion for ld, sd for O32.

LGTM.

Oct 18 2016, 6:38 AM
vkalintiris accepted D24667: [mips][ias] Handle more complicated expressions for memory operands.

LGTM.

Oct 18 2016, 6:36 AM
vkalintiris added inline comments to D24824: [mips][FastISel] Instantiate the MipsFastISel class only for targets that support FastISel..
Oct 18 2016, 6:18 AM
vkalintiris committed rL284475: [mips][FastISel] Instantiate the MipsFastISel class only for targets that….
[mips][FastISel] Instantiate the MipsFastISel class only for targets that…
Oct 18 2016, 6:15 AM
vkalintiris closed D24824: [mips][FastISel] Instantiate the MipsFastISel class only for targets that support FastISel. by committing rL284475: [mips][FastISel] Instantiate the MipsFastISel class only for targets that….
Oct 18 2016, 6:15 AM
vkalintiris requested changes to D22520: [mips] zeroext and logical 'and' mask optimizations.

Marking this with "Request Changes" based on my last comment.

Oct 18 2016, 4:58 AM
vkalintiris requested changes to D23159: [mips] MIPSR6 delay slot filler optimization..

When I tested this I noticed that MultiSource/Benchmarks/7zip/7zip-benchmark was failing. I'm marking this with "Request Changes" to better keep track of the pending review requests.

Oct 18 2016, 4:57 AM · Restricted Project
vkalintiris added inline comments to D25017: [mips][msa] Range check MSA intrinsics with immediates.
Oct 18 2016, 4:35 AM
vkalintiris accepted D25017: [mips][msa] Range check MSA intrinsics with immediates.

LGTM. See inline comments for a few small changes.

Oct 18 2016, 4:24 AM

Sep 28 2016

vkalintiris updated the diff for D24824: [mips][FastISel] Instantiate the MipsFastISel class only for targets that support FastISel..

Cleanup FastISel support checks and remember to reject it on MIPS16 as well.

Sep 28 2016, 12:19 PM

Sep 27 2016

vkalintiris requested changes to D24510: [mips] Correct c.cond.fmt instruction definition..

I'm getting a few test failures from the LLVM test-suite for MIPS32R2. Can you take a look at what's going wrong and update the patch before I review it? Given the symmetry of the code I'd expect, more or less, the same test failures to happen for microMIPS32R2 too but I'm not sure.

Sep 27 2016, 9:20 AM
vkalintiris added a comment to D24510: [mips] Correct c.cond.fmt instruction definition..

Hi Sean, is your intention to LGTM this patch by accepting it, or to convey that it's working fine for *BSDs?

I had hoped to express that it is an improvement to our FreeBSD toolchain. I cannot comment reliably on quality outside of style or the ability to be able to apply this review to a trunk checkout.

Sep 27 2016, 7:08 AM
vkalintiris accepted D24912: [mips] Disable tail calls temporarily.

LGTM.

Sep 27 2016, 5:17 AM
vkalintiris added a comment to D24510: [mips] Correct c.cond.fmt instruction definition..

Hi Sean, is your intention to LGTM this patch by accepting it, or to convey that it's working fine for *BSDs?

Sep 27 2016, 4:28 AM

Sep 26 2016

vkalintiris added a comment to D24721: [MC][MCParser] Mark local and weak symbols as such when parsing assembly text.

We should split this in two separate review requests, ie. one that introduces symbol dumping and another that marks local and weak symbols. Can you also add a separate test file just for checking the newly introduced -asm-show-symbol-table option?

Sep 26 2016, 8:09 AM

Sep 22 2016

vkalintiris requested changes to D24667: [mips][ias] Handle more complicated expressions for memory operands.
Sep 22 2016, 8:20 AM
vkalintiris requested changes to D24556: [mips] Macro expansion for ld, sd for O32.
Sep 22 2016, 7:06 AM
vkalintiris added inline comments to D24505: [mips][fastisel] Consider soft-float an unsupported floating point mode.
Sep 22 2016, 5:39 AM
vkalintiris added a reviewer for D24824: [mips][FastISel] Instantiate the MipsFastISel class only for targets that support FastISel.: sdardis.
Sep 22 2016, 5:34 AM
vkalintiris retitled D24824: [mips][FastISel] Instantiate the MipsFastISel class only for targets that support FastISel. from to [mips][FastISel] Instantiate the MipsFastISel class only for targets that support FastISel..
Sep 22 2016, 5:34 AM
vkalintiris abandoned D24823: [mips][FastISel] Instantiate the MipsFastISel class only for targets that support FastISel..

Abandoning this because arc didn't add llvm-commits.

Sep 22 2016, 5:20 AM
vkalintiris retitled D24823: [mips][FastISel] Instantiate the MipsFastISel class only for targets that support FastISel. from to [mips][FastISel] Instantiate the MipsFastISel class only for targets that support FastISel..
Sep 22 2016, 5:18 AM

Sep 21 2016

vkalintiris accepted D24499: [mips] Add rsqrt, recip for MIPS.

LGTM.

Sep 21 2016, 5:29 AM

Sep 20 2016

vkalintiris accepted D24674: [mips] MSA intrinsics header file.

@sdardis: can you update the review request before committing this because I don't think that test/CodeGen/builtins-mips-msa.c has ever been properly reviewed before.

Sep 20 2016, 9:07 AM
vkalintiris requested changes to D24674: [mips] MSA intrinsics header file.

@sdardis: can you update the review request before committing this because I don't think that test/CodeGen/builtins-mips-msa.c has ever been properly reviewed before.

Sep 20 2016, 9:01 AM
vkalintiris added a comment to D24448: [atomics] New warning -Watomic-libcall when atomic operation expands to a library call .

I removed myself from the reviewers because I'm not quite familiar with this area. @joerg I added you as reviewer because you've already commented, feel free to undo my change if you don't have time to review this.

Sep 20 2016, 8:38 AM
vkalintiris edited reviewers for D24448: [atomics] New warning -Watomic-libcall when atomic operation expands to a library call , added: joerg; removed: vkalintiris.
Sep 20 2016, 8:36 AM
vkalintiris accepted D24291: [mips] Add IAS support for dvp, evp.

LGTM with a few minor changes, see inline comments.

Sep 20 2016, 8:25 AM
vkalintiris added a comment to D22520: [mips] zeroext and logical 'and' mask optimizations.

Can you take a look at CodeGen/Mips/cconv/arguments-varargs.ll because it fails for me (and rebase the patch while at it :))?

Sep 20 2016, 6:31 AM
vkalintiris accepted D24674: [mips] MSA intrinsics header file.

LGTM with one comment/question inline.

Sep 20 2016, 6:12 AM

Sep 7 2016

vkalintiris accepted D24077: [mips] LLVM PR/30197 - Tail call incorrectly clobbers arguments.

LGTM but make sure that the checks from the new test enforce the correct ordering of loads/stores.

Sep 7 2016, 5:59 AM
vkalintiris committed rL280798: [mips] Disable the TImode shift libcalls for 32-bit targets..
[mips] Disable the TImode shift libcalls for 32-bit targets.
Sep 7 2016, 3:09 AM
vkalintiris closed D24259: [mips] Disable the TImode shift libcalls for 32-bit targets. by committing rL280798: [mips] Disable the TImode shift libcalls for 32-bit targets..
Sep 7 2016, 3:09 AM

Sep 6 2016

vkalintiris retitled D24259: [mips] Disable the TImode shift libcalls for 32-bit targets. from to [mips] Disable the TImode shift libcalls for 32-bit targets..
Sep 6 2016, 9:15 AM

Sep 5 2016

vkalintiris added a comment to D24184: [CMake] Use CMake's default RPATH for the unit tests.

When building with BUILD_SHARED_LIBRARIES, such tests don't manage
to find their libraries and are consequently not run (due to a bug
in LIT, this isn't even reported!).

Sep 5 2016, 4:50 AM

Sep 2 2016

vkalintiris added a comment to D24129: GVN-hoist: disable hoisting stores (PR30216).

Hi Sebastian. I tried this on one of our BB that tests recursive builds and test/Transforms/GVN/pr28626.ll is failing. I'm getting the same failure on an X86_64 host.

Sep 2 2016, 4:35 AM

Sep 1 2016

vkalintiris accepted D23795: [mips] Tighten FastISel restrictions.

Thanks! LGTM.

Sep 1 2016, 5:24 AM

Aug 30 2016

vkalintiris requested changes to D23795: [mips] Tighten FastISel restrictions.

The code changes LGTM but the test case doesn't look like it is testing the right thing.

Aug 30 2016, 8:24 AM
vkalintiris committed rL280084: [mips][tsan] XFAIL on every MIPS platform an x86_64-specific test..
[mips][tsan] XFAIL on every MIPS platform an x86_64-specific test.
Aug 30 2016, 6:09 AM

Aug 17 2016

vkalintiris accepted D23121: [mips] Add l.[sd] and s.[sd] instruction aliases.

LGTM with two small test fixes.

Aug 17 2016, 5:38 AM

Aug 8 2016

vkalintiris committed rL277998: Add release note for the MIPS target..
Add release note for the MIPS target.
Aug 8 2016, 5:36 AM

Aug 3 2016

vkalintiris updated subscribers of D23107: [MSAN][MIPS] Fix fork.cc test on MIPS.
Aug 3 2016, 2:06 AM · Restricted Project
vkalintiris updated subscribers of D22994: [MemorySanitizer] [MIPS] Changed memory mapping to support pie executable..
Aug 3 2016, 2:05 AM · Restricted Project
vkalintiris updated subscribers of D22993: [MSAN][MIPS] Changed memory mapping to support pie executable..
Aug 3 2016, 2:05 AM · Restricted Project

Jun 22 2016

vkalintiris accepted D21608: [mips] Fix dext/dins definitions.

LGTM.

Jun 22 2016, 11:13 AM

Jun 18 2016

vkalintiris committed rL273085: [mips] Emit a JALR with $rd equal to $zero, instead of a JR in MIPS32R6..
[mips] Emit a JALR with $rd equal to $zero, instead of a JR in MIPS32R6.
Jun 18 2016, 8:46 AM
vkalintiris closed D21370: [mips] Emit a JALR with $rd equal to $zero, instead of a JR in MIPS32R6. by committing rL273085: [mips] Emit a JALR with $rd equal to $zero, instead of a JR in MIPS32R6..
Jun 18 2016, 8:46 AM

Jun 16 2016

vkalintiris committed rL272895: [mips] Fix small typo. NFC..
[mips] Fix small typo. NFC.
Jun 16 2016, 7:32 AM

Jun 15 2016

vkalintiris committed rL272794: [mips] Eliminate unused code for addrRegReg complex pattern. NFC..
[mips] Eliminate unused code for addrRegReg complex pattern. NFC.
Jun 15 2016, 8:37 AM
vkalintiris closed D21381: [mips] Eliminate unused code for addrRegReg complex pattern. NFC. by committing rL272794: [mips] Eliminate unused code for addrRegReg complex pattern. NFC..
Jun 15 2016, 8:36 AM
vkalintiris retitled D21381: [mips] Eliminate unused code for addrRegReg complex pattern. NFC. from to [mips] Eliminate unused code for addrRegReg complex pattern. NFC..
Jun 15 2016, 7:50 AM
vkalintiris retitled D21370: [mips] Emit a JALR with $rd equal to $zero, instead of a JR in MIPS32R6. from to [mips] Emit a JALR with $rd equal to $zero, instead of a JR in MIPS32R6..
Jun 15 2016, 4:12 AM

Jun 8 2016

vkalintiris committed rL272138: [mips] Add a proper file header in MipsFastISel.cpp.
[mips] Add a proper file header in MipsFastISel.cpp
Jun 8 2016, 6:20 AM

Jun 5 2016

vkalintiris abandoned D16803: Use ComputeNumSignBits to fold (sext_inreg (trunc x)) -> (trunc x).
Jun 5 2016, 10:40 AM
vkalintiris abandoned D16290: [mips] Optimize materialization of i64 constants..
Jun 5 2016, 10:40 AM
vkalintiris abandoned D16221: [mips] Promote SETCC operands to i64 for 64-bit ISAs..
Jun 5 2016, 10:40 AM
vkalintiris abandoned D16220: [mips] Fix RetCC_MipsN to promote types smaller than i64 to GPR-width..
Jun 5 2016, 10:40 AM
vkalintiris abandoned D15145: Add expressions to ignore vim swap files in .gitinore..
Jun 5 2016, 10:39 AM
vkalintiris abandoned D13944: [plot2fig] Use the POSIX regex functions on Linux instead of the old/obsolete BSD ones..
Jun 5 2016, 10:39 AM
vkalintiris abandoned D13939: [archie-client][mips] Define NOREGEX macro since MUSL doesn't provide re_{comp,exec}()..
Jun 5 2016, 10:39 AM
vkalintiris abandoned D13938: [office-ispell] Use POSIX-compliant termios.h header on Linux instead of termio.h & sgtty.h..
Jun 5 2016, 10:39 AM
vkalintiris abandoned D13139: [builtins] Build both static and shared versions of the builtins library..
Jun 5 2016, 10:39 AM
vkalintiris abandoned D13025: Modify cmake to test whether link version scripts are supported..
Jun 5 2016, 10:39 AM
vkalintiris abandoned D9161: Make foldMemoryOperandImpl() insert instructions instead of caller..
Jun 5 2016, 10:38 AM
vkalintiris abandoned D5796: [mips] Avoid redudant store when generating code for ExtractElementF64 nodes.
Jun 5 2016, 10:37 AM

May 23 2016

vkalintiris added a comment to D20464: [LLDB][MIPS] Check if libatomic needs to be specified explicitly..

From what I remember it boils down to the fact that we don't want to have atomics whose width isn't natively supported on our targets. Take a look at the comments from this thread: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20160125/328321.html.

May 23 2016, 10:56 AM

May 16 2016

vkalintiris committed rL269651: [mips] Add test for the dynamic linker when using the mips64el-fedora-linux….
[mips] Add test for the dynamic linker when using the mips64el-fedora-linux…
May 16 2016, 5:00 AM

May 13 2016

vkalintiris committed rL269412: Simplify getLinuxDynamicLinker() by using a common variable for the triple. NFC..
Simplify getLinuxDynamicLinker() by using a common variable for the triple. NFC.
May 13 2016, 5:40 AM
vkalintiris committed rL269411: [mips] Consult triple's vendor field before using musl's interpreter..
[mips] Consult triple's vendor field before using musl's interpreter.
May 13 2016, 5:19 AM

Apr 22 2016

vkalintiris committed rL267149: [mips] Fix a small typo that would leave BLTZC out of getAnalyzableBrOpc().'.
[mips] Fix a small typo that would leave BLTZC out of getAnalyzableBrOpc().'
Apr 22 2016, 6:11 AM
vkalintiris accepted D19378: [mips] Fix select patterns for MIPS64.

LGTM with the addition of one test for the M3 prefix.

Apr 22 2016, 5:46 AM

Apr 20 2016

vkalintiris accepted D17540: [MIPS][LLVM-MC] Fix Disassemble of Negative Offset .

Hi Nitesh, you can go ahead and commit this. But you should change the comments from:

Apr 20 2016, 2:23 AM

Apr 19 2016

vkalintiris updated subscribers of D19168: [esan] EfficiencySanitizer base runtime library.
Apr 19 2016, 3:15 AM
vkalintiris updated subscribers of D19167: [esan] EfficiencySanitizer instrumentation pass.
Apr 19 2016, 3:15 AM

Apr 17 2016

vkalintiris accepted D19166: [mips][ias] Prevent double-filling of delay slots by generating '.set noreorder' regions..

LGTM.

Apr 17 2016, 1:48 PM