Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp | ||
---|---|---|
587–592 | I'm not a huge fan of different defaults per platform, wouldn't it be easier to just specify this for the platforms where you want this enabled? |
llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp | ||
---|---|---|
587–592 | I think it should be default, and I am just giving android time to investigate. How about I land as is and soon after we remove exceptions, so it would be easy to bisect/revert if it's not good enough for android. |
I'm not a huge fan of different defaults per platform, wouldn't it be easier to just specify this for the platforms where you want this enabled?