Page MenuHomePhabricator

fmayer (Florian Mayer)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 3 2020, 4:23 AM (116 w, 6 d)

Recent Activity

Yesterday

fmayer committed rGe06c9b63bc7b: [NFC] [HWASan] remove unnecessary cast (authored by fmayer).
[NFC] [HWASan] remove unnecessary cast
Wed, Sep 28, 5:48 PM · Restricted Project, Restricted Project
fmayer accepted D134796: [StackLifetime] More efficient loop for LivenessType::Must.
Wed, Sep 28, 4:14 PM · Restricted Project, Restricted Project
fmayer committed rG0401dc2913cd: [MTE] [HWASan] unify isInterestingAlloca (authored by fmayer).
[MTE] [HWASan] unify isInterestingAlloca
Wed, Sep 28, 3:53 PM · Restricted Project, Restricted Project
fmayer closed D134779: [MTE] [HWASan] unify isInterestingAlloca.
Wed, Sep 28, 3:52 PM · Restricted Project, Restricted Project
fmayer added inline comments to D134796: [StackLifetime] More efficient loop for LivenessType::Must.
Wed, Sep 28, 12:56 PM · Restricted Project, Restricted Project

Tue, Sep 27

fmayer committed rG979db5343f01: [HWASan] [NFC] use auto* over auto& for pointers (authored by fmayer).
[HWASan] [NFC] use auto* over auto& for pointers
Tue, Sep 27, 6:24 PM · Restricted Project, Restricted Project
fmayer requested review of D134779: [MTE] [HWASan] unify isInterestingAlloca.
Tue, Sep 27, 6:16 PM · Restricted Project, Restricted Project

Wed, Sep 21

fmayer committed rGa3153381af48: [libunwind] Handle G in personality string (authored by fmayer).
[libunwind] Handle G in personality string
Wed, Sep 21, 2:14 PM · Restricted Project
fmayer closed D128998: [libunwind] Handle G in personality string.
Wed, Sep 21, 2:13 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Sep 20

fmayer updated the diff for D128998: [libunwind] Handle G in personality string.

comment

Tue, Sep 20, 2:48 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 19

fmayer updated the diff for D128998: [libunwind] Handle G in personality string.

naming

Mon, Sep 19, 5:15 PM · Restricted Project, Restricted Project, Restricted Project
fmayer edited reviewers for D128998: [libunwind] Handle G in personality string, added: compnerd; removed: MaskRay.
Mon, Sep 19, 2:33 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Sep 16

fmayer added inline comments to D128998: [libunwind] Handle G in personality string.
Fri, Sep 16, 1:51 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 15

fmayer added inline comments to D128998: [libunwind] Handle G in personality string.
Thu, Sep 15, 4:50 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D128998: [libunwind] Handle G in personality string.
Thu, Sep 15, 3:02 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D128998: [libunwind] Handle G in personality string.
Thu, Sep 15, 2:11 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D128998: [libunwind] Handle G in personality string.
Thu, Sep 15, 1:37 PM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D128998: [libunwind] Handle G in personality string.

comments

Thu, Sep 15, 1:37 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Sep 14

fmayer updated the summary of D128998: [libunwind] Handle G in personality string.
Wed, Sep 14, 5:17 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 12

fmayer updated the diff for D133582: [ASan] rename internal references to left of/right of..

nit

Mon, Sep 12, 2:48 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added a comment to D133582: [ASan] rename internal references to left of/right of..

PTAL. I'd like to merge this earlier rather than later if possible, to avoid merge conflicts.

Mon, Sep 12, 2:14 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added a comment to D133582: [ASan] rename internal references to left of/right of..

PTAL. I'd like to merge this earlier rather than later if possible, to avoid merge conflicts.

Mon, Sep 12, 2:14 PM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D133582: [ASan] rename internal references to left of/right of..

nit

Mon, Sep 12, 2:13 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D133673: [NFC][msan] Convert some code to early returns.
Mon, Sep 12, 11:49 AM · Restricted Project, Restricted Project

Fri, Sep 9

fmayer added a comment to D132611: [ASan] rename left/right to before/after..

the same person also noticed that in the shadow map we dump shadow addresses rather than "real" addresses, which i'd never noticed because i just ignore that bit as being "for experts only". one day i might be brave enough to admit that i don't know whether i'm supposed to be using it, and if so, for what :-)

Fri, Sep 9, 11:52 AM · Restricted Project, Restricted Project
fmayer updated subscribers of D133582: [ASan] rename internal references to left of/right of..
Fri, Sep 9, 10:12 AM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D133582: [ASan] rename internal references to left of/right of..

typo

Fri, Sep 9, 10:10 AM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D133582: [ASan] rename internal references to left of/right of..

preceding -> front, succeeding -> back

Fri, Sep 9, 10:09 AM · Restricted Project, Restricted Project, Restricted Project
fmayer added a comment to D133582: [ASan] rename internal references to left of/right of..

Another option (probably better, WDYT?): replace preceding/succeeding with front/back.

Fri, Sep 9, 9:07 AM · Restricted Project, Restricted Project, Restricted Project
fmayer added a comment to D132611: [ASan] rename left/right to before/after..

If you want to update this, please do it everywhere.

(I don't think it's clearer and it broke a bunch of our tests, so I'm a bit grumpy about this change. Apologies.)

Fri, Sep 9, 8:48 AM · Restricted Project, Restricted Project
fmayer requested review of D133582: [ASan] rename internal references to left of/right of..
Fri, Sep 9, 8:47 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 8

fmayer accepted D133232: [msan] Disambiguate warnings debug location.
Thu, Sep 8, 11:22 AM · Restricted Project, Restricted Project

Wed, Sep 7

fmayer committed rG178554f3c8f9: [ASan] Show memory rather than tag addresses in tag dump (authored by fmayer).
[ASan] Show memory rather than tag addresses in tag dump
Wed, Sep 7, 1:23 PM · Restricted Project, Restricted Project
fmayer closed D133391: [ASan] Show memory rather than tag addresses in tag dump.
Wed, Sep 7, 1:23 PM · Restricted Project, Restricted Project
fmayer added a comment to D133391: [ASan] Show memory rather than tag addresses in tag dump.

LGTM

Maybe add a few compile-time checks that mem->shadow->mem returns the original value? At least the sparc equations are complicated enough.

Wed, Sep 7, 1:05 PM · Restricted Project, Restricted Project
fmayer updated the diff for D133391: [ASan] Show memory rather than tag addresses in tag dump.

add static assert

Wed, Sep 7, 12:51 PM · Restricted Project, Restricted Project
fmayer accepted D133392: [MTE] Add AArch64GlobalsTagging Pass.
Wed, Sep 7, 12:42 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D133392: [MTE] Add AArch64GlobalsTagging Pass.
Wed, Sep 7, 11:04 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Sep 6

fmayer added inline comments to D133392: [MTE] Add AArch64GlobalsTagging Pass.
Tue, Sep 6, 6:19 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added a reviewer for D133391: [ASan] Show memory rather than tag addresses in tag dump: eugenis.
Tue, Sep 6, 6:05 PM · Restricted Project, Restricted Project
fmayer requested review of D133391: [ASan] Show memory rather than tag addresses in tag dump.
Tue, Sep 6, 6:05 PM · Restricted Project, Restricted Project
fmayer committed rG4f5147a7cff5: [HWASan] Show memory rather than tag addresses in tag dump (authored by fmayer).
[HWASan] Show memory rather than tag addresses in tag dump
Tue, Sep 6, 4:55 PM · Restricted Project, Restricted Project
fmayer closed D133380: [HWASan] Show memory rather than tag addresses in tag dump.
Tue, Sep 6, 4:54 PM · Restricted Project, Restricted Project
fmayer added a reviewer for D133380: [HWASan] Show memory rather than tag addresses in tag dump: eugenis.
Tue, Sep 6, 3:52 PM · Restricted Project, Restricted Project
fmayer requested review of D133380: [HWASan] Show memory rather than tag addresses in tag dump.
Tue, Sep 6, 3:19 PM · Restricted Project, Restricted Project
fmayer accepted D133336: [msan] Convert Msan to ModulePass.
Tue, Sep 6, 2:24 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D133232: [msan] Disambiguate warnings debug location.
Tue, Sep 6, 2:21 PM · Restricted Project, Restricted Project
fmayer committed rG9006b082a5e5: [HWASan] rename left/right to before/after. (authored by fmayer).
[HWASan] rename left/right to before/after.
Tue, Sep 6, 1:52 PM · Restricted Project, Restricted Project
fmayer closed D132622: [HWASan] rename left/right to before/after..
Tue, Sep 6, 1:52 PM · Restricted Project, Restricted Project
fmayer committed rGa51d19636cd6: [ASan] Fix libfuzzer test (authored by fmayer).
[ASan] Fix libfuzzer test
Tue, Sep 6, 1:38 PM · Restricted Project, Restricted Project
fmayer committed rGbe366041fa65: [ASan] rename left/right to before/after. (authored by fmayer).
[ASan] rename left/right to before/after.
Tue, Sep 6, 1:25 PM · Restricted Project, Restricted Project
fmayer closed D132611: [ASan] rename left/right to before/after..
Tue, Sep 6, 1:25 PM · Restricted Project, Restricted Project

Thu, Sep 1

fmayer added a comment to D132611: [ASan] rename left/right to before/after..

This is fine from my perspective, if we want to be extra cautious it might be worth sending an announcement to Discourse before landing this change.

Thu, Sep 1, 2:14 PM · Restricted Project, Restricted Project
fmayer added a comment to D132622: [HWASan] rename left/right to before/after..

Ping

Thu, Sep 1, 1:28 PM · Restricted Project, Restricted Project

Aug 29 2022

fmayer added a comment to D128998: [libunwind] Handle G in personality string.

The clean part in the name and the clean parameter feels unclear to me.

And this.

Aug 29 2022, 6:12 PM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the summary of D128998: [libunwind] Handle G in personality string.
Aug 29 2022, 6:02 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added a comment to D128998: [libunwind] Handle G in personality string.

About __unw_clean_step:

libunwind/src/libunwind_ext.h provides a bunch of API which are not implemented by https://github.com/libunwind/libunwind .
Before we settle on an API there, it's worth raising an issue on https://github.com/libunwind/libunwind and giving them some time for the API design.

AFAICT my change does not in fact expose a new API, because it does not use _LIBUNWIND_WEAK_ALIAS, so __unw_clean_step will remain hidden visiblity.

Aug 29 2022, 3:43 PM · Restricted Project, Restricted Project, Restricted Project

Aug 25 2022

fmayer updated the diff for D132611: [ASan] rename left/right to before/after..

update

Aug 25 2022, 1:38 PM · Restricted Project, Restricted Project

Aug 24 2022

fmayer added a comment to D132611: [ASan] rename left/right to before/after..

https://github.com/google/clusterfuzz/blob/master/src/clusterfuzz/tests/test.py still passes if I change https://github.com/google/clusterfuzz/blob/master/src/clusterfuzz/tests/testdata/asan_stacktrace.txt to use the new format

Aug 24 2022, 6:09 PM · Restricted Project, Restricted Project
fmayer added a comment to D132622: [HWASan] rename left/right to before/after..
Aug 24 2022, 5:58 PM · Restricted Project, Restricted Project
fmayer updated the diff for D132611: [ASan] rename left/right to before/after..

fix tests

Aug 24 2022, 5:48 PM · Restricted Project, Restricted Project
fmayer planned changes to D132611: [ASan] rename left/right to before/after..

Need to fix tests, sorry, messed something up.

Aug 24 2022, 5:28 PM · Restricted Project, Restricted Project
fmayer added a reviewer for D132622: [HWASan] rename left/right to before/after.: eugenis.
Aug 24 2022, 4:41 PM · Restricted Project, Restricted Project
fmayer requested review of D132622: [HWASan] rename left/right to before/after..
Aug 24 2022, 4:40 PM · Restricted Project, Restricted Project
fmayer added a reviewer for D132611: [ASan] rename left/right to before/after.: eugenis.
Aug 24 2022, 2:53 PM · Restricted Project, Restricted Project
fmayer added a comment to D132611: [ASan] rename left/right to before/after..

not arguing for or against, but I wonder how many output parsers will break.

Aug 24 2022, 2:49 PM · Restricted Project, Restricted Project
fmayer updated the diff for D132611: [ASan] rename left/right to before/after..

test update

Aug 24 2022, 2:47 PM · Restricted Project, Restricted Project
fmayer requested review of D132611: [ASan] rename left/right to before/after..
Aug 24 2022, 2:45 PM · Restricted Project, Restricted Project

Aug 15 2022

fmayer added inline comments to D128998: [libunwind] Handle G in personality string.
Aug 15 2022, 10:17 AM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the summary of D128998: [libunwind] Handle G in personality string.
Aug 15 2022, 10:09 AM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the summary of D128998: [libunwind] Handle G in personality string.
Aug 15 2022, 10:09 AM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the summary of D128998: [libunwind] Handle G in personality string.
Aug 15 2022, 10:07 AM · Restricted Project, Restricted Project, Restricted Project
fmayer added a comment to D128998: [libunwind] Handle G in personality string.

About __unw_clean_step:

libunwind/src/libunwind_ext.h provides a bunch of API which are not implemented by https://github.com/libunwind/libunwind .
Before we settle on an API there, it's worth raising an issue on https://github.com/libunwind/libunwind and giving them some time for the API design.

Aug 15 2022, 10:06 AM · Restricted Project, Restricted Project, Restricted Project

Aug 5 2022

fmayer added a reviewer for D128998: [libunwind] Handle G in personality string: MaskRay.
Aug 5 2022, 5:15 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D128998: [libunwind] Handle G in personality string.
Aug 5 2022, 5:14 PM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D128998: [libunwind] Handle G in personality string.

address comments

Aug 5 2022, 5:14 PM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D128998: [libunwind] Handle G in personality string.

add comment

Aug 5 2022, 1:24 PM · Restricted Project, Restricted Project, Restricted Project
fmayer committed rG29ff262761af: [HWASan] Remove incorrect unreachable. (authored by fmayer).
[HWASan] Remove incorrect unreachable.
Aug 5 2022, 1:14 PM · Restricted Project, Restricted Project
fmayer closed D131279: [HWASan] Remove incorrect unreachable..
Aug 5 2022, 1:14 PM · Restricted Project, Restricted Project
fmayer added inline comments to D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions.
Aug 5 2022, 12:44 PM · Restricted Project, Restricted Project
fmayer added inline comments to D128998: [libunwind] Handle G in personality string.
Aug 5 2022, 12:42 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions.
Aug 5 2022, 12:21 PM · Restricted Project, Restricted Project
fmayer added a comment to D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions.

Hi folks,

I've been working on support hwasan for risc-v and I believe I've found an issue with the existing lit tests this commit causes.
Tests stack-{oob,uar,uas}.c check for correct backtrace being printed. From the code and comments the idea is to not to print any hwasan related frames(see the code and comments below).

void HandleTagMismatch(AccessInfo ai, uptr pc, uptr frame, void *uc,                                
                       uptr *registers_frame) {                                                     
  InternalMmapVector<BufferedStackTrace> stack_buffer(1);                                           
  BufferedStackTrace *stack = stack_buffer.data();                                                  
  stack->Reset();                                                                                   
  stack->Unwind(pc, frame, uc, common_flags()->fast_unwind_on_fatal);                               
                                                                                                    
  // The second stack frame contains the failure __hwasan_check function, as                        
  // we have a stack frame for the registers saved in __hwasan_tag_mismatch that                    
  // we wish to ignore. This (currently) only occurs on AArch64, as x64                      
  // implementations use SIGTRAP to implement the failure, and thus do not go                       
  // through the stack saver.                                                                       
  if (registers_frame && stack->trace && stack->size > 0) {                                         
    stack->trace++;                                                                              
    stack->size--;                                                                               
  }

Before this commit the return address and frame pointer to were taken directly from hwasan_tag_mismatch4, while after the commit those addresses are calculated after another function being called from hwasan_tag_mismatch4 (the HwasanTagMismatch one).
So, if I understand it correctly, now it looks like 2 stack frames must be ignored(for hwasan_tag_mismatch4 and HwasanTagMismatch) to get a proper backtrace.
What do you think?

Thanks

Aug 5 2022, 12:20 PM · Restricted Project, Restricted Project
fmayer published D131279: [HWASan] Remove incorrect unreachable. for review.
Aug 5 2022, 12:18 PM · Restricted Project, Restricted Project

Aug 4 2022

fmayer committed rGfc6a6ee507ec: [libunwind] undef NDEBUG for assert.h in tests. (authored by fmayer).
[libunwind] undef NDEBUG for assert.h in tests.
Aug 4 2022, 7:56 PM · Restricted Project
fmayer closed D131210: [libunwind] undef NDEBUG for assert.h in tests..
Aug 4 2022, 7:55 PM · Restricted Project, Restricted Project, Restricted Project
fmayer published D128998: [libunwind] Handle G in personality string for review.

In addition to the test described in the message, I ran the libunwind test suites on FVP with SANITIZE_TARGET=memtag-stack and they still pass.

Aug 4 2022, 7:32 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added a reviewer for D131210: [libunwind] undef NDEBUG for assert.h in tests.: MaskRay.
Aug 4 2022, 3:06 PM · Restricted Project, Restricted Project, Restricted Project
fmayer requested review of D131210: [libunwind] undef NDEBUG for assert.h in tests..
Aug 4 2022, 3:05 PM · Restricted Project, Restricted Project, Restricted Project

Aug 3 2022

fmayer added a comment to D130956: [X86][MC] Always emit `rep` prefix for `bsf`.

I'll revert, I'll have to do a fixup for a dependent patch that I committed after this.

Aug 3 2022, 2:50 PM · Restricted Project, Restricted Project
fmayer added a comment to D130956: [X86][MC] Always emit `rep` prefix for `bsf`.

This seems related to an error we see on our sanitizer bots: https://lab.llvm.org/buildbot/#/builders/37/builds/15446/steps/33/logs/stdio

Aug 3 2022, 2:39 PM · Restricted Project, Restricted Project

Aug 2 2022

fmayer accepted D131017: Fix use-after-free in clang-apply-replacements.
Aug 2 2022, 1:33 PM · Restricted Project, Restricted Project
fmayer added a comment to D130934: [clang] Update code that assumes FileEntry::getName is absolute NFC.

This CL seems to have an MSAN violation: https://lab.llvm.org/buildbot/#/builders/74/builds/12529/steps/11/logs/stdio

Aug 2 2022, 1:23 PM · Restricted Project, Restricted Project, Restricted Project

Aug 1 2022

fmayer added a comment to rG9028966a7172: [clang] Don't create executable in test.
Aug 1 2022, 5:22 PM · Restricted Project, Restricted Project
fmayer added a comment to rG9028966a7172: [clang] Don't create executable in test.

This broke the sanitizer buildbot: https://lab.llvm.org/buildbot/#/builders/168/builds/7879/steps/11/logs/stdio

Aug 1 2022, 4:59 PM · Restricted Project, Restricted Project

Jul 29 2022

fmayer added a comment to D130718: [compiler-rt] [builtins] Detect _Float16 support at compile time.

I think this broke the sanitizer-windows buildbot: https://lab.llvm.org/buildbot/#/builders/127/builds/33583/steps/4/logs/stdio

Jul 29 2022, 5:23 PM · Restricted Project, Restricted Project

Jul 1 2022

fmayer accepted D128873: [NFC][sanitizer] Minor change: eliminate loop.

Looks good! Please add "[NFC]" to the commit message to indicate this change is non-functional.

Jul 1 2022, 9:07 AM · Restricted Project, Restricted Project
fmayer added inline comments to D128958: Add assembler plumbing for sanitize_memtag.
Jul 1 2022, 8:59 AM · Restricted Project, Restricted Project, Restricted Project

Jun 27 2022

fmayer updated subscribers of D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC.
Jun 27 2022, 2:52 PM · Restricted Project, Restricted Project

Jun 24 2022

fmayer added a comment to D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC.

FWIW this is not really NFC, I found this as the culprit in bisecting the Android LLVM toolchain build, causing the following error:

Jun 24 2022, 4:23 PM · Restricted Project, Restricted Project