Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People fmayer

fmayer (Florian Mayer)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 3 2020, 4:23 AM (168 w, 5 d)

Recent Activity
View All

Fri, Sep 8

fmayer added inline comments to D158587: [sanitizer][msan] VarArgHelper for loongarch64.
Fri, Sep 8, 11:31 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Sep 6

fmayer added a reverting change for rG11171d81aeaf: [AMDGPU] Cope with SelectionDAG::UpdateNodeOperands returning a different…: rG42a1d16179cb: Revert "[AMDGPU] Cope with SelectionDAG::UpdateNodeOperands returning a….
Wed, Sep 6, 1:18 PM · Restricted Project, Restricted Project
fmayer committed rG42a1d16179cb: Revert "[AMDGPU] Cope with SelectionDAG::UpdateNodeOperands returning a… (authored by fmayer).
Revert "[AMDGPU] Cope with SelectionDAG::UpdateNodeOperands returning a…
Wed, Sep 6, 1:18 PM · Restricted Project, Restricted Project
fmayer committed rG08ad327dde93: Do not duplicate identical stack safety test for RISCV (authored by fmayer).
Do not duplicate identical stack safety test for RISCV
Wed, Sep 6, 9:17 AM · Restricted Project, Restricted Project
fmayer closed D159148: Do not duplicate identical stack safety test for RISCV.
Wed, Sep 6, 9:17 AM · Restricted Project, Restricted Project

Thu, Aug 31

fmayer committed rG7f12000a5f8a: Support atomic write operations in stack safety (authored by fmayer).
Support atomic write operations in stack safety
Thu, Aug 31, 3:42 PM · Restricted Project, Restricted Project
fmayer closed D159153: Support atomic write operations in stack safety.
Thu, Aug 31, 3:41 PM · Restricted Project, Restricted Project
fmayer updated the diff for D159153: Support atomic write operations in stack safety.

upd

Thu, Aug 31, 3:38 PM · Restricted Project, Restricted Project
fmayer updated the diff for D159153: Support atomic write operations in stack safety.

simplify

Thu, Aug 31, 3:31 PM · Restricted Project, Restricted Project
fmayer accepted rGc6aaf2e52134: [NFC][HWASAN] Extract insertShadowTagCheck().
Thu, Aug 31, 3:08 PM · Restricted Project, Restricted Project
fmayer accepted D159172: [HWASAN] Inline fast pass of instrumentMemAccessOutline.
Thu, Aug 31, 3:08 PM · Restricted Project, Restricted Project
fmayer accepted D159165: [NFC][HWASAN] Extract insertShadowTagCheck().
Thu, Aug 31, 1:12 PM · Restricted Project, Restricted Project

Wed, Aug 30

fmayer added inline comments to D159172: [HWASAN] Inline fast pass of instrumentMemAccessOutline.
Wed, Aug 30, 2:21 PM · Restricted Project, Restricted Project
fmayer published D159153: Support atomic write operations in stack safety for review.
Wed, Aug 30, 2:17 PM · Restricted Project, Restricted Project
fmayer added inline comments to D159157: [test][HWASAN] Precommit -hwasan-inline-fast-path-checks tests.
Wed, Aug 30, 10:27 AM · Restricted Project, Restricted Project
fmayer added inline comments to D159165: [NFC][HWASAN] Extract insertShadowTagCheck().
Wed, Aug 30, 10:23 AM · Restricted Project, Restricted Project
fmayer accepted D159157: [test][HWASAN] Precommit -hwasan-inline-fast-path-checks tests.
Wed, Aug 30, 10:18 AM · Restricted Project, Restricted Project

Tue, Aug 29

fmayer added inline comments to D159148: Do not duplicate identical stack safety test for RISCV.
Tue, Aug 29, 9:12 PM · Restricted Project, Restricted Project
fmayer added a reviewer for D159148: Do not duplicate identical stack safety test for RISCV: smd.
Tue, Aug 29, 5:02 PM · Restricted Project, Restricted Project
fmayer added a reviewer for D159148: Do not duplicate identical stack safety test for RISCV: vitalybuka.
Tue, Aug 29, 4:56 PM · Restricted Project, Restricted Project
fmayer requested review of D159148: Do not duplicate identical stack safety test for RISCV.
Tue, Aug 29, 4:55 PM · Restricted Project, Restricted Project

Aug 22 2023

fmayer added a comment to D157102: [scudo] Rename AllocatorRingBuffer into scudo:ring_buffer.
In D157102#4560976, @Chia-hungDuan wrote:

Add @fmayer to be aware of the name change

Aug 22 2023, 11:14 AM · Restricted Project, Restricted Project
fmayer committed rG9724bf999b2b: [compiler-rt] Fix typo in comment (authored by Eymay).
[compiler-rt] Fix typo in comment
Aug 22 2023, 11:13 AM · Restricted Project, Restricted Project
fmayer closed D157209: [compiler-rt] Fix typo in comment.
Aug 22 2023, 11:13 AM · Restricted Project, Restricted Project

Aug 16 2023

fmayer accepted D158116: Fix -DCOMPILER_RT_HWASAN_WITH_INTERCEPTORS=OFF regression.
Aug 16 2023, 2:07 PM · Restricted Project, Restricted Project
fmayer added inline comments to D158116: Fix -DCOMPILER_RT_HWASAN_WITH_INTERCEPTORS=OFF regression.
Aug 16 2023, 1:58 PM · Restricted Project, Restricted Project
fmayer added inline comments to D158116: Fix -DCOMPILER_RT_HWASAN_WITH_INTERCEPTORS=OFF regression.
Aug 16 2023, 1:54 PM · Restricted Project, Restricted Project
fmayer added a comment to D151262: hwasan: enable mmap interception (no tagging used).

I think this might have caused https://github.com/llvm/llvm-project/issues/64730

Aug 16 2023, 1:06 PM · Restricted Project, Restricted Project

Aug 9 2023

fmayer added inline comments to D157552: [asan] Fix GC of FakeFrames.
Aug 9 2023, 3:05 PM · Restricted Project, Restricted Project

Aug 7 2023

fmayer added inline comments to D157266: [sanitizer] use uptr to store the result of internal_strlen/internal_strnlen in printf_common.
Aug 7 2023, 11:07 AM · Restricted Project, Restricted Project
fmayer added inline comments to D157266: [sanitizer] use uptr to store the result of internal_strlen/internal_strnlen in printf_common.
Aug 7 2023, 11:05 AM · Restricted Project, Restricted Project
fmayer accepted D157209: [compiler-rt] Fix typo in comment.
Aug 7 2023, 11:02 AM · Restricted Project, Restricted Project

Aug 4 2023

fmayer added a reverting change for rGb82c2b9ac2ba: Reland "Fix __cfi_check not aligned to 4k on relocatable files with no…: rG043d03d25bd7: Revert "Reland "Fix __cfi_check not aligned to 4k on relocatable files with no….
Aug 4 2023, 2:25 PM · Restricted Project, Restricted Project
fmayer committed rG043d03d25bd7: Revert "Reland "Fix __cfi_check not aligned to 4k on relocatable files with no… (authored by fmayer).
Revert "Reland "Fix __cfi_check not aligned to 4k on relocatable files with no…
Aug 4 2023, 2:25 PM · Restricted Project, Restricted Project
fmayer added a comment to rGb82c2b9ac2ba: Reland "Fix __cfi_check not aligned to 4k on relocatable files with no….

I think this broke many of our sanitizer tests: https://lab.llvm.org/buildbot/#/builders/37/builds/24122/steps/24/logs/stdio

Aug 4 2023, 2:09 PM · Restricted Project, Restricted Project

Jul 26 2023

fmayer committed rG9a67c6beb226: [NFC] [HWASan] simplify code (authored by fmayer).
[NFC] [HWASan] simplify code
Jul 26 2023, 5:05 PM · Restricted Project, Restricted Project
fmayer closed D156382: [NFC] [HWASan] simplify code.
Jul 26 2023, 5:05 PM · Restricted Project, Restricted Project
fmayer added a reviewer for D156382: [NFC] [HWASan] simplify code: vitalybuka.
Jul 26 2023, 4:16 PM · Restricted Project, Restricted Project
fmayer requested review of D156382: [NFC] [HWASan] simplify code.
Jul 26 2023, 4:05 PM · Restricted Project, Restricted Project
fmayer committed rG12982d250d54: [NFC] [HWASan] remove unused include (authored by fmayer).
[NFC] [HWASan] remove unused include
Jul 26 2023, 2:35 PM · Restricted Project, Restricted Project
fmayer accepted D156282: [NFC][hwasan] Don't tag secondary allocations on free.
Jul 26 2023, 1:34 PM · Restricted Project, Restricted Project
fmayer added a comment to D156282: [NFC][hwasan] Don't tag secondary allocations on free.

Also nit: typo in commit message.

Jul 26 2023, 11:07 AM · Restricted Project, Restricted Project
fmayer committed rGc1f008e2e5ac: [HWASan] fix broken test (authored by fmayer).
[HWASan] fix broken test
Jul 26 2023, 10:55 AM · Restricted Project, Restricted Project

Jul 25 2023

fmayer committed rG6cc9244baa63: Enable hwasan-use-after-scope by default (authored by fmayer).
Enable hwasan-use-after-scope by default
Jul 25 2023, 5:36 PM · Restricted Project, Restricted Project, Restricted Project
fmayer closed D156267: Enable hwasan-use-after-scope by default.
Jul 25 2023, 5:36 PM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D156267: Enable hwasan-use-after-scope by default.

remove redundant test RUN

Jul 25 2023, 5:33 PM · Restricted Project, Restricted Project, Restricted Project
fmayer committed rGfdac98a7f3bb: Remove stable-runtime from many tests (authored by fmayer).
Remove stable-runtime from many tests
Jul 25 2023, 5:29 PM · Restricted Project, Restricted Project
fmayer committed rG17db2a1044b5: Re-enable lto.c test on ARM64 (authored by fmayer).
Re-enable lto.c test on ARM64
Jul 25 2023, 5:29 PM · Restricted Project, Restricted Project
fmayer closed D156273: Remove stable-runtime from many tests.
Jul 25 2023, 5:29 PM · Restricted Project, Restricted Project
fmayer closed D156269: Re-enable lto.c test on ARM64.
Jul 25 2023, 5:29 PM · Restricted Project, Restricted Project
fmayer added a comment to D156267: Enable hwasan-use-after-scope by default.
In D156267#4533704, @vitalybuka wrote:

You may add this into llvm/docs/ReleaseNotes.rst

You probably should remove -mllvm -hwasan-use-after-scope from tests (followup patch is find, after waiting few weeks this one not reverted)

Jul 25 2023, 5:27 PM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D156267: Enable hwasan-use-after-scope by default.

update tests

Jul 25 2023, 5:26 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D156282: [NFC][hwasan] Don't tag secondary allocations on free.
Jul 25 2023, 5:13 PM · Restricted Project, Restricted Project
fmayer added a reviewer for D156273: Remove stable-runtime from many tests: vitalybuka.
Jul 25 2023, 4:33 PM · Restricted Project, Restricted Project
fmayer updated the diff for D156273: Remove stable-runtime from many tests.

fix halt-on-error

Jul 25 2023, 4:32 PM · Restricted Project, Restricted Project
fmayer requested review of D156273: Remove stable-runtime from many tests.
Jul 25 2023, 4:22 PM · Restricted Project, Restricted Project
fmayer published D156269: Re-enable lto.c test on ARM64 for review.
Jul 25 2023, 3:38 PM · Restricted Project, Restricted Project
fmayer added a reviewer for D156267: Enable hwasan-use-after-scope by default: vitalybuka.
Jul 25 2023, 3:30 PM · Restricted Project, Restricted Project, Restricted Project
fmayer requested review of D156267: Enable hwasan-use-after-scope by default.
Jul 25 2023, 3:14 PM · Restricted Project, Restricted Project, Restricted Project

Jul 12 2023

fmayer added inline comments to D155013: [compiler-rt][xray] Fix alignment of XRayFileHeader.
Jul 12 2023, 10:59 AM · Restricted Project, Restricted Project

Jun 14 2023

fmayer accepted D152984: [scudo] Disable OddEvenTags by default..
Jun 14 2023, 5:07 PM · Restricted Project, Restricted Project

Jun 7 2023

fmayer added inline comments to rG73104d4fbd56: [Clang][OpenMP][OMPIRBuilder] Change llvm_unreachable inside of….
Jun 7 2023, 5:15 PM · Restricted Project, Restricted Project
fmayer added inline comments to rG73104d4fbd56: [Clang][OpenMP][OMPIRBuilder] Change llvm_unreachable inside of….
Jun 7 2023, 4:58 PM · Restricted Project, Restricted Project
fmayer added a comment to D152316: [hwasan] Only run tests for Android.
In D152316#4404486, @fmayer wrote:
In D152316#4404455, @aeubanks wrote:
In D152316#4401551, @fmayer wrote:

I don't think we want to disable HWASan tests on Linux generally. If a test has problems on x86, we should either fix that or disable that test only.

We also have an arm64 Linux buildbot, which we definitely don't want to disable.

makes sense, but is the arm64 linux bot actually running the hwasan tests, or are they all disabled currently?

It is actually running them.

there were a lot of hwasan tests failing on linux x64 (>40), is that expected?

That is unexpected.

% ninja -C build check-hwasan
ninja: Entering directory `build'
[0/1] Running the HWAddressSanitizer tests
Jun 7 2023, 3:21 PM · Restricted Project, Restricted Project
fmayer added a comment to D152316: [hwasan] Only run tests for Android.
In D152316#4404455, @aeubanks wrote:
In D152316#4401551, @fmayer wrote:

I don't think we want to disable HWASan tests on Linux generally. If a test has problems on x86, we should either fix that or disable that test only.

We also have an arm64 Linux buildbot, which we definitely don't want to disable.

makes sense, but is the arm64 linux bot actually running the hwasan tests, or are they all disabled currently?

It is actually running them.

there were a lot of hwasan tests failing on linux x64 (>40), is that expected?

That is unexpected.

Jun 7 2023, 3:05 PM · Restricted Project, Restricted Project
fmayer added a comment to D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder.
In D149162#4404271, @agozillon wrote:

I have hopefully fixed the sanitizer issue (the incorrect assert, thank you again for the catch) with the following patch: https://github.com/llvm/llvm-project/commit/309023263dba3b02bc885101faa47d110f662f99 it was a slightly more involved change than I expected, I had to rework the getTargetEntryUniqueInfo function to use a callback function to support Clang's use of a fallback filename and line number (gathered from a PresumedLoc). So I apologies for the extended time to land the change.

Jun 7 2023, 2:23 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder.
Jun 7 2023, 10:35 AM · Restricted Project, Restricted Project, Restricted Project
fmayer added a comment to D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder.

This triggered an MSAN error: https://lab.llvm.org/buildbot/#/builders/237/builds/3127/steps/13/logs/stdio

Jun 7 2023, 10:17 AM · Restricted Project, Restricted Project, Restricted Project

Jun 6 2023

fmayer added a reverting change for rGd5fbec30939f: Revert "[RISCV] Add special case to selectImm for constants that can be created…: rG38f7c7eb1a2a: Revert "Revert "[RISCV] Add special case to selectImm for constants that can be….
Jun 6 2023, 5:40 PM · Restricted Project, Restricted Project
fmayer committed rG38f7c7eb1a2a: Revert "Revert "[RISCV] Add special case to selectImm for constants that can be… (authored by fmayer).
Revert "Revert "[RISCV] Add special case to selectImm for constants that can be…
Jun 6 2023, 5:40 PM · Restricted Project, Restricted Project
fmayer added a comment to D152236: [RISCV] Add special case to selectImm for constants that can be created with (ADD (SLLI C, 32), C)..

Seems like I made matters worse. Un-reverting this. Please fix the UBSAan error.

Jun 6 2023, 5:39 PM · Restricted Project, Restricted Project
fmayer added a reverting change for rG58b2d652af49: [RISCV] Add special case to selectImm for constants that can be created with…: rGd5fbec30939f: Revert "[RISCV] Add special case to selectImm for constants that can be created….
Jun 6 2023, 5:31 PM · Restricted Project, Restricted Project
fmayer committed rGd5fbec30939f: Revert "[RISCV] Add special case to selectImm for constants that can be created… (authored by fmayer).
Revert "[RISCV] Add special case to selectImm for constants that can be created…
Jun 6 2023, 5:31 PM · Restricted Project, Restricted Project
fmayer added a reverting change for D152236: [RISCV] Add special case to selectImm for constants that can be created with (ADD (SLLI C, 32), C).: rGd5fbec30939f: Revert "[RISCV] Add special case to selectImm for constants that can be created….
Jun 6 2023, 5:31 PM · Restricted Project, Restricted Project
fmayer reopened D152236: [RISCV] Add special case to selectImm for constants that can be created with (ADD (SLLI C, 32), C)..
Jun 6 2023, 5:31 PM · Restricted Project, Restricted Project
fmayer added a comment to D152236: [RISCV] Add special case to selectImm for constants that can be created with (ADD (SLLI C, 32), C)..
/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:214:43: runtime error: signed integer overflow: 9223372034904144827 - -1950630981 cannot be represented in type 'int64_t' (aka 'long')
    #0 0xaaaae4525208 in selectImm(llvm::SelectionDAG*, llvm::SDLoc const&, llvm::MVT, long, llvm::RISCVSubtarget const&) /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:214:43
    #1 0xaaaae451fff8 in llvm::RISCVDAGToDAGISel::Select(llvm::SDNode*) /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:863:23
    #2 0xaaaae6204148 in llvm::SelectionDAGISel::DoInstructionSelection() /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:1178:7
    #3 0xaaaae6202418 in llvm::SelectionDAGISel::CodeGenAndEmitDAG() /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:949:5
    #4 0xaaaae61feb54 in llvm::SelectionDAGISel::SelectAllBasicBlocks(llvm::Function const&) /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:1700:7
    #5 0xaaaae61fa77c in llvm::SelectionDAGISel::runOnMachineFunction(llvm::MachineFunction&) /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:482:3
    #6 0xaaaae5469750 in llvm::MachineFunctionPass::runOnFunction(llvm::Function&) /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/CodeGen/MachineFunctionPass.cpp:91:13
    #7 0xaaaae5b2acf0 in llvm::FPPassManager::runOnFunction(llvm::Function&) /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1435:27
    #8 0xaaaae5b34fd0 in llvm::FPPassManager::runOnModule(llvm::Module&) /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1481:16
    #9 0xaaaae5b2b7f0 in runOnModule /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1550:27
    #10 0xaaaae5b2b7f0 in llvm::legacy::PassManagerImpl::run(llvm::Module&) /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:535:44
    #11 0xaaaae31ae314 in compileModule(char**, llvm::LLVMContext&) /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/tools/llc/llc.cpp:756:8
    #12 0xaaaae31ac0b8 in main /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/tools/llc/llc.cpp:420:22
    #13 0xffffbb03777c  (/lib/aarch64-linux-gnu/libc.so.6+0x2777c) (BuildId: fe1fc959438108d405a33383d7c3f00762a5bb93)
    #14 0xffffbb037854 in __libc_start_main (/lib/aarch64-linux-gnu/libc.so.6+0x27854) (BuildId: fe1fc959438108d405a33383d7c3f00762a5bb93)
    #15 0xaaaae3180fec in _start (/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/llc+0x5e90fec)
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:214:43 in
Jun 6 2023, 5:29 PM · Restricted Project, Restricted Project
fmayer added a comment to D152236: [RISCV] Add special case to selectImm for constants that can be created with (ADD (SLLI C, 32), C)..

I think this broke sanitizer tests: https://lab.llvm.org/buildbot/#/builders/238/builds/3867/steps/13/logs/stdio

Jun 6 2023, 5:28 PM · Restricted Project, Restricted Project
fmayer reopened D150298: [Sanitizers] Remove BuildId from sanitizers stacktrace on Darwin.
Jun 6 2023, 5:27 PM · Restricted Project, Restricted Project
fmayer added a reverting change for rGfdb1a891b64c: [Sanitizers] Remove BuildId from sanitizers stacktrace on Darwin: rGcb49160765ed: Revert "[Sanitizers] Remove BuildId from sanitizers stacktrace on.
Jun 6 2023, 5:26 PM · Restricted Project, Restricted Project
fmayer committed rGcb49160765ed: Revert "[Sanitizers] Remove BuildId from sanitizers stacktrace on (authored by fmayer).
Revert "[Sanitizers] Remove BuildId from sanitizers stacktrace on
Jun 6 2023, 5:26 PM · Restricted Project, Restricted Project
fmayer added a reverting change for D150298: [Sanitizers] Remove BuildId from sanitizers stacktrace on Darwin: rGcb49160765ed: Revert "[Sanitizers] Remove BuildId from sanitizers stacktrace on.
Jun 6 2023, 5:26 PM · Restricted Project, Restricted Project
fmayer added a comment to D150298: [Sanitizers] Remove BuildId from sanitizers stacktrace on Darwin.
In D150298#4401580, @thakis wrote:

Could this have broken check-hwasan? http://45.33.8.238/linux/109046/step_10.txt

Jun 6 2023, 5:23 PM · Restricted Project, Restricted Project
fmayer added a comment to D152316: [hwasan] Only run tests for Android.

I don't think we want to disable HWASan tests on Linux generally. If a test has problems on x86, we should either fix that or disable that test only.

Jun 6 2023, 5:06 PM · Restricted Project, Restricted Project
fmayer accepted D150298: [Sanitizers] Remove BuildId from sanitizers stacktrace on Darwin.

I still don't like the inconsistency between platforms, and I don't think a few bytes of repeated build id matter, but fine.

Jun 6 2023, 4:14 PM · Restricted Project, Restricted Project
fmayer added inline comments to D152309: [Sanitizers] UUID/Build ID is 16 bytes on Darwin..
Jun 6 2023, 4:10 PM · Restricted Project, Restricted Project
fmayer added a comment to D151152: [compiler-rt] Avoid memintrinsic calls inserted by the compiler.

Seems like the check_memcpy.c is broken: https://lab.llvm.org/buildbot/#/builders/37/builds/22633/steps/2/logs/stdio

Jun 6 2023, 10:22 AM · Restricted Project, Restricted Project, Restricted Project

Jun 5 2023

fmayer committed rG5ac240bbea14: [hwasan] Properly restore SP tag on exceptions (authored by fmayer).
[hwasan] Properly restore SP tag on exceptions
Jun 5 2023, 3:22 PM · Restricted Project, Restricted Project
fmayer closed D152036: [hwasan] Properly restore SP tag on exceptions.
Jun 5 2023, 3:22 PM · Restricted Project, Restricted Project
fmayer retitled D152036: [hwasan] Properly restore SP tag on exceptions from Properly restore SP tag on exceptions to [hwasan] Properly restore SP tag on exceptions.
Jun 5 2023, 2:30 PM · Restricted Project, Restricted Project
fmayer updated the diff for D152036: [hwasan] Properly restore SP tag on exceptions.

iwyu

Jun 5 2023, 2:18 PM · Restricted Project, Restricted Project
fmayer updated the diff for D152036: [hwasan] Properly restore SP tag on exceptions.

fix bug around tls

Jun 5 2023, 2:17 PM · Restricted Project, Restricted Project
fmayer added a comment to D152036: [hwasan] Properly restore SP tag on exceptions.
In D152036#4396207, @fmayer wrote:
In D152036#4394711, @kda wrote:

This looks to be breaking HWASAN sanitizer buildbot:
https://lab.llvm.org/buildbot/#/builders/236/builds/4452

seems to be try-catch.cpp

thinks. looking, i cannot reproduce on my own phone :(

Jun 5 2023, 11:03 AM · Restricted Project, Restricted Project
fmayer committed rGb14f95b988bb: [sanitizer] add new symbolizer symbol (authored by fmayer).
[sanitizer] add new symbolizer symbol
Jun 5 2023, 10:58 AM · Restricted Project, Restricted Project
fmayer planned changes to D152036: [hwasan] Properly restore SP tag on exceptions.
Jun 5 2023, 10:27 AM · Restricted Project, Restricted Project
fmayer reopened D152036: [hwasan] Properly restore SP tag on exceptions.
Jun 5 2023, 10:27 AM · Restricted Project, Restricted Project
fmayer added a reverting change for rG6a2e0cb41817: Properly restore SP tag on exceptions: rG9fa938d68730: Revert "Properly restore SP tag on exceptions".
Jun 5 2023, 10:27 AM · Restricted Project, Restricted Project
fmayer committed rG9fa938d68730: Revert "Properly restore SP tag on exceptions" (authored by fmayer).
Revert "Properly restore SP tag on exceptions"
Jun 5 2023, 10:27 AM · Restricted Project, Restricted Project
fmayer added a reverting change for D152036: [hwasan] Properly restore SP tag on exceptions: rG9fa938d68730: Revert "Properly restore SP tag on exceptions".
Jun 5 2023, 10:27 AM · Restricted Project, Restricted Project
fmayer added a comment to D152036: [hwasan] Properly restore SP tag on exceptions.
In D152036#4394711, @kda wrote:

This looks to be breaking HWASAN sanitizer buildbot:
https://lab.llvm.org/buildbot/#/builders/236/builds/4452

seems to be try-catch.cpp

Jun 5 2023, 9:12 AM · Restricted Project, Restricted Project

Jun 2 2023

fmayer committed rG6a2e0cb41817: Properly restore SP tag on exceptions (authored by fmayer).
Properly restore SP tag on exceptions
Jun 2 2023, 3:33 PM · Restricted Project, Restricted Project