Page MenuHomePhabricator

fmayer (Florian Mayer)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 3 2020, 4:23 AM (68 w, 6 h)

Recent Activity

Yesterday

fmayer added inline comments to D112098: [ASan] Added stack safety support in address sanitizer..
Thu, Oct 21, 12:55 PM · Restricted Project, Restricted Project
fmayer added a comment to D112098: [ASan] Added stack safety support in address sanitizer..

I think you also want to use SSI->isSafe(AllocaInst*) in isInterestingAlloca to prevent use-after-scope instrumentation if all accesses are safe.

Thu, Oct 21, 12:50 PM · Restricted Project, Restricted Project

Wed, Oct 20

fmayer added inline comments to D112098: [ASan] Added stack safety support in address sanitizer..
Wed, Oct 20, 1:55 PM · Restricted Project, Restricted Project
fmayer added inline comments to D112098: [ASan] Added stack safety support in address sanitizer..
Wed, Oct 20, 1:52 PM · Restricted Project, Restricted Project

Tue, Oct 19

fmayer added inline comments to D112098: [ASan] Added stack safety support in address sanitizer..
Tue, Oct 19, 5:18 PM · Restricted Project, Restricted Project

Thu, Oct 14

fmayer accepted D111841: [hwasan] Fix TestCases/thread-uaf.c..

lgtm

Thu, Oct 14, 2:32 PM · Restricted Project

Thu, Sep 30

fmayer committed rG9c8d8fc98fe7: [NFC] [hwasan] Remove unneeded member. (authored by fmayer).
[NFC] [hwasan] Remove unneeded member.
Thu, Sep 30, 8:11 AM
fmayer closed D110791: [NFC] [hwasan] Remove unneeded member..
Thu, Sep 30, 8:11 AM · Restricted Project

Wed, Sep 29

fmayer added a reviewer for D110791: [NFC] [hwasan] Remove unneeded member.: hctim.
Wed, Sep 29, 4:59 PM · Restricted Project
fmayer requested review of D110791: [NFC] [hwasan] Remove unneeded member..
Wed, Sep 29, 4:58 PM · Restricted Project

Mon, Sep 27

fmayer committed rG4f352d444ecf: [NFC] [PSI] explain encoding of PercentileCutoff. (authored by fmayer).
[NFC] [PSI] explain encoding of PercentileCutoff.
Mon, Sep 27, 1:41 PM
fmayer closed D109764: [NFC] [PSI] explain encoding of PercentileCutoff..
Mon, Sep 27, 1:41 PM · Restricted Project
fmayer added inline comments to D109764: [NFC] [PSI] explain encoding of PercentileCutoff..
Mon, Sep 27, 1:09 PM · Restricted Project

Sep 22 2021

fmayer updated the diff for D110254: [hwasan] have callbacks for 32 and 64 byte ops.

add more tests

Sep 22 2021, 8:02 AM · Restricted Project, Restricted Project
fmayer updated the diff for D110254: [hwasan] have callbacks for 32 and 64 byte ops.

simplify

Sep 22 2021, 7:51 AM · Restricted Project, Restricted Project
fmayer updated the diff for D110254: [hwasan] have callbacks for 32 and 64 byte ops.

add store test

Sep 22 2021, 7:41 AM · Restricted Project, Restricted Project
fmayer added a reviewer for D110254: [hwasan] have callbacks for 32 and 64 byte ops: eugenis.
Sep 22 2021, 7:31 AM · Restricted Project, Restricted Project
fmayer updated the diff for D110254: [hwasan] have callbacks for 32 and 64 byte ops.

add test

Sep 22 2021, 7:29 AM · Restricted Project, Restricted Project
fmayer requested review of D110254: [hwasan] have callbacks for 32 and 64 byte ops.
Sep 22 2021, 7:25 AM · Restricted Project, Restricted Project
fmayer committed rG36daf074d997: [hwasan] also omit safe mem[cpy|mov|set]. (authored by fmayer).
[hwasan] also omit safe mem[cpy|mov|set].
Sep 22 2021, 3:10 AM
fmayer closed D109816: [hwasan] also omit safe mem[cpy|mov|set]..
Sep 22 2021, 3:09 AM · Restricted Project
fmayer updated the diff for D109816: [hwasan] also omit safe mem[cpy|mov|set]..

resolve test confusion

Sep 22 2021, 3:07 AM · Restricted Project
fmayer added inline comments to D109816: [hwasan] also omit safe mem[cpy|mov|set]..
Sep 22 2021, 2:31 AM · Restricted Project
fmayer updated the diff for D109816: [hwasan] also omit safe mem[cpy|mov|set]..

nit

Sep 22 2021, 2:30 AM · Restricted Project

Sep 21 2021

fmayer added a comment to D109816: [hwasan] also omit safe mem[cpy|mov|set]..

I remember from the my C days that one of gotchas with memmove/memcpy is overlapping regions. Not sure if it is relevant the context of this change, just wanted to mention it.

Sep 21 2021, 9:53 AM · Restricted Project
fmayer added a comment to D109816: [hwasan] also omit safe mem[cpy|mov|set]..

Sorry, still need to sort out the other stack safety IR tests.

Sep 21 2021, 7:34 AM · Restricted Project
fmayer updated the diff for D109816: [hwasan] also omit safe mem[cpy|mov|set]..

fix tests

Sep 21 2021, 7:34 AM · Restricted Project
fmayer added a comment to D109816: [hwasan] also omit safe mem[cpy|mov|set]..

Sorry, still need to sort out the other stack safety IR tests.

Sep 21 2021, 7:26 AM · Restricted Project
fmayer updated the diff for D109816: [hwasan] also omit safe mem[cpy|mov|set]..

match logic to comment

Sep 21 2021, 5:40 AM · Restricted Project
fmayer updated the diff for D109816: [hwasan] also omit safe mem[cpy|mov|set]..

address comment

Sep 21 2021, 2:33 AM · Restricted Project

Sep 20 2021

fmayer committed rG16b5f4502c5b: [NFC] [hwasan] Separate outline and inline instrumentation. (authored by fmayer).
[NFC] [hwasan] Separate outline and inline instrumentation.
Sep 20 2021, 1:49 PM
fmayer closed D110067: [NFC] [hwasan] Separate outline and inline instrumentation..
Sep 20 2021, 1:49 PM · Restricted Project
fmayer added a reviewer for D110067: [NFC] [hwasan] Separate outline and inline instrumentation.: eugenis.
Sep 20 2021, 6:03 AM · Restricted Project
fmayer requested review of D110067: [NFC] [hwasan] Separate outline and inline instrumentation..
Sep 20 2021, 6:02 AM · Restricted Project
fmayer added a comment to D109764: [NFC] [PSI] explain encoding of PercentileCutoff..

Ping

Sep 20 2021, 4:40 AM · Restricted Project
fmayer added inline comments to D109816: [hwasan] also omit safe mem[cpy|mov|set]..
Sep 20 2021, 2:51 AM · Restricted Project
fmayer updated the diff for D109816: [hwasan] also omit safe mem[cpy|mov|set]..

more tests & comments

Sep 20 2021, 2:49 AM · Restricted Project

Sep 16 2021

fmayer committed rG95ba9f957aa9: [hwasan] print globals in symbolizer-friendly format. (authored by fmayer).
[hwasan] print globals in symbolizer-friendly format.
Sep 16 2021, 5:29 AM
fmayer closed D109698: [hwasan] print globals in symbolizer-friendly format..
Sep 16 2021, 5:29 AM · Restricted Project
fmayer added inline comments to D109816: [hwasan] also omit safe mem[cpy|mov|set]..
Sep 16 2021, 5:05 AM · Restricted Project
fmayer updated the diff for D109816: [hwasan] also omit safe mem[cpy|mov|set]..

use getDest/getSource

Sep 16 2021, 5:04 AM · Restricted Project

Sep 15 2021

fmayer added a comment to D109816: [hwasan] also omit safe mem[cpy|mov|set]..

This leads to a 20 % runtime improvement on PDFium, when stack instrumentation is disabled.

Sep 15 2021, 10:01 AM · Restricted Project
fmayer added inline comments to D109787: [HWASan] Catch cases where libc populated jmp_buf..
Sep 15 2021, 8:37 AM · Restricted Project
fmayer updated the diff for D109698: [hwasan] print globals in symbolizer-friendly format..

fix format

Sep 15 2021, 8:21 AM · Restricted Project
fmayer published D109816: [hwasan] also omit safe mem[cpy|mov|set]. for review.
Sep 15 2021, 6:35 AM · Restricted Project
fmayer updated the diff for D109764: [NFC] [PSI] explain encoding of PercentileCutoff..

mention it is decimal

Sep 15 2021, 1:40 AM · Restricted Project

Sep 14 2021

fmayer retitled D109764: [NFC] [PSI] explain encoding of PercentileCutoff. from [PSI] explain encoding of PercentileCutoff. to [NFC] [PSI] explain encoding of PercentileCutoff..
Sep 14 2021, 9:05 AM · Restricted Project
fmayer added a reviewer for D109764: [NFC] [PSI] explain encoding of PercentileCutoff.: mtrofin.
Sep 14 2021, 9:00 AM · Restricted Project
fmayer requested review of D109764: [NFC] [PSI] explain encoding of PercentileCutoff..
Sep 14 2021, 8:56 AM · Restricted Project

Sep 13 2021

fmayer committed rG0a22510f3e64: [value-tracking] see through returned attribute. (authored by fmayer).
[value-tracking] see through returned attribute.
Sep 13 2021, 12:53 PM
fmayer closed D109675: [value-tracking] see through returned attribute..
Sep 13 2021, 12:53 PM · Restricted Project
fmayer committed rG5b5d774f5d38: [hwasan] Respect returns attribute when tracking values. (authored by fmayer).
[hwasan] Respect returns attribute when tracking values.
Sep 13 2021, 12:53 PM
fmayer closed D109233: [hwasan] Respect returns attribute when tracking values..
Sep 13 2021, 12:52 PM · Restricted Project
fmayer added a reviewer for D109698: [hwasan] print globals in symbolizer-friendly format.: eugenis.
Sep 13 2021, 8:41 AM · Restricted Project
fmayer requested review of D109698: [hwasan] print globals in symbolizer-friendly format..
Sep 13 2021, 8:40 AM · Restricted Project
fmayer added a reviewer for D109675: [value-tracking] see through returned attribute.: vitalybuka.
Sep 13 2021, 4:30 AM · Restricted Project
fmayer requested review of D109675: [value-tracking] see through returned attribute..
Sep 13 2021, 2:31 AM · Restricted Project
fmayer added inline comments to D109233: [hwasan] Respect returns attribute when tracking values..
Sep 13 2021, 2:04 AM · Restricted Project
fmayer updated the diff for D109233: [hwasan] Respect returns attribute when tracking values..

split change

Sep 13 2021, 2:03 AM · Restricted Project

Sep 10 2021

fmayer committed rG09391e7e507f: [hwasan] Do not instrument accesses to uninteresting allocas. (authored by fmayer).
[hwasan] Do not instrument accesses to uninteresting allocas.
Sep 10 2021, 11:29 AM
fmayer closed D108457: [hwasan] Do not instrument accesses to uninteresting allocas..
Sep 10 2021, 11:29 AM · Restricted Project
fmayer committed rG57335b6e2ead: [stack-safety] Allow to determine safe accesses. (authored by fmayer).
[stack-safety] Allow to determine safe accesses.
Sep 10 2021, 11:24 AM
fmayer closed D109503: [stack-safety] Allow to determine safe accesses..
Sep 10 2021, 11:24 AM · Restricted Project
fmayer added inline comments to D109503: [stack-safety] Allow to determine safe accesses..
Sep 10 2021, 11:22 AM · Restricted Project
fmayer updated the diff for D109503: [stack-safety] Allow to determine safe accesses..

name

Sep 10 2021, 11:21 AM · Restricted Project
fmayer updated the diff for D109503: [stack-safety] Allow to determine safe accesses..

fix name

Sep 10 2021, 11:20 AM · Restricted Project
fmayer updated the diff for D108457: [hwasan] Do not instrument accesses to uninteresting allocas..

rebase

Sep 10 2021, 8:00 AM · Restricted Project
fmayer added inline comments to D109503: [stack-safety] Allow to determine safe accesses..
Sep 10 2021, 7:53 AM · Restricted Project
fmayer updated the diff for D109503: [stack-safety] Allow to determine safe accesses..

simplify test

Sep 10 2021, 7:51 AM · Restricted Project
fmayer updated the diff for D109503: [stack-safety] Allow to determine safe accesses..

add more tests

Sep 10 2021, 7:37 AM · Restricted Project

Sep 9 2021

fmayer updated the diff for D109233: [hwasan] Respect returns attribute when tracking values..

add test

Sep 9 2021, 7:39 AM · Restricted Project
fmayer updated the diff for D108457: [hwasan] Do not instrument accesses to uninteresting allocas..

style

Sep 9 2021, 7:09 AM · Restricted Project
fmayer updated the diff for D108457: [hwasan] Do not instrument accesses to uninteresting allocas..

remove unnecessary check (again)

Sep 9 2021, 7:06 AM · Restricted Project
fmayer added reviewers for D109503: [stack-safety] Allow to determine safe accesses.: eugenis, vitalybuka.
Sep 9 2021, 6:50 AM · Restricted Project
fmayer added a comment to D108457: [hwasan] Do not instrument accesses to uninteresting allocas..

I split the stack safety change to D109503 and added more tests to that.

Sep 9 2021, 6:49 AM · Restricted Project
fmayer updated the diff for D108457: [hwasan] Do not instrument accesses to uninteresting allocas..

split change

Sep 9 2021, 6:48 AM · Restricted Project
fmayer updated the diff for D109503: [stack-safety] Allow to determine safe accesses..

add more tests

Sep 9 2021, 6:48 AM · Restricted Project
fmayer committed rG039fd9af45b0: [NFC] [hwasan] move prints closer together. (authored by fmayer).
[NFC] [hwasan] move prints closer together.
Sep 9 2021, 5:39 AM
fmayer closed D109442: [NFC] [hwasan] move prints closer together..
Sep 9 2021, 5:39 AM · Restricted Project
fmayer requested review of D109503: [stack-safety] Allow to determine safe accesses..
Sep 9 2021, 5:27 AM · Restricted Project
fmayer committed rG6e12c73316b7: [NFC] [stack-safety] add placeholder addRange. (authored by fmayer).
[NFC] [stack-safety] add placeholder addRange.
Sep 9 2021, 5:14 AM
fmayer committed rGd261d4cf559d: [stack-safety] [NFC] do not terminate print with blank line. (authored by fmayer).
[stack-safety] [NFC] do not terminate print with blank line.
Sep 9 2021, 4:31 AM
fmayer committed rG08b4dd8b2407: [NFC] [stack-safety] remove unused return value. (authored by fmayer).
[NFC] [stack-safety] remove unused return value.
Sep 9 2021, 4:20 AM

Sep 8 2021

fmayer updated the diff for D108457: [hwasan] Do not instrument accesses to uninteresting allocas..

clang format

Sep 8 2021, 10:03 AM · Restricted Project
fmayer requested review of D109442: [NFC] [hwasan] move prints closer together..
Sep 8 2021, 8:32 AM · Restricted Project
fmayer updated the diff for D108457: [hwasan] Do not instrument accesses to uninteresting allocas..

revert unneeded change

Sep 8 2021, 8:31 AM · Restricted Project
fmayer updated the diff for D108457: [hwasan] Do not instrument accesses to uninteresting allocas..

only calculate address information when needed.

Sep 8 2021, 8:17 AM · Restricted Project
fmayer updated the diff for D108457: [hwasan] Do not instrument accesses to uninteresting allocas..

remove unnecessary check

Sep 8 2021, 1:55 AM · Restricted Project
fmayer updated the diff for D108457: [hwasan] Do not instrument accesses to uninteresting allocas..

address comment

Sep 8 2021, 1:45 AM · Restricted Project

Sep 7 2021

fmayer added a comment to D108457: [hwasan] Do not instrument accesses to uninteresting allocas..

EDIT: I ran pdfium benchmarks and had some results here, but I spoke too early and need to run some more.

Sep 7 2021, 7:25 AM · Restricted Project

Sep 6 2021

fmayer updated the diff for D108457: [hwasan] Do not instrument accesses to uninteresting allocas..

format

Sep 6 2021, 12:39 PM · Restricted Project
fmayer updated the diff for D108457: [hwasan] Do not instrument accesses to uninteresting allocas..

add tests for stack safety analysis

Sep 6 2021, 11:51 AM · Restricted Project
fmayer added a comment to D108457: [hwasan] Do not instrument accesses to uninteresting allocas..

What if an instruction may access either stack or heap?

i32 *p = flag ? p_heap_i16 : &stack_i32;
*p = 42;

The analysis will say "safe" because it is only scanning from the stack roots.
This should probably be fixed in hwasan by tracking the underlying alloca.

Ah yes, I did handle this but then accidentally lost that when I refactored around some stuff. Put that back and added an IR test.

Sep 6 2021, 5:56 AM · Restricted Project
fmayer updated the diff for D108457: [hwasan] Do not instrument accesses to uninteresting allocas..

don't use argument in select test

Sep 6 2021, 2:43 AM · Restricted Project
fmayer added a comment to D108457: [hwasan] Do not instrument accesses to uninteresting allocas..

What if an instruction may access either stack or heap?

i32 *p = flag ? p_heap_i16 : &stack_i32;
*p = 42;

The analysis will say "safe" because it is only scanning from the stack roots.
This should probably be fixed in hwasan by tracking the underlying alloca.

Sep 6 2021, 2:38 AM · Restricted Project
fmayer updated the diff for D108457: [hwasan] Do not instrument accesses to uninteresting allocas..

handle stores that might or might not use an alloca

Sep 6 2021, 2:38 AM · Restricted Project
fmayer committed rG2706b1a6e2df: [hwasan] Test use-after-scope with -fno-exceptions. (authored by fmayer).
[hwasan] Test use-after-scope with -fno-exceptions.
Sep 6 2021, 2:10 AM
fmayer closed D109224: [hwasan] Test use-after-scope with -fno-exceptions..
Sep 6 2021, 2:10 AM · Restricted Project
fmayer added a comment to D109224: [hwasan] Test use-after-scope with -fno-exceptions..

LGTM - Is this providing coverage that otherwise wasn't being found? Did you find a bug in an upcoming patchset?

Sep 6 2021, 2:05 AM · Restricted Project

Sep 3 2021

fmayer published D109233: [hwasan] Respect returns attribute when tracking values. for review.
Sep 3 2021, 8:27 AM · Restricted Project