This is an archive of the discontinued LLVM Phabricator instance.

[test][HWASAN] Precommit -hwasan-inline-fast-path-checks tests
ClosedPublic

Authored by vitalybuka on Aug 29 2023, 8:26 PM.

Diff Detail

Event Timeline

vitalybuka created this revision.Aug 29 2023, 8:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2023, 8:26 PM
vitalybuka requested review of this revision.Aug 29 2023, 8:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2023, 8:26 PM
fmayer accepted this revision.Aug 30 2023, 10:18 AM
This revision is now accepted and ready to land.Aug 30 2023, 10:18 AM
fmayer added inline comments.Aug 30 2023, 10:27 AM
llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
587–592

I'm not a huge fan of different defaults per platform, wouldn't it be easier to just specify this for the platforms where you want this enabled?

vitalybuka added inline comments.Aug 30 2023, 9:29 PM
llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
587–592

I think it should be default, and I am just giving android time to investigate.

How about I land as is and soon after we remove exceptions, so it would be easy to bisect/revert if it's not good enough for android.

This revision was landed with ongoing or failed builds.Aug 31 2023, 11:25 AM
This revision was automatically updated to reflect the committed changes.