This is an archive of the discontinued LLVM Phabricator instance.

Delete CloudABI support
ClosedPublic

Authored by brad on Aug 25 2023, 8:24 PM.

Details

Summary

After this https://reviews.llvm.org/D108637 and with FreeBSD -current and now 14 dropping support for CloudABI I think it is time to consider deleting the CloudABI support.

Diff Detail

Event Timeline

brad created this revision.Aug 25 2023, 8:24 PM
Herald added a project: Restricted Project. · View Herald Transcript
brad requested review of this revision.Aug 25 2023, 8:24 PM
MaskRay accepted this revision.Aug 25 2023, 8:32 PM

Thanks for the cleanup.

This revision is now accepted and ready to land.Aug 25 2023, 8:32 PM
brad updated this revision to Diff 553705.Aug 25 2023, 11:47 PM

Missed BUILD.gn, a unit test and one or two other files.

brad added a comment.Aug 25 2023, 11:51 PM

Also..

# RUN: llvm-mc -filetype=obj -triple=aarch64-unknown-cloudabi %s -o %t.o
./lld/test/ELF/aarch64-got-relocations.s
// RUN: llvm-mc -filetype=obj -triple=i686-unknown-cloudabi %s -o %t.o
./lld/test/ELF/static-with-export-dynamic.s
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-cloudabi %s -o %t1.o
./lld/test/ELF/x86-64-tls-pie.s

The only run lines in these tests are CloudABI targets and that triple is going away.

brad added a reviewer: emaste.Aug 26 2023, 1:40 PM
brad updated this revision to Diff 553815.Aug 27 2023, 4:05 PM

Rebase.

brad added a comment.Aug 27 2023, 7:08 PM

Looking for any feedback from the FreeBSD guys.

This revision was landed with ongoing or failed builds.Aug 29 2023, 8:06 PM
Closed by commit rG5165593a97a0: Delete CloudABI support (authored by brad). · Explain Why
This revision was automatically updated to reflect the committed changes.
emaste added a comment.Sep 6 2023, 6:50 PM

Looking for any feedback from the FreeBSD guys.

Sorry for no reply earlier, I was away for some of the summer and missed this originally. While CloudABI was a very interesting FreeBSD-related project it was removed from FreeBSD as you noted, and there's no reason to keep support in llvm

commit cf0ee8738e31aa9e6fbf4dca4dac56d89226a71a
Author: Konstantin Belousov <kib@FreeBSD.org>
Date:   Mon Sep 13 01:50:39 2021 +0300

    Drop cloudabi
    
    According to https://github.com/NuxiNL/cloudlibc:
    CloudABI is no longer being maintained. It was an awesome experiment,
    but it never got enough traction to be sustainable.
    
    There is no reason to keep it in FreeBSD.
    
    Approved by:    ed (private mail)
    Reviewed by:    emaste
    Sponsored by:   The FreeBSD Foundation
    Differential revision:  https://reviews.freebsd.org/D31923