ed (Ed Schouten)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 27 2015, 12:34 AM (172 w, 5 d)

Recent Activity

Feb 1 2018

ed added a comment to D42748: [ELF] Don't create a .dynamic section when linking with -Bstatic.

The dynamic symbol table is still included, it's only the PT_DYNAMIC, .dynamic and the _DYNAMIC symbol that are excluded.

Feb 1 2018, 2:40 PM

Jan 31 2018

ed added a comment to D42748: [ELF] Don't create a .dynamic section when linking with -Bstatic.

This effectively reverts rL295240, right? If so, I'd personally oppose to this change.

Jan 31 2018, 11:33 PM

Jan 9 2018

ed committed rL322064: ananas: Add shared library support.
ananas: Add shared library support
Jan 9 2018, 1:19 AM
ed committed rC322064: ananas: Add shared library support.
ananas: Add shared library support
Jan 9 2018, 1:19 AM
ed closed D41500: ananas: Add shared library support.
Jan 9 2018, 1:19 AM
ed accepted D41500: ananas: Add shared library support.
In D41500#965157, @zhmu wrote:

@ed I tried to keep things as much in line as the other <os>::linker::Construct() functions do. Do you wish to stray from that path?

I actually prefer to keep it like this as it's quite readable already, but YMMV of course :-)

Jan 9 2018, 12:43 AM

Dec 27 2017

ed added inline comments to D41500: ananas: Add shared library support.
Dec 27 2017, 6:39 AM

Dec 5 2017

ed committed rC319746: Add __WINT_MAX__..
Add __WINT_MAX__.
Dec 5 2017, 1:14 AM
ed committed rL319746: Add __WINT_MAX__..
Add __WINT_MAX__.
Dec 5 2017, 1:13 AM

Sep 21 2017

ed accepted D38108: [libunwind] Partially revert r297174 to fix build on at least FreeBSD..
Sep 21 2017, 12:27 PM

Sep 20 2017

ed accepted D38108: [libunwind] Partially revert r297174 to fix build on at least FreeBSD..
Sep 20 2017, 11:24 PM
ed added a comment to D38108: [libunwind] Partially revert r297174 to fix build on at least FreeBSD..

Hey! Sorry for the breakage. I thought I did a good job of testing this change on various operating systems, but somehow this still fell through the cracks. Odd.

Sep 20 2017, 11:23 PM

Jun 25 2017

ed committed rL306237: Add support for Ananas platform.
Add support for Ananas platform
Jun 25 2017, 1:55 PM
ed closed D32936: [clang] Add support for Ananas platform.
Jun 25 2017, 1:29 AM
ed closed D32937: [llvm] Add support for Ananas platform.
Jun 25 2017, 1:29 AM

Jun 19 2017

ed added a comment to D32936: [clang] Add support for Ananas platform.

Final call: do any of you have any more feedback on this change? If not, I will go ahead and commit this change one of these days (together with D32937).

Jun 19 2017, 12:04 PM

May 22 2017

ed added a comment to D32937: [llvm] Add support for Ananas platform.

Hi Davide,

May 22 2017, 1:27 AM

May 20 2017

ed accepted D32936: [clang] Add support for Ananas platform.

These changes look all right to me, except that I'd like it if someone else could take a look at Ananas.cpp as well. Is anyone interested in taking a look?

May 20 2017, 5:53 AM
ed accepted D32937: [llvm] Add support for Ananas platform.

This change looks good to me. Does anyone mind if I were to commit this?

May 20 2017, 5:52 AM
ed added a reviewer for D32936: [clang] Add support for Ananas platform: cfe-commits.
May 20 2017, 5:51 AM
ed added a reviewer for D32937: [llvm] Add support for Ananas platform: llvm-commits.
May 20 2017, 5:50 AM

Mar 16 2017

ed committed rL297956: Make table cells referring to Clang 4 green, as Clang 4 has been released..
Make table cells referring to Clang 4 green, as Clang 4 has been released.
Mar 16 2017, 7:33 AM

Mar 14 2017

ed added a comment to D29818: [libcxx] Threading support: Attempt to externalize system_clock::now() and steady_clock::now() implementations.

Worth mentioning: the latest version of macOS now supports clock_gettime(). Maybe better to leave the code as is and simply axe the Mach time code at some point in the future?

Mar 14 2017, 2:02 PM

Mar 9 2017

ed committed rL297364: Fix up the places where AddressSpace.hpp is included..
Fix up the places where AddressSpace.hpp is included.
Mar 9 2017, 12:16 AM

Mar 7 2017

ed committed rL297175: Tidy up the way we include EHHeaderParser.hpp..
Tidy up the way we include EHHeaderParser.hpp.
Mar 7 2017, 10:33 AM
ed committed rL297174: Improve readability and correctness of the OS specific libunwind bits..
Improve readability and correctness of the OS specific libunwind bits.
Mar 7 2017, 10:28 AM
ed closed D30696: Improve readability and correctness of the OS specific libunwind bits. by committing rL297174: Improve readability and correctness of the OS specific libunwind bits..
Mar 7 2017, 10:28 AM
ed created D30696: Improve readability and correctness of the OS specific libunwind bits..
Mar 7 2017, 7:58 AM
ed committed rL297149: Let arm_section_length store the number of bytes..
Let arm_section_length store the number of bytes.
Mar 7 2017, 7:34 AM
ed closed D30681: Let arm_section_length store the number of bytes. by committing rL297149: Let arm_section_length store the number of bytes..
Mar 7 2017, 7:34 AM
ed added a comment to D30681: Let arm_section_length store the number of bytes..

This change looks OK to me.

Mar 7 2017, 7:33 AM
ed created D30681: Let arm_section_length store the number of bytes..
Mar 7 2017, 12:11 AM

Mar 5 2017

ed committed rL296991: Drop the dependency on dl_unwind_find_exidx()..
Drop the dependency on dl_unwind_find_exidx().
Mar 5 2017, 11:23 AM
ed closed D30306: Drop the dependency on dl_unwind_find_exidx(). by committing rL296991: Drop the dependency on dl_unwind_find_exidx()..
Mar 5 2017, 11:23 AM

Feb 23 2017

ed created D30306: Drop the dependency on dl_unwind_find_exidx()..
Feb 23 2017, 11:52 AM
ed committed rL295948: Revert r295944..
Revert r295944.
Feb 23 2017, 1:25 AM
ed committed rL295944: Drop the dependency on dl_unwind_find_exidx()..
Drop the dependency on dl_unwind_find_exidx().
Feb 23 2017, 12:17 AM
ed closed D28082: Drop the dependency on dl_unwind_find_exidx(). by committing rL295944: Drop the dependency on dl_unwind_find_exidx()..
Feb 23 2017, 12:17 AM

Feb 21 2017

ed committed rL295725: Add a test for the feature introduced in r295240..
Add a test for the feature introduced in r295240.
Feb 21 2017, 7:46 AM
ed closed D30175: Add a test for the feature introduced in r295240. by committing rL295725: Add a test for the feature introduced in r295240..
Feb 21 2017, 7:46 AM
ed added a comment to D28082: Drop the dependency on dl_unwind_find_exidx()..

Any more feedback before I commit this change to the trunk?

Feb 21 2017, 1:56 AM
ed updated the diff for D28082: Drop the dependency on dl_unwind_find_exidx()..

Restore comment that was lost during sync to latest code.

Feb 21 2017, 1:55 AM

Feb 20 2017

ed updated the diff for D30175: Add a test for the feature introduced in r295240..

Remove numbers from llvm-readobj output to make test future proof.

Feb 20 2017, 10:14 PM
ed created D30175: Add a test for the feature introduced in r295240..
Feb 20 2017, 10:49 AM

Feb 15 2017

ed committed rL295240: Make --export-dynamic work on non-PIC/PIE targets..
Make --export-dynamic work on non-PIC/PIE targets.
Feb 15 2017, 2:03 PM
ed closed D29982: Make --export-dynamic work on non-PIC/PIE targets. by committing rL295240: Make --export-dynamic work on non-PIC/PIE targets..
Feb 15 2017, 2:03 PM
ed created D29982: Make --export-dynamic work on non-PIC/PIE targets..
Feb 15 2017, 2:24 AM

Feb 13 2017

ed added a reviewer for D28082: Drop the dependency on dl_unwind_find_exidx().: compnerd.
Feb 13 2017, 12:32 AM
ed updated the diff for D28082: Drop the dependency on dl_unwind_find_exidx()..

Sync to latest codebase.

Feb 13 2017, 12:31 AM

Feb 11 2017

ed committed rL294833: Remove a now unneeded __CloudABI__ check..
Remove a now unneeded __CloudABI__ check.
Feb 11 2017, 12:44 AM
ed committed rL294832: Fix the build of thread.cpp on CloudABI..
Fix the build of thread.cpp on CloudABI.
Feb 11 2017, 12:42 AM

Feb 2 2017

ed added a comment to D28082: Drop the dependency on dl_unwind_find_exidx()..

Friendly ping! :-)

Feb 2 2017, 4:22 AM

Dec 30 2016

ed committed rL290748: Remove mblen(), mbtowc() and wctomb() from the thread-unsafe functions..
Remove mblen(), mbtowc() and wctomb() from the thread-unsafe functions.
Dec 30 2016, 2:54 AM
ed closed D21436: Remove mblen(), mbtowc() and wctomb() from the thread-unsafe functions. by committing rL290748: Remove mblen(), mbtowc() and wctomb() from the thread-unsafe functions..
Dec 30 2016, 2:54 AM

Dec 29 2016

ed updated subscribers of D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__.
Dec 29 2016, 3:10 AM

Dec 28 2016

ed added a comment to D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__.

I'd be interested in seeing a feature like this appearing. Any chance this feature may be part of Clang 4.0?

Dec 28 2016, 4:23 AM

Dec 24 2016

ed added a comment to D28082: Drop the dependency on dl_unwind_find_exidx()..

Also an interesting observation: _LIBUNWIND_IS_BAREMETAL seems to be used only in this single source file and only provides an implementation for ARMv6.

Dec 24 2016, 5:57 AM

Dec 23 2016

ed updated the diff for D28082: Drop the dependency on dl_unwind_find_exidx()..

Add a comment after the 'else' to indicate this code applies to ARM.

Dec 23 2016, 11:21 PM
ed added a comment to D28082: Drop the dependency on dl_unwind_find_exidx()..

Interesting observation: dwarf_index_section_length stores the length of the section, whereas arm_section_length stores the number of entries in the section. This feels a bit unnatural in my opinion. Should this be tackled in this change as well, or do we want to do this separately?

Dec 23 2016, 2:39 PM
ed retitled D28082: Drop the dependency on dl_unwind_find_exidx(). from to Drop the dependency on dl_unwind_find_exidx()..
Dec 23 2016, 2:31 PM
ed committed rL290443: Extend the tests for -Wmissing-variable-declarations..
Extend the tests for -Wmissing-variable-declarations.
Dec 23 2016, 11:30 AM

Dec 18 2016

ed accepted D27902: Fix build breakage on FreeBSD after rL289878/rL289881.

I'm the author of FreeBSD's utmpx. LGTM!

Dec 18 2016, 1:12 PM

Nov 16 2016

ed committed rL287093: Merge r280672, per bug 30839:.
Merge r280672, per bug 30839:
Nov 16 2016, 2:28 AM

Sep 28 2016

ed committed rL282589: Also use the proper register numbers on CloudABI..
Also use the proper register numbers on CloudABI.
Sep 28 2016, 7:00 AM

Sep 22 2016

ed added a comment to D24827: [ARM][LLD] ARM TLS shouldn't use relaxations.

Not that it helps much, but with this patch I can at least get all of the packages for CloudABI to build on ARMv6. I can't test whether the resulting binaries work yet, as I'm at a conference. I will be able to test this for you on Monday.

Sep 22 2016, 2:20 PM

Sep 5 2016

ed committed rL280672: Add support for targeting armv6-unknown-cloudabi-eabihf..
Add support for targeting armv6-unknown-cloudabi-eabihf.
Sep 5 2016, 11:47 AM

Aug 20 2016

ed committed rL279368: Add R_386_TLS_LE as a relocation having an implicit addend..
Add R_386_TLS_LE as a relocation having an implicit addend.
Aug 20 2016, 4:03 AM
ed closed D23741: Add R_386_TLS_LE as a relocation having an implicit addend. by committing rL279368: Add R_386_TLS_LE as a relocation having an implicit addend..
Aug 20 2016, 4:02 AM
ed retitled D23741: Add R_386_TLS_LE as a relocation having an implicit addend. from to Add R_386_TLS_LE as a relocation having an implicit addend..
Aug 20 2016, 2:08 AM

Aug 13 2016

ed committed rL278605: Merge r278393 and r278395..
Merge r278393 and r278395.
Aug 13 2016, 1:52 PM

Aug 11 2016

ed committed rL278395: Don't enable PIE on i686-unknown-cloudabi..
Don't enable PIE on i686-unknown-cloudabi.
Aug 11 2016, 1:11 PM
ed committed rL278393: Pass in frame pointer omitting compiler flags for CloudABI as well..
Pass in frame pointer omitting compiler flags for CloudABI as well.
Aug 11 2016, 12:32 PM
ed added a comment to D22954: [ELF] Allow arbitrary code alignment in .eh_frame.
In D22954#512472, @ed wrote:

I just experienced this error while trying to build glib for i686.

Aug 11 2016, 6:25 AM · lld
ed added a comment to D22954: [ELF] Allow arbitrary code alignment in .eh_frame.

I just experienced this error while trying to build glib for i686.

Aug 11 2016, 4:40 AM · lld

Jul 2 2016

ed added a comment to D21436: Remove mblen(), mbtowc() and wctomb() from the thread-unsafe functions..

Friendly ping. :-)

Jul 2 2016, 2:12 AM

Jun 16 2016

ed updated D21436: Remove mblen(), mbtowc() and wctomb() from the thread-unsafe functions..
Jun 16 2016, 8:07 AM
ed retitled D21436: Remove mblen(), mbtowc() and wctomb() from the thread-unsafe functions. from to Remove mblen(), mbtowc() and wctomb() from the thread-unsafe functions..
Jun 16 2016, 8:06 AM
ed committed rL272886: Remove CloudABI specific workaround..
Remove CloudABI specific workaround.
Jun 16 2016, 5:00 AM

May 3 2016

ed accepted D19836: ELF: Fix regression in TLS attribute mismatch logic..

Seems to fix the issue. Thanks!

May 3 2016, 2:15 AM

Apr 9 2016

ed accepted D18846: [safestack] Add canary to unsafe stack frames.

I've just built a copy of LLVM and Clang with these patches applied. With that compiler I did a full rebuild of all core CloudABI libraries, including the C library's unit test suite (~1000 tests), with -fstack-protector-all and SafeStack enabled. All unit tests still seem to pass.

Apr 9 2016, 12:15 PM

Apr 6 2016

ed added a comment to D18846: [safestack] Add canary to unsafe stack frames.

Thanks for working on this! I know too little of LLVM internals to review this change properly, but I'd be more than happy to run our C library test suite against this. Could you also send out the patch for Clang you mentioned, so I can test this?

Apr 6 2016, 10:35 PM
ed committed rL265580: Sort relocations by name and size..
Sort relocations by name and size.
Apr 6 2016, 11:26 AM
ed closed D18835: Sort relocations by name and size. by committing rL265580: Sort relocations by name and size..
Apr 6 2016, 11:26 AM
ed retitled D18835: Sort relocations by name and size. from to Sort relocations by name and size..
Apr 6 2016, 11:01 AM
ed committed rL265575: Make TLS work for PIE executables on aarch64..
Make TLS work for PIE executables on aarch64.
Apr 6 2016, 10:59 AM
ed closed D18816: Make TLS work for PIE executables on aarch64. by committing rL265575: Make TLS work for PIE executables on aarch64..
Apr 6 2016, 10:58 AM
ed committed rL265546: Enable PIE for CloudABI..
Enable PIE for CloudABI.
Apr 6 2016, 8:42 AM
ed retitled D18816: Make TLS work for PIE executables on aarch64. from to Make TLS work for PIE executables on aarch64..
Apr 6 2016, 12:33 AM
ed closed D18688: Make TLS work for PIE executables on x86-64..
Apr 6 2016, 12:30 AM

Apr 5 2016

ed committed rL265462: Make TLS work for PIE executables on x86-64..
Make TLS work for PIE executables on x86-64.
Apr 5 2016, 1:57 PM
ed added a comment to D18688: Make TLS work for PIE executables on x86-64..

Okay. Now that my other change has landed, I think we can go ahead with this change as well. Any thoughts?

Apr 5 2016, 1:52 PM
ed updated the diff for D18688: Make TLS work for PIE executables on x86-64..

Put tls-initial-exec-local.s back in now that the GOT works properly.

Apr 5 2016, 1:51 PM
ed committed rL265453: Don't omit dynamic relocations for the GOT..
Don't omit dynamic relocations for the GOT.
Apr 5 2016, 1:24 PM
ed closed D18739: Don't omit dynamic relocations for the GOT. by committing rL265453: Don't omit dynamic relocations for the GOT..
Apr 5 2016, 1:23 PM
ed added a comment to D18739: Don't omit dynamic relocations for the GOT..

LGTM. Do you have commit access?

Apr 5 2016, 1:23 PM
ed added a comment to D18739: Don't omit dynamic relocations for the GOT..

The code does look wrong. It happens to work given the current implementations of isRelRelative. You should completely delete Dynrel, if we need a relocation for the got entry itself should only depend on the symbol and whether the output is relocatable (Config->Pic).

Apr 5 2016, 11:54 AM
ed updated the diff for D18739: Don't omit dynamic relocations for the GOT..

Simplify, as suggested by Rafael. Also add a test.

Apr 5 2016, 11:52 AM

Apr 3 2016

ed added a comment to D18688: Make TLS work for PIE executables on x86-64..

This is interesting. Together with http://reviews.llvm.org/D18739, test/ELF/tls-initial-exec-local.s passes again.

Apr 3 2016, 2:16 PM
ed retitled D18739: Don't omit dynamic relocations for the GOT. from to Don't omit dynamic relocations for the GOT..
Apr 3 2016, 3:47 AM

Apr 2 2016

ed committed rL265246: Provide support for Binutils' --no-dynamic-linker option..
Provide support for Binutils' --no-dynamic-linker option.
Apr 2 2016, 2:03 PM