This is an archive of the discontinued LLVM Phabricator instance.

[NFC][analyzer] Fix static analyzer concerns
ClosedPublic

Authored by Fznamznon on Jul 27 2023, 3:17 AM.

Details

Summary

CFGStmtMap frees resources in the destructor but doesn't
have user-written copy c'tor or assignment operator, so copying it using
default ones can cause double free.

Diff Detail

Event Timeline

Fznamznon created this revision.Jul 27 2023, 3:17 AM
Herald added a project: Restricted Project. · View Herald Transcript
Fznamznon requested review of this revision.Jul 27 2023, 3:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2023, 3:17 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Fznamznon updated this revision to Diff 545082.Jul 28 2023, 2:42 AM

Rebase to maybe pass precommit

Fznamznon retitled this revision from [NFC][clang] Fix static analyzer concerns to [NFC][analyzer] Fix static analyzer concerns.Jul 28 2023, 3:11 AM
cor3ntin accepted this revision.Jul 28 2023, 3:29 AM
cor3ntin added a subscriber: cor3ntin.

LGTM

This revision is now accepted and ready to land.Jul 28 2023, 3:29 AM

The failures are unrelated.

This revision was landed with ongoing or failed builds.Jul 28 2023, 5:32 AM
This revision was automatically updated to reflect the committed changes.