Page MenuHomePhabricator

ASDenysPetrov (Denys Petrov)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 17 2020, 10:23 AM (120 w, 1 d)

Recent Activity

Tue, Jul 5

ASDenysPetrov accepted D129152: [Clang][unittests] Silence trucation warning with MSVC.

@aganea Thank you for fixing this.
TestValues structure impies to hold a set of values which can do some kind of convertions including truncations. This is what tests are about. That's true, it may happen that some test cases don't need some values. You can carry them out to some TestValues2 structure and use them instead. That also would work. So it's up to you. I'm OK with both solutions.

Tue, Jul 5, 11:44 AM · Restricted Project, Restricted Project

Mon, Jun 27

ASDenysPetrov added a comment to D103096: [analyzer] Implement cast for ranges of symbolic integers.

@martong Just FYI. I've been working on reworking this solution to using EquivalenceClasses for several weeks. It turned out that this is an extremely hard task to acomplish. There a lot of cast cases like: (int8)x==y, (uint16)a==(int64)b, (uint8)y == b, Merging and inferring all of this without going beyond the complexity O(n) is really tricky.

Mon, Jun 27, 11:15 AM · Restricted Project, Restricted Project

May 30 2022

ASDenysPetrov accepted D126481: [analyzer] Handle SymbolCast in SValBuilder.

This part of the SValBuilder is responsible for constant folding. We need this constant folding, so the engine can work with less symbols, this way it can be more efficient. Whenever a symbol is constrained with a constant then we substitute the symbol with the corresponding integer. If a symbol is constrained with a range, then the symbol is kept and we fall-back to use the range based constraint manager, which is not that efficient. This patch is the natural extension of the existing constant folding machinery with the support of SymbolCast symbols.

Now I see. Thanks. I also wouldn't mind if you add this explanation to the summary.

May 30 2022, 9:37 AM · Restricted Project, Restricted Project

May 27 2022

ASDenysPetrov added a comment to D126481: [analyzer] Handle SymbolCast in SValBuilder.

@martong As you said, my solution D103096 suppose to pass these and more other tests cases. So how it will help in combination with my solution D103096?
Although, your patch is really simple but it's more like a plug then a real SymbolCast support, isn't it? I don't quite understand the motivation.

May 27 2022, 11:14 AM · Restricted Project, Restricted Project

May 19 2022

ASDenysPetrov updated the summary of D103096: [analyzer] Implement cast for ranges of symbolic integers.
May 19 2022, 10:26 AM · Restricted Project, Restricted Project

May 13 2022

ASDenysPetrov added a comment to D103096: [analyzer] Implement cast for ranges of symbolic integers.

Ping

Thank you, folk, for taking you time. I'll surely make corresponding changes according to your suggestions and notify you then. Sorry, @martong, for the late response. I'm pretty loaded recent times.

May 13 2022, 8:38 AM · Restricted Project, Restricted Project

Apr 26 2022

ASDenysPetrov updated the diff for D103096: [analyzer] Implement cast for ranges of symbolic integers.

@martong thank you for the idea. I've tried to implement it. Could you look at the patch once again, please? I've also described a new solution in the Summary.

Apr 26 2022, 9:36 AM · Restricted Project, Restricted Project

Apr 22 2022

ASDenysPetrov added a comment to D103096: [analyzer] Implement cast for ranges of symbolic integers.

Thank you for the review @martong! Your work is not less hard than mine. I'll rework and update the revision ASAP.

Apr 22 2022, 12:40 PM · Restricted Project, Restricted Project

Apr 19 2022

ASDenysPetrov updated the diff for D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

Loaded with comment updateds according to the remarks.
@martong thank you for your time for the review!

Apr 19 2022, 10:31 PM · Restricted Project, Restricted Project
ASDenysPetrov committed rGe37726beb22a: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions… (authored by ASDenysPetrov).
[analyzer] Implemented RangeSet::Factory::castTo function to perform promotions…
Apr 19 2022, 12:34 PM · Restricted Project, Restricted Project
ASDenysPetrov closed D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.
Apr 19 2022, 12:34 PM · Restricted Project, Restricted Project

Apr 15 2022

ASDenysPetrov updated the diff for D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

Updated according to suggestions.
@martong thank you for the review.

Apr 15 2022, 6:34 AM · Restricted Project, Restricted Project
ASDenysPetrov added inline comments to D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.
Apr 15 2022, 6:10 AM · Restricted Project, Restricted Project

Apr 14 2022

Herald added a project to D113004: [analyzer][docs] Add Configuration section to user-docs: Restricted Project.
Apr 14 2022, 3:02 AM · Restricted Project

Apr 12 2022

ASDenysPetrov accepted D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page.

Thanks! LGTM.

Apr 12 2022, 9:41 AM · Restricted Project, Restricted Project

Apr 11 2022

ASDenysPetrov accepted D122243: [analyzer][NFC] Introduce the checker package separator character.

LGTM

Apr 11 2022, 10:00 AM · Restricted Project, Restricted Project
Herald added a project to D107636: [analyzer][solver] Compute adjustment for unsupported symbols as well: Restricted Project.

I checked the tests file on the latest sources. It passes even without your changes. Maybe this patch is already outdated.

Apr 11 2022, 9:52 AM · Restricted Project, Restricted Project

Apr 7 2022

ASDenysPetrov added a comment to D112621: [analyzer][solver] Introduce reasoning for not equal to operator.

Here are my remarks.

Apr 7 2022, 9:55 AM · Restricted Project, Restricted Project

Mar 23 2022

Herald added a project to D103096: [analyzer] Implement cast for ranges of symbolic integers: Restricted Project.

Ping. If there is somebody interested in this? :)

Mar 23 2022, 10:13 AM · Restricted Project, Restricted Project
Herald added a project to D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions: Restricted Project.

Ping.

Mar 23 2022, 10:13 AM · Restricted Project, Restricted Project

Jan 27 2022

ASDenysPetrov abandoned D108032: [analyzer] Retrieve a character from CompoundLiteralExpr as an initializer for constant arrays..

Paused for a while.

Jan 27 2022, 8:41 AM · Restricted Project

Jan 20 2022

ASDenysPetrov added inline comments to D117229: [Analyzer] Produce SymbolCast for pointer to integer cast.
Jan 20 2022, 9:15 AM · Restricted Project, Restricted Project
ASDenysPetrov added inline comments to D117229: [Analyzer] Produce SymbolCast for pointer to integer cast.
Jan 20 2022, 9:14 AM · Restricted Project, Restricted Project

Jan 18 2022

ASDenysPetrov committed rGd835dd4cf5cc: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder… (authored by ASDenysPetrov).
[analyzer] Produce SymbolCast symbols for integral types in SValBuilder…
Jan 18 2022, 6:08 AM
ASDenysPetrov closed D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast.
Jan 18 2022, 6:08 AM · Restricted Project, Restricted Project

Jan 13 2022

ASDenysPetrov added inline comments to D117229: [Analyzer] Produce SymbolCast for pointer to integer cast.
Jan 13 2022, 8:39 AM · Restricted Project, Restricted Project
ASDenysPetrov added a comment to D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast.

Thank you @martong.
I'll load it ASAP. It's great to see symcasts is closer.

Jan 13 2022, 4:24 AM · Restricted Project, Restricted Project

Jan 12 2022

ASDenysPetrov added a comment to D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast.

This looks great with the option flag. Landing this patch will enable more people to test the new mode and produce feedback on whether the constraint solver keeps working well enough in presence of the new symbols.

Jan 12 2022, 6:53 AM · Restricted Project, Restricted Project

Jan 11 2022

ASDenysPetrov requested review of D117035: [analyzer] Added more tests for scalars, enums and records for StrictAliasingChecker.
Jan 11 2022, 9:37 AM · Restricted Project
ASDenysPetrov requested review of D117033: [analyzer] Added more tests for scalars and enums for StrictAliasingChecker.
Jan 11 2022, 9:35 AM · Restricted Project
ASDenysPetrov updated the diff for D114718: [analyzer] Implement a new checker for Strict Aliasing Rule..

Improved the checker. Reworked tests.

Jan 11 2022, 9:33 AM · Restricted Project

Jan 10 2022

ASDenysPetrov added inline comments to D115932: [Analyzer] Create and handle SymbolCast for pointer to integral conversion.
Jan 10 2022, 4:58 AM · Restricted Project
ASDenysPetrov added inline comments to D115932: [Analyzer] Create and handle SymbolCast for pointer to integral conversion.
Jan 10 2022, 4:46 AM · Restricted Project
ASDenysPetrov added a comment to D115932: [Analyzer] Create and handle SymbolCast for pointer to integral conversion.

Starting producing SymbolCast you should be careful. It'll be helpfull for you to pay attention on my revisions D105340 and D103096 before doing this. I don't want you walk through the things I fought with. At least we've discussed to introduce a new flag support-symbolic-integer-casts to turn on/off producing the casts.

Jan 10 2022, 4:32 AM · Restricted Project

Dec 22 2021

ASDenysPetrov updated the summary of D114718: [analyzer] Implement a new checker for Strict Aliasing Rule..
Dec 22 2021, 9:53 AM · Restricted Project
ASDenysPetrov updated the diff for D114718: [analyzer] Implement a new checker for Strict Aliasing Rule..

Added more tests for records (classes, structs, unions). Improved AccessInferrer. Removed support of cast kinds such as DerivedToBase and BaseToDerived, since they are not implied in C++20 7.2.1 p11 paragraph.
TODO: White tests for multi-level casts, e.g.:

T1 a;              // a
auto* b = (T2*)&a; // {a, T2}
auto* c = (T3*)b;  // {{a, T2}, T3}
auto* d = (T4*)c;  // {{{a, T2}, T3}, T4}
auto e = *d;

TODO: Fix case with loc::ConcreteInt, e.g.:

T1 *a = nullptr;   // 0 loc
auto* b = (T2*)&a; // 0 loc
auto c = *d;       // We are not able to detect an original type and aliased type from ConcreteInt.
Dec 22 2021, 9:10 AM · Restricted Project

Dec 21 2021

ASDenysPetrov added a comment to D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast.

Just a ping. I'd like to have this patch stack loaded somewhen :)

Dec 21 2021, 12:59 AM · Restricted Project, Restricted Project

Dec 20 2021

ASDenysPetrov updated the diff for D114718: [analyzer] Implement a new checker for Strict Aliasing Rule..

Improved AccessInferrer::isOppositeSign. Reworked tests.
TODO: Write more synthetic and real-world tests.

Dec 20 2021, 9:58 AM · Restricted Project

Dec 17 2021

ASDenysPetrov added a comment to D114718: [analyzer] Implement a new checker for Strict Aliasing Rule..

@steakhal Thanks! I appreciate your comprehensive comment! I'll take everything you suggested into account.

Dec 17 2021, 4:31 AM · Restricted Project
ASDenysPetrov closed D115883: [analyzer][NFC] Change return value of StoreManager::attemptDownCast function from SVal to Optional<SVal>.

Closed with rGda8bd972a33ad642d6237b5b95b31a2a20f46a35

Dec 17 2021, 3:38 AM · Restricted Project
ASDenysPetrov committed rGda8bd972a33a: [analyzer][NFC] Change return value of StoreManager::attemptDownCast function… (authored by ASDenysPetrov).
[analyzer][NFC] Change return value of StoreManager::attemptDownCast function…
Dec 17 2021, 3:04 AM
ASDenysPetrov added a comment to D115883: [analyzer][NFC] Change return value of StoreManager::attemptDownCast function from SVal to Optional<SVal>.

@xazax.hun
Many thanks for the review.

Dec 17 2021, 2:44 AM · Restricted Project

Dec 16 2021

ASDenysPetrov updated the summary of D115883: [analyzer][NFC] Change return value of StoreManager::attemptDownCast function from SVal to Optional<SVal>.
Dec 16 2021, 8:58 AM · Restricted Project
ASDenysPetrov requested review of D115883: [analyzer][NFC] Change return value of StoreManager::attemptDownCast function from SVal to Optional<SVal>.
Dec 16 2021, 8:57 AM · Restricted Project

Dec 15 2021

ASDenysPetrov added a comment to D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions.

@martong
Thanks for clarification.

TLDR, it is recommended to use the arcanist.

I'm not able to use arcanist. It doesn't work on Windows (at least I've tryed several ways to set up it).

Dec 15 2021, 10:58 AM · Restricted Project

Dec 14 2021

ASDenysPetrov added a comment to D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions.

@martong wrote:

Denis, you can see in the Revision Contents that Diff 3 has the baseline commit 63a6348. When I check out 63a6348 then the newly added test file triggers the assertion about BO_Add.

Yes is see it:


I don't get this feature. Is it a parent or something? Please explain how to interpret this table. And how can I use it myself and when?

Dec 14 2021, 9:59 AM · Restricted Project
ASDenysPetrov updated the diff for D114718: [analyzer] Implement a new checker for Strict Aliasing Rule..

Changed handler check:: functions. Reworked. Covered more cases.

Dec 14 2021, 9:33 AM · Restricted Project

Dec 13 2021

ASDenysPetrov added a comment to D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions.

@steakhal
I don't get this one. I've provided a bunch of tests, even annotated with no-crash comments where we crashed prior to this change.

I wasn't able to catch any crashes with your tests file (symbol-simplification-nonloc-loc.cpp) on the baseline before your patch (D115149#3180005). So I ask you to provide the concrete example you've caught which promted you to do this patch.

Dec 13 2021, 4:59 AM · Restricted Project

Dec 10 2021

ASDenysPetrov committed rG6a399bf4b3aa: [analyzer] Implemented RangeSet::Factory::unite function to handle… (authored by ASDenysPetrov).
[analyzer] Implemented RangeSet::Factory::unite function to handle…
Dec 10 2021, 8:48 AM
ASDenysPetrov closed D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency.
Dec 10 2021, 8:48 AM · Restricted Project
ASDenysPetrov updated the diff for D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency.

Fixed code formatting in the unit test file according to remarks. Ready to load.

Dec 10 2021, 8:46 AM · Restricted Project

Dec 9 2021

ASDenysPetrov added inline comments to D114718: [analyzer] Implement a new checker for Strict Aliasing Rule..
Dec 9 2021, 5:00 AM · Restricted Project
ASDenysPetrov added inline comments to D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions.
Dec 9 2021, 1:25 AM · Restricted Project
ASDenysPetrov added a comment to D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions.

@NoQ wrote:

I'm confident that there's a way to get it right, simply because the program under analysis is type-correct. If it's the simplifier, let's fix the simplifier.

I agree with your main thought. But I also believe there definitely are thing to improve everywhere. And this one could wait until we find the root cause and correct it somewhere before.

Dec 9 2021, 1:11 AM · Restricted Project

Dec 8 2021

ASDenysPetrov added a comment to D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions.

It seems like your test file passes even before your patch. I've just checked it. My last pull from the baseline was on Nov 15.

Dec 8 2021, 10:15 AM · Restricted Project
ASDenysPetrov updated the diff for D114718: [analyzer] Implement a new checker for Strict Aliasing Rule..

Improved dynamic type recognition. Provided -fstrict-aliasing compiler flag dependency.
Still has issues with some cases (see it at the bottom of the test file). WIP.

Dec 8 2021, 9:51 AM · Restricted Project
ASDenysPetrov updated the diff for D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances.

Fixed unit test.

Dec 8 2021, 12:17 AM · Restricted Project

Dec 7 2021

ASDenysPetrov updated the diff for D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances.

Passed a CodeGenOptions reference to CheckerManager as well. (Adjusted to D114718)

Dec 7 2021, 3:10 PM · Restricted Project
ASDenysPetrov added inline comments to D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions.
Dec 7 2021, 4:00 AM · Restricted Project

Dec 3 2021

ASDenysPetrov added a comment to D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency.

@martong

Nice, assiduous work!

Many thanks for your time! Your work is not less assiduous!

(LHS, RHS) swaps

it doesn't really matter, as the operation is comutative, but, yes, it does matter to depict the particular test case. I'll revise twise LHS-RHS's.

I am going to continue with the next patch in the stack. I recognize that the handling of casts is very important and problems related to not handling them occurs even more frequently as other parts of the engine evolve (e.g. https://reviews.llvm.org/D113753#3167134)

Aha. I saw you patch. I'll join to review it.

Dec 3 2021, 10:29 AM · Restricted Project

Dec 2 2021

ASDenysPetrov updated the summary of D114718: [analyzer] Implement a new checker for Strict Aliasing Rule..
Dec 2 2021, 9:05 AM · Restricted Project
ASDenysPetrov added a comment to D114718: [analyzer] Implement a new checker for Strict Aliasing Rule..

@xazax.hun Updated the summary for better undersanding differencies between the Standards.

Dec 2 2021, 8:35 AM · Restricted Project
ASDenysPetrov updated the summary of D114718: [analyzer] Implement a new checker for Strict Aliasing Rule..
Dec 2 2021, 8:34 AM · Restricted Project

Nov 30 2021

ASDenysPetrov added inline comments to D114718: [analyzer] Implement a new checker for Strict Aliasing Rule..
Nov 30 2021, 8:31 AM · Restricted Project

Nov 29 2021

ASDenysPetrov updated the summary of D114718: [analyzer] Implement a new checker for Strict Aliasing Rule..
Nov 29 2021, 9:56 AM · Restricted Project
ASDenysPetrov updated the summary of D114718: [analyzer] Implement a new checker for Strict Aliasing Rule..
Nov 29 2021, 9:48 AM · Restricted Project
ASDenysPetrov updated the summary of D114718: [analyzer] Implement a new checker for Strict Aliasing Rule..
Nov 29 2021, 9:47 AM · Restricted Project
ASDenysPetrov added a comment to D114718: [analyzer] Implement a new checker for Strict Aliasing Rule..

@rsmith, @aaron.ballman I kindly invite you to join the review process especially in a part of the Standard interpretation. Specifically @rsmith made proposals in this part of the Standard.

Nov 29 2021, 9:45 AM · Restricted Project
ASDenysPetrov requested review of D114718: [analyzer] Implement a new checker for Strict Aliasing Rule..
Nov 29 2021, 9:39 AM · Restricted Project
ASDenysPetrov added inline comments to D114441: [analyzer][NFC] Refactor AnalysisConsumer::getModeForDecl().
Nov 29 2021, 3:31 AM · Restricted Project

Nov 23 2021

ASDenysPetrov abandoned D110927: [analyzer] Access stored value of a constant array through a pointer to another type.

Temporary suspended this revision in favor of making a new checker StrictAliasingChecker, which would define an access to values through unpermited types as Undefined Behavior according to certain statements of the current Standard.

Nov 23 2021, 10:17 AM · Restricted Project

Nov 19 2021

ASDenysPetrov added a comment to D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances.

LGTM!

Nov 19 2021, 10:27 AM · Restricted Project
ASDenysPetrov updated the diff for D103096: [analyzer] Implement cast for ranges of symbolic integers.

Rebased.

Nov 19 2021, 10:14 AM · Restricted Project, Restricted Project
ASDenysPetrov updated the diff for D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast.

Rebased.

Nov 19 2021, 8:31 AM · Restricted Project, Restricted Project
ASDenysPetrov updated the diff for D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

Fixed missed part during rebasing in the unit test.

Nov 19 2021, 8:29 AM · Restricted Project, Restricted Project
ASDenysPetrov updated the diff for D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

Rebased.

Nov 19 2021, 6:02 AM · Restricted Project, Restricted Project

Nov 18 2021

ASDenysPetrov updated the diff for D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency.

Fixed comments.

Nov 18 2021, 8:42 AM · Restricted Project
ASDenysPetrov added inline comments to D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency.
Nov 18 2021, 8:40 AM · Restricted Project

Nov 17 2021

ASDenysPetrov added a comment to D110927: [analyzer] Access stored value of a constant array through a pointer to another type.

@steakhal Please, read the discussion started from here D104285#2943449. It's directly relates to this patch and what we've been arguing about.

Nov 17 2021, 11:22 AM · Restricted Project
ASDenysPetrov added a comment to D113588: [analyzer][NFC] Make the API of CallDescription safer slightly.

How to address this?

Nov 17 2021, 7:29 AM
ASDenysPetrov added inline comments to D113590: [analyzer][NFC] Introduce CallDescription::matches() in addition to isCalled().
Nov 17 2021, 7:09 AM · Restricted Project
ASDenysPetrov added a comment to D110927: [analyzer] Access stored value of a constant array through a pointer to another type.

@NoQ

If we ever prove that strict aliasing is violated on a given execution path (while being enabled), the ideal thing to do is to terminate the analysis immediately by generating a sink. We can then optionally develop a checker that emits a warning in such cases.

thinking about warnings I assume that the Store will produce UndefinedVals and Undef-related checkers will catch them. But yes, you're right. They wouldn't know anything about the origin of such UndefinedVals.

For the cases where you eliminate possibilities through recognizing strict aliasing, I wonder if a note can be added to the bug report to notify the user that the strict aliasing rule was invoked to add a certain assumption.

I didn't elaborate an idea with a checker yet but, I think, it can be the next step. What about a mechanism which would store the reason of UndefinedVal for existing checkers? It could make any checker more detailed and flexible.

Nov 17 2021, 7:05 AM · Restricted Project
ASDenysPetrov retitled D103096: [analyzer] Implement cast for ranges of symbolic integers from [analyzer] Implement cast for ranges of symbolic integers. to [analyzer] Implement cast for ranges of symbolic integers.
Nov 17 2021, 1:59 AM · Restricted Project, Restricted Project
ASDenysPetrov retitled D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions from [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions. to [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.
Nov 17 2021, 1:58 AM · Restricted Project, Restricted Project

Nov 16 2021

ASDenysPetrov added a comment to D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances.

Sweet!
I think commit titles are not punctuated, even though they start with an uppercase letter.

Nov 16 2021, 3:24 PM · Restricted Project
ASDenysPetrov retitled D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances from [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances. to [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances.
Nov 16 2021, 3:20 PM · Restricted Project
ASDenysPetrov updated the diff for D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances.

Fixed failed unittest (Syntax error).

Nov 16 2021, 3:17 PM · Restricted Project
ASDenysPetrov retitled D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances from [analyzer]{NFC} Enable access to CodeGenOptions from analyzer's instances. to [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances..
Nov 16 2021, 10:09 AM · Restricted Project
ASDenysPetrov requested review of D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances.
Nov 16 2021, 8:45 AM · Restricted Project

Nov 15 2021

ASDenysPetrov committed rGf0bc7d24882a: [analyzer] Fix region cast between the same types with different qualifiers. (authored by ASDenysPetrov).
[analyzer] Fix region cast between the same types with different qualifiers.
Nov 15 2021, 9:23 AM
ASDenysPetrov closed D113480: [analyzer] Fix region cast between the same types with different qualifiers..
Nov 15 2021, 9:23 AM · Restricted Project

Nov 12 2021

ASDenysPetrov added inline comments to D110927: [analyzer] Access stored value of a constant array through a pointer to another type.
Nov 12 2021, 7:26 AM · Restricted Project

Nov 11 2021

ASDenysPetrov added a comment to D110927: [analyzer] Access stored value of a constant array through a pointer to another type.

@steakhal

I think I know.

Great! Thank you!

Nov 11 2021, 6:14 AM · Restricted Project
ASDenysPetrov accepted D111795: [analyzer] Reject incomplete matches in CallEvent::isCalled(), also introduce wildcards.
Nov 11 2021, 1:24 AM
ASDenysPetrov added a comment to D111795: [analyzer] Reject incomplete matches in CallEvent::isCalled(), also introduce wildcards.

@steakhal for the changes.
Please, add to summary several examples of the feature usage.

Nov 11 2021, 1:23 AM

Nov 10 2021

ASDenysPetrov added a comment to D113480: [analyzer] Fix region cast between the same types with different qualifiers..

@steakhal Thank you!

Please clang-format the patch to reflow the touched comment. Given that's done, you are good to go.

The comment is OK. clang-format doesn't complain on it.

Also, wait a couple days before committing to give chance to the rest of the reviewers to have a look.

Sure.

Nov 10 2021, 1:02 PM · Restricted Project
ASDenysPetrov updated the diff for D113480: [analyzer] Fix region cast between the same types with different qualifiers..

Updated according to comments.

Nov 10 2021, 10:27 AM · Restricted Project
ASDenysPetrov added a comment to D111795: [analyzer] Reject incomplete matches in CallEvent::isCalled(), also introduce wildcards.

We could, but we would definitely pay the price. So, I'm not really a fan of doing that.

That's fair. Performance of regex really is a weak place.

Nov 10 2021, 10:11 AM
ASDenysPetrov added inline comments to D113480: [analyzer] Fix region cast between the same types with different qualifiers..
Nov 10 2021, 9:47 AM · Restricted Project
ASDenysPetrov added inline comments to D111795: [analyzer] Reject incomplete matches in CallEvent::isCalled(), also introduce wildcards.
Nov 10 2021, 9:41 AM