szepet (Peter Szecsi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 16 2016, 2:39 AM (105 w, 4 d)

Recent Activity

May 7 2018

szepet committed rC331630: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType….
[ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType…
May 7 2018, 5:12 AM
szepet committed rL331630: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType….
[ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType…
May 7 2018, 5:12 AM
szepet closed D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr.
May 7 2018, 5:12 AM

May 4 2018

szepet updated the diff for D40937: [clang-tidy] Infinite loop checker.

Changes based on comments.

May 4 2018, 1:12 AM · Restricted Project
szepet updated the diff for D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr.

Format changes added based on comments.

May 4 2018, 1:02 AM

May 2 2018

szepet committed rC331344: [ASTImporter] Fix isa cast assert.
[ASTImporter] Fix isa cast assert
May 2 2018, 4:56 AM
szepet committed rL331344: [ASTImporter] Fix isa cast assert.
[ASTImporter] Fix isa cast assert
May 2 2018, 4:56 AM
szepet closed D46019: [ASTImporter] Fix isa cast assert.
May 2 2018, 4:56 AM
szepet updated the diff for D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr.

Yepp, good point, Aleksei, rewritten the tests using explicit instantiation.

May 2 2018, 2:51 AM

Apr 26 2018

szepet added inline comments to D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr.
Apr 26 2018, 4:51 AM
szepet abandoned D32947: [ASTImporter] FriendDecl importing improvements.

I have commited this patch (r330847) but unfortunately "refactored" the differential revision link from the commit message out. Added it as a dependent commit.

Apr 26 2018, 4:24 AM
szepet added 1 commit(s) for D32947: [ASTImporter] FriendDecl importing improvements: rL330847: [ASTImporter] FriendDecl importing improvements.
Apr 26 2018, 4:17 AM
szepet added an edge to rL330847: [ASTImporter] FriendDecl importing improvements: D32947: [ASTImporter] FriendDecl importing improvements.
Apr 26 2018, 4:17 AM

Apr 25 2018

szepet committed rC330847: [ASTImporter] FriendDecl importing improvements.
[ASTImporter] FriendDecl importing improvements
Apr 25 2018, 10:31 AM
szepet committed rL330847: [ASTImporter] FriendDecl importing improvements.
[ASTImporter] FriendDecl importing improvements
Apr 25 2018, 10:31 AM
szepet accepted D46019: [ASTImporter] Fix isa cast assert.

Yepp, pretty straightforward check for something we were not aware previously (but unfortunately encountered it).

Apr 25 2018, 10:05 AM
szepet updated the diff for D40937: [clang-tidy] Infinite loop checker.

Changes made based on comments.
The CFG recreating problem is handled the following (only for this check):
Always store the last visited function and its CFG* (in form of the Sequence*) and check if we are visiting it again. If so, then the check reuses the previous one, if not, then replaces them. As far as I know the AST traverse done by the tidy fits this model (at least for this check, since it not uses narrowing matchers to other functions).
Sure, it would be better to find a general solution to this problem, and make the CFG reusable by every check which needs it, but I would left it for a follow-up (and a change like this probably would worth an own patch/review anyway).

Apr 25 2018, 9:34 AM · Restricted Project
szepet updated the diff for D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr.

Rewritten the tests using the newly added TEST_P method.
This patch failed earlier when -fdelayed-template-parsing flag was enabled, however, the actual import process was OK but the original AST havent included the checked nodes.
TEST_P made possible to check whether the original code contains the node we would like to import (and we test only in this case, since otherwise it does not make sense).

Apr 25 2018, 7:12 AM

Apr 11 2018

szepet added a comment to D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr.

Hello Aleksei,

Apr 11 2018, 3:27 AM

Apr 6 2018

szepet updated the diff for D40937: [clang-tidy] Infinite loop checker.

Addressed comments and readded the lost fixes.

Apr 6 2018, 5:33 AM · Restricted Project

Apr 5 2018

szepet updated the diff for D32947: [ASTImporter] FriendDecl importing improvements.

Rebase + set the IDNS in a more general way.

Apr 5 2018, 5:39 AM
szepet added inline comments to D40937: [clang-tidy] Infinite loop checker.
Apr 5 2018, 5:28 AM · Restricted Project
szepet updated the diff for D40937: [clang-tidy] Infinite loop checker.

Moved to bugprone category,
skipping memberExpr cases for now in order to avoid false positives,
other small changes based on review comments.

Apr 5 2018, 5:25 AM · Restricted Project

Mar 30 2018

szepet committed rL328906: [ASTImporter] Add test helper Fixture.
[ASTImporter] Add test helper Fixture
Mar 30 2018, 3:06 PM
szepet committed rC328906: [ASTImporter] Add test helper Fixture.
[ASTImporter] Add test helper Fixture
Mar 30 2018, 3:06 PM
szepet closed D43967: [ASTImporter] Add test helper Fixture.
Mar 30 2018, 3:06 PM
szepet accepted D45086: [analyzer] Unroll the loop when it has a unsigned counter..

Yepp, thanks for the patch! One small typo below.

Mar 30 2018, 12:00 PM

Mar 27 2018

szepet committed rL328619: [analyzer] LoopUnrolling: update the matched assignment operators.
[analyzer] LoopUnrolling: update the matched assignment operators
Mar 27 2018, 5:19 AM
szepet committed rC328619: [analyzer] LoopUnrolling: update the matched assignment operators.
[analyzer] LoopUnrolling: update the matched assignment operators
Mar 27 2018, 5:19 AM
szepet closed D38921: [analyzer] LoopUnrolling: update the matched assignment operators.
Mar 27 2018, 5:19 AM
szepet committed rL328618: [ASTMatchers] Add isAssignmentOperator matcher.
[ASTMatchers] Add isAssignmentOperator matcher
Mar 27 2018, 5:16 AM
szepet committed rC328618: [ASTMatchers] Add isAssignmentOperator matcher.
[ASTMatchers] Add isAssignmentOperator matcher
Mar 27 2018, 5:15 AM
szepet closed D44893: [ASTMatchers] Add isAssignmentOperator matcher.
Mar 27 2018, 5:15 AM

Mar 26 2018

szepet updated the diff for D38921: [analyzer] LoopUnrolling: update the matched assignment operators.

Added the assignment operator matcher patch as a dependency and rebased on top of that.

Mar 26 2018, 5:31 AM
szepet added a comment to D38921: [analyzer] LoopUnrolling: update the matched assignment operators.

Do you want to submit the matcher part separately?

Mar 26 2018, 3:31 AM
szepet added a dependent revision for D44893: [ASTMatchers] Add isAssignmentOperator matcher: D38921: [analyzer] LoopUnrolling: update the matched assignment operators.
Mar 26 2018, 3:29 AM
szepet added a dependency for D38921: [analyzer] LoopUnrolling: update the matched assignment operators: D44893: [ASTMatchers] Add isAssignmentOperator matcher.
Mar 26 2018, 3:29 AM
szepet created D44893: [ASTMatchers] Add isAssignmentOperator matcher.
Mar 26 2018, 3:27 AM

Mar 19 2018

szepet added a comment to D44606: [analyzer] Fix the crash in `IteratorChecker.cpp` when `SymbolConjured` has a null Stmt..

Nice catch, it looks good to me! Thank you!
One small nit for future debugging people: Could you insert a comment line in the test case where you explain what is this all about? E.g what you just have written in the description: "invalidateRegions() will construct the SymbolConjured with null Stmt" or something like this.

Mar 19 2018, 11:48 AM

Feb 21 2018

szepet committed rL325693: [analyzer] Prevent AnalyzerStatsChecker from crash.
[analyzer] Prevent AnalyzerStatsChecker from crash
Feb 21 2018, 8:09 AM
szepet committed rC325693: [analyzer] Prevent AnalyzerStatsChecker from crash.
[analyzer] Prevent AnalyzerStatsChecker from crash
Feb 21 2018, 8:09 AM
szepet closed D42266: [analyzer] Prevent AnalyzerStatsChecker from crash.
Feb 21 2018, 8:09 AM
szepet added a comment to D16403: Add scope information to CFG.
In D16403#1011218, @NoQ wrote:

Yeah, i mean, like, if we change the scope markers to also appear even when no variables are present in the scope, then it would be possible to replace loop markers with some of the scope markers, right?

Feb 21 2018, 7:28 AM · Restricted Project

Feb 16 2018

Herald added a reviewer for D41150: [CFG] Adding new CFGStmt LoopEntrance for the StaticAnalyzer: george.karpenkov.

ping

Feb 16 2018, 6:55 AM
Herald added a reviewer for D39398: [CFG][Analyzer] Add LoopExit element to the CFG in more cases: george.karpenkov.

ping

Feb 16 2018, 6:55 AM
szepet added a comment to D16403: Add scope information to CFG.
In D16403#992452, @NoQ wrote:

Thank you, this explanation looks very reasonable.

All right, so right after the termination of the loop we have

[B1]
1: ForStmt (LoopExit)
2: [B4.5].~A() (Implicit destructor)
3: [B5.3].~A() (Implicit destructor)
4: CFGScopeEnd(a)
5: CFGScopeEnd(b)

... where [B4.5] is A b = a; and [B5.3] is A a;. Am i understanding correctly that while destroying a you can still use the storage of b safely? Or should a go out of scope before b gets destroyed? Also, is the order of scope ends actually correct here - shouldn't b go out of scope earlier? Given that they are in very different lifetime scopes (a is one for the whole loop, b is per-loop-iteration). I guess the order would matter for the analyzer.

Feb 16 2018, 6:55 AM · Restricted Project

Jan 21 2018

szepet added a comment to D42266: [analyzer] Prevent AnalyzerStatsChecker from crash.

Would it make sense to use the last element of the block edge's source for the diagnostic location when the destination block is empty?

Jan 21 2018, 1:55 PM

Jan 18 2018

szepet added inline comments to D41151: [analyzer] Adding LoopContext and improve loop modeling.
Jan 18 2018, 4:48 PM
szepet updated the diff for D41151: [analyzer] Adding LoopContext and improve loop modeling.

First, sorry for this delayed update, however, I was working on this and running this on real projects. I wanted to make sure that this update will be complete enough that this patch would not cause any harm (yes, these features are hidden behind a flag but anyway) and not crashes on edge cases I haven't thought of. The core used the fact that LocationContext only contains StackFramce and BlockInvocation and I aimed to eliminate all these code snippets (more like rewrite).

Jan 18 2018, 4:37 PM
szepet added a dependency for D41150: [CFG] Adding new CFGStmt LoopEntrance for the StaticAnalyzer: D39398: [CFG][Analyzer] Add LoopExit element to the CFG in more cases.
Jan 18 2018, 3:53 PM
szepet added a dependent revision for D39398: [CFG][Analyzer] Add LoopExit element to the CFG in more cases: D41150: [CFG] Adding new CFGStmt LoopEntrance for the StaticAnalyzer.
Jan 18 2018, 3:53 PM
szepet updated the diff for D41150: [CFG] Adding new CFGStmt LoopEntrance for the StaticAnalyzer.

I essentially have one question at a glance - for loop counter variables, don't we want LoopEntrance be before the initialization?

Jan 18 2018, 3:51 PM
szepet updated the diff for D39398: [CFG][Analyzer] Add LoopExit element to the CFG in more cases.

Added comments and removed indirect goto support from this patch.

Jan 18 2018, 3:47 PM
szepet added inline comments to D39398: [CFG][Analyzer] Add LoopExit element to the CFG in more cases.
Jan 18 2018, 3:47 PM
szepet created D42266: [analyzer] Prevent AnalyzerStatsChecker from crash.
Jan 18 2018, 3:27 PM

Dec 21 2017

szepet updated the summary of D41151: [analyzer] Adding LoopContext and improve loop modeling.
Dec 21 2017, 9:03 AM
szepet updated the diff for D41150: [CFG] Adding new CFGStmt LoopEntrance for the StaticAnalyzer.

Comment added to LoopEntrance CFGElement.

Dec 21 2017, 8:42 AM
szepet accepted D41444: [ASTImporterTest] Make testing under '-fdelayed-template-parsing' mandatory.

Test both with and without '-fdelayed-template-parsing' in C++ mode.

Dec 21 2017, 6:44 AM

Dec 18 2017

szepet requested changes to D41077: [analyser] different.CallArgsOrder checker implementation.

Hi Alexey!

Dec 18 2017, 2:51 PM · Restricted Project

Dec 12 2017

szepet added a dependent revision for D41150: [CFG] Adding new CFGStmt LoopEntrance for the StaticAnalyzer: D41151: [analyzer] Adding LoopContext and improve loop modeling.
Dec 12 2017, 6:35 PM
szepet added a dependency for D41151: [analyzer] Adding LoopContext and improve loop modeling: D41150: [CFG] Adding new CFGStmt LoopEntrance for the StaticAnalyzer.
Dec 12 2017, 6:35 PM
szepet created D41151: [analyzer] Adding LoopContext and improve loop modeling.
Dec 12 2017, 6:32 PM
szepet created D41150: [CFG] Adding new CFGStmt LoopEntrance for the StaticAnalyzer.
Dec 12 2017, 6:24 PM

Dec 7 2017

szepet updated the diff for D38692: [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr.

Nope, that was me. If this (and the dependencies) are looking good, I can commit them as well (added the dependencies ^^).

Dec 7 2017, 8:38 AM
szepet added a dependent revision for D38692: [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr: D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr.
Dec 7 2017, 8:09 AM
szepet added a dependency for D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr: D38692: [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr.
Dec 7 2017, 8:09 AM
szepet added a comment to D40937: [clang-tidy] Infinite loop checker.

How does this check deal with atomic members?
...

Dec 7 2017, 8:02 AM · Restricted Project
szepet updated the diff for D40937: [clang-tidy] Infinite loop checker.

Updates based on comments.

Dec 7 2017, 8:00 AM · Restricted Project

Dec 6 2017

szepet added a comment to D40937: [clang-tidy] Infinite loop checker.

Hi Eugen!
Good question, probably should have detailed it in the description.
This matcher based solution would not gain much benefit from the symbolic execution provided information. (I mean, it would mean a much different type of check on the states.)
The main problems that the analyzer does not completely unroll the loops only the first steps and we always have information about the simulated path. However, detecting that some variables will surely not be modified requires a top level overview on the loop and the AST provides these informations. The one thing (that I can say right now) that can come handy is that we would able to detect more precisely the happened-before relation on the escape and the loop statements. Since the CFG can provide us fair enough information on this one, I do not think that this is enough reason to put this checker to the analyzer.

Dec 6 2017, 7:06 PM · Restricted Project
szepet updated the diff for D40937: [clang-tidy] Infinite loop checker.

Updated the wording in the docs.

Dec 6 2017, 6:50 PM · Restricted Project
szepet updated the summary of D40937: [clang-tidy] Infinite loop checker.
Dec 6 2017, 6:40 PM · Restricted Project
szepet created D40937: [clang-tidy] Infinite loop checker.
Dec 6 2017, 5:49 PM · Restricted Project

Dec 1 2017

szepet added reviewers for D38921: [analyzer] LoopUnrolling: update the matched assignment operators: alexfh, aaron.ballman.

Added Alexander and Aaron as reviewers for the matcher parts.

Dec 1 2017, 5:18 AM

Nov 29 2017

szepet updated the diff for D38692: [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr.

Yepp, I am not exactly sure how I managed to do it, but I've missed this comment last time. Fixed it.

Nov 29 2017, 7:23 PM
szepet added inline comments to D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr.
Nov 29 2017, 7:17 PM

Nov 24 2017

szepet updated the diff for D38843: [ASTImporter] Support importing CXXPseudoDestructorExpr.

Thank you for the review!

Nov 24 2017, 5:22 AM

Nov 23 2017

szepet updated the diff for D38694: [ASTImporter] Support importing CXXUnresolvedConstructExpr and UnresolvedLookupExpr.

Updating the usage of ImportTemplateArgumentListInfo.

Nov 23 2017, 4:35 PM
szepet updated the diff for D38692: [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr.

Updating the usage of ImportTemplateArgumentListInfo.

Nov 23 2017, 4:32 PM
szepet updated the diff for D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr.

Updated based on review comments.

Nov 23 2017, 4:17 PM
szepet added a comment to D38694: [ASTImporter] Support importing CXXUnresolvedConstructExpr and UnresolvedLookupExpr.

Hello Aleksei,

Nov 23 2017, 3:01 PM
szepet updated the diff for D38694: [ASTImporter] Support importing CXXUnresolvedConstructExpr and UnresolvedLookupExpr.

Updates based on review comments.

Nov 23 2017, 3:00 PM
szepet added inline comments to D38692: [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr.
Nov 23 2017, 7:46 AM
szepet updated the diff for D38692: [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr.

Left some unformatted lines in the previous version. Fixed.

Nov 23 2017, 7:44 AM
szepet added inline comments to D38692: [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr.
Nov 23 2017, 7:26 AM
szepet updated the diff for D38692: [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr.

Updates based on comments.

Nov 23 2017, 7:26 AM

Nov 16 2017

szepet updated the diff for D38921: [analyzer] LoopUnrolling: update the matched assignment operators.

Testfiles added and HTML updated.

Nov 16 2017, 8:14 AM
szepet updated the diff for D38921: [analyzer] LoopUnrolling: update the matched assignment operators.

isAssignmentOp matcher moved to ASTMatchers.h
(Manuel added to reviewers as the code owner of ASTMatchers)

Nov 16 2017, 6:55 AM

Oct 28 2017

szepet committed rL316852: [analyzer] MisusedMovedObjectChecker: More precise warning message.
[analyzer] MisusedMovedObjectChecker: More precise warning message
Oct 28 2017, 4:24 PM
szepet closed D38674: [analyzer] MisusedMovedObjectChecker: More precise warning message by committing rL316852: [analyzer] MisusedMovedObjectChecker: More precise warning message.
Oct 28 2017, 4:24 PM
szepet closed D38673: [analyzer] MisusedMovedObjectChecker: Fix false positive on state-resetting, handling method calls on base-class sub-objects.
Oct 28 2017, 4:19 PM
szepet added an edge to rL316850: [analyzer] MisusedMovedObjectChecker: Fix false positive on state-resetting…: D38673: [analyzer] MisusedMovedObjectChecker: Fix false positive on state-resetting, handling method calls on base-class sub-objects.
Oct 28 2017, 4:19 PM
szepet added 1 commit(s) for D38673: [analyzer] MisusedMovedObjectChecker: Fix false positive on state-resetting, handling method calls on base-class sub-objects: rL316850: [analyzer] MisusedMovedObjectChecker: Fix false positive on state-resetting….
Oct 28 2017, 4:19 PM
szepet committed rL316850: [analyzer] MisusedMovedObjectChecker: Fix false positive on state-resetting….
[analyzer] MisusedMovedObjectChecker: Fix false positive on state-resetting…
Oct 28 2017, 4:10 PM
szepet committed rL316830: [analyzer] LoopUnrolling: check the bitwidth of the used numbers (pr34943).
[analyzer] LoopUnrolling: check the bitwidth of the used numbers (pr34943)
Oct 28 2017, 5:20 AM
szepet closed D38922: [analyzer] LoopUnrolling: check the bitwidth of the used numbers (pr34943) by committing rL316830: [analyzer] LoopUnrolling: check the bitwidth of the used numbers (pr34943).
Oct 28 2017, 5:19 AM
szepet updated the diff for D38921: [analyzer] LoopUnrolling: update the matched assignment operators.
  • Updated to use a custom AST matcher for assignment operator check. (More structured and efficient.)
  • Tests added as well.
Oct 28 2017, 4:39 AM

Oct 27 2017

szepet updated the diff for D39398: [CFG][Analyzer] Add LoopExit element to the CFG in more cases.

Just removed some accidentally left changes from the patch.

Oct 27 2017, 6:33 PM
szepet created D39398: [CFG][Analyzer] Add LoopExit element to the CFG in more cases.
Oct 27 2017, 6:25 PM
szepet added a comment to D38842: [CrossTU] Fix handling of Cross Translation Unit directory path.

LGTM as well, but same note applies.

Oct 27 2017, 5:24 AM

Oct 19 2017

szepet updated the diff for D38843: [ASTImporter] Support importing CXXPseudoDestructorExpr.

Checking for importing base updated to (!Imported && From) style.

Oct 19 2017, 6:26 AM