szepet (Peter Szecsi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 16 2016, 2:39 AM (49 w, 1 d)

Recent Activity

Tue, May 16

szepet added inline comments to D32751: [ASTImporter] Support new kinds of declarations (mostly Using*).
Tue, May 16, 6:13 AM
szepet committed rL303158: [StaticAnalyzer] Move inline counter increaser to inlineCall function.
[StaticAnalyzer] Move inline counter increaser to inlineCall function
Tue, May 16, 5:07 AM
szepet closed D32179: [StaticAnalyzer] Move inline counter increaser to inlineCall function by committing rL303158: [StaticAnalyzer] Move inline counter increaser to inlineCall function.
Tue, May 16, 5:07 AM

Sun, May 7

szepet added a comment to D32939: Kaleidoscope - toy.cpp use after move fix.

Thanks for the fast review!

Sun, May 7, 4:22 AM
szepet committed rL302369: [Kaleidoscope] toy.cpp use after move fix.
[Kaleidoscope] toy.cpp use after move fix
Sun, May 7, 4:14 AM
szepet closed D32939: Kaleidoscope - toy.cpp use after move fix by committing rL302369: [Kaleidoscope] toy.cpp use after move fix.
Sun, May 7, 4:14 AM

Sat, May 6

szepet created D32947: [ASTImporter] FriendDecl importing improvements.
Sat, May 6, 1:51 PM
szepet created D32939: Kaleidoscope - toy.cpp use after move fix.
Sat, May 6, 7:08 AM

Apr 18 2017

szepet updated the summary of D32179: [StaticAnalyzer] Move inline counter increaser to inlineCall function.
Apr 18 2017, 10:46 AM
szepet created D32179: [StaticAnalyzer] Move inline counter increaser to inlineCall function.
Apr 18 2017, 10:44 AM

Apr 15 2017

szepet accepted D31538: [analyzer] MisusedMovedObjectChecker: Fix a false positive on state-resetting a base-class sub-object..
Apr 15 2017, 1:22 PM

Mar 31 2017

szepet accepted D31541: [analyzer] MisusedMovedObjectChecker: Add a printState() method..

LGTM, thank you (again)!

Mar 31 2017, 10:54 AM
szepet added inline comments to D31538: [analyzer] MisusedMovedObjectChecker: Fix a false positive on state-resetting a base-class sub-object..
Mar 31 2017, 10:36 AM
szepet added a comment to D31538: [analyzer] MisusedMovedObjectChecker: Fix a false positive on state-resetting a base-class sub-object..

Thank you for working on that, Artem!
The changes look good, just one comment about that suspicious remove.

Mar 31 2017, 10:32 AM

Mar 20 2017

szepet added inline comments to D30876: [ASTImporter] Unnamed structs import.
Mar 20 2017, 6:16 PM
szepet updated the diff for D30876: [ASTImporter] Unnamed structs import.

Nits resolved, dependency added in order to not to conflict the 2 patches.

Mar 20 2017, 6:05 PM
szepet updated the diff for D30877: [ASTImporter] Lookup SearchName instead of Name.

Test case added.

Mar 20 2017, 5:34 PM
szepet added a dependent revision for D30877: [ASTImporter] Lookup SearchName instead of Name: D30876: [ASTImporter] Unnamed structs import.
Mar 20 2017, 5:08 PM
szepet added a dependency for D30876: [ASTImporter] Unnamed structs import: D30877: [ASTImporter] Lookup SearchName instead of Name.
Mar 20 2017, 5:08 PM
szepet updated the diff for D24246: StaticAnalyzer - MisusedMovedObjectChecker.

Nit resolved.

Mar 20 2017, 4:27 PM

Mar 12 2017

szepet created D30877: [ASTImporter] Lookup SearchName instead of Name.
Mar 12 2017, 4:56 PM
szepet created D30876: [ASTImporter] Unnamed structs import.
Mar 12 2017, 4:38 PM

Mar 7 2017

szepet added a comment to D24246: StaticAnalyzer - MisusedMovedObjectChecker.

I guess the solution is to come up with more detailed heuristics to figure out which methods are safe and which aren't - either larger lists of methods, or regex-based analysis over method names. Would you be willing to come up with those in a follow-up patch? We may also have a look eventually, because we believe this checker is useful :)

Mar 7 2017, 7:10 PM
szepet updated the diff for D24246: StaticAnalyzer - MisusedMovedObjectChecker.

Done in this diff:

  • branch rebase
  • check comments in the test file separated to lines (only notes with the same messages are in the same line)
Mar 7 2017, 6:58 PM
szepet updated subscribers of D24246: StaticAnalyzer - MisusedMovedObjectChecker.
Mar 7 2017, 8:32 AM

Feb 13 2017

szepet updated the diff for D24246: StaticAnalyzer - MisusedMovedObjectChecker.

Small infotext added and test cases updated. (More loop test to make sure the checkEndFunction workaround works fine.)

Feb 13 2017, 7:23 AM
szepet updated the diff for D29612: [ASTImporter] ParmVarDecl default argument initialization.

Use one ToExpr and FromExpr in the patch.
Check for unsuccessful import added.

Feb 13 2017, 5:14 AM
szepet removed a reviewer for D29884: [analyzer] Proper caching in CallDescription objects.: szepet.
Feb 13 2017, 1:43 AM
szepet added a reviewer for D29884: [analyzer] Proper caching in CallDescription objects.: szepet.
Feb 13 2017, 1:40 AM

Feb 9 2017

szepet updated the diff for D29612: [ASTImporter] ParmVarDecl default argument initialization.

additional small test case added

Feb 9 2017, 6:38 PM
szepet updated subscribers of D29612: [ASTImporter] ParmVarDecl default argument initialization.
Feb 9 2017, 5:11 AM

Feb 8 2017

szepet updated the diff for D29612: [ASTImporter] ParmVarDecl default argument initialization.

Hello Aleksei,
thank you for the review and the advice!

Feb 8 2017, 8:34 AM

Feb 6 2017

szepet created D29612: [ASTImporter] ParmVarDecl default argument initialization.
Feb 6 2017, 5:10 PM
szepet added inline comments to D24246: StaticAnalyzer - MisusedMovedObjectChecker.
Feb 6 2017, 6:25 AM
szepet updated the diff for D24246: StaticAnalyzer - MisusedMovedObjectChecker.

CheckPointerEscape callback removed since checkRegionChanges handle all the necessary cases.
Member MoveStmt removed from RegionState.
+Some typo fixes in comments.

Feb 6 2017, 6:25 AM
szepet added inline comments to D24246: StaticAnalyzer - MisusedMovedObjectChecker.
Feb 6 2017, 3:22 AM

Dec 25 2016

szepet updated the diff for D22507: Clang-tidy - Enum misuse check.

The requested changes have been made.
Some more refactor on the Case2 since it is the same as the LHS/RHS case. Moved more common statements out of the branch (Case2-3) for better readabilty. (And less code duplication.)

Dec 25 2016, 4:19 PM · Unknown Object (Project)
szepet updated the diff for D24246: StaticAnalyzer - MisusedMovedObjectChecker.

Test cases updated.
Some invalidation moved to checkRegionChanges callback.
Missing feature added: do not report an SubRegion if any of its SuperRegion is already reported

Dec 25 2016, 5:58 AM

Dec 17 2016

szepet updated the diff for D22507: Clang-tidy - Enum misuse check.

Minor changes to improve the readability of the code according to comments.

Dec 17 2016, 11:56 AM · Unknown Object (Project)

Dec 13 2016

szepet added a comment to D22507: Clang-tidy - Enum misuse check.

What is your opinion about the new results? I hope the checker can make it into 4.0.

Dec 13 2016, 2:09 AM · Unknown Object (Project)
szepet added a comment to D24246: StaticAnalyzer - MisusedMovedObjectChecker.

I wasn't able to find time for this checker the last few weeks, but my schedule became much lighter and I plan to commit the required changes (and a bugfix) next week. Starting from next week I can work on the checker on a daily basis. Hopefully it can make it into 4.0.

Dec 13 2016, 2:09 AM

Oct 6 2016

szepet added inline comments to D24246: StaticAnalyzer - MisusedMovedObjectChecker.
Oct 6 2016, 8:10 AM

Oct 4 2016

szepet abandoned D23853: Assert in performTrivialCopy - Bug report and a possible solution.

At first I was not able to reproduce it. Then I realized it was my foul because I used the analyzer without the core checkers in this case. Sorry for the false positive.

Oct 4 2016, 8:13 AM
szepet updated the diff for D22507: Clang-tidy - Enum misuse check.

Note message checks added to testfiles.

Oct 4 2016, 3:15 AM · Unknown Object (Project)

Oct 2 2016

szepet added inline comments to D24246: StaticAnalyzer - MisusedMovedObjectChecker.
Oct 2 2016, 6:12 AM
szepet updated the diff for D24246: StaticAnalyzer - MisusedMovedObjectChecker.
  • Some refactor based on comments.
  • Updated testfiles.
Oct 2 2016, 6:03 AM

Sep 30 2016

szepet added inline comments to D22507: Clang-tidy - Enum misuse check.
Sep 30 2016, 3:56 PM · Unknown Object (Project)
szepet updated the diff for D22507: Clang-tidy - Enum misuse check.

Updates based on comments (the testfile note comments will be added in the next commit)

Sep 30 2016, 3:48 PM · Unknown Object (Project)

Sep 20 2016

szepet added inline comments to D24137: Misspelled checker description (argument comment).
Sep 20 2016, 7:14 AM · Unknown Object (Project)
szepet updated the diff for D24137: Misspelled checker description (argument comment).

rewritten description

Sep 20 2016, 7:14 AM · Unknown Object (Project)
szepet updated the diff for D22507: Clang-tidy - Enum misuse check.

In order to decrease false positive rate, the bitmask specific checker part investigate only the enumconstans which was initilized by a literal. (If this is too strong it can be modified)

Sep 20 2016, 6:50 AM · Unknown Object (Project)

Sep 6 2016

szepet updated the diff for D24246: StaticAnalyzer - MisusedMovedObjectChecker.

removed empty file which was added by mistake

Sep 6 2016, 5:12 AM
szepet retitled D24246: StaticAnalyzer - MisusedMovedObjectChecker from to StaticAnalyzer - MisusedMovedObjectChecker.
Sep 6 2016, 3:07 AM

Sep 5 2016

szepet updated the diff for D22507: Clang-tidy - Enum misuse check.

cast to dyn-cast change in order to fix a bug, changes based on comments

Sep 5 2016, 6:53 AM · Unknown Object (Project)

Sep 1 2016

szepet added inline comments to D22507: Clang-tidy - Enum misuse check.
Sep 1 2016, 8:48 AM · Unknown Object (Project)
szepet added a reviewer for D24137: Misspelled checker description (argument comment): alexfh.
Sep 1 2016, 8:39 AM · Unknown Object (Project)
szepet updated the diff for D22507: Clang-tidy - Enum misuse check.

Changes based on comments, fix a cast to dyn_cast bug, description updated (hopefully it became more clear).

Sep 1 2016, 8:38 AM · Unknown Object (Project)
szepet retitled D24137: Misspelled checker description (argument comment) from to Misspelled checker description (argument comment).
Sep 1 2016, 8:29 AM · Unknown Object (Project)

Aug 31 2016

szepet updated subscribers of D24040: codechecker tool core.
Aug 31 2016, 11:22 PM

Aug 24 2016

szepet updated D23853: Assert in performTrivialCopy - Bug report and a possible solution.
Aug 24 2016, 2:04 PM
szepet retitled D23853: Assert in performTrivialCopy - Bug report and a possible solution from to Assert in performTrivialCopy - Bug report and a possible solution.
Aug 24 2016, 2:01 PM

Aug 23 2016

szepet added inline comments to D22507: Clang-tidy - Enum misuse check.
Aug 23 2016, 5:04 AM · Unknown Object (Project)
szepet updated the diff for D22507: Clang-tidy - Enum misuse check.

Changes based on comments.

Aug 23 2016, 5:03 AM · Unknown Object (Project)

Jul 28 2016

szepet added a comment to D22507: Clang-tidy - Enum misuse check.
Jul 28 2016, 12:18 PM · Unknown Object (Project)
szepet updated the diff for D22507: Clang-tidy - Enum misuse check.

updates based on comments, counter and search functions replaced by std functions

Jul 28 2016, 12:17 PM · Unknown Object (Project)

Jul 26 2016

szepet updated subscribers of D15227: [analyzer] Valist checkers..
Jul 26 2016, 5:43 AM

Jul 25 2016

szepet updated the diff for D22507: Clang-tidy - Enum misuse check.

full diff submitted

Jul 25 2016, 1:16 AM · Unknown Object (Project)

Jul 21 2016

szepet added a comment to D22507: Clang-tidy - Enum misuse check.
Jul 21 2016, 8:09 AM · Unknown Object (Project)
szepet added a comment to D22507: Clang-tidy - Enum misuse check.
Jul 21 2016, 8:09 AM · Unknown Object (Project)
szepet updated the diff for D22507: Clang-tidy - Enum misuse check.

updating patch based on review comments

Jul 21 2016, 8:07 AM · Unknown Object (Project)

Jul 19 2016

szepet retitled D22507: Clang-tidy - Enum misuse check from to Clang-tidy - Enum misuse check.
Jul 19 2016, 4:25 AM · Unknown Object (Project)