Page MenuHomePhabricator

manas (Manas Gupta)
User

Projects

User does not belong to any projects.

User Details

User Since
May 17 2021, 1:21 PM (11 w, 1 d)

Recent Activity

Yesterday

manas added a comment to D105273: [analyzer] Introduce range-based reasoning for subtraction operator.
Tue, Aug 3, 7:54 AM · Restricted Project
manas added a comment to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

I have updated the proof for Add: https://gist.github.com/weirdsmiley/ad6a9dbf3370e96d29f9e90068931d25

Tue, Aug 3, 7:53 AM · Restricted Project
manas updated the diff for D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Fix unrelated commits mess up!

Tue, Aug 3, 7:49 AM · Restricted Project
manas added inline comments to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Tue, Aug 3, 7:42 AM · Restricted Project
manas updated the diff for D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Fix test comments

Tue, Aug 3, 7:39 AM · Restricted Project

Mon, Aug 2

manas added a reviewer for D107312: [analyzer] Fix deprecated plistlib functions: vsavchenko.
Mon, Aug 2, 2:35 PM · Restricted Project
manas requested review of D107312: [analyzer] Fix deprecated plistlib functions.
Mon, Aug 2, 2:34 PM · Restricted Project
manas added a comment to D106416: [analyzer] Fix build dependency issues for SATest.

Fixing another broken dependency packages error.

Mon, Aug 2, 2:16 PM · Restricted Project
manas updated the diff for D106416: [analyzer] Fix build dependency issues for SATest.

upgrade cmake-3.21.0 to cmake-3.21.1

Mon, Aug 2, 2:15 PM · Restricted Project

Tue, Jul 20

manas added reviewers for D106416: [analyzer] Fix build dependency issues for SATest: vsavchenko, NoQ, xazax.hun.
Tue, Jul 20, 7:32 PM · Restricted Project
manas requested review of D106416: [analyzer] Fix build dependency issues for SATest.
Tue, Jul 20, 7:31 PM · Restricted Project
manas added a comment to D105273: [analyzer] Introduce range-based reasoning for subtraction operator.

Here is the proof using Z3: https://gist.github.com/weirdsmiley/8a35a0e1f55f310e3566cbd47555491a

Tue, Jul 20, 3:19 PM · Restricted Project
manas added a comment to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Here is the proof of correctness of the algorithm using Z3: https://gist.github.com/weirdsmiley/ad6a9dbf3370e96d29f9e90068931d25

Tue, Jul 20, 3:18 PM · Restricted Project

Fri, Jul 16

manas added inline comments to D106102: [analyzer][solver] Introduce reasoning for not equal to operator.
Fri, Jul 16, 2:04 PM · Restricted Project

Thu, Jul 15

manas added reviewers for D106102: [analyzer][solver] Introduce reasoning for not equal to operator: vsavchenko, NoQ, xazax.hun.
Thu, Jul 15, 2:30 PM · Restricted Project
manas requested review of D106102: [analyzer][solver] Introduce reasoning for not equal to operator.
Thu, Jul 15, 2:29 PM · Restricted Project

Tue, Jul 6

manas updated the diff for D105447: [analyzer] Allow cmake options to be passed to satest container.

Pass commands through settings instead of rest

Tue, Jul 6, 2:32 PM · Restricted Project
manas added inline comments to D105447: [analyzer] Allow cmake options to be passed to satest container.
Tue, Jul 6, 4:17 AM · Restricted Project

Mon, Jul 5

manas updated the diff for D105447: [analyzer] Allow cmake options to be passed to satest container.

Edit summary

Mon, Jul 5, 4:11 PM · Restricted Project
manas added a comment to D105447: [analyzer] Allow cmake options to be passed to satest container.

Restore global cmake command

Mon, Jul 5, 4:10 PM · Restricted Project
manas updated the diff for D105447: [analyzer] Allow cmake options to be passed to satest container.

Restore global cmake command

Mon, Jul 5, 4:08 PM · Restricted Project
manas added reviewers for D105447: [analyzer] Allow cmake options to be passed to satest container: vsavchenko, NoQ, xazax.hun.
Mon, Jul 5, 3:38 PM · Restricted Project
manas requested review of D105447: [analyzer] Allow cmake options to be passed to satest container.
Mon, Jul 5, 3:37 PM · Restricted Project

Jul 2 2021

manas updated the diff for D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Rebase

Jul 2 2021, 1:02 PM · Restricted Project
manas updated the diff for D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Replace literal-value 0 with APSInt Zero

Jul 2 2021, 12:43 PM · Restricted Project
manas updated the diff for D105273: [analyzer] Introduce range-based reasoning for subtraction operator.

Remove redundant getAPSIntType calls

Jul 2 2021, 12:38 PM · Restricted Project
manas updated the diff for D105273: [analyzer] Introduce range-based reasoning for subtraction operator.

Replace literal-value 0 with APSInt Zero

Jul 2 2021, 12:22 PM · Restricted Project
manas added inline comments to D105273: [analyzer] Introduce range-based reasoning for subtraction operator.
Jul 2 2021, 11:49 AM · Restricted Project
manas updated the diff for D105273: [analyzer] Introduce range-based reasoning for subtraction operator.

Merge conditionals with similar block and add test for one overflow on Tmax-side

Jul 2 2021, 11:47 AM · Restricted Project
manas added a comment to D105273: [analyzer] Introduce range-based reasoning for subtraction operator.

Thanks Valeriy.

Jul 2 2021, 11:45 AM · Restricted Project

Jul 1 2021

manas added reviewers for D105273: [analyzer] Introduce range-based reasoning for subtraction operator: vsavchenko, NoQ, xazax.hun.
Jul 1 2021, 4:16 AM · Restricted Project
manas requested review of D105273: [analyzer] Introduce range-based reasoning for subtraction operator.
Jul 1 2021, 4:15 AM · Restricted Project
manas updated the diff for D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Reformat comments

Jul 1 2021, 3:57 AM · Restricted Project

Jun 25 2021

manas added inline comments to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Jun 25 2021, 12:00 AM · Restricted Project

Jun 24 2021

manas updated the diff for D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Add tests for overflows on both ends

Jun 24 2021, 11:58 PM · Restricted Project
manas updated the diff for D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Fix issues involving usage of uadd_ov and family of functions

Jun 24 2021, 7:54 PM · Restricted Project
manas added inline comments to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Jun 24 2021, 3:09 AM · Restricted Project
manas added inline comments to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Jun 24 2021, 2:26 AM · Restricted Project
manas added inline comments to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Jun 24 2021, 1:52 AM · Restricted Project
manas updated the diff for D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Rebase

Jun 24 2021, 1:41 AM · Restricted Project

Jun 23 2021

manas added inline comments to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Jun 23 2021, 10:34 PM · Restricted Project
manas updated the diff for D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Fix issues involving cases for unsigned type and add tests

Jun 23 2021, 10:25 PM · Restricted Project
manas added a comment to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

I am working on debugging those 3 cases.

Jun 23 2021, 1:53 AM · Restricted Project

Jun 22 2021

manas added a comment to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Regarding the tweakings in constant-folding.c, I have refrained from using cases which were resulting in UNKNOWN assertions as they were the primary reason for constraints being propagated.

Jun 22 2021, 5:05 PM · Restricted Project
manas updated the diff for D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Added updated logic for reasoning using number of overflows. Also, changed a couple of tests which were leading to unwanted constriants being propagated further.

Jun 22 2021, 4:57 PM · Restricted Project

Jun 21 2021

manas added inline comments to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Jun 21 2021, 11:17 PM · Restricted Project
manas added inline comments to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Jun 21 2021, 9:17 PM · Restricted Project
manas added inline comments to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Jun 21 2021, 6:51 PM · Restricted Project
manas added inline comments to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Jun 21 2021, 6:41 PM · Restricted Project
manas added inline comments to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Jun 21 2021, 1:57 AM · Restricted Project

Jun 18 2021

manas added a comment to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

The diff fixes all invalid assertion issues and also reasons about the cases where Min > Max.

Jun 18 2021, 11:33 PM · Restricted Project
manas updated the diff for D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Reason about cases where Min > Max

Jun 18 2021, 11:14 PM · Restricted Project

Jun 16 2021

manas added inline comments to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Jun 16 2021, 6:36 AM · Restricted Project
manas added inline comments to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Jun 16 2021, 6:16 AM · Restricted Project
manas added inline comments to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Jun 16 2021, 4:31 AM · Restricted Project

Jun 15 2021

manas added inline comments to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Jun 15 2021, 4:09 PM · Restricted Project
manas updated the diff for D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Add logic for computing rangeset for an expression containing BO_Add.

Jun 15 2021, 4:05 PM · Restricted Project

Jun 5 2021

manas added a comment to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

I was wondering, if we could try something new with the tests. To increase our confidence that the expected behavior is correct, how about including a Z3 proof with each of the test cases?

We are looking forward to design a unit-test framework for the solver which can compact the test cases and make them much more manageable (unlike constant-folding.c). Perhaps, we can incorporate the Z3 proves in that framework, corresponding to test cases.

Hmm, so you mean we can check if the analyzer was compiled with Z3 and if so, verify the same things by it?

Jun 5 2021, 7:02 AM · Restricted Project

Jun 4 2021

manas added a comment to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

I was wondering, if we could try something new with the tests. To increase our confidence that the expected behavior is correct, how about including a Z3 proof with each of the test cases?

Jun 4 2021, 3:23 PM · Restricted Project
manas updated the diff for D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Fix for cases involving residual paths and add case for overflowing range near extremum of a type

Jun 4 2021, 2:30 AM · Restricted Project
manas added inline comments to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Jun 4 2021, 2:30 AM · Restricted Project

Jun 3 2021

manas updated the diff for D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Added tests for residual paths and negation of certain values, and fixed expected warnings for UNKNOWN cases.

Jun 3 2021, 7:30 PM · Restricted Project
manas added a comment to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

I also would like to see tests where the ranges are not going all the way to either INT_MIN or INT_MAX (if we talk about int), but overflow still might happen, and cases where overflow might happen, but we still can identify the overflowing results precisely (e.g. the result is [INT_MIN, INT_MIN + 10] and [INT_MAX - 5, INT_MAX])

Jun 3 2021, 7:23 PM · Restricted Project

Jun 2 2021

manas updated the diff for D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

Fixed test cases expecting wrong assertions and added few more test cases.

Jun 2 2021, 4:08 AM · Restricted Project

Jun 1 2021

manas added inline comments to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Jun 1 2021, 11:12 PM · Restricted Project
manas added a comment to D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.

@NoQ I figured out the tests but while testing against Z3, I mixed up constraints. I am changing those.

Jun 1 2021, 10:28 PM · Restricted Project
manas added a reviewer for D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator: vsavchenko.
Jun 1 2021, 1:42 AM · Restricted Project
manas requested review of D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator.
Jun 1 2021, 1:38 AM · Restricted Project