This is an archive of the discontinued LLVM Phabricator instance.

Differential D155509

Revert "Remove rdar links; NFC"
ClosedPublic

Authored by mehdi_amini on Jul 17 2023, 12:49 PM.

Details

Reviewers
lattner
aaron.ballman
NoQ
tstellar
Commits
rGe0ac46e69d7a: Revert "Remove rdar links; NFC"
Summary

This reverts commit d618f1c3b12effd0c2bdb7d02108d3551f389d3d.
This commit wasn't reviewed ahead of time and significant concerns were
raised immediately after it landed. According to our developer policy
this warrants immediate revert of the commit.

https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy

Diff Detail

Event Timeline

mehdi_amini created this revision.Jul 17 2023, 12:49 PM
Herald added a reviewer: NoQ. · View Herald TranscriptJul 17 2023, 12:49 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: steakhal, jdoerfert, martong and 2 others. · View Herald Transcript
mehdi_amini requested review of this revision.Jul 17 2023, 12:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2023, 12:49 PM
Herald added subscribers: cfe-commits, MaskRay. · View Herald Transcript
tstellar accepted this revision.Jul 17 2023, 4:25 PM
tstellar added a subscriber: tstellar.

LGTM.

This revision is now accepted and ready to land.Jul 17 2023, 4:25 PM
lattner accepted this revision.Jul 17 2023, 5:37 PM

Thank you, this should have been reverted immediately when concerns were raised.

This revision was landed with ongoing or failed builds.Jul 17 2023, 6:11 PM
Closed by commit rGe0ac46e69d7a: Revert "Remove rdar links; NFC" (authored by mehdi_amini). · Explain Why
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rGe0ac46e69d7a: Revert "Remove rdar links; NFC".
Harbormaster completed remote builds in B245976: Diff 541193.Jul 17 2023, 6:39 PM
jroelofs added a subscriber: jroelofs.Jul 18 2023, 10:25 AM

Do you think this and the other patch are good candidates for .git-blame-ignore-revs entries?

aaron.ballman added a comment.Jul 18 2023, 10:55 AM
In D155509#4511568, @jroelofs wrote:

Do you think this and the other patch are good candidates for .git-blame-ignore-revs entries?

I think so, yes. (I didn't add the original commit to the ignore list because I thought folks might want to see the commit removing rdar links in their blame tracking, but I don't have a strong opinion on what to do should we reland the original changes.)

Revision Contents

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 15411932109587Jul 17 2023, 12:49 PM
★
★
Diff 2541291a5cee3erGe0ac46e69d7adbe327148550ffafe746cbc0ec78Jul 17 2023, 6:08 PM
★
★
This very large diff affects more than 1,000 files. Use the Changeset List to browse changes.