Details
Diff Detail
Event Timeline
llvm/test/Transforms/InstCombine/rem-mul-shl.ll | ||
---|---|---|
844 | Apply your comment, thanks |
This change has caused an llvm-test-suite failure to build on our SVE VLA (vector length agnostic) buildbot: https://lab.llvm.org/buildbot/#/builders/198/builds/3716
clang: ../llvm/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1946: SDValue llvm::SelectionDAG::getVScale(const SDLoc &, EVT, APInt, bool): Assertion `MulImm.getSignificantBits() <= VT.getSizeInBits() && "Immediate does not fit VT"' failed. PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script. Stack dump: 0. Program arguments: /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/stage1.install/bin/clang -DNDEBUG -mcpu=neoverse-512tvb -mllvm -scalable-vectorization=preferred -mllvm -treat-scalable-fixed-error-as-warning=false -O3 -w -DHAVE_CONFIG_H -I/home/tcwg-buildbot/worker/clang-aarch64-sve-vla/test/test-suite/MultiSource/Applications/ClamAV -I/home/tcwg-buildbot/worker/clang-aarch64-sve-vla/test/test-suite/MultiSource/Applications/ClamAV/zlib -DDONT_LOCK_DBDIRS -DC_LINUX -DFPU_WORDS_BIGENDIAN=0 -DWORDS_BIGENDIAN=0 -MD -MT MultiSource/Applications/ClamAV/CMakeFiles/clamscan.dir/libclamav_spin.c.o -MF CMakeFiles/clamscan.dir/libclamav_spin.c.o.d -o CMakeFiles/clamscan.dir/libclamav_spin.c.o -c /home/tcwg-buildbot/worker/clang-aarch64-sve-vla/test/test-suite/MultiSource/Applications/ClamAV/libclamav_spin.c 1. <eof> parser at end of file 2. Code generation 3. Running pass 'Function Pass Manager' on module '/home/tcwg-buildbot/worker/clang-aarch64-sve-vla/test/test-suite/MultiSource/Applications/ClamAV/libclamav_spin.c'. 4. Running pass 'AArch64 Instruction Selection' on function '@unspin'
I will dig out a reproducer for you.
There should be a fix (hopefully) in https://reviews.llvm.org/D155626.
(I wasn't sure it was caused by this, but the assert looks the same).
I don't think it should require SVE because it also shows up on our 1 stage bot: https://lab.llvm.org/buildbot/#/builders/197/builds/8213
I'll give it a go myself on a non-SVE machine.
There should be a fix (hopefully) in https://reviews.llvm.org/D155626.
It does fix it, thanks.
(and it does reproduce without an SVE machine, but that is academic now)
Don't use attribute group, inline the attribute.