[AMDGPU][DAGISel] Be more flexible about what calls are allowed

[rovka]

Summary

Remove DAGISel checks on calling conventions. GlobalISel doesn't have
these checks either and we prefer it that way (see D152794).

Add a simple test like the one introduced in D117479 for GlobalISel.

[arsenm]

llvm/test/CodeGen/AMDGPU/call-c-function.ll

14

Also test from amdgpu_gfx?

llvm/test/CodeGen/AMDGPU/unsupported-calls.ll

64–65

Move these into your new test, they shouldn't be in the unsupported test anymore with not run lines

[rovka]

llvm/test/CodeGen/AMDGPU/unsupported-calls.ll

64–65

They're still unsupported on R600, so I think it's reasonable to leave them here. I can remove the NOT line, I guess it's not useful anymore.

[rovka]

Add test from amdgpu_gfx, remove GCN-NOT line from unsupported-calls.ll.

llvm/lib/Target/AMDGPU/SIISelLowering.cpp

SDValue SITargetLowering::LowerCall(CallLoweringInfo &CLI,
   if (!CLI.CB)
     report_fatal_error("unsupported libcall legalization");
 
   if (IsTailCall && MF.getTarget().Options.GuaranteedTailCallOpt) {
     return lowerUnhandledCall(CLI, InVals,
                               "unsupported required tail call to function ");
   }
 
-  if (AMDGPU::isShader(CallConv)) {
-    // Note the issue is with the CC of the called function, not of the call
-    // itself.
-    return lowerUnhandledCall(CLI, InVals,
-                              "unsupported call to a shader function ");
-  }
-
-  if (AMDGPU::isShader(MF.getFunction().getCallingConv()) &&
-      CallConv != CallingConv::AMDGPU_Gfx) {
-    // Only allow calls with specific calling conventions.
-    return lowerUnhandledCall(CLI, InVals,
-                              "unsupported calling convention for call from "
-                              "graphics shader of function ");
-  }
-
   if (IsTailCall) {
     IsTailCall = isEligibleForTailCallOptimization(
       Callee, CallConv, IsVarArg, Outs, OutVals, Ins, DAG);
     if (!IsTailCall && CLI.CB && CLI.CB->isMustTailCall()) {
       report_fatal_error("failed to perform tail call elimination on a call "
                          "site marked musttail");
     }
 

llvm/test/CodeGen/AMDGPU/call-c-function.ll

+; NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+; RUN: llc -global-isel=0 -stop-after=finalize-isel -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx900 -verify-machineinstrs -o - %s | FileCheck -enable-var-scope %s
+
+; Test that we don't explode on calls from shaders to functions with the C calling convention.
+
+define amdgpu_ps void @amdgpu_ps_call_default_cc() {
+  ; CHECK-LABEL: name: amdgpu_ps_call_default_cc
+  ; CHECK: bb.0.main_body:
+  ; CHECK-NEXT:   S_ENDPGM 0
+main_body:
+  call void null()
+  ret void
+}
+
+define amdgpu_gfx void @amdgpu_gfx_call_default_cc() {
+  ; CHECK-LABEL: name: amdgpu_gfx_call_default_cc
+  ; CHECK: bb.0.main_body:
+  ; CHECK-NEXT:   SI_RETURN
+main_body:
+  call void null()
+  ret void
+}

llvm/test/CodeGen/AMDGPU/unsupported-calls.ll

 
 ; GCN: in function test_tail_call_bitcast_extern_variadic{{.*}}: unsupported required tail call to function extern_variadic
 ; R600: in function test_tail_call_bitcast_extern_variadic{{.*}}: unsupported call to function extern_variadic
 define i32 @test_tail_call_bitcast_extern_variadic(<4 x float> %arg0, <4 x float> %arg1, i32 %arg2) {
   %add = fadd <4 x float> %arg0, %arg1
   %call = tail call i32 @extern_variadic(<4 x float> %add)
   ret i32 %call
 }
 
-; GCN: :0:0: in function test_c_call_from_shader i32 (): unsupported calling convention for call from graphics shader of function defined_function
 ; R600: in function test_c_call{{.*}}: unsupported call to function defined_function
 define amdgpu_ps i32 @test_c_call_from_shader() {
   %call = call i32 @defined_function(i32 0)
   ret i32 %call
 }
 
 ; GCN-NOT: in function test_gfx_call{{.*}}unsupported
 ; R600: in function test_gfx_call{{.*}}: unsupported call to function defined_function
 define amdgpu_ps i32 @test_gfx_call_from_shader() {
   %call = call amdgpu_gfx i32 @defined_function(i32 0)
   ret i32 %call
 }