All counters (lgkmcnt, vmcnt, storecnt, etc.) are presumed in an unknown
state at function entry, so we needn't insert waits for them in the
prologue.
Details
Details
- Reviewers
arsenm - Group Reviewers
Restricted Project
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I don't quite understand the change, now that the counters are in unknown state, shouldn't we wait for their arrival so that we can access the registers for the arguments (which may be loaded from memory in the caller)? I think we definitely need these waits at the entry of cs_chain* function.
Comment Actions
now that the counters are in unknown state, shouldn't we wait for their arrival so that we can access the registers for the arguments (which may be loaded from memory in the caller)?
Agreed. The patch description does not make sense to me.