Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D158605

[AMDGPU] ISel for llvm.amdgcn.set.inactive.chain.arg
ClosedPublic
Actions

Authored by rovka on Aug 23 2023, 5:48 AM.

Details

Reviewers
arsenm
Group Reviewers
Restricted Project
Commits
rG3b905a0be508: [AMDGPU] ISel for llvm.amdgcn.set.inactive.chain.arg
Summary

Add patterns to select int_amdgcn_set_inactive_chain_arg to
V_SET_INACTIVE.

This could probably use some more testing, but at least for simple cases
V_SET_INACTIVE seems to mostly work out of the box.

Diff Detail

Event Timeline

rovka created this revision.Aug 23 2023, 5:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 5:48 AM
Herald added subscribers: foad, kerbowa, hiraditya and 6 others. · View Herald Transcript
rovka requested review of this revision.Aug 23 2023, 5:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 5:48 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
rovka added a parent revision: D158604: [AMDGPU] Add llvm.amdgcn.set.inactive.chain.arg intrinsic.Aug 23 2023, 5:48 AM
rovka added a reviewer: Restricted Project.
Harbormaster completed remote builds in B254320: Diff 552680.Aug 23 2023, 5:49 AM
arsenm accepted this revision.Aug 23 2023, 5:14 PM
arsenm added inline comments.
llvm/test/CodeGen/AMDGPU/llvm.amdgcn.set.inactive.chain.arg.ll
55–56

Is it worth adding some tests with SGPR inputs?

This revision is now accepted and ready to land.Aug 23 2023, 5:14 PM
rovka added a child revision: D158841: [AMDGPU] si-wqm: Skip only LiveMask COPY.Aug 25 2023, 6:10 AM
rovka updated this revision to Diff 554616.Aug 30 2023, 1:04 AM

Rebase

rovka added a child revision: D159176: [AMDGPU] Precommit test for D158841.Aug 30 2023, 1:11 AM
Harbormaster completed remote builds in B255722: Diff 554616.Aug 30 2023, 4:03 AM
This revision was landed with ongoing or failed builds.Wed, Nov 8, 12:55 AM
Closed by commit rG3b905a0be508: [AMDGPU] ISel for llvm.amdgcn.set.inactive.chain.arg (authored by rovka). · Explain Why
This revision was automatically updated to reflect the committed changes.
rovka added a commit: rG3b905a0be508: [AMDGPU] ISel for llvm.amdgcn.set.inactive.chain.arg.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
AMDGPU/
1 line
6 lines
test/
CodeGen/
AMDGPU/
514 lines

Diff 558053

View Options

llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp

Loading...
View Options

llvm/lib/Target/AMDGPU/SIInstructions.td

Loading...
View Options

llvm/test/CodeGen/AMDGPU/llvm.amdgcn.set.inactive.chain.arg.ll

Loading...