[mlir] Fix mlir-linalg-ods-yaml-gen

[aturetsk]

Summary

Fix a bug in getDpsInitsPositionRange definition to support operators with multiple outputs.

[aturetsk]

@nicolasvasilache, @mehdi_amini, @ThomasRaoux
Could anyone please take a look at this?

[aturetsk]

Ping

[nicolasvasilache]

I assume you found this bug because some example you were running locally failed for you.
Could we please add a test to this PR ?

[nicolasvasilache]

In D152388#4624028, @nicolasvasilache wrote:

I assume you found this bug because some example you were running locally failed for you.
Could we please add a test to this PR ?

My bad, I somehow didn't see the test update .. sorry for the noise.

LGTM!

[aturetsk]

Thanks for review!

mlir/test/mlir-linalg-ods-gen/test-linalg-ods-yaml-gen.yaml

 
 #       ODS:  (ins "TypeRange":$resultTensorTypes, "ValueRange":$inputs,
 #  ODS-NEXT:       "ValueRange":$outputs, "Attribute":$cast,
 #  ODS-NEXT:       CArg<"ArrayRef<NamedAttribute>", "{}">:$attributes),
 
 #       ODS:    buildStructuredOp($_builder, $_state, resultTensorTypes,
 #  ODS-NEXT:      attributes, Test1Op::getRegionBuilder())
 
+#       ODS:    std::pair<int64_t, int64_t> getDpsInitsPositionRange() {
+#  ODS-NEXT:      int64_t getNumOperands = this->getNumOperands();
+#  ODS-NEXT:      return {getNumOperands - getOutputs().size(), getNumOperands};
+#  ODS-NEXT:    }
 
 # IMPL-LABEL:  void Test1Op::regionBuilder(ImplicitLocOpBuilder &b,
 #  IMPL-NEXT:    Block &block, ArrayRef<NamedAttribute> attrs)
 #       IMPL:  TypeFn castVal = TypeFn::cast_signed;
 #  IMPL-NEXT:  auto castIter = llvm::find_if(attrs, [&](const NamedAttribute &attr) {
 #  IMPL-NEXT:                                return attr.getName() == "cast"; });
 #  IMPL-NEXT:  if (castIter != attrs.end()) {
 #  IMPL-NEXT:    if (auto attr = llvm::dyn_cast<TypeFnAttr>(castIter->getValue()))

mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp

let extraClassDeclaration = structuredOpsBaseDecls # [{{
       static std::function<void(ImplicitLocOpBuilder &,
                                 Block &, ArrayRef<NamedAttribute>)>
       getRegionBuilder() {{
         return regionBuilder;
       }
 
       std::pair<int64_t, int64_t> getDpsInitsPositionRange() {{
         int64_t getNumOperands = this->getNumOperands();
-        return {{getNumOperands - 1, getNumOperands};
+        return {{getNumOperands - getOutputs().size(), getNumOperands};
       }
 
       // Generic methods.
       static unsigned getNumRegionArgs();
       std::string getLibraryCallName();
       {7}
     }];
 }