This is an archive of the discontinued LLVM Phabricator instance.

[3/11][Clang][RISCV] Expand all variants for unit stride segment load
ClosedPublic

Authored by eopXD on Jun 3 2023, 10:51 AM.

Details

Summary

This is the 3rd patch of the patch-set. For the cover letter, please
checkout D152069.

Depends on D152070.

This patch expands all variants of unit stride segment load, including
the policy variants. This patch also fixes the trailing suffix in the
intrinsics' function name that representing the return type, adding
x{NF}.

Currently the tuple type co-exists with the non-tuple type intrinsics.
Since the co-existance is temporary, this patch only adds test cases of
all variants for vlseg2e32 to show the capability done.

Test cases of other data type and NF will be added in the patch-set
when the replacement happens.

Diff Detail

Unit TestsFailed

Event Timeline

eopXD created this revision.Jun 3 2023, 10:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2023, 10:51 AM
eopXD requested review of this revision.Jun 3 2023, 10:51 AM
eopXD retitled this revision from [3/N][Clang][RISCV] Expand all variants for unit stride segment load to [3/11][Clang][RISCV] Expand all variants for unit stride segment load.Jun 3 2023, 10:55 AM
eopXD edited the summary of this revision. (Show Details)
eopXD edited the summary of this revision. (Show Details)
eopXD edited the summary of this revision. (Show Details)
eopXD edited the summary of this revision. (Show Details)Jun 3 2023, 11:05 AM
eopXD edited the summary of this revision. (Show Details)Jun 3 2023, 11:07 AM
eopXD updated this revision to Diff 528137.Jun 3 2023, 11:13 AM

Bump CI.

craig.topper added inline comments.Jun 5 2023, 4:46 PM
clang/include/clang/Basic/riscv_vector.td
1533

if should use curly braces if the else uses curly braces.

clang/lib/Support/RISCVVIntrinsicUtils.cpp
854

Can we guarantee Tuple2-8 are contiguous? Then we can do return (NF - 2) + VectorTypeModifier::Tuple2

eopXD updated this revision to Diff 528724.Jun 6 2023, 12:22 AM
eopXD marked 2 inline comments as done.

Address comment from Craig.

This revision is now accepted and ready to land.Jun 8 2023, 11:30 AM
eopXD updated this revision to Diff 531201.Jun 13 2023, 11:48 PM

Rebase to latest main.

This revision was landed with ongoing or failed builds.Jun 13 2023, 11:48 PM
This revision was automatically updated to reflect the committed changes.