Page MenuHomePhabricator
Differential D151534

[RISCV] Add more tests in zdinx-boundary-check.ll
ClosedPublic
Actions

Authored by sunshaoce on Thu, May 25, 9:57 PM.

Details

Reviewers
craig.topper
jrtc27
asb
StephenFan
liaolucy
Commits
rG216e2820f96a: [RISCV] Add more tests in zdinx-boundary-check.ll

Diff Detail

Event Timeline

sunshaoce created this revision.Thu, May 25, 9:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, May 25, 9:57 PM
Herald added subscribers: jobnoorman, luke, VincentWu and 25 others. · View Herald Transcript
sunshaoce requested review of this revision.Thu, May 25, 9:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, May 25, 9:57 PM
Herald added subscribers: llvm-commits, pcwang-thead, eopXD, MaskRay. · View Herald Transcript
sunshaoce mentioned this in D149743: [RISCV][CodeGen] Support Zdinx on RV32 codegen.Thu, May 25, 9:58 PM
craig.topper requested changes to this revision.Thu, May 25, 10:03 PM

This isn't a test for constant pool. Constant pools are generated by when you reference floating point literal in an instruction like fadd %a, 1.0. They are named with symbols containing LCP in assembly.

This revision now requires changes to proceed.Thu, May 25, 10:03 PM
sunshaoce updated this revision to Diff 525947.Thu, May 25, 10:55 PM

Add tests for constant pool

jrtc27 added a comment.Thu, May 25, 11:01 PM

These aren't using floating-point constant pools on RV32. Also use nounwind to drop the CFI noise.

Harbormaster completed remote builds in B234772: Diff 525947.Fri, May 26, 12:32 AM
sunshaoce updated this revision to Diff 526122.Fri, May 26, 10:48 AM

Address comments

Harbormaster completed remote builds in B234906: Diff 526122.Fri, May 26, 12:20 PM
craig.topper accepted this revision.Mon, May 29, 8:11 PM

LGTM

This revision is now accepted and ready to land.Mon, May 29, 8:11 PM
Closed by commit rG216e2820f96a: [RISCV] Add more tests in zdinx-boundary-check.ll (authored by sunshaoce). · Explain WhyMon, May 29, 11:49 PM
This revision was automatically updated to reflect the committed changes.
sunshaoce added a commit: rG216e2820f96a: [RISCV] Add more tests in zdinx-boundary-check.ll.

Revision Contents
Changeset List

PathSize
llvm/
test/
CodeGen/
RISCV/
47 lines

Diff 526527

View Options

llvm/test/CodeGen/RISCV/zdinx-boundary-check.ll

Loading...