This patch applies the semantic checks for executable allocation directives to the new allocators construct. It also introduces a new check that ensures all items in the list appear in the corresponding Fortran allocate statement.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Looks OK. Please add tests for all error messages that are added or updated.
flang/lib/Semantics/check-omp-structure.cpp | ||
---|---|---|
290 | Please add a test for ALLOCATORS with this error message. | |
flang/lib/Semantics/resolve-directives.cpp | ||
1586 | Please add a test for this. | |
1766–1770 | Please add a test for ALLOCATORS with this error message. | |
2035 | Please add a test that exercises this path (Commonblocks?). | |
2055 | Is this currently only called for the allocate in allocators? |
Added more tests and adjusted Allocate OMP clause to modify isPredefinedAllocator.
flang/lib/Semantics/resolve-directives.cpp | ||
---|---|---|
2035 | Removed this because I can't think of a scenario where a common block name would appear in an allocation list. | |
2055 | For now, but I was planning on adding it to D150483 to cover the List items specified in an allocate directive that is associated with an allocate statement must be variables that are allocated by the allocate statement semantic requirement. |
LG.
flang/lib/Semantics/check-omp-structure.cpp | ||
---|---|---|
1120–1150 | The RequiresPositiveParameter requires a test. |
Please add a test for ALLOCATORS with this error message.