This is an archive of the discontinued LLVM Phabricator instance.

[X86] Fix checks for illegal physreg COPY instructions
ClosedPublic

Authored by foad on Apr 17 2023, 7:54 AM.

Details

Summary

D105263 changed this test to not expect a MachineVerifier error on this
instruction:

; FP16 reg is sub_reg of xmm
%0:_(s16) = COPY $xmm0

D107082 changed the behaviour back again so that this instruction did
cause an error, but the test was not updated to expect the error.

Diff Detail

Event Timeline

foad created this revision.Apr 17 2023, 7:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2023, 7:54 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
foad requested review of this revision.Apr 17 2023, 7:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2023, 7:54 AM
LuoYuanke accepted this revision.Apr 17 2023, 6:09 PM
This revision is now accepted and ready to land.Apr 17 2023, 6:09 PM
pengfei accepted this revision.Apr 18 2023, 12:32 AM

LGTM. Maybe update the description with more background.

The test case was indeed passed with D105263 but then failed since D107082 https://godbolt.org/z/x4nq5bcWo
D107082 changed the stack size of FR16(X) from 16 to 32 to workaround spill/reload problems. But seems it affects the COPY verification here.

foad edited the summary of this revision. (Show Details)Apr 18 2023, 2:22 AM
This revision was automatically updated to reflect the committed changes.