This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add SiFive extension support
ClosedPublic

Authored by 4vtomat on Apr 10 2023, 6:05 AM.

Details

Summary

Add SiFive extension support
Depends on D147934

Diff Detail

Event Timeline

4vtomat created this revision.Apr 10 2023, 6:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2023, 6:05 AM
4vtomat requested review of this revision.Apr 10 2023, 6:05 AM
asb added inline comments.Apr 11 2023, 4:51 AM
clang/include/clang/Support/RISCVVIntrinsicUtils.h
465

Nit: It would better match the surrounding capitalisation to call this RVV_REQ_Xsfvcp

Is there a different patch with the .td for these intrinsics?

Is there a different patch with the .td for these intrinsics?

Yes, it's in this patch: D148223

clang/include/clang/Support/RISCVVIntrinsicUtils.h
465

Got it! Thanks!

4vtomat updated this revision to Diff 513223.Apr 13 2023, 7:09 AM

Resolved Alex's comment.

This revision is now accepted and ready to land.Apr 13 2023, 10:02 AM
asb accepted this revision.Apr 17 2023, 9:43 PM

LGTM

This revision was automatically updated to reflect the committed changes.