This is an archive of the discontinued LLVM Phabricator instance.

[amdgpu][nfc] Remove dead code associated with LDS lowering
ClosedPublic

Authored by JonChesterfield on Apr 4 2023, 5:14 PM.

Details

Summary

Pass disabled since approximately D104962 for miscompiling openmp

The functions under ReplaceConstant miscompile phis as noted in D112717 and
have no users in tree other than the disabled pass. It seems likely it has no
users out of tree.

Deletes the test cases associated with the disabled pass as well.

Diff Detail

Event Timeline

JonChesterfield created this revision.Apr 4 2023, 5:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2023, 5:14 PM
JonChesterfield requested review of this revision.Apr 4 2023, 5:14 PM
Herald added a project: Restricted Project. · View Herald Transcript
JonChesterfield edited the summary of this revision. (Show Details)Apr 4 2023, 5:15 PM

Pass is disabled in ROCm as well. Change is expected to be uncontentious but posting so that people who reviewed the corresponding work know it's gone. Original author has moved on.

rampitec accepted this revision.Apr 5 2023, 11:18 AM

LGTM is you believe this pass is not needed anymore.

This revision is now accepted and ready to land.Apr 5 2023, 11:18 AM
llvm/test/CodeGen/AMDGPU/replace-lds-by-ptr-use-within-const-expr2.ll