This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] use macro to build common operations in LoopEmitter
ClosedPublic

Authored by Peiming on Apr 4 2023, 11:41 AM.

Diff Detail

Event Timeline

Peiming created this revision.Apr 4 2023, 11:41 AM
Herald added a project: Restricted Project. · View Herald Transcript
Peiming requested review of this revision.Apr 4 2023, 11:41 AM
aartbik accepted this revision.Apr 4 2023, 11:45 AM
aartbik added inline comments.
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp
39–41

I am not sure if we have a style recommendation for this, but I use it myself at lots of places since I like how short it gets.
I would just a comment here

// A few shorthand macros specific to this file.

or so

This revision is now accepted and ready to land.Apr 4 2023, 11:45 AM
Peiming updated this revision to Diff 510873.Apr 4 2023, 11:48 AM

address comments.

Peiming marked an inline comment as done.Apr 4 2023, 11:48 AM
Peiming updated this revision to Diff 510878.Apr 4 2023, 12:01 PM

more macros.

Peiming updated this revision to Diff 511131.Apr 5 2023, 9:38 AM

add macro for yield op