Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D147551

[clang-tidy] Fix init-list handling in readability-implicit-bool-conversion
ClosedPublic
Actions

Authored by PiotrZSL on Apr 4 2023, 11:38 AM.

Details

Reviewers
njames93
carlosgalvezp
ccotter
Commits
rGdfa8f5b13e58: [clang-tidy] Fix init-list handling in readability-implicit-bool-conversion
Summary

Adds support for explicit casts using initListExpr,
for example: int{boolValue} constructions.

Fixes: #47000

Diff Detail

Event Timeline

PiotrZSL created this revision.Apr 4 2023, 11:38 AM
Herald added a reviewer: njames93. · View Herald TranscriptApr 4 2023, 11:38 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: carlosgalvezp, xazax.hun. · View Herald Transcript
PiotrZSL requested review of this revision.Apr 4 2023, 11:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2023, 11:38 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Eugene.Zelenko added a reviewer: carlosgalvezp.Apr 4 2023, 11:52 AM
Harbormaster completed remote builds in B223626: Diff 510867.Apr 4 2023, 12:22 PM
ccotter accepted this revision.Apr 4 2023, 6:10 PM
ccotter added a subscriber: ccotter.

lgtm

This revision is now accepted and ready to land.Apr 4 2023, 6:10 PM
Closed by commit rGdfa8f5b13e58: [clang-tidy] Fix init-list handling in readability-implicit-bool-conversion (authored by PiotrZSL). · Explain WhyApr 5 2023, 3:42 AM
This revision was automatically updated to reflect the committed changes.
PiotrZSL added a commit: rGdfa8f5b13e58: [clang-tidy] Fix init-list handling in readability-implicit-bool-conversion.

Revision Contents
Changeset List

PathSize
clang-tools-extra/
clang-tidy/
readability/
7 lines
docs/
4 lines
test/
clang-tidy/
checkers/
readability/
7 lines

Diff 511037

View Options

clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp

Loading...
View Options

clang-tools-extra/docs/ReleaseNotes.rst

Loading...
View Options

clang-tools-extra/test/clang-tidy/checkers/readability/implicit-bool-conversion.cpp

Loading...