This is an archive of the discontinued LLVM Phabricator instance.

[sanitizers] Simplify Explainer about dyld and weak overrides on Darwin. (NFC)
ClosedPublic

Authored by rsundahl on Apr 4 2023, 6:24 AM.

Details

Summary

Presenting more than one way to satisfy the single-weak-ref requirement leads to
confusing messaging for the end user. Use the introduction of a single unused
weak variable as the preferred solution. This differential modifies D146745.

rdar://103453678

Diff Detail

Event Timeline

rsundahl created this revision.Apr 4 2023, 6:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2023, 6:24 AM
rsundahl requested review of this revision.Apr 4 2023, 6:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2023, 6:24 AM
thetruestblue accepted this revision.Apr 4 2023, 8:19 AM
This revision is now accepted and ready to land.Apr 4 2023, 8:19 AM
yln accepted this revision.Apr 4 2023, 11:30 AM
yln added a reviewer: dcoughlin.

LGTM, with nit!

llvm/docs/ReleaseNotes.rst
252–255
rsundahl updated this revision to Diff 510881.Apr 4 2023, 12:04 PM

Added some suggested comments

rsundahl marked an inline comment as done.Apr 4 2023, 12:05 PM