Page MenuHomePhabricator

yln (Julian Lettner)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 21 2014, 12:56 PM (312 w, 3 d)

Recent Activity

Mon, Jan 13

yln updated the diff for D72549: [TSan] Register threads created via pthread_create_from_mach_thread.

Fixed signature of pthread_setspecific_introspection_np and added
CHECK_EQ(res, 0); to ensure the call to it succeeds.

Mon, Jan 13, 10:07 AM · Restricted Project, Restricted Project
yln added inline comments to D72549: [TSan] Register threads created via pthread_create_from_mach_thread.
Mon, Jan 13, 9:57 AM · Restricted Project, Restricted Project

Fri, Jan 10

yln abandoned D72108: [TSan] Initialize injected mach threads.

Superseded by D72549.

Fri, Jan 10, 6:18 PM · Restricted Project, Restricted Project
yln added reviewers for D72549: [TSan] Register threads created via pthread_create_from_mach_thread: MadCoder, kubamracek, samsonov, dvyukov, delcypher, dcoughlin.
Fri, Jan 10, 6:10 PM · Restricted Project, Restricted Project
yln abandoned D72305: [TSan] The "thread_terminate" event is delivered on the terminating thread.

Superseded by D72549.

Fri, Jan 10, 6:09 PM · Restricted Project, Restricted Project
yln created D72549: [TSan] Register threads created via pthread_create_from_mach_thread.
Fri, Jan 10, 6:09 PM · Restricted Project, Restricted Project

Thu, Jan 9

yln committed rG84c5ccbfa266: [TSan] Fix TSan flag for Swift on Linux testing (authored by yln).
[TSan] Fix TSan flag for Swift on Linux testing
Thu, Jan 9, 5:48 PM
yln committed rGafa441599e8f: Fix `ignore_noninstrumented_modules` on Linux (authored by yln).
Fix `ignore_noninstrumented_modules` on Linux
Thu, Jan 9, 5:47 PM
yln added reviewers for D72305: [TSan] The "thread_terminate" event is delivered on the terminating thread: dcoughlin, MadCoder.
Thu, Jan 9, 3:39 PM · Restricted Project, Restricted Project

Tue, Jan 7

yln retitled D72305: [TSan] The "thread_terminate" event is delivered on the terminating thread from [TSan] The "thread_terminate" is delivered on the terminating thread to [TSan] The "thread_terminate" event is delivered on the terminating thread.
Tue, Jan 7, 11:11 AM · Restricted Project, Restricted Project
yln abandoned D72115: [TSan] Remove side effects from ThreadTid.

Thanks for pointing this out, Dmitry! I have found your explanation:
https://github.com/llvm-mirror/compiler-rt/commit/411b2c9d6787b64939fc15fdeec65e9d65ba1a51
https://reviews.llvm.org/D54521#1305021

Tue, Jan 7, 10:05 AM · Restricted Project, Restricted Project

Mon, Jan 6

yln created D72305: [TSan] The "thread_terminate" event is delivered on the terminating thread.
Mon, Jan 6, 3:12 PM · Restricted Project, Restricted Project

Thu, Jan 2

yln updated the summary of D72115: [TSan] Remove side effects from ThreadTid.
Thu, Jan 2, 3:54 PM · Restricted Project, Restricted Project
yln added a comment to D72115: [TSan] Remove side effects from ThreadTid.

If I add a second, dummy call to ThreadTid in one of the places where it is used (e.g., pthread_join interceptor) many tests start to fail.

Thu, Jan 2, 3:54 PM · Restricted Project, Restricted Project
yln added a comment to D72115: [TSan] Remove side effects from ThreadTid.

Is this an oversight or on purpose?
The functions are duplicated in lsan_thread.cpp, but the LSan version does not have the tctx->user_id = 0; part.

Thu, Jan 2, 3:54 PM · Restricted Project, Restricted Project
yln created D72115: [TSan] Remove side effects from ThreadTid.
Thu, Jan 2, 3:45 PM · Restricted Project, Restricted Project
yln created D72108: [TSan] Initialize injected mach threads.
Thu, Jan 2, 2:00 PM · Restricted Project, Restricted Project

Fri, Dec 20

yln committed rGd1783db9dbda: [iOS sim] Ensure simulator device is booted in iossim_prepare.py (authored by yln).
[iOS sim] Ensure simulator device is booted in iossim_prepare.py
Fri, Dec 20, 1:48 PM
yln closed D71449: [iOS sim] Ensure simulator device is booted in iossim_prepare.py.
Fri, Dec 20, 1:48 PM · Restricted Project, Restricted Project
yln updated the diff for D71449: [iOS sim] Ensure simulator device is booted in iossim_prepare.py.

Add radar number.

Fri, Dec 20, 11:21 AM · Restricted Project, Restricted Project
yln added a comment to D71449: [iOS sim] Ensure simulator device is booted in iossim_prepare.py.

ping

Fri, Dec 20, 9:20 AM · Restricted Project, Restricted Project

Dec 16 2019

yln accepted D71573: Change `asan/TestCases/Darwin/malloc_zone-protected.cpp` to call abort so that it **always crashes**..
Dec 16 2019, 3:57 PM · Restricted Project, Restricted Project
yln committed rGf9a706a36ae5: [TSan][Darwin] Avoid calling pthread_self() before libpthread is initialized (authored by yln).
[TSan][Darwin] Avoid calling pthread_self() before libpthread is initialized
Dec 16 2019, 1:12 PM
yln closed D71559: [TSan][Darwin] Avoid calling pthread_self() before libpthread is initialized.
Dec 16 2019, 1:12 PM · Restricted Project, Restricted Project
yln updated the diff for D71449: [iOS sim] Ensure simulator device is booted in iossim_prepare.py.

Add comment about teardown. Remove unused/organize imports.

Dec 16 2019, 11:12 AM · Restricted Project, Restricted Project
yln added reviewers for D71559: [TSan][Darwin] Avoid calling pthread_self() before libpthread is initialized: kubamracek, delcypher, dcoughlin.
Dec 16 2019, 11:03 AM · Restricted Project, Restricted Project
yln created D71559: [TSan][Darwin] Avoid calling pthread_self() before libpthread is initialized.
Dec 16 2019, 11:03 AM · Restricted Project, Restricted Project
yln committed rG00ffa744f978: [lit] max_failures does not need to be stored in LitConfig (authored by yln).
[lit] max_failures does not need to be stored in LitConfig
Dec 16 2019, 10:16 AM
yln added inline comments to D71449: [iOS sim] Ensure simulator device is booted in iossim_prepare.py.
Dec 16 2019, 9:48 AM · Restricted Project, Restricted Project

Dec 13 2019

yln committed rGcf252240e881: [lit] Small cleanups. NFCI (authored by yln).
[lit] Small cleanups. NFCI
Dec 13 2019, 5:07 PM

Dec 12 2019

yln added a reviewer for D71449: [iOS sim] Ensure simulator device is booted in iossim_prepare.py: delcypher.
Dec 12 2019, 6:06 PM · Restricted Project, Restricted Project
yln created D71449: [iOS sim] Ensure simulator device is booted in iossim_prepare.py.
Dec 12 2019, 5:48 PM · Restricted Project, Restricted Project
yln committed rGcdb456055712: [iOS sim] Simplify iossim_run.py script (authored by yln).
[iOS sim] Simplify iossim_run.py script
Dec 12 2019, 5:39 PM
yln committed rG3455f31515a4: [TSan] Disable flaky test to unblock Swift PR testing (authored by yln).
[TSan] Disable flaky test to unblock Swift PR testing
Dec 12 2019, 3:55 PM
yln committed rGd0a17a3253f6: Fix `ignore_noninstrumented_modules` on Linux (authored by yln).
Fix `ignore_noninstrumented_modules` on Linux
Dec 12 2019, 3:54 PM
yln committed rGf133d5a5de64: [TSan] Fix TSan flag for Swift on Linux testing (authored by yln).
[TSan] Fix TSan flag for Swift on Linux testing
Dec 12 2019, 3:54 PM
yln committed rGad7677d2b240: Make `mach_vm_allocate.c` test less flaky (authored by yln).
Make `mach_vm_allocate.c` test less flaky
Dec 12 2019, 3:54 PM
yln committed rGe631f0957b83: Fixup "[compiler-rt] Rename test file to ensure it gets executed" (authored by yln).
Fixup "[compiler-rt] Rename test file to ensure it gets executed"
Dec 12 2019, 3:01 PM
yln committed rG5836e747498c: Reland "Fix TSan check failure" (authored by yln).
Reland "Fix TSan check failure"
Dec 12 2019, 3:00 PM
yln committed rGd76a30ef8569: [compiler-rt] Rename test file to ensure it gets executed (authored by yln).
[compiler-rt] Rename test file to ensure it gets executed
Dec 12 2019, 2:29 PM
yln committed rG6a7bf397f257: [TSan] Suppress false positive in test (authored by yln).
[TSan] Suppress false positive in test
Dec 12 2019, 2:21 PM
yln committed rGe72e6304c116: More fixup for "[TSan] Turn on ignore_interceptors_accesses" (authored by yln).
More fixup for "[TSan] Turn on ignore_interceptors_accesses"
Dec 12 2019, 2:20 PM
yln committed rGb3555cef3533: Fixup for "[TSan] Turn on ignore_interceptors_accesses" (authored by yln).
Fixup for "[TSan] Turn on ignore_interceptors_accesses"
Dec 12 2019, 2:20 PM
yln committed rG67bb9b1bef01: [TSan] Follow-up for my previous commit (authored by yln).
[TSan] Follow-up for my previous commit
Dec 12 2019, 2:19 PM
yln committed rG852d7801cce2: [TSan] Turn on ignore_interceptors_accesses (authored by yln).
[TSan] Turn on ignore_interceptors_accesses
Dec 12 2019, 2:18 PM
GitHub <noreply@github.com> committed rGf1fc161ea587: Merge pull request #44 from apple/enable-ignore_interceptors_accesses2 (authored by yln).
Merge pull request #44 from apple/enable-ignore_interceptors_accesses2
Dec 12 2019, 2:05 PM
yln committed rG3b04589717ff: [TSan] Turn on ignore_interceptors_accesses (authored by yln).
[TSan] Turn on ignore_interceptors_accesses
Dec 12 2019, 2:04 PM
yln committed rGf2ba8cecb47e: [TSan] Fix link failure in test (authored by yln).
[TSan] Fix link failure in test
Dec 12 2019, 1:42 PM
GitHub <noreply@github.com> committed rG38ee3f6e7803: Merge pull request #38 from apple/ignore_noninstrumented_modules-quick-fix (authored by yln).
Merge pull request #38 from apple/ignore_noninstrumented_modules-quick-fix
Dec 12 2019, 1:42 PM
yln committed rG1c5f0b0ea694: Enable ignore_noninstrumented_modules=1 on Linux (authored by yln).
Enable ignore_noninstrumented_modules=1 on Linux
Dec 12 2019, 1:42 PM
yln committed rG61592420d3e2: Support `ignore_noninstrumented_modules` on Linux (authored by yln).
Support `ignore_noninstrumented_modules` on Linux
Dec 12 2019, 1:42 PM
yln committed rGab1fb45ae822: [Sanitizer] Fix TSan check failure (authored by yln).
[Sanitizer] Fix TSan check failure
Dec 12 2019, 12:23 PM

Dec 11 2019

yln committed rGf38b543b97de: [lit] Improve formatting of error messages. NFC (authored by yln).
[lit] Improve formatting of error messages. NFC
Dec 11 2019, 2:48 PM
yln committed rG6e3b60625bfc: [TSan] Pacify flaky test on Darwin (authored by yln).
[TSan] Pacify flaky test on Darwin
Dec 11 2019, 1:05 PM

Dec 2 2019

yln committed rG62ab949248d8: [lit] Be more explicit about the state of tests (authored by yln).
[lit] Be more explicit about the state of tests
Dec 2 2019, 10:17 AM
yln closed D70612: [lit] Be more explicit about the state of tests.
Dec 2 2019, 10:17 AM · Restricted Project

Nov 22 2019

yln added a comment to D70612: [lit] Be more explicit about the state of tests.

@yln It's still useful to know which tests are marked as UNSUPPORTED without actually running the tests. Does this change break that workflow?

Nov 22 2019, 4:23 PM · Restricted Project
yln added reviewers for D70612: [lit] Be more explicit about the state of tests: jdenny, probinson, rnk, atrick, nate_chandler.
Nov 22 2019, 11:29 AM · Restricted Project
yln created D70612: [lit] Be more explicit about the state of tests.
Nov 22 2019, 11:20 AM · Restricted Project
yln committed rG718d68e6ca87: [lit] Attempt to print test summary on CTRL+C (authored by yln).
[lit] Attempt to print test summary on CTRL+C
Nov 22 2019, 11:11 AM

Nov 21 2019

yln committed rG0163329dbd6c: [TSan] Make `mach_vm_allocate.c` test less flaky (authored by yln).
[TSan] Make `mach_vm_allocate.c` test less flaky
Nov 21 2019, 3:25 PM

Nov 19 2019

yln accepted D69549: [Symbolizers] On Darwin compute function offset when possible..
Nov 19 2019, 9:38 AM · Restricted Project, Restricted Project

Nov 18 2019

yln committed rG7e4d386b77f9: [cmake] Factor out DEFAULT_SANITIZER_MIN_OSX_VERSION (authored by yln).
[cmake] Factor out DEFAULT_SANITIZER_MIN_OSX_VERSION
Nov 18 2019, 9:47 AM
yln committed rG4d4066a52013: Bump sanitizer iOS deployment target to 9.0 (authored by yln).
Bump sanitizer iOS deployment target to 9.0
Nov 18 2019, 9:47 AM
yln committed rGb87fc09dceef: Bump sanitizer macOS deployment target to 10.10 (authored by yln).
Bump sanitizer macOS deployment target to 10.10
Nov 18 2019, 9:47 AM
yln committed rGb0567be2b48a: [ASan] Mark test as UNSUPPORTED for iOS simulator (authored by yln).
[ASan] Mark test as UNSUPPORTED for iOS simulator
Nov 18 2019, 8:09 AM

Nov 15 2019

yln added inline comments to D69549: [Symbolizers] On Darwin compute function offset when possible..
Nov 15 2019, 11:08 AM · Restricted Project, Restricted Project

Nov 14 2019

yln added inline comments to D69549: [Symbolizers] On Darwin compute function offset when possible..
Nov 14 2019, 12:34 PM · Restricted Project, Restricted Project
yln accepted D69546: [SanitizerCommon] Print the current value of options when printing out help..
Nov 14 2019, 11:39 AM · Restricted Project, Restricted Project
yln added a comment to D70239: Fix up lit's tests to run in a multi-config environment.

Thank you Joel and Paul!

Nov 14 2019, 11:11 AM · Restricted Project

Nov 12 2019

yln committed rG54a9b4c02ff5: [lit] Better/earlier errors for empty runs (authored by yln).
[lit] Better/earlier errors for empty runs
Nov 12 2019, 9:23 AM
yln closed D70105: [lit] Better/earlier errors for empty runs.
Nov 12 2019, 9:23 AM · Restricted Project
yln updated the diff for D70105: [lit] Better/earlier errors for empty runs.

Address feedback.x

Nov 12 2019, 9:04 AM · Restricted Project
yln added inline comments to D70105: [lit] Better/earlier errors for empty runs.
Nov 12 2019, 8:09 AM · Restricted Project

Nov 11 2019

yln added reviewers for D70105: [lit] Better/earlier errors for empty runs: jdenny, probinson, rnk, atrick, nate_chandler.
Nov 11 2019, 5:04 PM · Restricted Project
yln created D70105: [lit] Better/earlier errors for empty runs.
Nov 11 2019, 4:55 PM · Restricted Project
yln added inline comments to D69546: [SanitizerCommon] Print the current value of options when printing out help..
Nov 11 2019, 11:08 AM · Restricted Project, Restricted Project

Nov 8 2019

yln added inline comments to D69549: [Symbolizers] On Darwin compute function offset when possible..
Nov 8 2019, 9:58 AM · Restricted Project, Restricted Project

Nov 6 2019

yln added a comment to D69546: [SanitizerCommon] Print the current value of options when printing out help..
In D69546#1731024, @yln wrote:

I thought that might be ambiguous (Is ... part of the string or is the string truncated?).

Do you anticipate this to be an issue? My feeling is that truncation would only happen with file paths?! I have a slight preference towards the other because it seems simpler (simple, not easy), but I am not blocking on this.

Nov 6 2019, 9:13 AM · Restricted Project, Restricted Project

Nov 5 2019

yln committed rGd77ef856fc24: Revert "[lit] Better/earlier errors when no tests are executed" (authored by yln).
Revert "[lit] Better/earlier errors when no tests are executed"
Nov 5 2019, 12:20 PM
yln added a reverting change for rGd8f2bff75126: [lit] Better/earlier errors when no tests are executed: rGd77ef856fc24: Revert "[lit] Better/earlier errors when no tests are executed".
Nov 5 2019, 12:20 PM

Nov 4 2019

yln committed rGbd14bb42f03a: [lit] Move measurement of testing time out of Run.execute (authored by yln).
[lit] Move measurement of testing time out of Run.execute
Nov 4 2019, 10:20 AM
yln committed rGd8f2bff75126: [lit] Better/earlier errors when no tests are executed (authored by yln).
[lit] Better/earlier errors when no tests are executed
Nov 4 2019, 10:19 AM

Nov 1 2019

yln added a comment to D69546: [SanitizerCommon] Print the current value of options when printing out help..

I thought that might be ambiguous (Is ... part of the string or is the string truncated?).

Do you anticipate this to be an issue? My feeling is that this would only happen with file paths. I have a slight preference towards the other because it seems simpler (simple, not easy), but I am not blocking on this.

Nov 1 2019, 5:20 PM · Restricted Project, Restricted Project

Oct 31 2019

yln committed rG20bb48c7a7da: [lit] Extract Display.print_header function (authored by yln).
[lit] Extract Display.print_header function
Oct 31 2019, 11:47 AM
yln committed rGbbebdbbd2053: [lit] Always print newline before test time/summary (authored by yln).
[lit] Always print newline before test time/summary
Oct 31 2019, 11:47 AM
yln committed rG62c0746896f9: [lit] Rename ProgressDisplay -> Display (authored by yln).
[lit] Rename ProgressDisplay -> Display
Oct 31 2019, 10:30 AM
yln accepted D69659: [compiler-rt] Use xcrun instead of xcodebuild to find the SDK directory.

Thanks Alexander! I did not run this on my machine, but since D69610 worked I think this should too.

Oct 31 2019, 10:10 AM · Restricted Project, Restricted Project
yln accepted D69610: Fix compiler-rt build on macOS without XCode.

Applied it locally, ninja check-asap still seems to work after rm -rf projects/compiler-rt. Thanks Alexander!

Oct 31 2019, 10:01 AM · Restricted Project, Restricted Project

Oct 30 2019

yln committed rG577dca62e918: [lit] Change progress bar color to red on first failure (authored by yln).
[lit] Change progress bar color to red on first failure
Oct 30 2019, 3:18 PM
yln committed rG4dba95f0ddd7: [lit] Extract `_install_win32_signal_handler` function (authored by yln).
[lit] Extract `_install_win32_signal_handler` function
Oct 30 2019, 3:17 PM
yln committed rG89e34d3e5a46: [lit] Add helper for `test.result.code.isFailure` (authored by yln).
[lit] Add helper for `test.result.code.isFailure`
Oct 30 2019, 3:17 PM
yln added a comment to D69549: [Symbolizers] On Darwin compute function offset when possible..

I have a few small comments. Looks good overall!

Oct 30 2019, 1:06 PM · Restricted Project, Restricted Project
yln added a comment to D69610: Fix compiler-rt build on macOS without XCode.

@delcypher: would xcrun --sdk ${sdk_name} --show-sdk-version work in all cases? If yes, we could use it instead of xcodebuild.

Oct 30 2019, 11:40 AM · Restricted Project, Restricted Project

Oct 29 2019

yln committed rG3b982b11f4e7: [lit] Refactor ordering of tests (authored by yln).
[lit] Refactor ordering of tests
Oct 29 2019, 5:50 PM
yln committed rG2b0b84108320: [lit] Small improvements in cl_arguments.py (authored by yln).
[lit] Small improvements in cl_arguments.py
Oct 29 2019, 5:46 PM
yln added a comment to D69546: [SanitizerCommon] Print the current value of options when printing out help..

Thanks for this patch, I am pretty sure I will find this useful! :)

Oct 29 2019, 11:23 AM · Restricted Project, Restricted Project

Oct 28 2019

yln committed rG7cd301677461: [lit] Remove callback indirection (authored by yln).
[lit] Remove callback indirection
Oct 28 2019, 6:58 PM
yln committed rG91095fe0726e: [lit] Refactor merging of user parameters (authored by yln).
[lit] Refactor merging of user parameters
Oct 28 2019, 3:28 PM
yln committed rGe6102dc5ef88: [lit] Remove redundant comments from main function (authored by yln).
[lit] Remove redundant comments from main function
Oct 28 2019, 11:11 AM