Page MenuHomePhabricator

yln (Julian Lettner)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 21 2014, 12:56 PM (286 w, 5 d)

Recent Activity

Thu, Jul 18

yln added inline comments to D64773: [ASan] Support `{f}puts(NULL)` on Darwin.
Thu, Jul 18, 1:16 PM · Restricted Project, Restricted Project
yln committed rGbe7a7ae0c3da: [ASan] Support `{f}puts(NULL)` on Darwin, part 2 (authored by yln).
[ASan] Support `{f}puts(NULL)` on Darwin, part 2
Thu, Jul 18, 1:16 PM
yln committed rL366488: [ASan] Support `{f}puts(NULL)` on Darwin, part 2.
[ASan] Support `{f}puts(NULL)` on Darwin, part 2
Thu, Jul 18, 1:15 PM

Wed, Jul 17

yln committed rG9a050f92bb29: [ASan] Support `{f}puts(NULL)` on Darwin (authored by yln).
[ASan] Support `{f}puts(NULL)` on Darwin
Wed, Jul 17, 9:15 AM
yln committed rL366342: [ASan] Support `{f}puts(NULL)` on Darwin.
[ASan] Support `{f}puts(NULL)` on Darwin
Wed, Jul 17, 9:10 AM
yln closed D64773: [ASan] Support `{f}puts(NULL)` on Darwin.
Wed, Jul 17, 9:09 AM · Restricted Project, Restricted Project

Tue, Jul 16

yln committed rGd069a1921065: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.6 (authored by yln).
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.6
Tue, Jul 16, 1:44 PM
yln committed rL366258: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.6.
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.6
Tue, Jul 16, 1:40 PM
yln committed rGe6e33cf9f568: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.10 (authored by yln).
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.10
Tue, Jul 16, 9:23 AM
yln committed rL366225: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.10.
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.10
Tue, Jul 16, 9:22 AM

Mon, Jul 15

yln committed rGc48162db994a: [TSan] Fix asm token error (again) (authored by yln).
[TSan] Fix asm token error (again)
Mon, Jul 15, 4:06 PM
yln committed rL366150: [TSan] Fix asm token error (again).
[TSan] Fix asm token error (again)
Mon, Jul 15, 4:06 PM
yln added a reviewer for D64773: [ASan] Support `{f}puts(NULL)` on Darwin: delcypher.
Mon, Jul 15, 3:41 PM · Restricted Project, Restricted Project
yln added reviewers for D64773: [ASan] Support `{f}puts(NULL)` on Darwin: kubamracek, eugenis, Lekensteyn.
Mon, Jul 15, 2:53 PM · Restricted Project, Restricted Project
yln created D64773: [ASan] Support `{f}puts(NULL)` on Darwin.
Mon, Jul 15, 2:50 PM · Restricted Project, Restricted Project
yln committed rG228f80d92dc2: [TSan] Fix asm token error (authored by yln).
[TSan] Fix asm token error
Mon, Jul 15, 2:26 PM
yln committed rL366131: [TSan] Fix asm token error.
[TSan] Fix asm token error
Mon, Jul 15, 2:25 PM
yln abandoned D64459: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.9.

Landed these cleanup changes in smaller chunks on my own.

Mon, Jul 15, 1:53 PM · Restricted Project, Restricted Project
yln committed rG39d888c1e42a: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.9 (authored by yln).
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.9
Mon, Jul 15, 1:23 PM
yln committed rL366126: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.9.
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.9
Mon, Jul 15, 1:22 PM

Fri, Jul 12

yln committed rG4f519b6919d2: [TSan] Tiny cleanup of UnmangleLongJmpSp for Linux/x86_64 (authored by yln).
[TSan] Tiny cleanup of UnmangleLongJmpSp for Linux/x86_64
Fri, Jul 12, 5:56 PM
yln committed rL365982: [TSan] Tiny cleanup of UnmangleLongJmpSp for Linux/x86_64.
[TSan] Tiny cleanup of UnmangleLongJmpSp for Linux/x86_64
Fri, Jul 12, 5:55 PM

Thu, Jul 11

yln committed rG9d41429ff790: [TSan] Move DECLARE_REAL macro outside of namespace (authored by yln).
[TSan] Move DECLARE_REAL macro outside of namespace
Thu, Jul 11, 11:30 AM
yln committed rL365806: [TSan] Move DECLARE_REAL macro outside of namespace.
[TSan] Move DECLARE_REAL macro outside of namespace
Thu, Jul 11, 11:29 AM

Wed, Jul 10

yln committed rG6a155f52bc2a: [TSan] Fix linker error on Linux/AArch64 (authored by yln).
[TSan] Fix linker error on Linux/AArch64
Wed, Jul 10, 3:51 PM
yln committed rL365707: [TSan] Fix linker error on Linux/AArch64.
[TSan] Fix linker error on Linux/AArch64
Wed, Jul 10, 3:50 PM
yln committed rG098e0a79fa7c: [TSan] Fix compiler error on Linux/AArch64 (authored by yln).
[TSan] Fix compiler error on Linux/AArch64
Wed, Jul 10, 12:47 PM
yln committed rL365693: [TSan] Fix compiler error on Linux/AArch64.
[TSan] Fix compiler error on Linux/AArch64
Wed, Jul 10, 12:46 PM
yln committed rG1a2c8809248d: [TSan] Attempt to fix linker error on Linux/AArch64 (authored by yln).
[TSan] Attempt to fix linker error on Linux/AArch64
Wed, Jul 10, 11:38 AM
yln committed rL365681: [TSan] Attempt to fix linker error on Linux/AArch64.
[TSan] Attempt to fix linker error on Linux/AArch64
Wed, Jul 10, 11:37 AM

Tue, Jul 9

yln added a reviewer for D64459: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.9: dvyukov.
Tue, Jul 9, 5:31 PM · Restricted Project, Restricted Project
yln created D64459: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.9.
Tue, Jul 9, 5:31 PM · Restricted Project, Restricted Project
yln committed rGba9eb4831842: Reland "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt. (authored by yln).
Reland "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.
Tue, Jul 9, 2:28 PM
yln committed rL365560: Reland "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt..
Reland "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.
Tue, Jul 9, 2:27 PM
yln committed rGc11c43b64f31: [TSan] Refine longjmp key management on Darwin (authored by yln).
[TSan] Refine longjmp key management on Darwin
Tue, Jul 9, 1:49 PM
yln committed rL365554: [TSan] Refine longjmp key management on Darwin.
[TSan] Refine longjmp key management on Darwin
Tue, Jul 9, 1:48 PM
yln committed rG95176d72c7e8: Revert "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt. (authored by yln).
Revert "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.
Tue, Jul 9, 11:43 AM
yln added a reverting change for rG521f77e6351f: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.8: rG95176d72c7e8: Revert "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt..
Tue, Jul 9, 11:43 AM
yln committed rL365534: Revert "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt..
Revert "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.
Tue, Jul 9, 11:41 AM
yln committed rG521f77e6351f: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.8 (authored by yln).
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.8
Tue, Jul 9, 9:52 AM
yln committed rL365513: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.8.
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.8
Tue, Jul 9, 9:51 AM
yln closed D64092: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.8.
Tue, Jul 9, 9:51 AM · Restricted Project, Restricted Project
yln added a comment to rL364700: [TSan] Attempt to fix linker error for Linux on AArch64.

Yes, it is. I am going to land the linked revision now, which will hopefully fix it.

Tue, Jul 9, 9:48 AM

Mon, Jul 8

yln committed rGc6fe02b60b77: [TSan] Fix linker error for Linux/AArch64 (authored by yln).
[TSan] Fix linker error for Linux/AArch64
Mon, Jul 8, 5:49 PM
yln committed rL365415: [TSan] Fix linker error for Linux/AArch64.
[TSan] Fix linker error for Linux/AArch64
Mon, Jul 8, 5:49 PM
yln committed rG611c122045c8: Revert "[TSan] Attempt to fix iOS on-device test" (authored by yln).
Revert "[TSan] Attempt to fix iOS on-device test"
Mon, Jul 8, 12:27 PM
yln added a reverting change for rGa2ca358291a3: [TSan] Attempt to fix iOS on-device test: rG611c122045c8: Revert "[TSan] Attempt to fix iOS on-device test".
Mon, Jul 8, 12:27 PM
yln committed rL365375: Revert "[TSan] Attempt to fix iOS on-device test".
Revert "[TSan] Attempt to fix iOS on-device test"
Mon, Jul 8, 12:26 PM
yln added a comment to rL364700: [TSan] Attempt to fix linker error for Linux on AArch64.

We are still seeing liner errors in the AArch64 build bots (http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/7487/steps/ninja%20check%202/logs/stdio), are you looking into this? If there's not a quick, obvious fix, it would be better to revert the original commit to get the bots back to green.

Mon, Jul 8, 11:49 AM
yln committed rGfa0d1d8e456e: Revert "[TSan] Attempt to fix linker error for Linux on AArch64" (authored by yln).
Revert "[TSan] Attempt to fix linker error for Linux on AArch64"
Mon, Jul 8, 11:38 AM
yln added a reverting change for rGbe4148062b15: [TSan] Attempt to fix linker error for Linux on AArch64: rGfa0d1d8e456e: Revert "[TSan] Attempt to fix linker error for Linux on AArch64".
Mon, Jul 8, 11:38 AM
yln committed rL365367: Revert "[TSan] Attempt to fix linker error for Linux on AArch64".
Revert "[TSan] Attempt to fix linker error for Linux on AArch64"
Mon, Jul 8, 11:37 AM

Fri, Jul 5

yln committed rGa2ca358291a3: [TSan] Attempt to fix iOS on-device test (authored by yln).
[TSan] Attempt to fix iOS on-device test
Fri, Jul 5, 5:52 PM
yln committed rL365257: [TSan] Attempt to fix iOS on-device test.
[TSan] Attempt to fix iOS on-device test
Fri, Jul 5, 5:52 PM
yln added a comment to D58110: Support fiber API on macOS.

Had to XFAIL a few tests for iOS (macOS works), see attached log.

Fri, Jul 5, 4:32 PM · Restricted Project, Restricted Project
yln committed rGb1ff896e92a8: XFAIL a few failing TSan-fiber tests for iOS (authored by yln).
XFAIL a few failing TSan-fiber tests for iOS
Fri, Jul 5, 4:27 PM
yln committed rL365254: XFAIL a few failing TSan-fiber tests for iOS.
XFAIL a few failing TSan-fiber tests for iOS
Fri, Jul 5, 4:23 PM
yln committed rGb6654319f7a0: Remove `XFAIL: ios` from test that passes in CI (authored by yln).
Remove `XFAIL: ios` from test that passes in CI
Fri, Jul 5, 3:56 PM
yln committed rL365253: Remove `XFAIL: ios` from test that passes in CI.
Remove `XFAIL: ios` from test that passes in CI
Fri, Jul 5, 3:55 PM
yln abandoned D64023: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.6.

Still need to save/restore x1 (even if we don't clobber it ourselves).
Same as: https://reviews.llvm.org/D63946

Fri, Jul 5, 2:37 PM · Restricted Project, Restricted Project
yln added a comment to D63946: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.4.

I reverted this, because we are doing a call (%rsi is not a preserved register), so of course we have to save/restore it (even if we don't clobber it ourselves).

Fri, Jul 5, 2:11 PM · Restricted Project, Restricted Project
yln committed rG2f533bdd2afe: Revert "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt. (authored by yln).
Revert "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.
Fri, Jul 5, 2:06 PM
yln added a reverting change for rG6bb13da7c16f: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.4: rG2f533bdd2afe: Revert "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt..
Fri, Jul 5, 2:06 PM
yln committed rL365244: Revert "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt..
Revert "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.
Fri, Jul 5, 2:06 PM
yln committed rG515fdfd5125f: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.5 (authored by yln).
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.5
Fri, Jul 5, 11:03 AM
yln committed rG6bb13da7c16f: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.4 (authored by yln).
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.4
Fri, Jul 5, 11:03 AM
yln committed rL365230: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.5.
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.5
Fri, Jul 5, 11:02 AM
yln closed D64022: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.5.
Fri, Jul 5, 11:02 AM · Restricted Project, Restricted Project
yln committed rL365229: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.4.
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.4
Fri, Jul 5, 11:02 AM
yln closed D63946: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.4.
Fri, Jul 5, 11:02 AM · Restricted Project, Restricted Project

Tue, Jul 2

yln added a comment to D64023: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.6.

Rubber stamp LGTM, if you want a real review please ask somebody else. But if you are sure it's good and covered by tests, submit.

Tue, Jul 2, 5:59 PM · Restricted Project, Restricted Project
yln created D64092: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.8.
Tue, Jul 2, 11:58 AM · Restricted Project, Restricted Project
yln committed rG36face4c1df7: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.7 (authored by yln).
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.7
Tue, Jul 2, 10:33 AM
yln committed rL364947: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.7.
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.7
Tue, Jul 2, 10:33 AM
yln closed D64050: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.7.
Tue, Jul 2, 10:33 AM · Restricted Project, Restricted Project
yln added a comment to D64050: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.7.

Is there anything else to review at the moment? Want to make sure I did not lost track of things.

Tue, Jul 2, 10:19 AM · Restricted Project, Restricted Project

Mon, Jul 1

yln created D64050: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.7.
Mon, Jul 1, 5:39 PM · Restricted Project, Restricted Project
yln abandoned D64021: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.4.

Duplicated review.

Mon, Jul 1, 5:36 PM · Restricted Project, Restricted Project
yln committed rGd66c606a3461: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.3 (authored by yln).
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.3
Mon, Jul 1, 4:25 PM
yln committed rL364874: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.3.
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.3
Mon, Jul 1, 4:25 PM
yln closed D63944: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.3.
Mon, Jul 1, 4:25 PM · Restricted Project, Restricted Project
yln committed rGb7fb723ea386: [TSan] Fix initialized and declared ‘extern’ warning (authored by yln).
[TSan] Fix initialized and declared ‘extern’ warning
Mon, Jul 1, 11:07 AM
yln committed rL364823: [TSan] Fix initialized and declared ‘extern’ warning.
[TSan] Fix initialized and declared ‘extern’ warning
Mon, Jul 1, 11:06 AM
yln created D64023: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.6.
Mon, Jul 1, 10:48 AM · Restricted Project, Restricted Project
yln created D64022: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.5.
Mon, Jul 1, 10:44 AM · Restricted Project, Restricted Project
yln created D64021: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.4.
Mon, Jul 1, 10:43 AM · Restricted Project, Restricted Project
yln committed rGe93458668093: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.2 (authored by yln).
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.2
Mon, Jul 1, 10:41 AM
yln committed rL364818: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.2.
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.2
Mon, Jul 1, 10:40 AM
yln closed D63942: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.2.
Mon, Jul 1, 10:40 AM · Restricted Project, Restricted Project

Fri, Jun 28

yln committed rGbe4148062b15: [TSan] Attempt to fix linker error for Linux on AArch64 (authored by yln).
[TSan] Attempt to fix linker error for Linux on AArch64
Fri, Jun 28, 5:46 PM
yln committed rL364700: [TSan] Attempt to fix linker error for Linux on AArch64.
[TSan] Attempt to fix linker error for Linux on AArch64
Fri, Jun 28, 5:46 PM
yln committed rG1c6337ca5ab7: [TSan] Fix build build breakage on Android (authored by yln).
[TSan] Fix build build breakage on Android
Fri, Jun 28, 12:50 PM
yln committed rL364676: [TSan] Fix build build breakage on Android.
[TSan] Fix build build breakage on Android
Fri, Jun 28, 12:50 PM
yln created D63946: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.4.
Fri, Jun 28, 11:30 AM · Restricted Project, Restricted Project
yln added a reviewer for D63944: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.3: dvyukov.
Fri, Jun 28, 11:04 AM · Restricted Project, Restricted Project
yln created D63944: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.3.
Fri, Jun 28, 11:01 AM · Restricted Project, Restricted Project
yln added a reviewer for D63942: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.2: dvyukov.
Fri, Jun 28, 10:29 AM · Restricted Project, Restricted Project
yln committed rG5be69ebe121d: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.1 (authored by yln).
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.1
Fri, Jun 28, 10:29 AM
yln created D63942: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.2.
Fri, Jun 28, 10:29 AM · Restricted Project, Restricted Project
yln committed rL364662: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.1.
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.1
Fri, Jun 28, 10:27 AM