Page MenuHomePhabricator

yln (Julian Lettner)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 21 2014, 12:56 PM (260 w, 1 d)

Recent Activity

Yesterday

yln added reviewers for D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls: eugenis, cryptoad.
Wed, Jan 16, 5:14 PM · Restricted Project

Tue, Jan 15

yln committed rCRT351288: [TSan] Use switches when dealing with enums.
[TSan] Use switches when dealing with enums
Tue, Jan 15, 5:49 PM
yln committed rL351288: [TSan] Use switches when dealing with enums.
[TSan] Use switches when dealing with enums
Tue, Jan 15, 5:49 PM
yln closed D56295: [TSan] Use switches when dealing with enums.
Tue, Jan 15, 5:49 PM · Restricted Project

Fri, Jan 11

yln created D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls.
Fri, Jan 11, 5:02 PM · Restricted Project

Thu, Jan 10

yln committed rL350883: [TSan] Remove ignore_interceptors_accesses flag.
[TSan] Remove ignore_interceptors_accesses flag
Thu, Jan 10, 12:08 PM
yln committed rCRT350883: [TSan] Remove ignore_interceptors_accesses flag.
[TSan] Remove ignore_interceptors_accesses flag
Thu, Jan 10, 12:08 PM
yln closed D55075: [TSan] Remove ignore_interceptors_accesses flag.
Thu, Jan 10, 12:08 PM · Restricted Project
yln updated the diff for D55075: [TSan] Remove ignore_interceptors_accesses flag.

No change in functionality

Thu, Jan 10, 12:01 PM · Restricted Project
yln updated the summary of D55075: [TSan] Remove ignore_interceptors_accesses flag.
Thu, Jan 10, 11:58 AM · Restricted Project

Mon, Jan 7

yln committed rCRT350556: [TSan] Support Objective-C @synchronized with tagged pointers.
[TSan] Support Objective-C @synchronized with tagged pointers
Mon, Jan 7, 11:23 AM
yln committed rL350556: [TSan] Support Objective-C @synchronized with tagged pointers.
[TSan] Support Objective-C @synchronized with tagged pointers
Mon, Jan 7, 11:23 AM
yln closed D56238: [TSan] Support Objective-C @synchronized with tagged pointers.
Mon, Jan 7, 11:23 AM · Restricted Project
yln added inline comments to D56238: [TSan] Support Objective-C @synchronized with tagged pointers.
Mon, Jan 7, 11:15 AM · Restricted Project
yln added inline comments to D56238: [TSan] Support Objective-C @synchronized with tagged pointers.
Mon, Jan 7, 11:06 AM · Restricted Project
yln updated the diff for D56238: [TSan] Support Objective-C @synchronized with tagged pointers.

Use user_alloc surrounded by ThreadIgnoreBegin/End.

Mon, Jan 7, 10:47 AM · Restricted Project

Fri, Jan 4

yln added inline comments to D56238: [TSan] Support Objective-C @synchronized with tagged pointers.
Fri, Jan 4, 11:44 AM · Restricted Project
yln added inline comments to D56295: [TSan] Use switches when dealing with enums.
Fri, Jan 4, 9:36 AM · Restricted Project
yln updated the diff for D56295: [TSan] Use switches when dealing with enums.

Add UNREACHABLE("missing case");

Fri, Jan 4, 9:32 AM · Restricted Project

Thu, Jan 3

yln added inline comments to D56295: [TSan] Use switches when dealing with enums.
Thu, Jan 3, 3:12 PM · Restricted Project
yln created D56295: [TSan] Use switches when dealing with enums.
Thu, Jan 3, 3:12 PM · Restricted Project
yln updated the diff for D56238: [TSan] Support Objective-C @synchronized with tagged pointers.

Improve/extend comments.

Thu, Jan 3, 11:35 AM · Restricted Project

Wed, Jan 2

yln created D56238: [TSan] Support Objective-C @synchronized with tagged pointers.
Wed, Jan 2, 5:17 PM · Restricted Project
yln committed rL350258: [TSan] Enable detection of lock-order-inversions for Objective-C @synchronized.
[TSan] Enable detection of lock-order-inversions for Objective-C @synchronized
Wed, Jan 2, 12:14 PM
yln committed rCRT350258: [TSan] Enable detection of lock-order-inversions for Objective-C @synchronized.
[TSan] Enable detection of lock-order-inversions for Objective-C @synchronized
Wed, Jan 2, 12:14 PM
yln closed D55959: [TSan] Enable detection of lock-order-inversions for Objective-C @synchronized.
Wed, Jan 2, 12:14 PM · Restricted Project
yln updated the diff for D55959: [TSan] Enable detection of lock-order-inversions for Objective-C @synchronized.

Trying to arc diff on git monorepo and arc patch && arc commit on svn working copy is painful, because path is longer on monorepo.

Wed, Jan 2, 12:12 PM · Restricted Project
yln updated the diff for D55959: [TSan] Enable detection of lock-order-inversions for Objective-C @synchronized.

Create diff via arcanist

Wed, Jan 2, 11:37 AM · Restricted Project

Fri, Dec 21

yln updated the diff for D55959: [TSan] Enable detection of lock-order-inversions for Objective-C @synchronized.

Fix bug in test.

Fri, Dec 21, 4:05 PM · Restricted Project
yln added inline comments to D55075: [TSan] Remove ignore_interceptors_accesses flag.
Fri, Dec 21, 3:43 PM · Restricted Project
yln added a comment to D55959: [TSan] Enable detection of lock-order-inversions for Objective-C @synchronized.

I would like to land this and fix @synchronized with tagged pointers in a follow-up since more discussion is required what we actually want it to do.

Fri, Dec 21, 2:50 PM · Restricted Project
yln updated the diff for D55959: [TSan] Enable detection of lock-order-inversions for Objective-C @synchronized.

Addressed most comments and added failing test for @synchronize with tagged pointers.

Fri, Dec 21, 2:43 PM · Restricted Project
yln added inline comments to D55959: [TSan] Enable detection of lock-order-inversions for Objective-C @synchronized.
Fri, Dec 21, 11:25 AM · Restricted Project

Thu, Dec 20

yln updated the diff for D55959: [TSan] Enable detection of lock-order-inversions for Objective-C @synchronized.

Added test for recursive @synchronized blocks, that is, nested @synchronized on the same object. This tests proves lock recursiveness.

Thu, Dec 20, 4:01 PM · Restricted Project
yln added a reviewer for D55075: [TSan] Remove ignore_interceptors_accesses flag: delcypher.
Thu, Dec 20, 3:14 PM · Restricted Project
yln created D55959: [TSan] Enable detection of lock-order-inversions for Objective-C @synchronized.
Thu, Dec 20, 3:11 PM · Restricted Project

Tue, Dec 18

yln retitled D55846: [TSan] Align default value of `detect_deadlocks` flag with actual behavior from [TSan] Align default value of `detect_deadlock` flag with actual beh to [TSan] Align default value of `detect_deadlocks` flag with actual behavior.
Tue, Dec 18, 12:11 PM · Restricted Project
yln created D55846: [TSan] Align default value of `detect_deadlocks` flag with actual behavior.
Tue, Dec 18, 12:01 PM · Restricted Project

Nov 29 2018

yln updated the diff for D55075: [TSan] Remove ignore_interceptors_accesses flag.

Use std::atomic to make test cleaner

Nov 29 2018, 3:29 PM · Restricted Project
yln created D55075: [TSan] Remove ignore_interceptors_accesses flag.
Nov 29 2018, 1:19 PM · Restricted Project

Nov 28 2018

yln closed D54908: Fix objc_sync_exit TSAN interceptor.

Closing manually, since somehow I managed to mess up the commit message (it's empty).
Fixed by https://reviews.llvm.org/rCRT347788.

Nov 28 2018, 10:53 AM · Restricted Project
yln committed rL347788.
Nov 28 2018, 10:20 AM
yln committed rCRT347788.
Nov 28 2018, 10:20 AM

Nov 26 2018

yln created D54908: Fix objc_sync_exit TSAN interceptor.
Nov 26 2018, 11:09 AM · Restricted Project

Aug 15 2017

yln abandoned D3395: Randomize instruction scheduling to increase security against ROP attacks (clang).
Aug 15 2017, 4:10 PM
yln abandoned D3391: Random Number Generator (clang).
Aug 15 2017, 4:08 PM
yln abandoned D3394: Randomize instruction scheduling to increase security against ROP attacks (llvm).
Aug 15 2017, 4:08 PM
yln abandoned D1802: Adding diversity for security (llvm).
Aug 15 2017, 4:07 PM
yln abandoned D1803: Adding diversity for security (clang).
Aug 15 2017, 4:07 PM

Jun 25 2014

yln added a comment to D3390: Random Number Generator (llvm).

Thanks jfb.
Just to be sure: Do you think the "packing" is worth the added complexity?

Jun 25 2014, 2:07 PM

Jun 18 2014

yln added a comment to D3390: Random Number Generator (llvm).

I thought we prefer the xxx_t data types whenever possible (because they
have a well-defined size).
... but I just realized that long long is also guaranteed to be at least 64
bits.
http://stackoverflow.com/questions/589575/size-of-int-long-etc

Jun 18 2014, 12:45 PM
yln added a comment to D3390: Random Number Generator (llvm).

@jfb
Thanks again for advocating this patch and sorry for all the trouble that I
am causing.

Jun 18 2014, 6:20 AM

Jun 17 2014

yln updated the diff for D3390: Random Number Generator (llvm).

Path for added files was incorrect (developing on another machine now).

Jun 17 2014, 2:09 PM
yln updated the diff for D3390: Random Number Generator (llvm).

Update to trunk.

Jun 17 2014, 10:48 AM

May 15 2014

yln added inline comments to D3392: Insert random noops to increase security against ROP attacks (llvm).
May 15 2014, 11:15 AM
yln added a comment to D3390: Random Number Generator (llvm).

So will this go into trunk as it is?
If yes, I will start working on the comments for the NOP patch.

May 15 2014, 10:55 AM

May 6 2014

yln added inline comments to D3390: Random Number Generator (llvm).
May 6 2014, 10:29 PM
yln updated the diff for D3390: Random Number Generator (llvm).

Lazily instantiate RNG in Module::getRNG().

May 6 2014, 10:25 PM
yln added inline comments to D3390: Random Number Generator (llvm).
May 6 2014, 9:40 PM
yln added inline comments to D3390: Random Number Generator (llvm).
May 6 2014, 2:11 PM
yln added inline comments to D3390: Random Number Generator (llvm).
May 6 2014, 1:34 PM
yln added inline comments to D3390: Random Number Generator (llvm).
May 6 2014, 1:27 PM
yln updated the diff for D3390: Random Number Generator (llvm).

Update comments.

May 6 2014, 1:26 PM
yln added inline comments to D3390: Random Number Generator (llvm).
May 6 2014, 1:01 PM
yln updated the diff for D3390: Random Number Generator (llvm).

Add pointer to bug tracker.

May 6 2014, 12:47 PM
yln updated the diff for D3390: Random Number Generator (llvm).

Move RNG to Module.

May 6 2014, 12:04 PM

Apr 30 2014

yln added inline comments to D3390: Random Number Generator (llvm).
Apr 30 2014, 10:22 PM

Apr 24 2014

yln added inline comments to D3390: Random Number Generator (llvm).

Since we incorporated most of jfb's comments and also touched core LLVM classes in the process this might be a good time to ping other people and try to get them involved in reviewing!?

Apr 24 2014, 8:35 PM
yln added inline comments to D3390: Random Number Generator (llvm).
Apr 24 2014, 1:55 AM
yln updated the diff for D3390: Random Number Generator (llvm).
Apr 24 2014, 1:46 AM
yln added inline comments to D3390: Random Number Generator (llvm).
Apr 24 2014, 1:28 AM
yln updated the diff for D3390: Random Number Generator (llvm).

Refactor RNG to be non-static and make it available via LLVMContext.

Apr 24 2014, 1:24 AM
yln updated the diff for D3391: Random Number Generator (clang).

Refactor RNG to be non-static and make it available via LLVMContext.

Apr 24 2014, 1:20 AM