Page MenuHomePhabricator

yln (Julian Lettner)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 21 2014, 12:56 PM (295 w, 5 d)

Recent Activity

Mon, Sep 9

yln committed rG6d04ee0f8638: [TSan] Add AnnotateIgnoreReadsBegin declaration to tsan/test.h (authored by yln).
[TSan] Add AnnotateIgnoreReadsBegin declaration to tsan/test.h
Mon, Sep 9, 1:09 PM
yln committed rL371446: [TSan] Add AnnotateIgnoreReadsBegin declaration to tsan/test.h.
[TSan] Add AnnotateIgnoreReadsBegin declaration to tsan/test.h
Mon, Sep 9, 1:05 PM
yln committed rGfc910c507e44: [TSan] Add interceptors for mach_vm_[de]allocate (authored by yln).
[TSan] Add interceptors for mach_vm_[de]allocate
Mon, Sep 9, 11:58 AM
yln committed rL371439: [TSan] Add interceptors for mach_vm_[de]allocate.
[TSan] Add interceptors for mach_vm_[de]allocate
Mon, Sep 9, 11:58 AM
yln closed D66616: [TSan] Add interceptors for mach_vm_[de]allocate.
Mon, Sep 9, 11:57 AM · Restricted Project, Restricted Project
yln updated the diff for D66616: [TSan] Add interceptors for mach_vm_[de]allocate.

Drop {} on one-liners for consistency.

Mon, Sep 9, 10:54 AM · Restricted Project, Restricted Project

Fri, Sep 6

yln added a comment to D66616: [TSan] Add interceptors for mach_vm_[de]allocate.

*ping*
Any comments before I ask Kuba to waive this through?

Fri, Sep 6, 2:39 PM · Restricted Project, Restricted Project

Wed, Sep 4

yln committed rL370984: Request commit access for yln.
Request commit access for yln
Wed, Sep 4, 2:21 PM
yln added a comment to D66616: [TSan] Add interceptors for mach_vm_[de]allocate.

@dvyukov, do you want to weigh in here?

Wed, Sep 4, 9:20 AM · Restricted Project, Restricted Project

Thu, Aug 29

yln committed rGaf78899457a7: [ASan] Version mismatch check follow-up (authored by yln).
[ASan] Version mismatch check follow-up
Thu, Aug 29, 1:22 PM
yln committed rL370403: [ASan] Version mismatch check follow-up.
[ASan] Version mismatch check follow-up
Thu, Aug 29, 1:22 PM

Wed, Aug 28

yln committed rG3ae9b9d5e40d: [ASan] Make insertion of version mismatch guard configurable (authored by yln).
[ASan] Make insertion of version mismatch guard configurable
Wed, Aug 28, 1:46 PM
yln committed rL370258: [ASan] Make insertion of version mismatch guard configurable.
[ASan] Make insertion of version mismatch guard configurable
Wed, Aug 28, 1:40 PM
yln closed D66826: [ASan] Make insertion of version mismatch guard configurable.
Wed, Aug 28, 1:39 PM · Restricted Project
yln added a comment to D66826: [ASan] Make insertion of version mismatch guard configurable.

Filipe Cabecinhas <filcab+llvm.phabricator@gmail.com>
when might we not want this?

Wed, Aug 28, 1:27 PM · Restricted Project

Tue, Aug 27

yln committed rGd3136661bac0: [sanitizer_common] Close superfluous file descriptors in spawned process (authored by yln).
[sanitizer_common] Close superfluous file descriptors in spawned process
Tue, Aug 27, 3:13 PM
yln committed rL370121: [sanitizer_common] Close superfluous file descriptors in spawned process.
[sanitizer_common] Close superfluous file descriptors in spawned process
Tue, Aug 27, 3:12 PM
yln added reviewers for D66826: [ASan] Make insertion of version mismatch guard configurable: kubamracek, dcoughlin, delcypher, eugenis.
Tue, Aug 27, 12:55 PM · Restricted Project
yln created D66826: [ASan] Make insertion of version mismatch guard configurable.
Tue, Aug 27, 12:55 PM · Restricted Project

Mon, Aug 26

yln updated the diff for D66616: [TSan] Add interceptors for mach_vm_[de]allocate.

Extract UnmapShadow and MemoryRangeImitateWriteOrResetRange
helper functions to reduce code duplication.

Mon, Aug 26, 11:27 AM · Restricted Project, Restricted Project

Aug 23 2019

yln added inline comments to D66616: [TSan] Add interceptors for mach_vm_[de]allocate.
Aug 23 2019, 6:46 PM · Restricted Project, Restricted Project

Aug 22 2019

yln updated the diff for D66616: [TSan] Add interceptors for mach_vm_[de]allocate.

Fix warning in test.

Aug 22 2019, 1:22 PM · Restricted Project, Restricted Project
yln added reviewers for D66616: [TSan] Add interceptors for mach_vm_[de]allocate: kubamracek, dcoughlin, delcypher, vitalybuka, dvyukov.
Aug 22 2019, 1:00 PM · Restricted Project, Restricted Project
yln created D66616: [TSan] Add interceptors for mach_vm_[de]allocate.
Aug 22 2019, 12:51 PM · Restricted Project, Restricted Project

Aug 21 2019

yln committed rG894abb46f891: [TSan] #include header instead of forward declaring interceptees (authored by yln).
[TSan] #include header instead of forward declaring interceptees
Aug 21 2019, 4:44 PM
yln committed rL369601: [TSan] #include header instead of forward declaring interceptees.
[TSan] #include header instead of forward declaring interceptees
Aug 21 2019, 4:44 PM

Aug 19 2019

yln committed rGdef061e6f0d5: [TSan] Rename file with libdispatch interceptors (authored by yln).
[TSan] Rename file with libdispatch interceptors
Aug 19 2019, 5:08 PM
yln committed rL369314: [TSan] Rename file with libdispatch interceptors.
[TSan] Rename file with libdispatch interceptors
Aug 19 2019, 5:03 PM
yln committed rG9f985dd380a3: [sanitizer_common] Extend test after switch to posix_spawn (authored by yln).
[sanitizer_common] Extend test after switch to posix_spawn
Aug 19 2019, 4:52 PM
yln committed rL369311: [sanitizer_common] Extend test after switch to posix_spawn.
[sanitizer_common] Extend test after switch to posix_spawn
Aug 19 2019, 4:50 PM
yln committed rGe644d5e230ef: [TSan] Rename file to make it clear that it defines interceptors (authored by yln).
[TSan] Rename file to make it clear that it defines interceptors
Aug 19 2019, 11:43 AM
yln committed rL369289: [TSan] Rename file to make it clear that it defines interceptors.
[TSan] Rename file to make it clear that it defines interceptors
Aug 19 2019, 11:43 AM

Aug 16 2019

yln committed rG0c2f26d66402: Revert "[TSan] Don't guard #include <xpc/xpc.h>" (authored by yln).
Revert "[TSan] Don't guard #include <xpc/xpc.h>"
Aug 16 2019, 3:59 PM
yln added a reverting change for rG8191585b36eb: [TSan] Don't guard #include <xpc/xpc.h>: rG0c2f26d66402: Revert "[TSan] Don't guard #include <xpc/xpc.h>".
Aug 16 2019, 3:59 PM
yln committed rL369165: Revert "[TSan] Don't guard #include <xpc/xpc.h>".
Revert "[TSan] Don't guard #include <xpc/xpc.h>"
Aug 16 2019, 3:59 PM
yln committed rG4a9b747bfb55: [TSan] Add interceptors for os_unfair_lock (authored by yln).
[TSan] Add interceptors for os_unfair_lock
Aug 16 2019, 3:42 PM
yln committed rL369164: [TSan] Add interceptors for os_unfair_lock.
[TSan] Add interceptors for os_unfair_lock
Aug 16 2019, 3:42 PM
yln committed rG8191585b36eb: [TSan] Don't guard #include <xpc/xpc.h> (authored by yln).
[TSan] Don't guard #include <xpc/xpc.h>
Aug 16 2019, 1:43 PM
yln committed rL369150: [TSan] Don't guard #include <xpc/xpc.h>.
[TSan] Don't guard #include <xpc/xpc.h>
Aug 16 2019, 1:43 PM

Aug 15 2019

yln added a comment to D65253: [sanitizer_common] Replace forkpty with posix_spawn on Darwin.

I do think, though, that LLVMSymbolizerProcess should also use posix_spawn *on Darwin*. Can we get that (as a separate change)?

Aug 15 2019, 10:31 AM · Restricted Project, Restricted Project
yln committed rGbb99437f6d45: [sanitizer_common] Always use posix_spawn on Darwin (authored by yln).
[sanitizer_common] Always use posix_spawn on Darwin
Aug 15 2019, 10:26 AM
yln committed rL369021: [sanitizer_common] Always use posix_spawn on Darwin.
[sanitizer_common] Always use posix_spawn on Darwin
Aug 15 2019, 10:24 AM

Aug 14 2019

yln committed rG399408a92f1d: [sanitizer_common] Replace forkpty with posix_spawn on Darwin (authored by yln).
[sanitizer_common] Replace forkpty with posix_spawn on Darwin
Aug 14 2019, 5:19 PM
yln committed rL368947: [sanitizer_common] Replace forkpty with posix_spawn on Darwin.
[sanitizer_common] Replace forkpty with posix_spawn on Darwin
Aug 14 2019, 5:18 PM
yln closed D65253: [sanitizer_common] Replace forkpty with posix_spawn on Darwin.
Aug 14 2019, 5:18 PM · Restricted Project, Restricted Project
yln updated the diff for D65253: [sanitizer_common] Replace forkpty with posix_spawn on Darwin.

Fixed failing test closed-fds.cpp: external symbolizer should continue to work
even when client program implements any of std{in,out,err}. Implemented similiar
functionality as CreateTwoHighNumberedPipes for internal_spawn.

Aug 14 2019, 4:38 PM · Restricted Project, Restricted Project

Aug 12 2019

yln committed rGd8c47d52da51: [TSan] Fix test failing on Linux (authored by yln).
[TSan] Fix test failing on Linux
Aug 12 2019, 5:38 PM
yln committed rL368641: [TSan] Fix test failing on Linux.
[TSan] Fix test failing on Linux
Aug 12 2019, 5:36 PM

Aug 9 2019

yln committed rG5ef4b190d991: [Sanitizer][Darwin] Add interceptor for malloc_zone_from_ptr (authored by yln).
[Sanitizer][Darwin] Add interceptor for malloc_zone_from_ptr
Aug 9 2019, 2:47 PM
yln committed rL368492: [Sanitizer][Darwin] Add interceptor for malloc_zone_from_ptr.
[Sanitizer][Darwin] Add interceptor for malloc_zone_from_ptr
Aug 9 2019, 2:45 PM
yln closed D65990: [Sanitizer][Darwin] Add interceptor for malloc_zone_from_ptr.
Aug 9 2019, 2:45 PM · Restricted Project, Restricted Project
yln added inline comments to D65990: [Sanitizer][Darwin] Add interceptor for malloc_zone_from_ptr.
Aug 9 2019, 2:37 PM · Restricted Project, Restricted Project
yln updated the diff for D65990: [Sanitizer][Darwin] Add interceptor for malloc_zone_from_ptr.

Rename test file '.cc' -> '.cpp'.

Aug 9 2019, 9:46 AM · Restricted Project, Restricted Project

Aug 8 2019

yln updated the summary of D65990: [Sanitizer][Darwin] Add interceptor for malloc_zone_from_ptr.
Aug 8 2019, 6:58 PM · Restricted Project, Restricted Project
yln created D65990: [Sanitizer][Darwin] Add interceptor for malloc_zone_from_ptr.
Aug 8 2019, 6:55 PM · Restricted Project, Restricted Project

Aug 2 2019

yln added a comment to D65253: [sanitizer_common] Replace forkpty with posix_spawn on Darwin.

Thanks! This looks like a great step in the right direction. An overall question first: Should we use posix_spawn for *all platforms*? IIRC, unifying the launch paths was discussed on mailing lists before and sounds desirable.

Aug 2 2019, 3:54 PM · Restricted Project, Restricted Project

Jul 24 2019

yln committed rG758f6da687b8: [sanitizer_common] Allow customization of StartSymbolizerSubprocess (authored by yln).
[sanitizer_common] Allow customization of StartSymbolizerSubprocess
Jul 24 2019, 5:21 PM
yln committed rL366967: [sanitizer_common] Allow customization of StartSymbolizerSubprocess.
[sanitizer_common] Allow customization of StartSymbolizerSubprocess
Jul 24 2019, 5:20 PM
yln closed D65252: [sanitizer_common] Allow customization of StartSymbolizerSubprocess.
Jul 24 2019, 5:20 PM · Restricted Project, Restricted Project
yln added a reviewer for D65253: [sanitizer_common] Replace forkpty with posix_spawn on Darwin: alex.
Jul 24 2019, 4:49 PM · Restricted Project, Restricted Project
yln added reviewers for D65253: [sanitizer_common] Replace forkpty with posix_spawn on Darwin: dvyukov, eugenis, vitalybuka, samsonov, rnk, kubamracek, delcypher, dcoughlin.
Jul 24 2019, 4:18 PM · Restricted Project, Restricted Project
yln added reviewers for D65252: [sanitizer_common] Allow customization of StartSymbolizerSubprocess: vitalybuka, kubamracek, delcypher, dcoughlin.
Jul 24 2019, 4:16 PM · Restricted Project, Restricted Project
yln created D65253: [sanitizer_common] Replace forkpty with posix_spawn on Darwin.
Jul 24 2019, 4:15 PM · Restricted Project, Restricted Project
yln created D65252: [sanitizer_common] Allow customization of StartSymbolizerSubprocess.
Jul 24 2019, 4:08 PM · Restricted Project, Restricted Project

Jul 22 2019

yln committed rG2ef9ec40504b: [TSan] Enable fiber tests on iOS simulator (authored by yln).
[TSan] Enable fiber tests on iOS simulator
Jul 22 2019, 2:14 PM
yln committed rL366738: [TSan] Enable fiber tests on iOS simulator.
[TSan] Enable fiber tests on iOS simulator
Jul 22 2019, 2:12 PM

Jul 18 2019

yln added inline comments to D64773: [ASan] Support `{f}puts(NULL)` on Darwin.
Jul 18 2019, 1:16 PM · Restricted Project, Restricted Project
yln committed rGbe7a7ae0c3da: [ASan] Support `{f}puts(NULL)` on Darwin, part 2 (authored by yln).
[ASan] Support `{f}puts(NULL)` on Darwin, part 2
Jul 18 2019, 1:16 PM
yln committed rL366488: [ASan] Support `{f}puts(NULL)` on Darwin, part 2.
[ASan] Support `{f}puts(NULL)` on Darwin, part 2
Jul 18 2019, 1:15 PM

Jul 17 2019

yln committed rG9a050f92bb29: [ASan] Support `{f}puts(NULL)` on Darwin (authored by yln).
[ASan] Support `{f}puts(NULL)` on Darwin
Jul 17 2019, 9:15 AM
yln committed rL366342: [ASan] Support `{f}puts(NULL)` on Darwin.
[ASan] Support `{f}puts(NULL)` on Darwin
Jul 17 2019, 9:10 AM
yln closed D64773: [ASan] Support `{f}puts(NULL)` on Darwin.
Jul 17 2019, 9:09 AM · Restricted Project, Restricted Project

Jul 16 2019

yln committed rGd069a1921065: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.6 (authored by yln).
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.6
Jul 16 2019, 1:44 PM
yln committed rL366258: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.6.
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.6
Jul 16 2019, 1:40 PM
yln committed rGe6e33cf9f568: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.10 (authored by yln).
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.10
Jul 16 2019, 9:23 AM
yln committed rL366225: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.10.
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.10
Jul 16 2019, 9:22 AM

Jul 15 2019

yln committed rGc48162db994a: [TSan] Fix asm token error (again) (authored by yln).
[TSan] Fix asm token error (again)
Jul 15 2019, 4:06 PM
yln committed rL366150: [TSan] Fix asm token error (again).
[TSan] Fix asm token error (again)
Jul 15 2019, 4:06 PM
yln added a reviewer for D64773: [ASan] Support `{f}puts(NULL)` on Darwin: delcypher.
Jul 15 2019, 3:41 PM · Restricted Project, Restricted Project
yln added reviewers for D64773: [ASan] Support `{f}puts(NULL)` on Darwin: kubamracek, eugenis, Lekensteyn.
Jul 15 2019, 2:53 PM · Restricted Project, Restricted Project
yln created D64773: [ASan] Support `{f}puts(NULL)` on Darwin.
Jul 15 2019, 2:50 PM · Restricted Project, Restricted Project
yln committed rG228f80d92dc2: [TSan] Fix asm token error (authored by yln).
[TSan] Fix asm token error
Jul 15 2019, 2:26 PM
yln committed rL366131: [TSan] Fix asm token error.
[TSan] Fix asm token error
Jul 15 2019, 2:25 PM
yln abandoned D64459: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.9.

Landed these cleanup changes in smaller chunks on my own.

Jul 15 2019, 1:53 PM · Restricted Project, Restricted Project
yln committed rG39d888c1e42a: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.9 (authored by yln).
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.9
Jul 15 2019, 1:23 PM
yln committed rL366126: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.9.
[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.9
Jul 15 2019, 1:22 PM

Jul 12 2019

yln committed rG4f519b6919d2: [TSan] Tiny cleanup of UnmangleLongJmpSp for Linux/x86_64 (authored by yln).
[TSan] Tiny cleanup of UnmangleLongJmpSp for Linux/x86_64
Jul 12 2019, 5:56 PM
yln committed rL365982: [TSan] Tiny cleanup of UnmangleLongJmpSp for Linux/x86_64.
[TSan] Tiny cleanup of UnmangleLongJmpSp for Linux/x86_64
Jul 12 2019, 5:55 PM

Jul 11 2019

yln committed rG9d41429ff790: [TSan] Move DECLARE_REAL macro outside of namespace (authored by yln).
[TSan] Move DECLARE_REAL macro outside of namespace
Jul 11 2019, 11:30 AM
yln committed rL365806: [TSan] Move DECLARE_REAL macro outside of namespace.
[TSan] Move DECLARE_REAL macro outside of namespace
Jul 11 2019, 11:29 AM

Jul 10 2019

yln committed rG6a155f52bc2a: [TSan] Fix linker error on Linux/AArch64 (authored by yln).
[TSan] Fix linker error on Linux/AArch64
Jul 10 2019, 3:51 PM
yln committed rL365707: [TSan] Fix linker error on Linux/AArch64.
[TSan] Fix linker error on Linux/AArch64
Jul 10 2019, 3:50 PM
yln committed rG098e0a79fa7c: [TSan] Fix compiler error on Linux/AArch64 (authored by yln).
[TSan] Fix compiler error on Linux/AArch64
Jul 10 2019, 12:47 PM
yln committed rL365693: [TSan] Fix compiler error on Linux/AArch64.
[TSan] Fix compiler error on Linux/AArch64
Jul 10 2019, 12:46 PM
yln committed rG1a2c8809248d: [TSan] Attempt to fix linker error on Linux/AArch64 (authored by yln).
[TSan] Attempt to fix linker error on Linux/AArch64
Jul 10 2019, 11:38 AM
yln committed rL365681: [TSan] Attempt to fix linker error on Linux/AArch64.
[TSan] Attempt to fix linker error on Linux/AArch64
Jul 10 2019, 11:37 AM

Jul 9 2019

yln added a reviewer for D64459: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.9: dvyukov.
Jul 9 2019, 5:31 PM · Restricted Project, Restricted Project
yln created D64459: [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.9.
Jul 9 2019, 5:31 PM · Restricted Project, Restricted Project
yln committed rGba9eb4831842: Reland "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt. (authored by yln).
Reland "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.
Jul 9 2019, 2:28 PM
yln committed rL365560: Reland "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt..
Reland "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.
Jul 9 2019, 2:27 PM