- User Since
- Jan 21 2014, 12:56 PM (435 w, 3 d)
Tue, May 24
Mon, May 23
Thu, May 19
Wed, May 18
Tue, May 17
Fri, May 13
Thu, May 12
llvm issues now live on Github. Here is the imported one from the Bugzilla: https://github.com/llvm/llvm-project/issues/27917
You can make yourself the Assignee, leave a reference to this revision in a comment, and close the issue.
Wed, May 11
Mon, May 9
Fri, May 6
@ZijunZhao: what do you think?
Tue, May 3
Apr 26 2022
Apr 21 2022
arm64 and iOS support were introduced at the same time, but without mention why a special case is necessary:
Apr 13 2022
Apr 12 2022
@thetruestblue please verify that this fixes the problem you saw on your AS machine.
Thank you for continuing to improve this code! I see my TODOs from 3 years ago when I tried and failed.
LGTM to me, thanks!
@delcypher, what do you think?
Apr 6 2022
Blue doesn't have commit access yet. I will land her change.
Suggested title for commit: [Darwin][ASan] Fix "interceptor working?" check for DriverKit platform
Apr 4 2022
LGTM, with nits.
Apr 1 2022
LGTM, with one small comment, thanks!
Mar 31 2022
Mar 30 2022
Mar 29 2022
Mar 23 2022
Thank you @zequanwu, for providing the minimized reproducer! It really made fixing this much easier! :)
Mar 17 2022
Mar 16 2022
Plan to land tomorrow morning. Test passes on the Debian bot:
PASS: LLVM :: Transforms/LowerGlobalDestructors/lower-global-dtors.ll (72299 of 93291)
FYI - you could have continued to use this phab for review, it makes it easier to compare the changes you've made
Mar 15 2022
It looks like all tests succeed for x64 debian:
New revision here: D121736
Mar 14 2022
Report fatal error when we can, instead of never.
Hi Dan, I hope you are still happy with this change. I didn't change any WebAssembly tests, but rather added a new IR-level test, so all existing WebAssembly behavior should stay the same. Let me know if you have any concerns.
Add support for an escape hatch to fallback to the old behavior: via Clang driver flag
(-fregister-global-dtors-with-atexit) or llc / code generation flag
(-lower-global-dtors-via-cxa-atexit). This escape hatch will be
removed in the future.
Mar 11 2022
Mar 10 2022
Declare preserved analyses in new pass format.
Make pass compatible with new pass manager to ease testing with opt. Add and adapt tests. Add documentation. Make clang-format happy.
Mar 9 2022
I wanted to check in to get your feedback on the overall approach while I am working on adding tests for the behavior change.
Jan 24 2022
Exact spelling of the temporary test directory shouldn't matter.
The z/OS linker not being able to handle this sounds like a bug... but oh my.