Page MenuHomePhabricator

yln (Julian Lettner)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 21 2014, 12:56 PM (435 w, 3 d)

Recent Activity

Today

yln committed rG8e724ad96565: [TSan][Darwin] Deflake test (authored by yln).
[TSan][Darwin] Deflake test
Fri, May 27, 10:20 AM · Restricted Project, Restricted Project

Tue, May 24

yln requested review of D126351: [ASan][Darwin] Ensure we always register GCD worker threads.
Tue, May 24, 9:14 PM · Restricted Project, Restricted Project
yln accepted D126263: [Sanitizers][Darwin] Replace SANITIZER_MAC with SANITIZER_APPLE in source files.

LGTM, thanks!

Tue, May 24, 10:04 AM · Restricted Project, Restricted Project

Mon, May 23

yln committed rG1962389979be: [Sanitizer][Darwin] Add explanation for Apple platform macros (authored by yln).
[Sanitizer][Darwin] Add explanation for Apple platform macros
Mon, May 23, 12:00 PM · Restricted Project, Restricted Project
yln closed D126229: [Sanitizer][Darwin] Add explanation for Apple platform macros.
Mon, May 23, 11:59 AM · Restricted Project, Restricted Project
yln requested review of D126229: [Sanitizer][Darwin] Add explanation for Apple platform macros.
Mon, May 23, 11:34 AM · Restricted Project, Restricted Project
yln committed rG806e8a1c8e54: [Sanitizer][Darwin] Add SANITIZER_DRIVERKIT platform macro (authored by yln).
[Sanitizer][Darwin] Add SANITIZER_DRIVERKIT platform macro
Mon, May 23, 11:22 AM · Restricted Project, Restricted Project

Thu, May 19

yln committed rGec563c5a905a: [ASan] Add sleep_before_init flag (authored by yln).
[ASan] Add sleep_before_init flag
Thu, May 19, 8:42 PM · Restricted Project, Restricted Project
yln closed D126037: [ASan] Add sleep_before_init flag.
Thu, May 19, 8:41 PM · Restricted Project, Restricted Project
yln requested review of D126037: [ASan] Add sleep_before_init flag.
Thu, May 19, 5:51 PM · Restricted Project, Restricted Project

Wed, May 18

yln added inline comments to D125816: [Sanitizers][Darwin] Rename Apple macro SANITIZER_MAC -> SANITIZER_APPLE.
Wed, May 18, 10:02 AM · Restricted Project, Restricted Project

Tue, May 17

yln accepted D125816: [Sanitizers][Darwin] Rename Apple macro SANITIZER_MAC -> SANITIZER_APPLE.
Tue, May 17, 10:57 AM · Restricted Project, Restricted Project
yln added inline comments to D125816: [Sanitizers][Darwin] Rename Apple macro SANITIZER_MAC -> SANITIZER_APPLE.
Tue, May 17, 10:43 AM · Restricted Project, Restricted Project

Fri, May 13

yln added inline comments to D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks..
Fri, May 13, 10:28 AM · Restricted Project, Restricted Project, Restricted Project

Thu, May 12

yln committed rG824d83068efc: [TSan] Relax pthread introspection-based test (authored by yln).
[TSan] Relax pthread introspection-based test
Thu, May 12, 6:14 PM · Restricted Project, Restricted Project
yln added a reviewer for D125416: [Sanitizers][Darwin] Add READ/WRITE detection on arm64 for darwin.: wrotki.
Thu, May 12, 9:51 AM · Restricted Project, Restricted Project
yln accepted D125416: [Sanitizers][Darwin] Add READ/WRITE detection on arm64 for darwin..
Thu, May 12, 9:51 AM · Restricted Project, Restricted Project
yln added a comment to D125416: [Sanitizers][Darwin] Add READ/WRITE detection on arm64 for darwin..

llvm issues now live on Github. Here is the imported one from the Bugzilla: https://github.com/llvm/llvm-project/issues/27917
You can make yourself the Assignee, leave a reference to this revision in a comment, and close the issue.

Thu, May 12, 9:50 AM · Restricted Project, Restricted Project

Wed, May 11

yln added inline comments to D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks..
Wed, May 11, 4:11 PM · Restricted Project, Restricted Project, Restricted Project

Mon, May 9

yln added inline comments to D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks..
Mon, May 9, 11:03 AM · Restricted Project, Restricted Project, Restricted Project
yln added inline comments to D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks..
Mon, May 9, 10:55 AM · Restricted Project, Restricted Project, Restricted Project
yln added inline comments to D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks..
Mon, May 9, 10:51 AM · Restricted Project, Restricted Project, Restricted Project

Fri, May 6

yln accepted D125152: [compiler-rt] Add missing arguments to dynamic cflags.

@ZijunZhao: what do you think?

Fri, May 6, 5:52 PM · Restricted Project, Restricted Project

Tue, May 3

yln added reviewers for D124591: tsan: for unittests, change to use test fixtures to clear racy stacks: thetruestblue, rsundahl.
Tue, May 3, 9:28 AM · Restricted Project, Restricted Project

Apr 26 2022

yln accepted D124480: [Darwin][UBSan][Sanitizer] abort_on_error ubsan test fix for arm64.

LGTM, thanks!

Apr 26 2022, 2:52 PM · Restricted Project, Restricted Project

Apr 21 2022

yln accepted D124140: Fix sanitizer stack traces on aarch64..
Apr 21 2022, 1:49 PM · Restricted Project, Restricted Project
yln added a comment to D124140: Fix sanitizer stack traces on aarch64..

arm64 and iOS support were introduced at the same time, but without mention why a special case is necessary:
https://reviews.llvm.org/D10510

Apr 21 2022, 1:46 PM · Restricted Project, Restricted Project

Apr 13 2022

yln committed rG8887c63e327f: Adapt "cross compile?" check for Apple Silicon (authored by yln).
Adapt "cross compile?" check for Apple Silicon
Apr 13 2022, 3:26 PM · Restricted Project, Restricted Project
yln closed D123633: Adapt "cross compile?" check for Apple Silicon.
Apr 13 2022, 3:26 PM · Restricted Project, Restricted Project
yln accepted D123736: [Darwin][ASan][Sanitizer] Fixes Sanitizer NonUnique Identifier to Account for Mac arm64 architectures..

LGTM, thanks!

Apr 13 2022, 3:24 PM · Restricted Project, Restricted Project

Apr 12 2022

yln added inline comments to D123633: Adapt "cross compile?" check for Apple Silicon.
Apr 12 2022, 7:42 PM · Restricted Project, Restricted Project
yln added a comment to D123633: Adapt "cross compile?" check for Apple Silicon.

@thetruestblue please verify that this fixes the problem you saw on your AS machine.

Apr 12 2022, 2:07 PM · Restricted Project, Restricted Project
yln requested review of D123633: Adapt "cross compile?" check for Apple Silicon.
Apr 12 2022, 2:06 PM · Restricted Project, Restricted Project
yln accepted D123562: [ubsan] Fix print_stacktrace=1:fast_unwind_on_fatal=0 to correctly fallback to fast unwinder.

Thank you for continuing to improve this code! I see my TODOs from 3 years ago when I tried and failed.

Apr 12 2022, 10:55 AM · Restricted Project, Restricted Project
yln accepted D123475: [compiler-rt] Stop explictly ad-hoc signing compiler-rt dylibs in apple builds if ld is new enough.

LGTM to me, thanks!
@delcypher, what do you think?

Apr 12 2022, 10:12 AM · Restricted Project, Restricted Project

Apr 6 2022

yln committed rGfc4c872d8f1e: [Darwin][ASan] Fix "interceptor working?" check for DriverKit platform (authored by Blue Gaston <bgaston2@apple.com>).
[Darwin][ASan] Fix "interceptor working?" check for DriverKit platform
Apr 6 2022, 3:51 PM · Restricted Project, Restricted Project
yln closed D123245: [Darwin][ASan] Fix "interceptor working?" check for DriverKit platform.
Apr 6 2022, 3:51 PM · Restricted Project, Restricted Project
yln added a comment to D123245: [Darwin][ASan] Fix "interceptor working?" check for DriverKit platform.

Blue doesn't have commit access yet. I will land her change.

Apr 6 2022, 3:46 PM · Restricted Project, Restricted Project
yln accepted D123245: [Darwin][ASan] Fix "interceptor working?" check for DriverKit platform.
Apr 6 2022, 3:00 PM · Restricted Project, Restricted Project
yln added a comment to D123245: [Darwin][ASan] Fix "interceptor working?" check for DriverKit platform.

Suggested title for commit: [Darwin][ASan] Fix "interceptor working?" check for DriverKit platform

Apr 6 2022, 1:40 PM · Restricted Project, Restricted Project

Apr 4 2022

yln accepted D123099: [Darwin][ASan][Sanitizer] Enable dlclose-test for all darwin targets..

LGTM, with nits.

Apr 4 2022, 4:45 PM · Restricted Project, Restricted Project
yln reopened D122251: [lit] Use sharding for GoogleTest format.
Apr 4 2022, 10:52 AM · Restricted Project, Restricted Project
yln added inline comments to D122251: [lit] Use sharding for GoogleTest format.
Apr 4 2022, 10:50 AM · Restricted Project, Restricted Project

Apr 1 2022

yln added inline comments to D122251: [lit] Use sharding for GoogleTest format.
Apr 1 2022, 3:22 PM · Restricted Project, Restricted Project
yln added inline comments to D122251: [lit] Use sharding for GoogleTest format.
Apr 1 2022, 2:47 PM · Restricted Project, Restricted Project
yln accepted D122251: [lit] Use sharding for GoogleTest format.

LGTM, with one small comment, thanks!

Apr 1 2022, 2:35 PM · Restricted Project, Restricted Project

Mar 31 2022

yln committed rGa5228bcaad9c: [Darwin] Limit parallelism for sanitizer tests that use shadow memory on AS (authored by yln).
[Darwin] Limit parallelism for sanitizer tests that use shadow memory on AS
Mar 31 2022, 2:43 PM · Restricted Project, Restricted Project
yln closed D122751: [Darwin] Limit parallelism for sanitizer tests that use shadow memory on AS.
Mar 31 2022, 2:43 PM · Restricted Project, Restricted Project
yln added inline comments to D122751: [Darwin] Limit parallelism for sanitizer tests that use shadow memory on AS.
Mar 31 2022, 2:34 PM · Restricted Project, Restricted Project

Mar 30 2022

yln added a reviewer for D122751: [Darwin] Limit parallelism for sanitizer tests that use shadow memory on AS: rsundahl.
Mar 30 2022, 12:46 PM · Restricted Project, Restricted Project
yln added a reviewer for D122751: [Darwin] Limit parallelism for sanitizer tests that use shadow memory on AS: thetruestblue.
Mar 30 2022, 12:07 PM · Restricted Project, Restricted Project
yln committed rG15c4239dff0f: Do not generate x86_64 test targets on AS hosts (authored by yln).
Do not generate x86_64 test targets on AS hosts
Mar 30 2022, 11:32 AM · Restricted Project, Restricted Project
yln closed D122700: Do not generate x86_64 test targets on AS hots.
Mar 30 2022, 11:32 AM · Restricted Project, Restricted Project
yln requested review of D122751: [Darwin] Limit parallelism for sanitizer tests that use shadow memory on AS.
Mar 30 2022, 10:55 AM · Restricted Project, Restricted Project

Mar 29 2022

yln retitled D122700: Do not generate x86_64 test targets on AS hots from Do not generate x86_64 test targets on M1 Macs to Do not generate x86_64 test targets on AS hots.
Mar 29 2022, 7:20 PM · Restricted Project, Restricted Project
yln added a comment to D122700: Do not generate x86_64 test targets on AS hots.

Relevant: https://reviews.llvm.org/D82610

Mar 29 2022, 7:18 PM · Restricted Project, Restricted Project
yln requested review of D122700: Do not generate x86_64 test targets on AS hots.
Mar 29 2022, 7:16 PM · Restricted Project, Restricted Project

Mar 23 2022

yln added a comment to D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.

Thank you @zequanwu, for providing the minimized reproducer! It really made fixing this much easier! :)

Mar 23 2022, 6:42 PM · Restricted Project, Restricted Project, Restricted Project
yln committed rG64902d335c21: Reland "Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO" (authored by yln).
Reland "Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO"
Mar 23 2022, 6:37 PM · Restricted Project

Mar 17 2022

yln added a comment to D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.

LGTM - but please hang around after you commit

Mar 17 2022, 4:13 PM · Restricted Project, Restricted Project, Restricted Project
yln committed rG22570bac6943: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO (authored by yln).
Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO
Mar 17 2022, 10:47 AM · Restricted Project
yln closed D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.
Mar 17 2022, 10:47 AM · Restricted Project, Restricted Project, Restricted Project

Mar 16 2022

yln added a comment to D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.

Plan to land tomorrow morning. Test passes on the Debian bot:

PASS: LLVM :: Transforms/LowerGlobalDestructors/lower-global-dtors.ll (72299 of 93291)
Mar 16 2022, 6:50 PM · Restricted Project, Restricted Project, Restricted Project
yln added a comment to D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.

FYI - you could have continued to use this phab for review, it makes it easier to compare the changes you've made

Mar 16 2022, 6:43 PM · Restricted Project, Restricted Project, Restricted Project

Mar 15 2022

yln added a comment to D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.

It looks like all tests succeed for x64 debian:
https://buildkite.com/llvm-project/premerge-checks/builds/83802#c5002be5-e01c-46fc-a767-50fe6f854465

Mar 15 2022, 5:46 PM · Restricted Project, Restricted Project, Restricted Project
yln added a comment to D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.

Hi @Orlando and @RKSimon, would you be able to confirm that this version avoids the previous opt: Unknown command line argument '-lower-global-dtors' error?

Mar 15 2022, 1:55 PM · Restricted Project, Restricted Project, Restricted Project
yln added a comment to D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.

New revision here: D121736

Mar 15 2022, 1:42 PM · Restricted Project, Restricted Project, Restricted Project
yln requested review of D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.
Mar 15 2022, 1:41 PM · Restricted Project, Restricted Project, Restricted Project
yln added a comment to D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.

Hi @Orlando and @RKSimon!

Mar 15 2022, 1:28 PM · Restricted Project, Restricted Project, Restricted Project

Mar 14 2022

yln committed rG9c542a5a4e1b: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO (authored by yln).
Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO
Mar 14 2022, 5:52 PM · Restricted Project
yln closed D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.
Mar 14 2022, 5:51 PM · Restricted Project, Restricted Project, Restricted Project
yln added inline comments to D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.
Mar 14 2022, 5:48 PM · Restricted Project, Restricted Project, Restricted Project
yln updated the diff for D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.

Report fatal error when we can, instead of never.

Mar 14 2022, 5:29 PM · Restricted Project, Restricted Project, Restricted Project
yln added a comment to D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.

@sunfish
Hi Dan, I hope you are still happy with this change. I didn't change any WebAssembly tests, but rather added a new IR-level test, so all existing WebAssembly behavior should stay the same. Let me know if you have any concerns.

Mar 14 2022, 5:16 PM · Restricted Project, Restricted Project, Restricted Project
yln added inline comments to D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.
Mar 14 2022, 5:02 PM · Restricted Project, Restricted Project, Restricted Project
yln updated the diff for D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.

Add support for an escape hatch to fallback to the old behavior: via Clang driver flag
(-fregister-global-dtors-with-atexit) or llc / code generation flag
(-lower-global-dtors-via-cxa-atexit). This escape hatch will be
removed in the future.

Mar 14 2022, 4:48 PM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2022

yln added a reviewer for D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO: ahatanak.
Mar 11 2022, 3:59 PM · Restricted Project, Restricted Project, Restricted Project
yln committed rG46626bc87382: [NFC] Improve comment and rename test file (authored by yln).
[NFC] Improve comment and rename test file
Mar 11 2022, 2:48 PM · Restricted Project
yln added inline comments to D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.
Mar 11 2022, 2:45 PM · Restricted Project, Restricted Project, Restricted Project

Mar 10 2022

yln updated the diff for D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.

Declare preserved analyses in new pass format.

Mar 10 2022, 6:55 PM · Restricted Project, Restricted Project, Restricted Project
yln added inline comments to D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.
Mar 10 2022, 6:32 PM · Restricted Project, Restricted Project, Restricted Project
yln added inline comments to D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.
Mar 10 2022, 6:30 PM · Restricted Project, Restricted Project, Restricted Project
yln updated the diff for D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.

Make pass compatible with new pass manager to ease testing with opt. Add and adapt tests. Add documentation. Make clang-format happy.

Mar 10 2022, 6:09 PM · Restricted Project, Restricted Project, Restricted Project

Mar 9 2022

yln added a comment to D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.

I wanted to check in to get your feedback on the overall approach while I am working on adding tests for the behavior change.

Mar 9 2022, 1:19 PM · Restricted Project, Restricted Project, Restricted Project
yln requested review of D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.
Mar 9 2022, 1:07 PM · Restricted Project, Restricted Project, Restricted Project

Jan 24 2022

yln added a reviewer for D118071: [SystemZ][z/OS]: fix lit tmp_dir to use - instead of _ : mstorsjo.
Jan 24 2022, 1:48 PM · Restricted Project
yln accepted D118071: [SystemZ][z/OS]: fix lit tmp_dir to use - instead of _ .

Exact spelling of the temporary test directory shouldn't matter.
The z/OS linker not being able to handle this sounds like a bug... but oh my.

Jan 24 2022, 1:47 PM · Restricted Project

Jan 23 2022

yln committed rG1f4a0531b3fd: [TSan] Mark test unsupported on Darwin (authored by yln).
[TSan] Mark test unsupported on Darwin
Jan 23 2022, 10:02 PM

Jan 21 2022

yln committed rGdb07e082abaf: [TSan] Omit vfork interceptor iOS simulator runtime (authored by yln).
[TSan] Omit vfork interceptor iOS simulator runtime
Jan 21 2022, 5:37 PM

Jan 13 2022

yln committed rG0f6f6284d733: [lit] Make sure our test temp directory is actually used by tests (authored by yln).
[lit] Make sure our test temp directory is actually used by tests
Jan 13 2022, 11:24 AM
yln closed D117179: [lit] Make sure our test temp directory is actually used by tests.
Jan 13 2022, 11:23 AM · Restricted Project

Jan 12 2022

yln requested review of D117179: [lit] Make sure our test temp directory is actually used by tests.
Jan 12 2022, 7:13 PM · Restricted Project

Jan 11 2022

yln committed rG7acb68b80be6: [NFC] Fixup for comment (authored by yln).
[NFC] Fixup for comment
Jan 11 2022, 3:35 PM
yln committed rGff11cd955019: [TSan][Darwin] Enable Trace/TraceAlloc unit tests (authored by yln).
[TSan][Darwin] Enable Trace/TraceAlloc unit tests
Jan 11 2022, 3:33 PM
yln committed rG4614b93f5373: [TSan][Darwin] Mark test UNSUPPORTED for iOS simulator (authored by yln).
[TSan][Darwin] Mark test UNSUPPORTED for iOS simulator
Jan 11 2022, 3:01 PM
yln accepted D116989: [compiler-rt][darwin] check for strcmp to test interceptors instead of pthread_create.
Jan 11 2022, 2:05 PM · Restricted Project

Jan 10 2022

yln committed rGf4ab0f6e097f: [TSan] Avoid deadlock in test for compiler-rt debug build (authored by yln).
[TSan] Avoid deadlock in test for compiler-rt debug build
Jan 10 2022, 11:41 AM

Jan 7 2022

yln committed rGbdef75fd6127: [Darwin][Sanitizer] Lower Python requirement for iOS simulator testing (authored by yln).
[Darwin][Sanitizer] Lower Python requirement for iOS simulator testing
Jan 7 2022, 5:37 PM
yln committed rGebd8eee62a43: [Darwin] Apply workaround to make symbolication in iOS simulators work (authored by yln).
[Darwin] Apply workaround to make symbolication in iOS simulators work
Jan 7 2022, 4:49 PM
yln committed rG6f480655e69a: [ASan][Darwin] Avoid crash during ASan initialization (authored by yln).
[ASan][Darwin] Avoid crash during ASan initialization
Jan 7 2022, 12:29 PM