- User Since
- Mar 30 2022, 12:03 PM (60 w, 3 d)
Thu, May 18
My only nit is to add more description to commit message about why we are removing this and perhaps a link to the review that this was introduced. https://reviews.llvm.org/D114294
Thu, May 11
Tue, May 9
Small insignificant note from me: When this lands, please be sure to add me as co-author.
Apr 20 2023
Apr 18 2023
Yes, it's here: https://ci.chromium.org/ui/p/chromium/builders/try/mac_upload_clang/3593/overview
I haven't confirmed this patch is the cause, but it looks very likely. I'm trying to setup the environment for build llvm on my mac to confirm it.
Yes. it's very likey, but seems strange, no other OSX bots complained.
Not sure why linker is unhappy. Could this be an issue with incremental build, e.g. it's linking agains older library?
I will disabled darwin for now.
Apr 13 2023
Apr 10 2023
Apr 7 2023
Apr 6 2023
Apr 4 2023
Mar 30 2023
Can you just do
git cherry-pick -n
aka no commit? shouldn't require an email?
Mar 23 2023
This is fine... feels a little off.
Is there a script to run the docker container? Couldn't we bring it in there or when we build it?
Mar 21 2023
fixed trailing white space issues.
Mar 10 2023
This looks good to me. I'm not sure the policy on what should be added to the release notes. But this was a temporary flag only added to slowly deprecate this, and was noted when it was added that it would be removed.
Mar 7 2023
Mar 1 2023
Currently & ideally asabi_shim.h is unnecessary -- but we hope to use only headers from ../asan/
Feb 28 2023
You could probably use FILTER to remove all arm7* variants in one command, but there's no real need to do that.
Feb 24 2023
Feb 8 2023
This seems reasonable and fine to me.
Though I'd feel better if someone familiar with MSVC/Windows gave approval.
Feb 7 2023
Nit: When you land this will you update commit message to reflect the new change?
Feb 6 2023
Thanks @delcypher for reviewing. Thanks @thieta for the work -- I'll keep an eye out for the updated diff, @delcypher doesn't work on Sanitizers as much anymore.
Jan 26 2023
LGTM, but also confused regarding @yln's point.
Jan 20 2023
Jan 17 2023
This seems reasonable to me.
Jan 10 2023
Rather than skip the test, lower expected ratio. Per @rsundahl 's suggestion.
incorporate @yln's suggestion.
Jan 9 2023
Removed check for apple in second conditional.
Jan 6 2023
Jan 4 2023
fixed long line
Dec 22 2022
Dec 20 2022
This fixes the case where map_end is greater than end because of page size and alignment difference.
However, I believe this function could use further refinement, I don't think it is handling "alignment" versus "page-aligned" adequately.
alignment is being treated as a size, rather than a page aligned location, which seems to be what we should be expecting here.
Particularly with the calls to UnmaporDie, which expect a page-aligned value.
Dec 19 2022
Dec 8 2022
Dec 2 2022
Nov 30 2022
This looks fine to me.
Nov 28 2022
Thanks for fixing this quick, @rsundahl.
Nov 16 2022
While I sympathize with you, I don't think this is valid reason to maintain full compatibility with llvm-config.
This breaks our use case. We run sanitizer tests built in a standalone build using a toolchain from an artifact built upstream-- the toolchain contains binaries only.
Compiler-rt tests rely on the llvm tools binary being in the PATH.
Nov 14 2022
Is there a radar tracking this that we can add to these updates?
Nov 11 2022
LGTM -- fixes the arm64 hang I've been running into.
Sep 19 2022
Updating commit message
C++ standard can be manually overwritten and manually defined. As the codebase stands, without this overwrite, no this is never not true. And in the case of someone running Apple tests, I'm not sure *why* this would happen. But because the the mechanism exists, I added a conditional. I agree that guarding tests against every potential case might be unnecessary.
Sep 16 2022
Abandoning for a more lightweight change.
Sep 14 2022
Sep 9 2022
Keeping the null guard from the original commit.
Sep 7 2022
Aug 3 2022
Made the format consistent.
Jul 29 2022
Additional weak def