Page MenuHomePhabricator

thetruestblue (Brittany Blue Gaston)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 30 2022, 12:03 PM (60 w, 3 d)

Recent Activity

Thu, May 18

thetruestblue added a comment to D150298: [Sanitizers] Remove BuildId from sanitizers stacktrace on Darwin.

My only nit is to add more description to commit message about why we are removing this and perhaps a link to the review that this was introduced. https://reviews.llvm.org/D114294

Thu, May 18, 1:06 PM · Restricted Project, Restricted Project

Thu, May 11

thetruestblue added reviewers for D143675: Discussion: Darwin Sanitizers Stable ABI: yln, kubamracek.
Thu, May 11, 8:13 PM · Restricted Project, Restricted Project, Restricted Project
thetruestblue added inline comments to D143675: Discussion: Darwin Sanitizers Stable ABI.
Thu, May 11, 8:12 PM · Restricted Project, Restricted Project, Restricted Project

Tue, May 9

thetruestblue added a comment to D143675: Discussion: Darwin Sanitizers Stable ABI.

Small insignificant note from me: When this lands, please be sure to add me as co-author.
https://github.blog/2018-01-29-commit-together-with-co-authors/

Tue, May 9, 1:52 PM · Restricted Project, Restricted Project, Restricted Project

Apr 20 2023

thetruestblue accepted D148727: [fuzzer][test] Disable big-file-copy.test for everything but macOS.
Apr 20 2023, 12:13 PM · Restricted Project, Restricted Project

Apr 18 2023

thetruestblue requested review of D148669: [Sanitizers][Darwin][Minversion] Bump DEFAULT_SANITIZER_MIN_OSX_VERSION to 10.13.
Apr 18 2023, 3:31 PM · Restricted Project, Restricted Project
thetruestblue added a comment to D148281: [lsan] Don't crash on ThreadRegistry::threads_ data race.

Yes, it's here: https://ci.chromium.org/ui/p/chromium/builders/try/mac_upload_clang/3593/overview

I haven't confirmed this patch is the cause, but it looks very likely. I'm trying to setup the environment for build llvm on my mac to confirm it.

Yes. it's very likey, but seems strange, no other OSX bots complained.
Not sure why linker is unhappy. Could this be an issue with incremental build, e.g. it's linking agains older library?
I will disabled darwin for now.

Apr 18 2023, 1:39 PM · Restricted Project, Restricted Project

Apr 13 2023

thetruestblue committed rG4826aa01dbae: [Test][Sanitizer][atos] Disable atos-symbolized-recovery test (authored by thetruestblue).
[Test][Sanitizer][atos] Disable atos-symbolized-recovery test
Apr 13 2023, 11:15 AM · Restricted Project, Restricted Project

Apr 10 2023

thetruestblue committed rG039f0e69a45e: [Sanitizer][Test] Disable atos test on unknown address for ubsan (authored by thetruestblue).
[Sanitizer][Test] Disable atos test on unknown address for ubsan
Apr 10 2023, 7:14 PM · Restricted Project, Restricted Project
thetruestblue closed D147977: [Sanitizer][Test] Disable atos test on unknown address for ubsan.
Apr 10 2023, 7:13 PM · Restricted Project, Restricted Project
thetruestblue requested review of D147977: [Sanitizer][Test] Disable atos test on unknown address for ubsan.
Apr 10 2023, 4:04 PM · Restricted Project, Restricted Project
thetruestblue added a comment to D147725: [Sanitizers][Atos] Remove null-ing of atos process pointer.

@thetruestblue It looks like the new test in this change fails https://green.lab.llvm.org/green/job/clang-stage1-RA/33833/

Apr 10 2023, 1:56 PM · Restricted Project, Restricted Project

Apr 7 2023

thetruestblue committed rG0f9bfe0a02ff: [Sanitizers][Atos] Remove null-ing of atos process pointer (authored by thetruestblue).
[Sanitizers][Atos] Remove null-ing of atos process pointer
Apr 7 2023, 2:57 PM · Restricted Project, Restricted Project
thetruestblue closed D147725: [Sanitizers][Atos] Remove null-ing of atos process pointer.
Apr 7 2023, 2:56 PM · Restricted Project, Restricted Project
thetruestblue accepted D147788: [CMake][fuzzer] Add riscv64 to fuzzer supported arch list.
Apr 7 2023, 9:23 AM · Restricted Project, Restricted Project

Apr 6 2023

thetruestblue added a comment to D147725: [Sanitizers][Atos] Remove null-ing of atos process pointer.

One small nit that I just thought of:
If it's easy to do, then let's move the test under sanitizer_common/TestCases/Darwin, since sanitizer_common is where the code change is as well.

Apr 6 2023, 5:53 PM · Restricted Project, Restricted Project
thetruestblue updated the summary of D147725: [Sanitizers][Atos] Remove null-ing of atos process pointer.
Apr 6 2023, 2:24 PM · Restricted Project, Restricted Project
thetruestblue added a comment to D147725: [Sanitizers][Atos] Remove null-ing of atos process pointer.

However, in new simulators there is an early call that atos does not return any symbol information for

  1. Do we know why this is / what changed?
  1. Previously we completely stopped trying to symbolicate after the first failure. Now we will always try for new requests. Can you think of any scenarios where this might be a problem, i.e., some interaction with a retry where we would now spend much more time, or maybe even hang on report generation?
Apr 6 2023, 2:23 PM · Restricted Project, Restricted Project
thetruestblue added a reviewer for D147725: [Sanitizers][Atos] Remove null-ing of atos process pointer: kubamracek.
Apr 6 2023, 12:43 PM · Restricted Project, Restricted Project
thetruestblue requested review of D147725: [Sanitizers][Atos] Remove null-ing of atos process pointer.
Apr 6 2023, 10:57 AM · Restricted Project, Restricted Project

Apr 4 2023

thetruestblue accepted D147502: [fuzzer][test] Avoid big-file-copy.test on memory constrained devices.
Apr 4 2023, 9:27 AM · Restricted Project, Restricted Project
thetruestblue accepted D147526: [sanitizers] Simplify Explainer about dyld and weak overrides on Darwin. (NFC).
Apr 4 2023, 8:19 AM · Restricted Project, Restricted Project
thetruestblue added inline comments to D147502: [fuzzer][test] Avoid big-file-copy.test on memory constrained devices.
Apr 4 2023, 8:14 AM · Restricted Project, Restricted Project

Mar 30 2023

thetruestblue added a comment to D146728: [utils] Give git a dummy email address when cherry picking..

Can you just do

git cherry-pick -n

aka no commit? shouldn't require an email?

Mar 30 2023, 8:36 PM · Restricted Project, Restricted Project
thetruestblue accepted D146745: [sanitizers] Explainer about dyld and weak overrides on Darwin. (NFC).

Ping - Thank you.

Mar 30 2023, 7:54 PM · Restricted Project, Restricted Project

Mar 23 2023

thetruestblue added a comment to D146728: [utils] Give git a dummy email address when cherry picking..

This is fine... feels a little off.
Is there a script to run the docker container? Couldn't we bring it in there or when we build it?

Mar 23 2023, 9:29 PM · Restricted Project, Restricted Project

Mar 21 2023

thetruestblue committed rGae484c21c056: [TSAN][Darwin] Forward declare spinlock functions on darwin for TSAN… (authored by Blue Gaston <bgaston2@apple.com>).
[TSAN][Darwin] Forward declare spinlock functions on darwin for TSAN…
Mar 21 2023, 12:26 PM · Restricted Project, Restricted Project
thetruestblue closed D146537: [TSAN][Darwin] Forward declare spinlock functions on darwin for TSAN interceptors.
Mar 21 2023, 12:26 PM · Restricted Project, Restricted Project
thetruestblue updated the diff for D146537: [TSAN][Darwin] Forward declare spinlock functions on darwin for TSAN interceptors.

fixed trailing white space issues.

Mar 21 2023, 9:15 AM · Restricted Project, Restricted Project
thetruestblue added reviewers for D146537: [TSAN][Darwin] Forward declare spinlock functions on darwin for TSAN interceptors: yln, rsundahl, wrotki, kubamracek.
Mar 21 2023, 9:10 AM · Restricted Project, Restricted Project
thetruestblue requested review of D146537: [TSAN][Darwin] Forward declare spinlock functions on darwin for TSAN interceptors.
Mar 21 2023, 9:09 AM · Restricted Project, Restricted Project

Mar 10 2023

thetruestblue accepted D145715: Remove -lower-global-dtors-via-cxa-atexit flag.

This looks good to me. I'm not sure the policy on what should be added to the release notes. But this was a temporary flag only added to slowly deprecate this, and was noted when it was added that it would be removed.

Mar 10 2023, 8:49 AM · Restricted Project, Restricted Project, Restricted Project

Mar 7 2023

thetruestblue updated the summary of D125416: [Sanitizers][Darwin] Add READ/WRITE detection on arm64 for darwin..
Mar 7 2023, 9:55 AM · Restricted Project, Restricted Project
thetruestblue updated the summary of D125416: [Sanitizers][Darwin] Add READ/WRITE detection on arm64 for darwin..
Mar 7 2023, 9:51 AM · Restricted Project, Restricted Project
thetruestblue updated the summary of D125416: [Sanitizers][Darwin] Add READ/WRITE detection on arm64 for darwin..
Mar 7 2023, 9:49 AM · Restricted Project, Restricted Project

Mar 1 2023

thetruestblue added a comment to D143675: Discussion: Darwin Sanitizers Stable ABI.

Currently & ideally asabi_shim.h is unnecessary -- but we hope to use only headers from ../asan/

Mar 1 2023, 3:55 PM · Restricted Project, Restricted Project, Restricted Project

Feb 28 2023

thetruestblue added inline comments to D143675: Discussion: Darwin Sanitizers Stable ABI.
Feb 28 2023, 4:38 PM · Restricted Project, Restricted Project, Restricted Project
thetruestblue accepted D145000: [Sanitizers] Disable armv7* sanitizers slice for ios.

You could probably use FILTER to remove all arm7* variants in one command, but there's no real need to do that.

Feb 28 2023, 3:07 PM · Restricted Project, Restricted Project

Feb 24 2023

Herald added a project to D116182: [ASan] Moved optimized callbacks into a separate library.: Restricted Project.
Feb 24 2023, 12:26 PM · Restricted Project, Restricted Project, Restricted Project

Feb 8 2023

thetruestblue added a comment to D143557: [CMake][compiler-rt] Support clang-cl in CompilerRTMockLLVMCMakeConfig.

This seems reasonable and fine to me.
Though I'd feel better if someone familiar with MSVC/Windows gave approval.

Feb 8 2023, 9:51 AM · Restricted Project, Restricted Project

Feb 7 2023

thetruestblue accepted D133273: [compiler-rt][macOS]: Disable iOS support if iOS SDK is not found.

Nit: When you land this will you update commit message to reflect the new change?

Feb 7 2023, 9:54 AM · Restricted Project, Restricted Project

Feb 6 2023

thetruestblue added a comment to D133273: [compiler-rt][macOS]: Disable iOS support if iOS SDK is not found.

Thanks @delcypher for reviewing. Thanks @thieta for the work -- I'll keep an eye out for the updated diff, @delcypher doesn't work on Sanitizers as much anymore.

Feb 6 2023, 1:24 PM · Restricted Project, Restricted Project

Jan 26 2023

thetruestblue accepted D142421: [Sanitizers] fix -fno-sanitize-link-runtime for darwin.

LGTM, but also confused regarding @yln's point.

Jan 26 2023, 3:39 PM · Restricted Project, Restricted Project

Jan 20 2023

thetruestblue added inline comments to D142164: [Sanitizers] Fix read buffer overrun in scanning loader commands.
Jan 20 2023, 10:51 AM · Restricted Project, Restricted Project

Jan 17 2023

thetruestblue accepted D141550: [CompilerRT] Remove ubsan static runtime on Apple.

This seems reasonable to me.

Jan 17 2023, 10:19 AM · Restricted Project, Restricted Project, Restricted Project

Jan 10 2023

thetruestblue updated the diff for D141171: [Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic.

update revision

Jan 10 2023, 12:20 PM · Restricted Project, Restricted Project
thetruestblue retitled D141171: [Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic from [Sanitizer][Apple] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic to [Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic.
Jan 10 2023, 12:18 PM · Restricted Project, Restricted Project
thetruestblue updated the summary of D141171: [Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic.
Jan 10 2023, 12:17 PM · Restricted Project, Restricted Project
thetruestblue added reviewers for D141170: [Sanitizer][Apple] Enable sanitizer common unittests for arm64 archs on Apple: MaskRay, kstoimenov.
Jan 10 2023, 11:36 AM · Restricted Project, Restricted Project
thetruestblue updated the summary of D141170: [Sanitizer][Apple] Enable sanitizer common unittests for arm64 archs on Apple.
Jan 10 2023, 11:36 AM · Restricted Project, Restricted Project
thetruestblue updated the diff for D141170: [Sanitizer][Apple] Enable sanitizer common unittests for arm64 archs on Apple.

Rather than skip the test, lower expected ratio. Per @rsundahl 's suggestion.

Jan 10 2023, 11:35 AM · Restricted Project, Restricted Project
thetruestblue updated the diff for D141171: [Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic.

incorporate @yln's suggestion.

Jan 10 2023, 11:30 AM · Restricted Project, Restricted Project
thetruestblue retitled D141171: [Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic from [Sanitizer][Apple] Arm64 MacOS should be using allocator64 to [Sanitizer][Apple] Clean up SANITIZER_CAN_USE_ALLOCATOR64 .
Jan 10 2023, 10:51 AM · Restricted Project, Restricted Project
thetruestblue added a comment to D141171: [Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic.

If we are not doing the optional cleanup, then I think I would prefer this:

#  if (SANITIZER_ANDROID && defined(__aarch64__)) || SANITIZER_FUCHSIA
#    define SANITIZER_CAN_USE_ALLOCATOR64 1
# elif defined(__mips64) || defined(__arm__) || defined(__i386__) || \
      SANITIZER_RISCV64 || defined(__hexagon__) || SANITIZER_IOS
#    define SANITIZER_CAN_USE_ALLOCATOR64 0
#  else

That is, adding SANITIZER_IOS to the branch that disable the 64 bit allocator.

Please also adjust the outdated comment:

// But in some cases (e.g. AArch64's 39-bit address space) SizeClassAllocator64
-->
// But in some cases (e.g. iOS/AArch64's 39-bit address space) SizeClassAllocator64
Jan 10 2023, 10:46 AM · Restricted Project, Restricted Project

Jan 9 2023

thetruestblue updated the diff for D141171: [Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic.

Removed check for apple in second conditional.

Jan 9 2023, 7:27 PM · Restricted Project, Restricted Project
thetruestblue added a comment to D141171: [Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic.

I think we can drop && !defined(SANITIZER_APPLE) altogether and let the "default" (last else) case handle things. It definitely doesn't make sense in it's current form: && takes precedence so the code is currently saying: xxx || (hexagon && !apple)

We need !SANITIZER_APPLE [we don't need !defined(SANITIZER_APPLE) tho, the way written here is incorrect]
Because otherwise MacOS takes this path because arm is defined. But you're right. I moved it to the end thinking it would make readability easier and spaced on the precedence.

Updated the diff for now with a fix for the spacing and that logic. But need to think on your optional suggestion, cause I agree it needs a refactor. Did you intentionally skip i386?

Jan 9 2023, 7:23 PM · Restricted Project, Restricted Project
thetruestblue added a comment to D141171: [Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic.

I think we can drop && !defined(SANITIZER_APPLE) altogether and let the "default" (last else) case handle things. It definitely doesn't make sense in it's current form: && takes precedence so the code is currently saying: xxx || (hexagon && !apple)

Jan 9 2023, 6:57 PM · Restricted Project, Restricted Project
thetruestblue updated the diff for D141171: [Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic.
Jan 9 2023, 6:57 PM · Restricted Project, Restricted Project
thetruestblue added a comment to D141171: [Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic.

Before you land this - I just noticed that your #elifs spacing is slightly off.

Jan 9 2023, 10:09 AM · Restricted Project, Restricted Project
thetruestblue updated the summary of D141171: [Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic.
Jan 9 2023, 7:59 AM · Restricted Project, Restricted Project

Jan 6 2023

thetruestblue updated the diff for D141171: [Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic.
Jan 6 2023, 4:39 PM · Restricted Project, Restricted Project
thetruestblue requested review of D141171: [Sanitizer] Clean up SANITIZER_CAN_USE_ALLOCATOR64 logic.
Jan 6 2023, 4:38 PM · Restricted Project, Restricted Project
thetruestblue requested review of D141170: [Sanitizer][Apple] Enable sanitizer common unittests for arm64 archs on Apple.
Jan 6 2023, 4:31 PM · Restricted Project, Restricted Project

Jan 4 2023

thetruestblue updated the diff for D140567: [Sanitizers] Fix procmap tests for apple arm64.

fixed long line

Jan 4 2023, 10:08 AM · Restricted Project, Restricted Project
thetruestblue added inline comments to D140567: [Sanitizers] Fix procmap tests for apple arm64.
Jan 4 2023, 8:55 AM · Restricted Project, Restricted Project
thetruestblue updated the diff for D140567: [Sanitizers] Fix procmap tests for apple arm64.
Jan 4 2023, 8:55 AM · Restricted Project, Restricted Project

Dec 22 2022

thetruestblue updated the summary of D140567: [Sanitizers] Fix procmap tests for apple arm64.
Dec 22 2022, 11:10 AM · Restricted Project, Restricted Project
thetruestblue updated the summary of D140567: [Sanitizers] Fix procmap tests for apple arm64.
Dec 22 2022, 11:10 AM · Restricted Project, Restricted Project
thetruestblue requested review of D140567: [Sanitizers] Fix procmap tests for apple arm64.
Dec 22 2022, 11:09 AM · Restricted Project, Restricted Project

Dec 20 2022

thetruestblue added a comment to D140353: [Sanitizer] Fix page alignment for mmap calls.

This fixes the case where map_end is greater than end because of page size and alignment difference.
However, I believe this function could use further refinement, I don't think it is handling "alignment" versus "page-aligned" adequately.
alignment is being treated as a size, rather than a page aligned location, which seems to be what we should be expecting here.
Particularly with the calls to UnmaporDie, which expect a page-aligned value.

Dec 20 2022, 1:05 PM · Restricted Project, Restricted Project
thetruestblue updated the diff for D140353: [Sanitizer] Fix page alignment for mmap calls.
Dec 20 2022, 7:44 AM · Restricted Project, Restricted Project

Dec 19 2022

thetruestblue requested review of D140353: [Sanitizer] Fix page alignment for mmap calls.
Dec 19 2022, 4:15 PM · Restricted Project, Restricted Project

Dec 8 2022

thetruestblue requested review of D139661: [Sanitizers][CFG][arm64e] Fix test because -fsanitize-coverage=control-flow does not sign BB entry.
Dec 8 2022, 12:08 PM · Restricted Project, Restricted Project

Dec 2 2022

thetruestblue accepted D139230: [ubsan][test] Be more specific than "error:" with implicit-check-not.

LGTM

Dec 2 2022, 3:41 PM · Restricted Project, Restricted Project

Nov 30 2022

thetruestblue added inline comments to D139030: [asan][aarch64] Don't use 64 bit allocator for Apple ios family.
Nov 30 2022, 12:28 PM · Restricted Project, Restricted Project
thetruestblue added inline comments to D139030: [asan][aarch64] Don't use 64 bit allocator for Apple ios family.
Nov 30 2022, 11:18 AM · Restricted Project, Restricted Project
thetruestblue accepted D139030: [asan][aarch64] Don't use 64 bit allocator for Apple ios family.

This looks fine to me.

Nov 30 2022, 10:24 AM · Restricted Project, Restricted Project

Nov 28 2022

thetruestblue accepted D138824: [asan][test] Fix SED issues with macOS (BSD).

Thanks for fixing this quick, @rsundahl.

Nov 28 2022, 3:58 PM · Restricted Project, Restricted Project

Nov 16 2022

thetruestblue added a comment to D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM).

@thetruestblue What paths besides LLVM_TOOLS_BINARY_DIR do you need?

Nov 16 2022, 11:43 AM · Restricted Project, Restricted Project
thetruestblue added a comment to D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM).

While I sympathize with you, I don't think this is valid reason to maintain full compatibility with llvm-config.

Nov 16 2022, 10:19 AM · Restricted Project, Restricted Project
thetruestblue added a comment to D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM).

This breaks our use case. We run sanitizer tests built in a standalone build using a toolchain from an artifact built upstream-- the toolchain contains binaries only.
Compiler-rt tests rely on the llvm tools binary being in the PATH.

Nov 16 2022, 9:13 AM · Restricted Project, Restricted Project

Nov 14 2022

thetruestblue accepted D138001: [asan][darwin] This test is x86_64 specific, not non-ios in general..

Is there a radar tracking this that we can add to these updates?
LGTM.

Nov 14 2022, 7:24 PM · Restricted Project, Restricted Project

Nov 11 2022

thetruestblue accepted D137292: [lsan] Fix stack buffer overwrite in SuspendedThreadsListMac::GetRegistersAndSP.

LGTM -- fixes the arm64 hang I've been running into.

Nov 11 2022, 9:15 PM · Restricted Project, Restricted Project

Sep 19 2022

thetruestblue updated the diff for D134091: [Sanitizer] Bump macOS deployment target for sanitizer unit test binary to support C++17 requirements..

Updating commit message

Sep 19 2022, 12:17 PM · Restricted Project, Restricted Project
thetruestblue updated the diff for D134091: [Sanitizer] Bump macOS deployment target for sanitizer unit test binary to support C++17 requirements..

removed conditionalw

Sep 19 2022, 12:15 PM · Restricted Project, Restricted Project
thetruestblue added a comment to D134091: [Sanitizer] Bump macOS deployment target for sanitizer unit test binary to support C++17 requirements..

C++ standard can be manually overwritten and manually defined. As the codebase stands, without this overwrite, no this is never not true. And in the case of someone running Apple tests, I'm not sure *why* this would happen. But because the the mechanism exists, I added a conditional. I agree that guarding tests against every potential case might be unnecessary.

Sep 19 2022, 11:41 AM · Restricted Project, Restricted Project

Sep 16 2022

thetruestblue requested review of D134091: [Sanitizer] Bump macOS deployment target for sanitizer unit test binary to support C++17 requirements..
Sep 16 2022, 3:55 PM · Restricted Project, Restricted Project
thetruestblue abandoned D133878: [Sanitizers][Apple][Cmake] Lower C++ standard to 14 for single sanitizer test on Apple platforms.

Abandoning for a more lightweight change.

Sep 16 2022, 11:04 AM · Restricted Project, Restricted Project

Sep 14 2022

thetruestblue retitled D133878: [Sanitizers][Apple][Cmake] Lower C++ standard to 14 for single sanitizer test on Apple platforms from Lower C++ standard to 14 for single sanitizer test on Apple platforms to [Sanitizers][Apple][Cmake] Lower C++ standard to 14 for single sanitizer test on Apple platforms.
Sep 14 2022, 11:22 AM · Restricted Project, Restricted Project
thetruestblue updated the summary of D133878: [Sanitizers][Apple][Cmake] Lower C++ standard to 14 for single sanitizer test on Apple platforms.
Sep 14 2022, 11:00 AM · Restricted Project, Restricted Project
thetruestblue updated the summary of D133878: [Sanitizers][Apple][Cmake] Lower C++ standard to 14 for single sanitizer test on Apple platforms.
Sep 14 2022, 10:59 AM · Restricted Project, Restricted Project
thetruestblue requested review of D133878: [Sanitizers][Apple][Cmake] Lower C++ standard to 14 for single sanitizer test on Apple platforms.
Sep 14 2022, 10:57 AM · Restricted Project, Restricted Project

Sep 9 2022

thetruestblue updated the diff for D133445: [ASAN][DARWIN] Remove getpwnam(NULL) test for undefined behavior.

Keeping the null guard from the original commit.

Sep 9 2022, 8:44 AM · Restricted Project, Restricted Project
thetruestblue retitled D133445: [ASAN][DARWIN] Remove getpwnam(NULL) test for undefined behavior from [ASAN][DARWIN] Revert 21e6efcb after change in expected behavior for getpwnam(NULL) to [ASAN][DARWIN] Remove getpwnam(NULL) test for undefined behavior.
Sep 9 2022, 8:43 AM · Restricted Project, Restricted Project

Sep 7 2022

thetruestblue added a comment to D133445: [ASAN][DARWIN] Remove getpwnam(NULL) test for undefined behavior.

Because of the change in the expected behavior

What is that change? I am a bit confused about this revert.

If I compile the test file without ASan, it still doesn't crash so ASan should allow execution without a crash as well.

Sep 7 2022, 1:48 PM · Restricted Project, Restricted Project
thetruestblue requested review of D133445: [ASAN][DARWIN] Remove getpwnam(NULL) test for undefined behavior.
Sep 7 2022, 12:17 PM · Restricted Project, Restricted Project

Aug 3 2022

thetruestblue updated the diff for D131119: [TSAN][Darwin] x86_64 specific tests requiring weak symbols.

Made the format consistent.

Aug 3 2022, 3:46 PM · Restricted Project, Restricted Project
thetruestblue requested review of D131119: [TSAN][Darwin] x86_64 specific tests requiring weak symbols.
Aug 3 2022, 3:12 PM · Restricted Project, Restricted Project

Jul 29 2022

thetruestblue updated the diff for D130732: [TSan][Darwin] Additional TSAN test requiring weak symbol for dyld64.

Additional weak def

Jul 29 2022, 11:09 AM · Restricted Project, Restricted Project
thetruestblue updated the diff for D130732: [TSan][Darwin] Additional TSAN test requiring weak symbol for dyld64.
Jul 29 2022, 11:08 AM · Restricted Project, Restricted Project